Re: [PATCH] drm/i915: blacklist lid status: Sony VGN-BX196VP, Dell Inspiron 700m

2010-03-05 Thread Surbhi Palande
Hi Eric,

On Wed, 2010-03-03 at 15:34 -0800, Eric Anholt wrote:
 On Tue,  2 Mar 2010 22:59:52 +0200, Surbhi Palande 
 surbhi.pala...@canonical.com wrote:
  BugLink: https://bugs.launchpad.net/bugs/515246
  
  Sony VGN-BX196VP and Dell Inspiron 700m report lid status as closed
  when it is open. This leads to a no connectors reported error at startup.
  Blacklisting them, to always return a connected status for the default
  lvds connector.
  
  Signed-off-by: Surbhi Palande surbhi.pala...@canonical.com
 
 As far as I know, this should already be covered by:
 
 commit 7b9c5abee98c54f85bcc04bd4d7ec8d5094c73f4
 Author: Jesse Barnes jbar...@virtuousgeek.org
 Date:   Fri Feb 12 09:30:00 2010 -0800
 
 drm/i915: give up on 8xx lid status

Yes I agree. Thanks for the comment.

However, the drm/i915: give up on 8xx lid status will work for the
Dell Inspiron 700m. But, the Sony VGN-BX196VP will still need to be
blacklisted as it is a 915GM device.

If you agree with this, I will rewrite the patch and send you another
version.

Thanks!

Warm Regards,
Surbhi.


--
Download Intel#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


Re: [PATCH] drm/i915: blacklist lid status: Sony VGN-BX196VP, Dell Inspiron 700m

2010-03-03 Thread Eric Anholt
On Tue,  2 Mar 2010 22:59:52 +0200, Surbhi Palande 
surbhi.pala...@canonical.com wrote:
 BugLink: https://bugs.launchpad.net/bugs/515246
 
 Sony VGN-BX196VP and Dell Inspiron 700m report lid status as closed
 when it is open. This leads to a no connectors reported error at startup.
 Blacklisting them, to always return a connected status for the default
 lvds connector.
 
 Signed-off-by: Surbhi Palande surbhi.pala...@canonical.com

As far as I know, this should already be covered by:

commit 7b9c5abee98c54f85bcc04bd4d7ec8d5094c73f4
Author: Jesse Barnes jbar...@virtuousgeek.org
Date:   Fri Feb 12 09:30:00 2010 -0800

drm/i915: give up on 8xx lid status


pgpNe85gsm2Yr.pgp
Description: PGP signature
--
Download Intel#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


[PATCH] drm/i915: blacklist lid status: Sony VGN-BX196VP, Dell Inspiron 700m

2010-03-02 Thread Surbhi Palande
BugLink: https://bugs.launchpad.net/bugs/515246

Sony VGN-BX196VP and Dell Inspiron 700m report lid status as closed
when it is open. This leads to a no connectors reported error at startup.
Blacklisting them, to always return a connected status for the default
lvds connector.

Signed-off-by: Surbhi Palande surbhi.pala...@canonical.com
---
Due to lack of hardware, I have not tested this patch on my own. Further
testing shall be helpful.

 drivers/gpu/drm/i915/intel_lvds.c |   14 ++
 1 files changed, 14 insertions(+), 0 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_lvds.c 
b/drivers/gpu/drm/i915/intel_lvds.c
index c2e8a45..b94a5e5 100644
--- a/drivers/gpu/drm/i915/intel_lvds.c
+++ b/drivers/gpu/drm/i915/intel_lvds.c
@@ -643,6 +643,20 @@ static const struct dmi_system_id bad_lid_status[] = {
DMI_MATCH(DMI_BOARD_NAME, M5x0N),
},
},
+   {
+   .ident = Sony VGN-BX196VP,
+   .matches = {
+   DMI_MATCH(DMI_SYS_VENDOR, Sony Corporation),
+   DMI_MATCH(DMI_BOARD_NAME, VGN-BX196VP),
+   },
+   },
+   {
+   .ident = Dell Inspiron 700m,
+   .matches = {
+   DMI_MATCH(DMI_SYS_VENDOR, Dell Inc),
+   DMI_MATCH(DMI_BOARD_NAME, Inspiron 700m),
+   },
+   },
{ }
 };
 
-- 
1.6.3.3


--
Download Intel#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel