Re: [PATCH] drm/radeon/kms: add dynamic engine reclocking (v3)

2009-12-15 Thread Rafał Miłecki
2009/12/14 Sedat Dilek sedat.di...@googlemail.com:
 # cat /sys/kernel/debug/dri/*/radeon_pm_info
 engine clock: 391500 kHz
 memory clock: 297000 kHz
 engine clock: 391500 kHz
 memory clock: 297000 kHz

Thanks you for testing! After some additional testing I've noticed I
hit similar issue. My GPU just keeps running on current engine clock
without reclocking. That's because I don't get VBLANK IRQ for some
reason.

[glxgears start]
[   80.783033] [drm] pm.planned_action = RADEON_PM_ACTION_UPCLOCK
[   81.083015] [drm] pm.vblank_callback = true
[   81.096860] [drm] radeon_pm_reclock_work_handler
[   81.096863] [drm] pm.vblank_callback = false
[   81.096867] [drm] radeon_atom_set_engine_clock 68 KHz
[   81.103097] [drm] pm.planned_action = RADEON_PM_ACTION_NONE
[glxgears stop]
[   85.585011] [drm] pm.planned_action = RADEON_PM_ACTION_DOWNCLOCK
[   85.685032] [drm] pm.planned_action = RADEON_PM_ACTION_NONE
[   87.686051] [drm] pm.planned_action = RADEON_PM_ACTION_DOWNCLOCK
[   87.986088] [drm] pm.vblank_callback = true
[glxgears start]
[  209.707912] [drm] radeon_pm_reclock_work_handler

I've started glxgears and this did upclock my engine. That was fine.
When I stopper my PM noticed GPU is not loaded and decided to
downclock it. It has set pm.vblank_callback = true but for some
reason IRQ didn't happen (and so it didn't call reclocking function).
Finally when I decided to start glxgears again VBLANK has came but it
was way too late of course :|

Could someone explain that IRQs issue, please?

-- 
Rafał

--
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev 
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


Re: [PATCH] drm/radeon/kms: add dynamic engine reclocking (v3)

2009-12-14 Thread Sedat Dilek
Addendum Up-/Downclocking:

# cat /sys/module/radeon/parameters/dynclks
-1

Value of -1 means dynamic clocking (dynclks) is not set.

Two options to activate dynamic clocking:

[1] At modprobe-time: (tested in runlevel-3: booted with nomodeset):

# modprobe -r -v radeon --- unload kernel-module
# modprobe -v radeon modeset=1 dynclks=1 --- load with new module-options

# dmesg | egrep -i 'dynamic clocking|power management'
[drm] radeon: dynamic clocking enabled
[drm] radeon: power management initialized

[2] At boot-time:

Add modeset=1 and dynclks=1 to your Kernel-command-line (in most
cases grub, see grub documentation).
Depending on distribution and kernel it might be radeon.modeset=1
and radeon.dynclks=1.

Unfortunately, with dynamic clocking enabled, I have still no luck
with upclocking:

# cat /sys/kernel/debug/dri/*/radeon_pm_info
engine clock: 391500 kHz
memory clock: 297000 kHz
engine clock: 391500 kHz
memory clock: 297000 kHz

Thanks Rafal (sorry don't know how to activate that crossed L-sign in
your first name) Zajec for explanation on IRC.

- Sedat -

On Sun, Dec 13, 2009 at 11:00 PM, Sedat Dilek
sedat.di...@googlemail.com wrote:
 Hi,

 I tried v3 of the radeon PM patch from [1].
 Here my feeback:

 # lspci -nnvv | grep VGA controller
 01:00.0 VGA compatible controller [0300]: ATI Technologies Inc M52
 [Mobility Radeon X1300] [1002:714a] (prog-if 00 [VGA controller])

 # mount -t debugfs none /sys/kernel/debug/
 # ln -s /sys/kernel/debug /debug

 # find /debug/ -name radeon_pm_info
 /debug/dri/0/radeon_pm_info
 /debug/dri/64/radeon_pm_info

 # cat /sys/kernel/debug/dri/*/radeon_pm_info
 engine clock: 391500 kHz
 memory clock: 297000 kHz
 engine clock: 391500 kHz
 memory clock: 297000 kHz

 From the backlog [3]:
 13:32 #radeon:  Zajec dileX: Wikipedia says your default engine
 clock is 450MHz... your logs shows 391MHz which should mean
 downclocking working :)

 While starting glxgears upclocking seems not to work, yet.
 Good job, anyway!

 Kind Regards,
 - Sedat -

 [1] 0001-drm-radeon-kms-add-dynamic-engine-reclocking-v3.patch
 http://marc.info/?l=dri-develm=126063445301253w=2
 [2] debugfs mount point
 http://lwn.net/Articles/323307/
 [3] Backlog #radeon/freenode
 http://people.freedesktop.org/~cbrill/dri-log/index.php?date=2009-12-13channel=radeon


--
Return on Information:
Google Enterprise Search pays you back
Get the facts.
http://p.sf.net/sfu/google-dev2dev
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


Re: [PATCH] drm/radeon/kms: add dynamic engine reclocking (v3)

2009-12-13 Thread Sedat Dilek
Hi,

I tried v3 of the radeon PM patch from [1].
Here my feeback:

# lspci -nnvv | grep VGA controller
01:00.0 VGA compatible controller [0300]: ATI Technologies Inc M52
[Mobility Radeon X1300] [1002:714a] (prog-if 00 [VGA controller])

# mount -t debugfs none /sys/kernel/debug/
# ln -s /sys/kernel/debug /debug

# find /debug/ -name radeon_pm_info
/debug/dri/0/radeon_pm_info
/debug/dri/64/radeon_pm_info

# cat /sys/kernel/debug/dri/*/radeon_pm_info
engine clock: 391500 kHz
memory clock: 297000 kHz
engine clock: 391500 kHz
memory clock: 297000 kHz

From the backlog [3]:
13:32 #radeon:  Zajec dileX: Wikipedia says your default engine
clock is 450MHz... your logs shows 391MHz which should mean
downclocking working :)

While starting glxgears upclocking seems not to work, yet.
Good job, anyway!

Kind Regards,
- Sedat -

[1] 0001-drm-radeon-kms-add-dynamic-engine-reclocking-v3.patch
http://marc.info/?l=dri-develm=126063445301253w=2
[2] debugfs mount point
http://lwn.net/Articles/323307/
[3] Backlog #radeon/freenode
http://people.freedesktop.org/~cbrill/dri-log/index.php?date=2009-12-13channel=radeon

--
Return on Information:
Google Enterprise Search pays you back
Get the facts.
http://p.sf.net/sfu/google-dev2dev
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel