Re: [PATCH] drm/radeon/kms: crtc_ omitted in display assignments in radeon_atom_mode_fixup()?

2010-01-15 Thread Alex Deucher
On Fri, Jan 15, 2010 at 9:11 AM, Roel Kluin  wrote:
> The crtc_ prefix was omitted in h/vdisplay assignments
>
> Signed-off-by: Roel Kluin 
> ---
> Not sure, but maybe the change below is needed? please ack/nack.

NAK.  the code is correct as is.

>
> diff --git a/drivers/gpu/drm/radeon/radeon_encoders.c 
> b/drivers/gpu/drm/radeon/radeon_encoders.c
> index 82eb551..a9dc073 100644
> --- a/drivers/gpu/drm/radeon/radeon_encoders.c
> +++ b/drivers/gpu/drm/radeon/radeon_encoders.c
> @@ -233,8 +233,8 @@ static bool radeon_atom_mode_fixup(struct drm_encoder 
> *encoder,
>                if (!ASIC_IS_AVIVO(rdev)) {
>                        adjusted_mode->hdisplay = mode->hdisplay;
>                        adjusted_mode->vdisplay = mode->vdisplay;
> -                       adjusted_mode->crtc_hdisplay = mode->hdisplay;
> -                       adjusted_mode->crtc_vdisplay = mode->vdisplay;
> +                       adjusted_mode->crtc_hdisplay = mode->crtc_hdisplay;
> +                       adjusted_mode->crtc_vdisplay = mode->crtc_vdisplay;
>                }
>                adjusted_mode->base.id = mode_id;
>        }
>
> --
> Throughout its 18-year history, RSA Conference consistently attracts the
> world's best and brightest in the field, creating opportunities for Conference
> attendees to learn about information security's most important issues through
> interactions with peers, luminaries and emerging and established companies.
> http://p.sf.net/sfu/rsaconf-dev2dev
> --
> ___
> Dri-devel mailing list
> Dri-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/dri-devel
>

--
Throughout its 18-year history, RSA Conference consistently attracts the
world's best and brightest in the field, creating opportunities for Conference
attendees to learn about information security's most important issues through
interactions with peers, luminaries and emerging and established companies.
http://p.sf.net/sfu/rsaconf-dev2dev
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


[PATCH] drm/radeon/kms: crtc_ omitted in display assignments in radeon_atom_mode_fixup()?

2010-01-15 Thread Roel Kluin
The crtc_ prefix was omitted in h/vdisplay assignments

Signed-off-by: Roel Kluin 
---
Not sure, but maybe the change below is needed? please ack/nack.

diff --git a/drivers/gpu/drm/radeon/radeon_encoders.c 
b/drivers/gpu/drm/radeon/radeon_encoders.c
index 82eb551..a9dc073 100644
--- a/drivers/gpu/drm/radeon/radeon_encoders.c
+++ b/drivers/gpu/drm/radeon/radeon_encoders.c
@@ -233,8 +233,8 @@ static bool radeon_atom_mode_fixup(struct drm_encoder 
*encoder,
if (!ASIC_IS_AVIVO(rdev)) {
adjusted_mode->hdisplay = mode->hdisplay;
adjusted_mode->vdisplay = mode->vdisplay;
-   adjusted_mode->crtc_hdisplay = mode->hdisplay;
-   adjusted_mode->crtc_vdisplay = mode->vdisplay;
+   adjusted_mode->crtc_hdisplay = mode->crtc_hdisplay;
+   adjusted_mode->crtc_vdisplay = mode->crtc_vdisplay;
}
adjusted_mode->base.id = mode_id;
}

--
Throughout its 18-year history, RSA Conference consistently attracts the
world's best and brightest in the field, creating opportunities for Conference
attendees to learn about information security's most important issues through
interactions with peers, luminaries and emerging and established companies.
http://p.sf.net/sfu/rsaconf-dev2dev
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel