Re: [PATCH] drm/radeon/kms: don't report allocate failure on ERESTARTSYS

2009-12-15 Thread Jerome Glisse
On Tue, Dec 15, 2009 at 10:40:36AM +1000, Dave Airlie wrote:
 From: Dave Airlie airl...@redhat.com
 
 if we fail with ERESTARTSYS during alloc, we'll get a retry from
 userspace so don't report it in dmesg.
 
 Signed-off-by: Dave Airlie airl...@redhat.com

Ack-by: Jerome Glisse jgli...@redhat.com

 ---
  drivers/gpu/drm/radeon/radeon_gem.c |5 +++--
  1 files changed, 3 insertions(+), 2 deletions(-)
 
 diff --git a/drivers/gpu/drm/radeon/radeon_gem.c 
 b/drivers/gpu/drm/radeon/radeon_gem.c
 index 2944486..ee827cc 100644
 --- a/drivers/gpu/drm/radeon/radeon_gem.c
 +++ b/drivers/gpu/drm/radeon/radeon_gem.c
 @@ -66,8 +66,9 @@ int radeon_gem_object_create(struct radeon_device *rdev, 
 int size,
   }
   r = radeon_bo_create(rdev, gobj, size, kernel, initial_domain, robj);
   if (r) {
 - DRM_ERROR(Failed to allocate GEM object (%d, %d, %u)\n,
 -   size, initial_domain, alignment);
 + if (r != -ERESTARTSYS)
 + DRM_ERROR(Failed to allocate GEM object (%d, %d, %u, 
 %d)\n,
 +   size, initial_domain, alignment, r);
   mutex_lock(rdev-ddev-struct_mutex);
   drm_gem_object_unreference(gobj);
   mutex_unlock(rdev-ddev-struct_mutex);
 -- 
 1.6.5.2
 
 
 --
 Return on Information:
 Google Enterprise Search pays you back
 Get the facts.
 http://p.sf.net/sfu/google-dev2dev
 --
 ___
 Dri-devel mailing list
 Dri-devel@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/dri-devel
 

--
Return on Information:
Google Enterprise Search pays you back
Get the facts.
http://p.sf.net/sfu/google-dev2dev
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


[PATCH] drm/radeon/kms: don't report allocate failure on ERESTARTSYS

2009-12-14 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com

if we fail with ERESTARTSYS during alloc, we'll get a retry from
userspace so don't report it in dmesg.

Signed-off-by: Dave Airlie airl...@redhat.com
---
 drivers/gpu/drm/radeon/radeon_gem.c |5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/radeon/radeon_gem.c 
b/drivers/gpu/drm/radeon/radeon_gem.c
index 2944486..ee827cc 100644
--- a/drivers/gpu/drm/radeon/radeon_gem.c
+++ b/drivers/gpu/drm/radeon/radeon_gem.c
@@ -66,8 +66,9 @@ int radeon_gem_object_create(struct radeon_device *rdev, int 
size,
}
r = radeon_bo_create(rdev, gobj, size, kernel, initial_domain, robj);
if (r) {
-   DRM_ERROR(Failed to allocate GEM object (%d, %d, %u)\n,
- size, initial_domain, alignment);
+   if (r != -ERESTARTSYS)
+   DRM_ERROR(Failed to allocate GEM object (%d, %d, %u, 
%d)\n,
+ size, initial_domain, alignment, r);
mutex_lock(rdev-ddev-struct_mutex);
drm_gem_object_unreference(gobj);
mutex_unlock(rdev-ddev-struct_mutex);
-- 
1.6.5.2


--
Return on Information:
Google Enterprise Search pays you back
Get the facts.
http://p.sf.net/sfu/google-dev2dev
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel