Re: [PATCH] drm/radeon/kms: fix bo leak on ERESTARTSYS.
On Tue, Dec 15, 2009 at 10:38:36AM +1000, Dave Airlie wrote: From: Dave Airlie airl...@redhat.com If we get ERESTARTSYS we leaked the radeon_bo object here. Signed-off-by: Dave Airlie airl...@redhat.com Ack-by: Jerome Glisse jgli...@redhat.com --- drivers/gpu/drm/radeon/radeon_object.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_object.c b/drivers/gpu/drm/radeon/radeon_object.c index 115222e..af77168 100644 --- a/drivers/gpu/drm/radeon/radeon_object.c +++ b/drivers/gpu/drm/radeon/radeon_object.c @@ -119,6 +119,7 @@ int radeon_bo_create(struct radeon_device *rdev, struct drm_gem_object *gobj, dev_err(rdev-dev, object_init failed for (%lu, 0x%08X)\n, size, domain); + kfree(bo); return r; } *bo_ptr = bo; -- 1.6.5.2 -- Return on Information: Google Enterprise Search pays you back Get the facts. http://p.sf.net/sfu/google-dev2dev -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel -- Return on Information: Google Enterprise Search pays you back Get the facts. http://p.sf.net/sfu/google-dev2dev -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
Re: [PATCH] drm/radeon/kms: fix bo leak on ERESTARTSYS.
On Tue, Dec 15, 2009 at 6:58 PM, Jerome Glisse gli...@freedesktop.org wrote: On Tue, Dec 15, 2009 at 10:38:36AM +1000, Dave Airlie wrote: From: Dave Airlie airl...@redhat.com If we get ERESTARTSYS we leaked the radeon_bo object here. Signed-off-by: Dave Airlie airl...@redhat.com NAK myself, my own patch causing me issues!! I didn't realise the object was still getting onto the ddestroy list from here and being freed, the double free was doing bad things then. Dave. Ack-by: Jerome Glisse jgli...@redhat.com --- drivers/gpu/drm/radeon/radeon_object.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_object.c b/drivers/gpu/drm/radeon/radeon_object.c index 115222e..af77168 100644 --- a/drivers/gpu/drm/radeon/radeon_object.c +++ b/drivers/gpu/drm/radeon/radeon_object.c @@ -119,6 +119,7 @@ int radeon_bo_create(struct radeon_device *rdev, struct drm_gem_object *gobj, dev_err(rdev-dev, object_init failed for (%lu, 0x%08X)\n, size, domain); + kfree(bo); return r; } *bo_ptr = bo; -- 1.6.5.2 -- Return on Information: Google Enterprise Search pays you back Get the facts. http://p.sf.net/sfu/google-dev2dev -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel -- This SF.Net email is sponsored by the Verizon Developer Community Take advantage of Verizon's best-in-class app development support A streamlined, 14 day to market process makes app distribution fast and easy Join now and get one step closer to millions of Verizon customers http://p.sf.net/sfu/verizon-dev2dev -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
[PATCH] drm/radeon/kms: fix bo leak on ERESTARTSYS.
From: Dave Airlie airl...@redhat.com If we get ERESTARTSYS we leaked the radeon_bo object here. Signed-off-by: Dave Airlie airl...@redhat.com --- drivers/gpu/drm/radeon/radeon_object.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_object.c b/drivers/gpu/drm/radeon/radeon_object.c index 115222e..af77168 100644 --- a/drivers/gpu/drm/radeon/radeon_object.c +++ b/drivers/gpu/drm/radeon/radeon_object.c @@ -119,6 +119,7 @@ int radeon_bo_create(struct radeon_device *rdev, struct drm_gem_object *gobj, dev_err(rdev-dev, object_init failed for (%lu, 0x%08X)\n, size, domain); + kfree(bo); return r; } *bo_ptr = bo; -- 1.6.5.2 -- Return on Information: Google Enterprise Search pays you back Get the facts. http://p.sf.net/sfu/google-dev2dev -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
