Re: [PATCH] drm/ttm: fix incorrect logic in ttm_bo_io path

2009-12-15 Thread Jerome Glisse
On Tue, Dec 15, 2009 at 08:08:51AM +1000, Dave Airlie wrote:
 From: Dave Airlie airl...@redhat.com
 
 This path isn't used by radeon yet, but future drivers will want it,
 so fix it right.
 
 Reported-by: Luca Barbieri l...@luca-barbieri.com
 Signed-off-by: Dave Airlie airl...@redhat.com

Ack-by: Jerome Glisse jgli...@redhat.com


 ---
  drivers/gpu/drm/ttm/ttm_bo_vm.c |2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
 
 diff --git a/drivers/gpu/drm/ttm/ttm_bo_vm.c b/drivers/gpu/drm/ttm/ttm_bo_vm.c
 index 609a85a..668dbe8 100644
 --- a/drivers/gpu/drm/ttm/ttm_bo_vm.c
 +++ b/drivers/gpu/drm/ttm/ttm_bo_vm.c
 @@ -320,7 +320,7 @@ ssize_t ttm_bo_io(struct ttm_bo_device *bdev, struct file 
 *filp,
   return -EFAULT;
  
   driver = bo-bdev-driver;
 - if (unlikely(driver-verify_access)) {
 + if (unlikely(!driver-verify_access)) {
   ret = -EPERM;
   goto out_unref;
   }
 -- 
 1.6.5.2
 
 
 --
 Return on Information:
 Google Enterprise Search pays you back
 Get the facts.
 http://p.sf.net/sfu/google-dev2dev
 --
 ___
 Dri-devel mailing list
 Dri-devel@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/dri-devel
 

--
Return on Information:
Google Enterprise Search pays you back
Get the facts.
http://p.sf.net/sfu/google-dev2dev
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


[PATCH] drm/ttm: fix incorrect logic in ttm_bo_io path

2009-12-14 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com

This path isn't used by radeon yet, but future drivers will want it,
so fix it right.

Reported-by: Luca Barbieri l...@luca-barbieri.com
Signed-off-by: Dave Airlie airl...@redhat.com
---
 drivers/gpu/drm/ttm/ttm_bo_vm.c |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/gpu/drm/ttm/ttm_bo_vm.c b/drivers/gpu/drm/ttm/ttm_bo_vm.c
index 609a85a..668dbe8 100644
--- a/drivers/gpu/drm/ttm/ttm_bo_vm.c
+++ b/drivers/gpu/drm/ttm/ttm_bo_vm.c
@@ -320,7 +320,7 @@ ssize_t ttm_bo_io(struct ttm_bo_device *bdev, struct file 
*filp,
return -EFAULT;
 
driver = bo-bdev-driver;
-   if (unlikely(driver-verify_access)) {
+   if (unlikely(!driver-verify_access)) {
ret = -EPERM;
goto out_unref;
}
-- 
1.6.5.2


--
Return on Information:
Google Enterprise Search pays you back
Get the facts.
http://p.sf.net/sfu/google-dev2dev
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel