Re: [R300][PATCH] Allow use of custom compiler in drm
On Tuesday 14 December 2004 05:27, Nicolai Haehnle wrote: > Hi, > > On Monday 13 December 2004 18:29, Kronos wrote: > > In this way calling: > > CC=gcc-3.4 make > > does the Right Thing > > The base DRM Makefile doesn't pass the CC on either, and this may or may > not be with good reason. AFAIK kernel code can be rather dependant on the > exact compiler version used, so it's probably a good idea to always use the > same compiler for both the kernel itself and all modules. > > Perhaps somebody with more experience in this area wants to comment? Consider the inverse case, where you built the kernel with gcc3.3, but have mostly changed your userspace to 3.4, and don't really feel like rebuilding the whole kernel. I know that's bitten me more than once before. I don't object to the change. On 2.6 at least the kernel will refuse to load modules compiled with a different compiler version. - ajax pgpccWPyLWMK6.pgp Description: PGP signature
Re: [R300][PATCH] Allow use of custom compiler in drm
Il Tue, Dec 14, 2004 at 11:27:14AM +0100, Nicolai Haehnle ha scritto: > > --- a/drm/linux-core/Makefile 2004-10-23 14:43:44.0 +0200 > > +++ b/drm/linux-core/Makefile 2004-12-13 18:20:16.0 +0100 > > @@ -172,7 +172,7 @@ > > all: modules > > > > modules: includes > > - make -C $(LINUXDIR) $(GETCONFIG) SUBDIRS=`pwd` DRMSRCDIR=`pwd` modules > > + make -C $(LINUXDIR) $(GETCONFIG) CC=$(CC) SUBDIRS=`pwd` DRMSRCDIR=`pwd` > modules > > > > ifeq ($(HEADERFROMBOOT),1) > > > > > > In this way calling: > > CC=gcc-3.4 make > > does the Right Thing > > The base DRM Makefile doesn't pass the CC on either, and this may or may not > be with good reason. AFAIK kernel code can be rather dependant on the exact > compiler version used, so it's probably a good idea to always use the same > compiler for both the kernel itself and all modules. The point is that my kernel is compiled with gcc-3.4 and (without patch) modules are compiled with default gcc (which on my system is gcc-3.3): modules will NOT load (with CONFIG_MODVERSIONS). Luca -- Home: http://kronoz.cjb.net Ligabue canta: "Tutti vogliono viaggiare in prim..." Io ci ho provato e dopo un chilometro ho fuso il motore e bruciato la frizione... --- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://productguide.itmanagersjournal.com/ -- ___ Dri-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/dri-devel
Re: [R300][PATCH] Allow use of custom compiler in drm
Hi, On Monday 13 December 2004 18:29, Kronos wrote: > Hi, > Makefile in drm/linux-core/ doesn't pass CC to linux kernel build > system. This prevents loading the modules if kernel has been compiled > with a compiler different from the default (ie. gcc). > > The following patch add CC to kernel Makefile: > > --- a/drm/linux-core/Makefile 2004-10-23 14:43:44.0 +0200 > +++ b/drm/linux-core/Makefile 2004-12-13 18:20:16.0 +0100 > @@ -172,7 +172,7 @@ > all: modules > > modules: includes > - make -C $(LINUXDIR) $(GETCONFIG) SUBDIRS=`pwd` DRMSRCDIR=`pwd` modules > + make -C $(LINUXDIR) $(GETCONFIG) CC=$(CC) SUBDIRS=`pwd` DRMSRCDIR=`pwd` modules > > ifeq ($(HEADERFROMBOOT),1) > > > In this way calling: > CC=gcc-3.4 make > does the Right Thing The base DRM Makefile doesn't pass the CC on either, and this may or may not be with good reason. AFAIK kernel code can be rather dependant on the exact compiler version used, so it's probably a good idea to always use the same compiler for both the kernel itself and all modules. Perhaps somebody with more experience in this area wants to comment? cu, Nicolai pgpBEwFUW4YOm.pgp Description: PGP signature