Re: [patch -next] i915/intel_sdvo: remove unneeded null check

2010-05-26 Thread Eric Anholt
On Fri, 7 May 2010 10:40:09 +0200, Dan Carpenter  wrote:
> The "connector" variable is used as the cursor in a
> list_for_each_entry() and it's always non-null so we don't need to check
> it.

Applied.  Thanks!


pgp5LjYtrnRQc.pgp
Description: PGP signature
--

--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


[patch -next] i915/intel_sdvo: remove unneeded null check

2010-05-07 Thread Dan Carpenter
The "connector" variable is used as the cursor in a
list_for_each_entry() and it's always non-null so we don't need to check
it.

Signed-off-by: Dan Carpenter 

diff --git a/drivers/gpu/drm/i915/intel_sdvo.c 
b/drivers/gpu/drm/i915/intel_sdvo.c
index 42ceb15..179d146 100644
--- a/drivers/gpu/drm/i915/intel_sdvo.c
+++ b/drivers/gpu/drm/i915/intel_sdvo.c
@@ -1479,7 +1479,7 @@ intel_find_analog_connector(struct drm_device *dev)
intel_encoder = enc_to_intel_encoder(encoder);
if (intel_encoder->type == INTEL_OUTPUT_ANALOG) {
list_for_each_entry(connector, 
&dev->mode_config.connector_list, head) {
-   if (connector && encoder == 
intel_attached_encoder(connector))
+   if (encoder == 
intel_attached_encoder(connector))
return connector;
}
}

--

--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel