Re: [patch for 2.6.32? 1/3] drivers/gpu/drm/i915/i915_dma.c: fix unused var
On Tue, 17 Nov 2009 14:08:52 -0800, a...@linux-foundation.org wrote: From: Andrew Morton a...@linux-foundation.org drivers/gpu/drm/i915/i915_dma.c: In function 'i915_driver_load': drivers/gpu/drm/i915/i915_dma.c:1114: warning: 'll_base' may be used uninitialized in this function Partly this is because gcc isn't smart enough. But `ll_base' does get used uninitialised in the DRM_DEBUG() call. Cc: Jesse Barnes jbar...@virtuousgeek.org Cc: Eric Anholt e...@anholt.net Cc: Dave Airlie airl...@linux.ie Signed-off-by: Andrew Morton a...@linux-foundation.org Applied. thanks! pgpNDghQt7z80.pgp Description: PGP signature -- This SF.Net email is sponsored by the Verizon Developer Community Take advantage of Verizon's best-in-class app development support A streamlined, 14 day to market process makes app distribution fast and easy Join now and get one step closer to millions of Verizon customers http://p.sf.net/sfu/verizon-dev2dev -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
Re: [patch for 2.6.32? 1/3] drivers/gpu/drm/i915/i915_dma.c: fix unused var
Yeah, may as well apply this one, or the printk will look funky on
GM45+ platforms.
Eric?
Jesse
On Mon, 21 Dec 2009 15:23:20 -0800
Andrew Morton a...@linux-foundation.org wrote:
This bugfix appears to have been ignored, so it missed 2.6.32.
I've tagged my 2.6.33 copy as needing a 2.6.32.x backport.
On Tue, 17 Nov 2009 14:08:52 -0800
a...@linux-foundation.org wrote:
From: Andrew Morton a...@linux-foundation.org
drivers/gpu/drm/i915/i915_dma.c: In function 'i915_driver_load':
drivers/gpu/drm/i915/i915_dma.c:1114: warning: 'll_base' may be
used uninitialized in this function
Partly this is because gcc isn't smart enough. But `ll_base' does
get used uninitialised in the DRM_DEBUG() call.
Cc: Jesse Barnes jbar...@virtuousgeek.org
Cc: Eric Anholt e...@anholt.net
Cc: Dave Airlie airl...@linux.ie
Signed-off-by: Andrew Morton a...@linux-foundation.org
---
drivers/gpu/drm/i915/i915_dma.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff -puN
drivers/gpu/drm/i915/i915_dma.c~drivers-gpu-drm-i915-i915_dmac-fix-unused-var
drivers/gpu/drm/i915/i915_dma.c ---
a/drivers/gpu/drm/i915/i915_dma.c~drivers-gpu-drm-i915-i915_dmac-fix-unused-var
+++ a/drivers/gpu/drm/i915/i915_dma.c @@ -,7 +,8 @@ static
void i915_setup_compression(struc { struct drm_i915_private
*dev_priv = dev-dev_private; struct drm_mm_node *compressed_fb,
*compressed_llb;
- unsigned long cfb_base, ll_base;
+ unsigned long cfb_base;
+ unsigned long ll_base = 0;
/* Leave 1M for line length buffer misc. */
compressed_fb = drm_mm_search_free(dev_priv-vram, size,
4096, 0); _
--
Jesse Barnes, Intel Open Source Technology Center
--
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel
Re: [patch for 2.6.32? 1/3] drivers/gpu/drm/i915/i915_dma.c: fix unused var
This bugfix appears to have been ignored, so it missed 2.6.32.
I've tagged my 2.6.33 copy as needing a 2.6.32.x backport.
On Tue, 17 Nov 2009 14:08:52 -0800
a...@linux-foundation.org wrote:
From: Andrew Morton a...@linux-foundation.org
drivers/gpu/drm/i915/i915_dma.c: In function 'i915_driver_load':
drivers/gpu/drm/i915/i915_dma.c:1114: warning: 'll_base' may be used
uninitialized in this function
Partly this is because gcc isn't smart enough. But `ll_base' does get used
uninitialised in the DRM_DEBUG() call.
Cc: Jesse Barnes jbar...@virtuousgeek.org
Cc: Eric Anholt e...@anholt.net
Cc: Dave Airlie airl...@linux.ie
Signed-off-by: Andrew Morton a...@linux-foundation.org
---
drivers/gpu/drm/i915/i915_dma.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff -puN
drivers/gpu/drm/i915/i915_dma.c~drivers-gpu-drm-i915-i915_dmac-fix-unused-var
drivers/gpu/drm/i915/i915_dma.c
---
a/drivers/gpu/drm/i915/i915_dma.c~drivers-gpu-drm-i915-i915_dmac-fix-unused-var
+++ a/drivers/gpu/drm/i915/i915_dma.c
@@ -,7 +,8 @@ static void i915_setup_compression(struc
{
struct drm_i915_private *dev_priv = dev-dev_private;
struct drm_mm_node *compressed_fb, *compressed_llb;
- unsigned long cfb_base, ll_base;
+ unsigned long cfb_base;
+ unsigned long ll_base = 0;
/* Leave 1M for line length buffer misc. */
compressed_fb = drm_mm_search_free(dev_priv-vram, size, 4096, 0);
_
--
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel
[patch for 2.6.32? 1/3] drivers/gpu/drm/i915/i915_dma.c: fix unused var
From: Andrew Morton a...@linux-foundation.org
drivers/gpu/drm/i915/i915_dma.c: In function 'i915_driver_load':
drivers/gpu/drm/i915/i915_dma.c:1114: warning: 'll_base' may be used
uninitialized in this function
Partly this is because gcc isn't smart enough. But `ll_base' does get used
uninitialised in the DRM_DEBUG() call.
Cc: Jesse Barnes jbar...@virtuousgeek.org
Cc: Eric Anholt e...@anholt.net
Cc: Dave Airlie airl...@linux.ie
Signed-off-by: Andrew Morton a...@linux-foundation.org
---
drivers/gpu/drm/i915/i915_dma.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff -puN
drivers/gpu/drm/i915/i915_dma.c~drivers-gpu-drm-i915-i915_dmac-fix-unused-var
drivers/gpu/drm/i915/i915_dma.c
---
a/drivers/gpu/drm/i915/i915_dma.c~drivers-gpu-drm-i915-i915_dmac-fix-unused-var
+++ a/drivers/gpu/drm/i915/i915_dma.c
@@ -,7 +,8 @@ static void i915_setup_compression(struc
{
struct drm_i915_private *dev_priv = dev-dev_private;
struct drm_mm_node *compressed_fb, *compressed_llb;
- unsigned long cfb_base, ll_base;
+ unsigned long cfb_base;
+ unsigned long ll_base = 0;
/* Leave 1M for line length buffer misc. */
compressed_fb = drm_mm_search_free(dev_priv-vram, size, 4096, 0);
_
--
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel
