Re: [Dri-devel] Re: [Xpert]Re: Probable return of Radeon, R128 XFree86 crash at VT switch

2002-10-19 Thread David Dawes
On Fri, Oct 18, 2002 at 07:42:23PM -0400, Mike A. Harris wrote:
>On Thu, 17 Oct 2002, Marc Aurele La France wrote:
>
>>> The problem WAS that this re-enabling did not always take place before
>>> Marc's changes, which is why we added the explicit call to do this.  I've
>>> checked the code in current XFree86 CVS, but would very much like to know
>>> (just for interest's sake) WHERE exactly the PCI enable (or whatnot) is
>>> called from that re-enables bus mastering after a VT switch.
>>
>>The question on my, and David's, mind is whether or not bus mastering was
>>enabled on server entry.
>
>I can't say for every reported case, but I can say that on the 
>cases I examined personally, that the video hardware had Bus 
>Mastering enabled prior to the X server being started (lspci 
>-vvv), as well as while the X server was running.  Switching to a 
>VT and doing lspci -vvv then showed bus mastering disabled.

OK, I just tested this with a stock XFree86 4.2.0 build, and lspci -vvv
shows that the bus master state when switching to another VT is always
the same as that before the X server was started.  I tried this with a
Radeon 7500 and a PIII motherboard with a 440BX chipset, running RH 7.2
with the default kernel.  Bus mastering was on by default, and never
got turned off when VT switching.  If I turned it off manually, then it
got turned on by the radeon driver, and back off at VTLeave.  It then
remained off because the unpatched driver didn't turn it back on at
VTEnter.

If the X server doesn't restore the PCI state at VTLeave and X server
exit, it's a bug.  So, if you do reproduce it again, it would help to
find out exactly why it's happening.

David


---
This sf.net email is sponsored by:
Access Your PC Securely with GoToMyPC. Try Free Now
https://www.gotomypc.com/s/OSND/DD
___
Dri-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/dri-devel



Re: [Dri-devel] Re: [Xpert]Re: Probable return of Radeon, R128 XFree86 crash at VT switch

2002-10-17 Thread Charl P. Botha
On Thu, Oct 17, 2002 at 02:51:57PM -0600, Marc Aurele La France wrote:
> The question on my, and David's, mind is whether or not bus mastering was
> enabled on server entry.

According to lspci, it was definitely enabled.

> > Thanks and my apologies for the upset.
> 
> Indeed.  In the future, please differentiate between real and perceived
> problems.

Please excuse me for having spent a frustrating two weeks of my time
previously to try and find this problem and present a solution which, at
that time, fixed VT switches for quite a number of ATI users.  This should
be seen in the context of the fact that this problem was known about and
nobody else was able to/was willing to spend the time to find a suitable
solution.

Please also excuse me for getting a little concerned at your changes and the
very cryptic CVS log message that you took time to submit.

I would also like to thank you for the decidedly unclear reply you sent to
the mail in which I voiced my concern.  If I were you, I would simply have
sent a mail clearing up the confusion (have a look at David's mail if you
would like to know how this is done) and thus politely stopping that whole
thread, but that's just me.

Thanks again,

-- 
charl p. botha http://cpbotha.net/ http://visualisation.tudelft.nl/


---
This sf.net email is sponsored by: viaVerio will pay you up to
$1,000 for every account that you consolidate with us.
http://ad.doubleclick.net/clk;4749864;7604308;v?
http://www.viaverio.com/consolidator/osdn.cfm
___
Dri-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/dri-devel



Re: [Dri-devel] Re: [Xpert]Re: Probable return of Radeon, R128 XFree86 crash at VT switch

2002-10-17 Thread David Dawes
On Fri, Oct 18, 2002 at 12:12:03AM +0200, Charl P. Botha wrote:
>On Thu, Oct 17, 2002 at 02:51:57PM -0600, Marc Aurele La France wrote:
>> The question on my, and David's, mind is whether or not bus mastering was
>> enabled on server entry.
>
>According to lspci, it was definitely enabled.

I'm reluctant to prolong this thread any further, but was bus
mastering enabled after a clean reboot and before running any X
server?  Whatever it was at this time is how the X server should
leave it after VT switching away and when exiting.

>Please also excuse me for getting a little concerned at your changes and the
>very cryptic CVS log message that you took time to submit.

I thought the message very descriptive, and the change a good idea
after running into exactly the same bug with the i830/i845G support
recently.

David


---
This sf.net email is sponsored by: viaVerio will pay you up to
$1,000 for every account that you consolidate with us.
http://ad.doubleclick.net/clk;4749864;7604308;v?
http://www.viaverio.com/consolidator/osdn.cfm
___
Dri-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/dri-devel