Re: Commit 96a4c8d50de20da865296a380b996f73204d6b34 breaks PowerBook LVDS
2010/3/16 Michel Dänzer : > > Commit 96a4c8d50de20da865296a380b996f73204d6b34 ('drm/radeon/kms: fix > i2c prescale calc on older radeons') breaks LVDS on my RV350 PowerBook > again. Reverting just that commit on top of drm-radeon-testing commit > 589468458fa964c2020e23e4d9353be2ef8bd3be fixes it. > Do any of the suggestions on bug 26430 help? http://bugs.freedesktop.org/show_bug.cgi?id=26430 Alex > > -- > Earthling Michel Dänzer | http://www.vmware.com > Libre software enthusiast | Debian, X and DRI developer > -- Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
Re: Commit 96a4c8d50de20da865296a380b996f73204d6b34 breaks PowerBook LVDS
On Tue, 2010-03-16 at 10:56 -0400, Alex Deucher wrote: > 2010/3/16 Michel Dänzer : > > > > Commit 96a4c8d50de20da865296a380b996f73204d6b34 ('drm/radeon/kms: fix > > i2c prescale calc on older radeons') breaks LVDS on my RV350 PowerBook > > again. Reverting just that commit on top of drm-radeon-testing commit > > 589468458fa964c2020e23e4d9353be2ef8bd3be fixes it. > > > > Do any of the suggestions on bug 26430 help? > http://bugs.freedesktop.org/show_bug.cgi?id=26430 I can try, but it'll probably take a while... -- Earthling Michel Dänzer |http://www.vmware.com Libre software enthusiast | Debian, X and DRI developer -- Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
Re: Commit 96a4c8d50de20da865296a380b996f73204d6b34 breaks PowerBook LVDS
On Tue, 2010-03-16 at 10:56 -0400, Alex Deucher wrote: > 2010/3/16 Michel Dänzer : > > > > Commit 96a4c8d50de20da865296a380b996f73204d6b34 ('drm/radeon/kms: fix > > i2c prescale calc on older radeons') breaks LVDS on my RV350 PowerBook > > again. Reverting just that commit on top of drm-radeon-testing commit > > 589468458fa964c2020e23e4d9353be2ef8bd3be fixes it. > > > > Do any of the suggestions on bug 26430 help? > http://bugs.freedesktop.org/show_bug.cgi?id=26430 I've tried i2c_clock = 50/10/100 and m = loop - 1, no luck. I also added debugging output to verify that sclk seems sane the calculations seem to take effect as expected: [ 59.138772] [drm] sclk=44550 [ 59.138775] [drm] nm=2227 [ 59.138779] [drm] loop=48 n=47 m=46 => prescale=0x2f2e So, did that commit actually fix anything? :} It regresses at least for me and doesn't seem to help for the bug it claims it 'should fix'... -- Earthling Michel Dänzer |http://www.vmware.com Libre software enthusiast | Debian, X and DRI developer -- Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
Re: Commit 96a4c8d50de20da865296a380b996f73204d6b34 breaks PowerBook LVDS
2010/3/17 Michel Dänzer : > On Tue, 2010-03-16 at 10:56 -0400, Alex Deucher wrote: >> 2010/3/16 Michel Dänzer : >> > >> > Commit 96a4c8d50de20da865296a380b996f73204d6b34 ('drm/radeon/kms: fix >> > i2c prescale calc on older radeons') breaks LVDS on my RV350 PowerBook >> > again. Reverting just that commit on top of drm-radeon-testing commit >> > 589468458fa964c2020e23e4d9353be2ef8bd3be fixes it. >> > >> >> Do any of the suggestions on bug 26430 help? >> http://bugs.freedesktop.org/show_bug.cgi?id=26430 > > I've tried i2c_clock = 50/10/100 and m = loop - 1, no luck. I also added > debugging output to verify that sclk seems sane the calculations seem to > take effect as expected: > > [ 59.138772] [drm] sclk=44550 > [ 59.138775] [drm] nm=2227 > [ 59.138779] [drm] loop=48 n=47 m=46 => prescale=0x2f2e > > > So, did that commit actually fix anything? :} It regresses at least for > me and doesn't seem to help for the bug it claims it 'should fix'... It fixed r1xx for me. Also, the prescale is actually applied to the sclk, to I think it was just luck that it worked with the reference clock. It just happened to be the right combination of numbers... All my cards worked fine with both algos :/ Alex -- Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel