Re: confirming broken EXT_texture_rectangle.
Dave Airlie wrote:
Hi Roland,
Just to reconfirm what I said on IRC, I put my M7 back into my
machine and my internal application is defintely broken with the latest
radeon texrect changes...
I'll leave the M7 in for a few days and I'll have a look at the code if I
get a chance..
Does this patch help? It's somehwat overkill I guess always updating the
texture matrix when the _NEW_TEXTURE flag is set (though the r200 driver
does exactly that, not quite sure yet why), but I think currently the
update_texturematrix function may not get triggered if a texrect texture
changes and since the texture matrix is needed to get correct coords for
texture rectangles it may not work correctly.
Roland
Index: radeon_state.c
===
RCS file: /cvs/mesa/Mesa/src/mesa/drivers/dri/radeon/radeon_state.c,v
retrieving revision 1.36
diff -u -r1.36 radeon_state.c
--- radeon_state.c 8 Oct 2005 23:36:35 - 1.36
+++ radeon_state.c 12 Oct 2005 12:38:58 -
@@ -2281,7 +2280,7 @@
/* Does this need to be triggered on eg. modelview for
* texgen-derived objplane/eyeplane matrices?
*/
- if (new_state _NEW_TEXTURE_MATRIX) {
+ if (new_state (_NEW_TEXTURE|_NEW_TEXTURE_MATRIX) {
update_texturematrix( ctx );
}
Re: confirming broken EXT_texture_rectangle.
Does this patch help? It's somehwat overkill I guess always updating the texture matrix when the _NEW_TEXTURE flag is set (though the r200 driver does exactly that, not quite sure yet why), but I think currently the update_texturematrix function may not get triggered if a texrect texture changes and since the texture matrix is needed to get correct coords for texture rectangles it may not work correctly. Yes that makes by textures works again.. Dave. -- David Airlie, Software Engineer http://www.skynet.ie/~airlied / airlied at skynet.ie Linux kernel - DRI, VAX / pam_smb / ILUG --- This SF.Net email is sponsored by: Power Architecture Resource Center: Free content, downloads, discussions, and more. http://solutions.newsforge.com/ibmarch.tmpl -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
confirming broken EXT_texture_rectangle.
Hi Roland, Just to reconfirm what I said on IRC, I put my M7 back into my machine and my internal application is defintely broken with the latest radeon texrect changes... I'll leave the M7 in for a few days and I'll have a look at the code if I get a chance.. Dave. -- David Airlie, Software Engineer http://www.skynet.ie/~airlied / airlied at skynet.ie Linux kernel - DRI, VAX / pam_smb / ILUG --- This SF.Net email is sponsored by: Power Architecture Resource Center: Free content, downloads, discussions, and more. http://solutions.newsforge.com/ibmarch.tmpl -- ___ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
