drm bugs hopefully fixed but there might still be one..

2005-03-24 Thread Dave Airlie

Hi Andrew, Dave,

I've put a couple of patches into my drm-2.6 tree that hopefully fix up
the multi-bridge on i915 and the XFree86 4.3 issue.. Andrew can you drop
the two patches in your tree.. the one from Brice and the one I attached
to the bug? you'll get conflicts anyway I'm sure. I had to modify Brices
one as it didn't look safe to me in all cases..

I think their might be one left, but I think it only seems to be on
non-intel AGP system, as in my system works fine for a combination of
cards and X releases ... anyone with a VIA chipset and Radeon graphics
card or r128 card.. testing the next -mm would help me a lot..

Dave.

-- 
David Airlie, Software Engineer
http://www.skynet.ie/~airlied / airlied at skynet.ie
Linux kernel - DRI, VAX / pam_smb / ILUG



---
This SF.net email is sponsored by Microsoft Mobile  Embedded DevCon 2005
Attend MEDC 2005 May 9-12 in Vegas. Learn more about the latest Windows
Embedded(r)  Windows Mobile(tm) platforms, applications  content.  Register
by 3/29  save $300 http://ads.osdn.com/?ad_id=6883alloc_id=15149op=click
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


Re: drm bugs hopefully fixed but there might still be one..

2005-03-24 Thread Andrew Morton
Dave Airlie [EMAIL PROTECTED] wrote:

 I've put a couple of patches into my drm-2.6 tree that hopefully fix up
  the multi-bridge on i915 and the XFree86 4.3 issue.. Andrew can you drop
  the two patches in your tree.. the one from Brice and the one I attached
  to the bug? you'll get conflicts anyway I'm sure. I had to modify Brices
  one as it didn't look safe to me in all cases..
 
  I think their might be one left, but I think it only seems to be on
  non-intel AGP system, as in my system works fine for a combination of
  cards and X releases ... anyone with a VIA chipset and Radeon graphics
  card or r128 card.. testing the next -mm would help me a lot..

argh, I just uploaded -mm2, but haven't announced it yet.  I'll resync with
your -bk.



---
This SF.net email is sponsored by Microsoft Mobile  Embedded DevCon 2005
Attend MEDC 2005 May 9-12 in Vegas. Learn more about the latest Windows
Embedded(r)  Windows Mobile(tm) platforms, applications  content.  Register
by 3/29  save $300 http://ads.osdn.com/?ad_id=6883alloc_id=15149op=click
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


Re: drm bugs hopefully fixed but there might still be one..

2005-03-24 Thread Jesse Barnes
On Thursday, March 24, 2005 2:33 am, Dave Airlie wrote:
 Hi Andrew, Dave,

 I've put a couple of patches into my drm-2.6 tree that hopefully fix up
 the multi-bridge on i915 and the XFree86 4.3 issue.. Andrew can you drop
 the two patches in your tree.. the one from Brice and the one I attached
 to the bug? you'll get conflicts anyway I'm sure. I had to modify Brices
 one as it didn't look safe to me in all cases..

 I think their might be one left, but I think it only seems to be on
 non-intel AGP system, as in my system works fine for a combination of
 cards and X releases ... anyone with a VIA chipset and Radeon graphics
 card or r128 card.. testing the next -mm would help me a lot..

I'm trying to get ahold of one--so hopefully I'll be able to test and fix this 
stuff up when I do.

Jesse


---
SF email is sponsored by - The IT Product Guide
Read honest  candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595alloc_id=14396op=click
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


Re: drm bugs hopefully fixed but there might still be one..

2005-03-24 Thread Dave Jones
On Thu, Mar 24, 2005 at 09:02:03AM -0800, Jesse Barnes wrote:
  On Thursday, March 24, 2005 2:33 am, Dave Airlie wrote:
   Hi Andrew, Dave,
  
   I've put a couple of patches into my drm-2.6 tree that hopefully fix up
   the multi-bridge on i915 and the XFree86 4.3 issue.. Andrew can you drop
   the two patches in your tree.. the one from Brice and the one I attached
   to the bug? you'll get conflicts anyway I'm sure. I had to modify Brices
   one as it didn't look safe to me in all cases..
  
   I think their might be one left, but I think it only seems to be on
   non-intel AGP system, as in my system works fine for a combination of
   cards and X releases ... anyone with a VIA chipset and Radeon graphics
   card or r128 card.. testing the next -mm would help me a lot..
  
  I'm trying to get ahold of one--so hopefully I'll be able to test and fix 
  this 
  stuff up when I do.

Aparently backing out the changes to via's tlb_flush routine fixed it
for one VIA user. I've not had a chance to look into it just yet.
Worse case we can just drop those changes for 2.6.12

Dave




---
SF email is sponsored by - The IT Product Guide
Read honest  candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595alloc_id=14396op=click
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


Re: drm bugs hopefully fixed but there might still be one..

2005-03-24 Thread Jesse Barnes
On Thursday, March 24, 2005 10:18 am, Dave Jones wrote:
   I'm trying to get ahold of one--so hopefully I'll be able to test and
   fix this stuff up when I do.

 Aparently backing out the changes to via's tlb_flush routine fixed it
 for one VIA user. I've not had a chance to look into it just yet.
 Worse case we can just drop those changes for 2.6.12

You mean these changes?

--- a/drivers/char/agp/via-agp.c2005-03-24 10:33:45 -08:00
+++ b/drivers/char/agp/via-agp.c2005-03-24 10:33:45 -08:00
@@ -83,8 +83,10 @@
 
pci_read_config_dword(agp_bridge-dev, VIA_GARTCTRL, temp);
temp |= (17);
+   temp = ~0x7f;
pci_write_config_dword(agp_bridge-dev, VIA_GARTCTRL, temp);
temp = ~(17);
+   temp = ~0x7f;
pci_write_config_dword(agp_bridge-dev, VIA_GARTCTRL, temp);
 }


I'll ask Markus to try reverting this since I still don't have a machine 
setup.  It sounds like a possibility given what he's seeing.

Jesse


---
SF email is sponsored by - The IT Product Guide
Read honest  candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595alloc_id=14396op=click
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


Re: drm bugs hopefully fixed but there might still be one..

2005-03-24 Thread cliff white
On Thu, 24 Mar 2005 10:33:02 + (GMT)
Dave Airlie [EMAIL PROTECTED] wrote:

 
 Hi Andrew, Dave,
 
 I've put a couple of patches into my drm-2.6 tree that hopefully fix up
 the multi-bridge on i915 and the XFree86 4.3 issue.. Andrew can you drop
 the two patches in your tree.. the one from Brice and the one I attached
 to the bug? you'll get conflicts anyway I'm sure. I had to modify Brices
 one as it didn't look safe to me in all cases..
 
 I think their might be one left, but I think it only seems to be on
 non-intel AGP system, as in my system works fine for a combination of
 cards and X releases ... anyone with a VIA chipset and Radeon graphics
 card or r128 card.. testing the next -mm would help me a lot..

Okay, i have a iBook G4, with radeon, with 2.6.12-rc1-mm2, i'm getting the 
following OOPS
on boot. I'm hand-copying this stuff, please let me know if you need any more 
info, .config, etc
[drm] Initalized drm 1.0.0 20040925
floating point used in kernel (task=effc1770, pc=c03bd040)
Oops: kernel access of nad area, sig:11 [#1]
PREEMPT
NIP: C03BD040 LR: C01, cliffw80540 SP:
...
TASK = effc1770[1] 'swapper' THREAD: effc2000


LRL [c0180540] drm_agp_init+0x48/0xdc
Call trace:
 [c017e74c] drm_fill_in_dev+0xdc/0x180
 [c017eb44] drm_get_dev+0x78
 [c...] radeon_init
 [c...] do_initcalls
 [c..] init
 [c..] kernel_thread
---
cliffw

 
 Dave.
 
 -- 
 David Airlie, Software Engineer
 http://www.skynet.ie/~airlied / airlied at skynet.ie
 Linux kernel - DRI, VAX / pam_smb / ILUG
 
 -
 To unsubscribe from this list: send the line unsubscribe linux-kernel in
 the body of a message to [EMAIL PROTECTED]
 More majordomo info at  http://vger.kernel.org/majordomo-info.html
 Please read the FAQ at  http://www.tux.org/lkml/
 


-- 
Ive always gone through periods where I bolt upright at four in the morning; 
now at least theres a reason. -Michael Feldman


---
SF email is sponsored by - The IT Product Guide
Read honest  candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595alloc_id=14396op=click
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


Re: drm bugs hopefully fixed but there might still be one..

2005-03-24 Thread Andrew Morton
cliff white [EMAIL PROTECTED] wrote:

 Okay, i have a iBook G4, with radeon, with 2.6.12-rc1-mm2, i'm getting the 
 following OOPS
 on boot. 

Please try reverting agp-make-some-code-static.patch (Dunno why that would
fix an oops, but apparently it does).



---
SF email is sponsored by - The IT Product Guide
Read honest  candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595alloc_id=14396op=click
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


Re: drm bugs hopefully fixed but there might still be one..

2005-03-24 Thread Andrew Morton
cliff white [EMAIL PROTECTED] wrote:

 -extern struct agp_bridge_data *(*agp_find_bridge)(struct pci_dev *);
 -

Oh crap, so the compiler decided that agp_find_bridge() was a function and
decided to jump to it, rather than reading from it and doing an indirect
jump.  Yup, that'll crash it.  Sorry about that.

This is another reason why doing the old-style

(*agp_find_bridge)(...);

is better than doing the new-style

agp_find_bridge(...);

The former case won't even compile, and is more readable.


---
SF email is sponsored by - The IT Product Guide
Read honest  candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595alloc_id=14396op=click
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel


Re: drm bugs hopefully fixed but there might still be one..

2005-03-24 Thread cliff white
On Thu, 24 Mar 2005 14:21:31 -0800
Andrew Morton [EMAIL PROTECTED] wrote:

 cliff white [EMAIL PROTECTED] wrote:
 
  Okay, i have a iBook G4, with radeon, with 2.6.12-rc1-mm2, i'm getting the 
  following OOPS
  on boot. 
 
 Please try reverting agp-make-some-code-static.patch (Dunno why that would
 fix an oops, but apparently it does).
 
It does the same thing Brice's fix does. Need to put the 
one extern struct definition back in agp_backend.h and that is the badness:

diff -puN include/linux/agp_backend.h~agp-make-some-code-static 
include/linux/agp_backend.h
--- 25/include/linux/agp_backend.h~agp-make-some-code-static2005-03-21 
21:53:17.0 -0800
+++ 25-akpm/include/linux/agp_backend.h 2005-03-21 21:53:17.0 -0800
@@ -94,8 +94,6 @@ struct agp_memory {
 extern struct agp_bridge_data *agp_bridge;
 extern struct list_head agp_bridges;

-extern struct agp_bridge_data *(*agp_find_bridge)(struct pci_dev *);
-
 extern void agp_free_memory(struct agp_memory *);
 extern struct agp_memory *agp_allocate_memory(struct agp_bridge_data *, 
size_t, u32);
 extern int agp_copy_info(struct agp_bridge_data *, struct agp_kern_info *);
_
--
cliffw

-- 
Ive always gone through periods where I bolt upright at four in the morning; 
now at least theres a reason. -Michael Feldman


---
SF email is sponsored by - The IT Product Guide
Read honest  candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595alloc_id=14396op=click
--
___
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel