Re: [PATCH] Staging: ft1000: fixed coding style issues
On Sat, Nov 02, 2013 at 11:18:20PM +0200, Aldo Iljazi wrote: Aldo Iljazi wrote: Fixed a few coding style issues that checkpatch reported. Specifically: 1. line over 80 characters issue on the lines 9 and 10. 2. space prohibited before open square bracket '[' issue on the lines 31. 3. inserted space after comma on lines 32 to 156. Signed-off-by: Aldo Iljazi m...@aldo.io This file is easy to review so you may as well fix all the issues. Clean up the license block so it's in the normal format. Put the commas at the end of the line instead of the beginning. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Staging: ft1000: fixed coding style issues
Dan Carpenter wrote: On Sat, Nov 02, 2013 at 11:18:20PM +0200, Aldo Iljazi wrote: Aldo Iljazi wrote: Fixed a few coding style issues that checkpatch reported. Specifically: 1. line over 80 characters issue on the lines 9 and 10. 2. space prohibited before open square bracket '[' issue on the lines 31. 3. inserted space after comma on lines 32 to 156. Signed-off-by: Aldo Iljazi m...@aldo.io This file is easy to review so you may as well fix all the issues. Clean up the license block so it's in the normal format. Put the commas at the end of the line instead of the beginning. regards, dan carpenter Okay I'll resend later. -- Aldo Iljazi ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] Staging: ft1000: fixed a few styling issues
Fixed a few styling issues, specifically: boot.h:30: ERROR: space prohibited before open square bracket '[' boot.h:31: ERROR: space required after that ',' (ctx:VxV) boot.h:31: ERROR: space required after that ',' (ctx:VxV) boot.h:31: ERROR: space required after that ',' (ctx:VxV) boot.h:31: ERROR: space required after that ',' (ctx:VxV) boot.h:31: ERROR: space required after that ',' (ctx:VxV) boot.h:32: ERROR: space required after that ',' (ctx:ExV) boot.h:32: ERROR: space required after that ',' (ctx:VxV) boot.h:32: ERROR: space required after that ',' (ctx:VxV) boot.h:32: ERROR: space required after that ',' (ctx:VxV) boot.h:32: ERROR: space required after that ',' (ctx:VxV) boot.h:32: ERROR: space required after that ',' (ctx:VxV) boot.h:33: ERROR: space required after that ',' (ctx:ExV) boot.h:33: ERROR: space required after that ',' (ctx:VxV) boot.h:33: ERROR: space required after that ',' (ctx:VxV) boot.h:33: ERROR: space required after that ',' (ctx:VxV) boot.h:33: ERROR: space required after that ',' (ctx:VxV) boot.h:33: ERROR: space required after that ',' (ctx:VxV) boot.h:34: ERROR: space required after that ',' (ctx:ExV) boot.h:34: ERROR: space required after that ',' (ctx:VxV) boot.h:34: ERROR: space required after that ',' (ctx:VxV) boot.h:34: ERROR: space required after that ',' (ctx:VxV) boot.h:34: ERROR: space required after that ',' (ctx:VxV) boot.h:34: ERROR: space required after that ',' (ctx:VxV) boot.h:35: ERROR: space required after that ',' (ctx:ExV) boot.h:35: ERROR: space required after that ',' (ctx:VxV) boot.h:35: ERROR: space required after that ',' (ctx:VxV) boot.h:35: ERROR: space required after that ',' (ctx:VxV) boot.h:35: ERROR: space required after that ',' (ctx:VxV) boot.h:35: ERROR: space required after that ',' (ctx:VxV) boot.h:36: ERROR: space required after that ',' (ctx:ExV) boot.h:36: ERROR: space required after that ',' (ctx:VxV) boot.h:36: ERROR: space required after that ',' (ctx:VxV) boot.h:36: ERROR: space required after that ',' (ctx:VxV) boot.h:36: ERROR: space required after that ',' (ctx:VxV) boot.h:36: ERROR: space required after that ',' (ctx:VxV) boot.h:37: ERROR: space required after that ',' (ctx:ExV) boot.h:37: ERROR: space required after that ',' (ctx:VxV) boot.h:37: ERROR: space required after that ',' (ctx:VxV) boot.h:37: ERROR: space required after that ',' (ctx:VxV) boot.h:37: ERROR: space required after that ',' (ctx:VxV) boot.h:37: ERROR: space required after that ',' (ctx:VxV) boot.h:38: ERROR: space required after that ',' (ctx:ExV) boot.h:38: ERROR: space required after that ',' (ctx:VxV) boot.h:38: ERROR: space required after that ',' (ctx:VxV) boot.h:38: ERROR: space required after that ',' (ctx:VxV) boot.h:38: ERROR: space required after that ',' (ctx:VxV) boot.h:38: ERROR: space required after that ',' (ctx:VxV) boot.h:39: ERROR: space required after that ',' (ctx:ExV) boot.h:39: ERROR: space required after that ',' (ctx:VxV) boot.h:39: ERROR: space required after that ',' (ctx:VxV) boot.h:39: ERROR: space required after that ',' (ctx:VxV) boot.h:39: ERROR: space required after that ',' (ctx:VxV) boot.h:39: ERROR: space required after that ',' (ctx:VxV) boot.h:40: ERROR: space required after that ',' (ctx:ExV) boot.h:40: ERROR: space required after that ',' (ctx:VxV) boot.h:40: ERROR: space required after that ',' (ctx:VxV) boot.h:40: ERROR: space required after that ',' (ctx:VxV) boot.h:40: ERROR: space required after that ',' (ctx:VxV) boot.h:40: ERROR: space required after that ',' (ctx:VxV) boot.h:41: ERROR: space required after that ',' (ctx:ExV) boot.h:41: ERROR: space required after that ',' (ctx:VxV) boot.h:41: ERROR: space required after that ',' (ctx:VxV) boot.h:41: ERROR: space required after that ',' (ctx:VxV) boot.h:41: ERROR: space required after that ',' (ctx:VxV) boot.h:41: ERROR: space required after that ',' (ctx:VxV) boot.h:42: ERROR: space required after that ',' (ctx:ExV) boot.h:42: ERROR: space required after that ',' (ctx:VxV) boot.h:42: ERROR: space required after that ',' (ctx:VxV) boot.h:42: ERROR: space required after that ',' (ctx:VxV) boot.h:42: ERROR: space required after that ',' (ctx:VxV) boot.h:42: ERROR: space required after that ',' (ctx:VxV) boot.h:43: ERROR: space required after that ',' (ctx:ExV) boot.h:43: ERROR: space required after that ',' (ctx:VxV) boot.h:43: ERROR: space required after that ',' (ctx:VxV) boot.h:43: ERROR: space required after that ',' (ctx:VxV) boot.h:43: ERROR: space required after that ',' (ctx:VxV) boot.h:43: ERROR: space required after that ',' (ctx:VxV) boot.h:44: ERROR: space required after that ',' (ctx:ExV) boot.h:44: ERROR: space required after that ',' (ctx:VxV) boot.h:44: ERROR: space required after that ',' (ctx:VxV) boot.h:44: ERROR: space required after that ',' (ctx:VxV) boot.h:44: ERROR: space required after that ',' (ctx:VxV) boot.h:44: ERROR: space required after that ',' (ctx:VxV) boot.h:45: ERROR: space required after that ',' (ctx:ExV) boot.h:45: ERROR:
Re: [patch] Staging: sb105x: info leak in mp_get_count()
On Tue, Oct 29, 2013 at 11:01:43PM +0300, Dan Carpenter wrote:
The icount.reserved[] array isn't initialized so it leaks stack
information to userspace.
Reported-by: Nico Golde n...@ngolde.de
Reported-by: Fabian Yamaguchi f...@goesec.de
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
Reviewed-by: Josh Triplett j...@joshtriplett.org
Also, you don't quite have the patch format right here; you should have
a --- line after the commit mesage, followed by a diffstat. Did you use
git format-patch to generate this patch?
diff --git a/drivers/staging/sb105x/sb_pci_mp.c
b/drivers/staging/sb105x/sb_pci_mp.c
index bc53b4e..bde28b9 100644
--- a/drivers/staging/sb105x/sb_pci_mp.c
+++ b/drivers/staging/sb105x/sb_pci_mp.c
@@ -1063,7 +1063,7 @@ static int mp_wait_modem_status(struct sb_uart_state
*state, unsigned long arg)
static int mp_get_count(struct sb_uart_state *state, struct
serial_icounter_struct *icnt)
{
- struct serial_icounter_struct icount;
+ struct serial_icounter_struct icount = {};
struct sb_uart_icount cnow;
struct sb_uart_port *port = state-port;
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Staging: ft1000: fixed a few styling issues
On Sun, Nov 03, 2013 at 04:20:38PM +0200, Aldo Iljazi wrote: Fixed a few styling issues, specifically: Gar... No one wants to read that changelog. That was over 700 lines of repeated text. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [patch] Staging: sb105x: info leak in mp_get_count()
On Sun, Nov 03, 2013 at 10:28:02AM -0800, Josh Triplett wrote: On Tue, Oct 29, 2013 at 11:01:43PM +0300, Dan Carpenter wrote: The icount.reserved[] array isn't initialized so it leaks stack information to userspace. Reported-by: Nico Golde n...@ngolde.de Reported-by: Fabian Yamaguchi f...@goesec.de Signed-off-by: Dan Carpenter dan.carpen...@oracle.com Reviewed-by: Josh Triplett j...@joshtriplett.org Also, you don't quite have the patch format right here; you should have a --- line after the commit mesage, followed by a diffstat. Did you use git format-patch to generate this patch? I normally don't include the diffstat. Which tools care about that? regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [patch] Staging: sb105x: info leak in mp_get_count()
On Mon, Nov 04, 2013 at 02:11:50AM +0300, Dan Carpenter wrote: On Sun, Nov 03, 2013 at 10:28:02AM -0800, Josh Triplett wrote: On Tue, Oct 29, 2013 at 11:01:43PM +0300, Dan Carpenter wrote: The icount.reserved[] array isn't initialized so it leaks stack information to userspace. Reported-by: Nico Golde n...@ngolde.de Reported-by: Fabian Yamaguchi f...@goesec.de Signed-off-by: Dan Carpenter dan.carpen...@oracle.com Reviewed-by: Josh Triplett j...@joshtriplett.org Also, you don't quite have the patch format right here; you should have a --- line after the commit mesage, followed by a diffstat. Did you use git format-patch to generate this patch? I normally don't include the diffstat. Which tools care about that? Human wetware. :) It isn't required by any tools. The --- is, though, to produce something applicable by git. - Josh Triplett ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [patch] Staging: sb105x: info leak in mp_get_count()
I've dropped most of the people from the CC list. On Sun, Nov 03, 2013 at 08:31:50PM -0800, Josh Triplett wrote: On Mon, Nov 04, 2013 at 02:11:50AM +0300, Dan Carpenter wrote: On Sun, Nov 03, 2013 at 10:28:02AM -0800, Josh Triplett wrote: On Tue, Oct 29, 2013 at 11:01:43PM +0300, Dan Carpenter wrote: The icount.reserved[] array isn't initialized so it leaks stack information to userspace. Reported-by: Nico Golde n...@ngolde.de Reported-by: Fabian Yamaguchi f...@goesec.de Signed-off-by: Dan Carpenter dan.carpen...@oracle.com Reviewed-by: Josh Triplett j...@joshtriplett.org Also, you don't quite have the patch format right here; you should have a --- line after the commit mesage, followed by a diffstat. Did you use git format-patch to generate this patch? I normally don't include the diffstat. Which tools care about that? Human wetware. :) It isn't required by any tools. The --- is, though, to produce something applicable by git. That's really weird. I've been using the same scripts for years and no one has complained before. The patch applies fine with `git am` for me. I'm using git version 1.7.10.4. How are you applying patches? I can update my scripts. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
