[PATCH] staging: goldfish: Fix NULL comparison style

2015-09-02 Thread Ravi Teja Darbha 
Fixed NULL comparison style as suggested by checkpatch.pl with --strict
option.

Signed-off-by: Ravi Teja Darbha 
---
 drivers/staging/goldfish/goldfish_nand.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/goldfish/goldfish_nand.c 
b/drivers/staging/goldfish/goldfish_nand.c
index 66ae48f..623353db5 100644
--- a/drivers/staging/goldfish/goldfish_nand.c
+++ b/drivers/staging/goldfish/goldfish_nand.c
@@ -48,7 +48,7 @@ static u32 goldfish_nand_cmd_with_params(struct mtd_info *mtd,
struct cmd_params *cps = nand->cmd_params;
unsigned char __iomem  *base = nand->base;
 
-   if (cps == NULL)
+   if (!cps)
return -1;
 
switch (cmd) {
@@ -379,7 +379,7 @@ static int goldfish_nand_probe(struct platform_device *pdev)
unsigned char __iomem  *base;
 
r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-   if (r == NULL)
+   if (!r)
return -ENODEV;
 
base = devm_ioremap(>dev, r->start, PAGE_SIZE);
-- 
1.9.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 2/2] staging/fbtft: use spi_setup instead of direct call to master->setup

2015-09-02 Thread Noralf Trønnes 


Den 01.09.2015 19:52, skrev Brüns, Stefan:

On Tuesday, September 01, 2015 16:57:14 Noralf Trønnes wrote:

IMHO, this is a bad idea. A controller supporting more than 32 bpw can
not set the bpw mask, as the mask is limited to 32 bits. Thus it has to
check the bpw in its own setup function, and may or may not reject 9 bpw.

Why should one penalize any controllers having an unset bpw mask, which
is a completely valid configuration?

BTW, the SPI core patch needed for this to work is in the 4.3 pull
request.

I have acked a patch from Stefan Wahren adressing this issue:
http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2015-Augus
t/075423.html

Two issues:

1st: Stefan Wahren posted a patch large part identical to mine, 18 hours
later. Coincidence?


For my part I admit to being sloppy here, I should have pulled you into 
the thread.


According to the commit message, Stefan Wahren seem to have detected 
this problem
on the ARM MXS platform and you refere to xilinx, so I guess it's a 
coincidence.



2nd: Modifying bpw and not calling spi_setup() is IMHO wrong. The controller
setup function could e.g. modify max_speed_hz.


We are only changing bits_per_word, and spi_setup() has already been called.

Callchain for DT registered spi devices:
spi_register_master->of_register_spi_devices->of_register_spi_device->
spi_add_device->spi_setup

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: amso1100: change occurrences of foo* to foo *

2015-09-02 Thread Ivan Radanov Ivanov 
Signed-off-by: Ivan Radanov Ivanov 
---
 drivers/staging/amso1100/c2_ae.c | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/amso1100/c2_ae.c b/drivers/staging/amso1100/c2_ae.c
index cedda25..24faa77 100644
--- a/drivers/staging/amso1100/c2_ae.c
+++ b/drivers/staging/amso1100/c2_ae.c
@@ -66,9 +66,9 @@ static int c2_convert_cm_status(u32 c2_status)
}
 }
 
-static const char* to_event_str(int event)
+static const char *to_event_str(int event)
 {
-   static const char* event_str[] = {
+   static const char *event_str[] = {
"CCAE_REMOTE_SHUTDOWN",
"CCAE_ACTIVE_CONNECT_RESULTS",
"CCAE_CONNECTION_REQUEST",
@@ -244,7 +244,7 @@ void c2_ae_event(struct c2_dev *c2dev, u32 mq_index)
case CCAE_LLP_CLOSE_COMPLETE:
case CCAE_LLP_CONNECTION_RESET:
case CCAE_LLP_CONNECTION_LOST:
-   BUG_ON(cm_id->event_handler==(void*)0x6b6b6b6b);
+   BUG_ON(cm_id->event_handler==(void *)0x6b6b6b6b);
 
spin_lock_irqsave(>lock, flags);
if (qp->cm_id) {
@@ -282,7 +282,7 @@ void c2_ae_event(struct c2_dev *c2dev, u32 mq_index)
break;
}
cm_event.event = IW_CM_EVENT_CONNECT_REQUEST;
-   cm_event.provider_data = (void*)(unsigned long)req->cr_handle;
+   cm_event.provider_data = (void *)(unsigned long)req->cr_handle;
laddr->sin_addr.s_addr = req->laddr;
raddr->sin_addr.s_addr = req->raddr;
laddr->sin_port = req->lport;
-- 
2.5.0

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCHv4 1/2] staging: wilc1000: remove FREE_WILC_BUFFER()

2015-09-02 Thread Greg Kroah-Hartman 
On Tue, Aug 18, 2015 at 11:14:49PM -0400, Raphaël Beamonte wrote:
> It was just a wrapper around kfree(), so call that instead.
> 
> Signed-off-by: Raphaël Beamonte 
> ---
>  drivers/staging/wilc1000/wilc_exported_buf.c | 9 +++--
>  1 file changed, 3 insertions(+), 6 deletions(-)

Turns out this file is never even built, you should just remove it :)

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: android: fix typo

2015-09-02 Thread Greg KH 
On Thu, Aug 20, 2015 at 08:29:12AM +0900, Junesung Lee wrote:
> Fix typo.

What typo?  Be specific please.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: fbtft: Removed a space

2015-09-02 Thread Greg KH 
On Fri, Aug 21, 2015 at 06:31:33PM +0530, Aparna Karuthodi wrote:
> I fetched it yesterday using git fetch origin master. So, I thought I am in 
> the recent kernel tree.

That's a horrible changelog text :(

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 3/4] staging:fbtft : Fix whitespace issues

2015-09-02 Thread Greg KH 
On Wed, Sep 02, 2015 at 04:29:35PM -0700, Anish Bhatt wrote:
> * Add missing spaces after and before operators
> * Add blank lines where recommended by checkpatch.pl
> * Remove extra blank lines where recommended by checkpatch.pl

That's a lot of different things to do in one patch.  Remember, one
logical thing per patch.  If you have to list what you did, then it
needs to be split up.

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 2/4] staging/fbtft : Use macro for common fbtft addr win debug print

2015-09-02 Thread Greg KH 
On Wed, Sep 02, 2015 at 04:29:34PM -0700, Anish Bhatt wrote:
> Same fbtft_par_dbg(DEBUG_SET_ADDR_WIN..) debug print is repeated in
> every set_addr_win handler, repalce with a macro.

Ick.

>  static void set_addr_win(struct fbtft_par *par, int xs, int ys, int xe, int 
> ye)
>  {
> - fbtft_par_dbg(DEBUG_SET_ADDR_WIN, par,
> - "%s(xs=%d, ys=%d, xe=%d, ye=%d)\n", __func__, xs, ys, xe, ye);
> + fbtft_par_dbg_addr_win();

This should just be deleted entirely, we have function tracing in the
kernel if you want to use it, no need to write macros to duplicate the
same thing.

Please just remove these lines.

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 4/4] staging/fbtft : Use BIT() macro when possible

2015-09-02 Thread Greg KH 
On Wed, Sep 02, 2015 at 04:29:36PM -0700, Anish Bhatt wrote:
> Signed-off-by: Anish Bhatt 

I always need a changelog text :(
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 1/4] staging/fbtft : Remove FSF mailing address

2015-09-02 Thread Greg KH 
On Wed, Sep 02, 2015 at 04:29:33PM -0700, Anish Bhatt wrote:
> checkpatch.pl recommends that this is no longer required.
> Also replaces ASCII-art copyright notice with simple text
> 
> Signed-off-by: Anish Bhatt 

Corrupted and can't be applied :(
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 3/4] staging:fbtft : Fix whitespace issues

2015-09-02 Thread Anish Bhatt 
On Wed, Sep 2, 2015 at 6:12 PM, Greg KH  wrote:
> On Wed, Sep 02, 2015 at 04:29:35PM -0700, Anish Bhatt wrote:
>> * Add missing spaces after and before operators
>> * Add blank lines where recommended by checkpatch.pl
>> * Remove extra blank lines where recommended by checkpatch.pl
>
> That's a lot of different things to do in one patch.  Remember, one
> logical thing per patch.  If you have to list what you did, then it
> needs to be split up.
>
> thanks,
>
> greg k-h

Will do, thanks
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 1/4] staging/fbtft : Remove FSF mailing address

2015-09-02 Thread Anish Bhatt 
On Wed, Sep 2, 2015 at 6:13 PM, Greg KH  wrote:
> On Wed, Sep 02, 2015 at 04:29:33PM -0700, Anish Bhatt wrote:
>> checkpatch.pl recommends that this is no longer required.
>> Also replaces ASCII-art copyright notice with simple text
>>
>> Signed-off-by: Anish Bhatt 
>
> Corrupted and can't be applied :(

I'm guessing it has something to do with this git send-email warning :

The following files are 8bit, but do not declare a Content-Transfer-Encoding.
   0001-staging-fbtft-Remove-FSF-mailing-address-from-GPL-co.patch
   0003-staging-fbtft-Fix-whitespace-issues.patch
Which 8bit encoding should I declare [UTF-8]? y
Are you sure you want to use  [y/N]? y

I have patch generation and send scripted, and seems to get delivered
to net-next just fine,
so might be something with the actual files that are being modified.
Will dig around, but
pointers appreciated.
-Anish
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 1/4] staging/fbtft : Remove FSF mailing address

2015-09-02 Thread Greg KH 
On Wed, Sep 02, 2015 at 06:20:14PM -0700, Anish Bhatt wrote:
> On Wed, Sep 2, 2015 at 6:13 PM, Greg KH  wrote:
> > On Wed, Sep 02, 2015 at 04:29:33PM -0700, Anish Bhatt wrote:
> >> checkpatch.pl recommends that this is no longer required.
> >> Also replaces ASCII-art copyright notice with simple text
> >>
> >> Signed-off-by: Anish Bhatt 
> >
> > Corrupted and can't be applied :(
> 
> I'm guessing it has something to do with this git send-email warning :
> 
> The following files are 8bit, but do not declare a Content-Transfer-Encoding.
>0001-staging-fbtft-Remove-FSF-mailing-address-from-GPL-co.patch
>0003-staging-fbtft-Fix-whitespace-issues.patch
> Which 8bit encoding should I declare [UTF-8]? y
> Are you sure you want to use  [y/N]? y

Why did you use 'y' as an encoding?  That's not a valid one, and was
what the error was.

Just hit enter at the first question.

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v2] staging/fbtft : Remove FSF mailing address

2015-09-02 Thread Greg KH 
On Wed, Sep 02, 2015 at 06:28:34PM -0700, Anish Bhatt wrote:
> checkpatch.pl recommends that this is no longer required.
> Also replaces ASCII-art copyright notice with simple text
> 
> v2: Fix encoding issues accidentally introduced in git send-email

This shouldn't be in the changelog section, it should be below the ---
so that it doesn't show up in the final commit.

third try?
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v3] staging/fbtft : Remove FSF mailing address

2015-09-02 Thread Anish Bhatt 
checkpatch.pl recommends that this is no longer required.
Also replaces ASCII-art copyright notice with simple text

Signed-off-by: Anish Bhatt 
---
v2 : Fix encoding issues accidentally introduced in git send-email
v3 : Move patch versioning so that it wont show in changelog, cross fingers

 drivers/staging/fbtft/fb_bd663474.c  |  4 
 drivers/staging/fbtft/fb_hx8340bn.c  |  4 
 drivers/staging/fbtft/fb_hx8347d.c   |  4 
 drivers/staging/fbtft/fb_hx8353d.c   |  4 
 drivers/staging/fbtft/fb_hx8357d.c   |  3 ---
 drivers/staging/fbtft/fb_ili9320.c   |  4 
 drivers/staging/fbtft/fb_ili9325.c   |  4 
 drivers/staging/fbtft/fb_ili9340.c   |  4 
 drivers/staging/fbtft/fb_ili9341.c   |  4 
 drivers/staging/fbtft/fb_ili9481.c   |  4 
 drivers/staging/fbtft/fb_ili9486.c   |  4 
 drivers/staging/fbtft/fb_pcd8544.c   |  4 
 drivers/staging/fbtft/fb_ra8875.c| 24 
 drivers/staging/fbtft/fb_s6d02a1.c   |  4 
 drivers/staging/fbtft/fb_s6d1121.c   |  4 
 drivers/staging/fbtft/fb_ssd1289.c   |  4 
 drivers/staging/fbtft/fb_ssd1306.c   |  4 
 drivers/staging/fbtft/fb_st7735r.c   |  4 
 drivers/staging/fbtft/fb_tinylcd.c   |  4 
 drivers/staging/fbtft/fb_tls8204.c   |  4 
 drivers/staging/fbtft/fb_uc1701.c|  4 
 drivers/staging/fbtft/fb_upd161704.c |  4 
 drivers/staging/fbtft/fb_watterott.c |  4 
 drivers/staging/fbtft/fbtft-core.c   |  4 
 drivers/staging/fbtft/fbtft.h|  4 
 drivers/staging/fbtft/fbtft_device.c |  4 
 26 files changed, 4 insertions(+), 119 deletions(-)

diff --git a/drivers/staging/fbtft/fb_bd663474.c 
b/drivers/staging/fbtft/fb_bd663474.c
index 17a2162..deb069f 100644
--- a/drivers/staging/fbtft/fb_bd663474.c
+++ b/drivers/staging/fbtft/fb_bd663474.c
@@ -16,10 +16,6 @@
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
  */
 
 #include 
diff --git a/drivers/staging/fbtft/fb_hx8340bn.c 
b/drivers/staging/fbtft/fb_hx8340bn.c
index 54528aa..c5b2e51 100644
--- a/drivers/staging/fbtft/fb_hx8340bn.c
+++ b/drivers/staging/fbtft/fb_hx8340bn.c
@@ -17,10 +17,6 @@
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
  */
 
 #include 
diff --git a/drivers/staging/fbtft/fb_hx8347d.c 
b/drivers/staging/fbtft/fb_hx8347d.c
index 03ae95b..42fed64 100644
--- a/drivers/staging/fbtft/fb_hx8347d.c
+++ b/drivers/staging/fbtft/fb_hx8347d.c
@@ -14,10 +14,6 @@
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
  */
 
 #include 
diff --git a/drivers/staging/fbtft/fb_hx8353d.c 
b/drivers/staging/fbtft/fb_hx8353d.c
index d7f4308..79e7ebc 100644
--- a/drivers/staging/fbtft/fb_hx8353d.c
+++ b/drivers/staging/fbtft/fb_hx8353d.c
@@ -13,10 +13,6 @@
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
  */
 
 #include 
diff --git a/drivers/staging/fbtft/fb_hx8357d.c 
b/drivers/staging/fbtft/fb_hx8357d.c
index 8c7bb3a..1b0a29d 100644
--- a/drivers/staging/fbtft/fb_hx8357d.c
+++ b/drivers/staging/fbtft/fb_hx8357d.c
@@ -16,9 +16,6 @@
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, see .
  */
 
 #include 
diff --git a/drivers/staging/fbtft/fb_ili9320.c 
b/drivers/staging/fbtft/fb_ili9320.c
index ef4fa6b..edcd79c 100644
--- a/drivers/staging/fbtft/fb_ili9320.c
+++ b/drivers/staging/fbtft/fb_ili9320.c
@@ -12,10 +12,6 @@
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A

Re: [PATCH 0/8] staging: unisys: visornic/visorbus fixes

2015-09-02 Thread Greg KH 
On Tue, Aug 18, 2015 at 03:13:55PM -0400, Benjamin Romer wrote:
> This patch series addresses several issues found during review,
> testing, and by the kernel test bot.

These aren't all "fixes" so I can't just add them to the 4.3-final
release, but some look like they should go there.  So please split this
into two different series and resend, one for 4.3-final and one for
4.4-rc1.

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 3/4] staging:fbtft : Fix whitespace issues

2015-09-02 Thread Anish Bhatt 
* Add missing spaces after and before operators
* Add blank lines where recommended by checkpatch.pl
* Remove extra blank lines where recommended by checkpatch.pl

Signed-off-by: Anish Bhatt 
---
 drivers/staging/fbtft/fb_agm1264k-fl.c |  5 ++---
 drivers/staging/fbtft/fb_bd663474.c|  1 +
 drivers/staging/fbtft/fb_hx8340bn.c|  7 +++
 drivers/staging/fbtft/fb_hx8347d.c |  6 +++---
 drivers/staging/fbtft/fb_hx8353d.c |  3 +--
 drivers/staging/fbtft/fb_hx8357d.c |  2 +-
 drivers/staging/fbtft/fb_ili9163.c |  5 +++--
 drivers/staging/fbtft/fb_ili9320.c |  9 -
 drivers/staging/fbtft/fb_ili9325.c |  9 -
 drivers/staging/fbtft/fb_ili9340.c |  3 +--
 drivers/staging/fbtft/fb_ili9341.c |  8 
 drivers/staging/fbtft/fb_ili9481.c |  2 +-
 drivers/staging/fbtft/fb_ili9486.c |  3 +--
 drivers/staging/fbtft/fb_pcd8544.c | 10 +-
 drivers/staging/fbtft/fb_ra8875.c  |  9 +
 drivers/staging/fbtft/fb_s6d02a1.c |  2 +-
 drivers/staging/fbtft/fb_s6d1121.c |  7 ---
 drivers/staging/fbtft/fb_ssd1289.c |  8 
 drivers/staging/fbtft/fb_ssd1306.c | 12 ++--
 drivers/staging/fbtft/fb_ssd1331.c |  2 --
 drivers/staging/fbtft/fb_ssd1351.c | 12 +---
 drivers/staging/fbtft/fb_st7735r.c |  6 +++---
 drivers/staging/fbtft/fb_tinylcd.c |  3 +--
 drivers/staging/fbtft/fb_tls8204.c |  8 
 drivers/staging/fbtft/fb_uc1701.c  | 17 +
 drivers/staging/fbtft/fb_upd161704.c   |  1 +
 drivers/staging/fbtft/fb_watterott.c   |  4 ++--
 drivers/staging/fbtft/fbtft-bus.c  | 13 -
 drivers/staging/fbtft/fbtft-core.c | 16 +---
 drivers/staging/fbtft/fbtft-sysfs.c|  6 ++
 drivers/staging/fbtft/fbtft_device.c   |  7 ++-
 31 files changed, 92 insertions(+), 114 deletions(-)

diff --git a/drivers/staging/fbtft/fb_agm1264k-fl.c 
b/drivers/staging/fbtft/fb_agm1264k-fl.c
index 94dd49c..9d74e61 100644
--- a/drivers/staging/fbtft/fb_agm1264k-fl.c
+++ b/drivers/staging/fbtft/fb_agm1264k-fl.c
@@ -41,8 +41,7 @@
 #define CS0gpio.aux[0]
 #define CS1gpio.aux[1]
 
-
-/* diffusing error (?Floyd-Steinberg?) */
+/* diffusing error (Floyd-Steinberg) */
 #define DIFFUSING_MATRIX_WIDTH 2
 #define DIFFUSING_MATRIX_HEIGHT2
 
@@ -420,7 +419,6 @@ static int write(struct fbtft_par *par, void *buf, size_t 
len)
 
gpio_set_value(par->RW, 0); /* set write mode */
 
-
while (len--) {
u8 i, data;
 
@@ -456,6 +454,7 @@ static struct fbtft_display display = {
.write_vmem = write_vmem,
},
 };
+
 FBTFT_REGISTER_DRIVER(DRVNAME, "displaytronic,fb_agm1264k-fl", );
 
 MODULE_ALIAS("platform:" DRVNAME);
diff --git a/drivers/staging/fbtft/fb_bd663474.c 
b/drivers/staging/fbtft/fb_bd663474.c
index 69eb6d2..3614cd7 100644
--- a/drivers/staging/fbtft/fb_bd663474.c
+++ b/drivers/staging/fbtft/fb_bd663474.c
@@ -177,6 +177,7 @@ static struct fbtft_display display = {
.set_var = set_var,
},
 };
+
 FBTFT_REGISTER_DRIVER(DRVNAME, "hitachi,bd663474", );
 
 MODULE_ALIAS("spi:" DRVNAME);
diff --git a/drivers/staging/fbtft/fb_hx8340bn.c 
b/drivers/staging/fbtft/fb_hx8340bn.c
index c5b2e51..df2e213 100644
--- a/drivers/staging/fbtft/fb_hx8340bn.c
+++ b/drivers/staging/fbtft/fb_hx8340bn.c
@@ -35,12 +35,10 @@
 #define DEFAULT_GAMMA  "1 3 0E 5 0 2 09 0 6 1 7 1 0 2 2\n" \
"3 3 17 8 4 7 05 7 6 0 3 1 6 0 0 "
 
-
 static bool emulate;
 module_param(emulate, bool, 0);
 MODULE_PARM_DESC(emulate, "Force emulation in 9-bit mode");
 
-
 static int init_display(struct fbtft_par *par)
 {
par->fbtftops.reset(par);
@@ -141,7 +139,7 @@ static int set_var(struct fbtft_par *par)
 OP0 OP1 CP0 CP1 CP2 CP3 CP4 MP0 MP1 MP2 MP3 MP4 MP5 CGM0 CGM1
 ON0 ON1 CN0 CN1 CN2 CN3 CN4 MN0 MN1 MN2 MN3 MN4 MN5   GC
 */
-#define CURVE(num, idx)  curves[num*par->gamma.num_values + idx]
+#define CURVE(num, idx)  curves[num * par->gamma.num_values + idx]
 static int set_gamma(struct fbtft_par *par, unsigned long *curves)
 {
unsigned long mask[] = {
@@ -186,8 +184,8 @@ static int set_gamma(struct fbtft_par *par, unsigned long 
*curves)
 
return 0;
 }
-#undef CURVE
 
+#undef CURVE
 
 static struct fbtft_display display = {
.regwidth = 8,
@@ -204,6 +202,7 @@ static struct fbtft_display display = {
.set_gamma = set_gamma,
},
 };
+
 FBTFT_REGISTER_DRIVER(DRVNAME, "himax,hx8340bn", );
 
 MODULE_ALIAS("spi:" DRVNAME);
diff --git a/drivers/staging/fbtft/fb_hx8347d.c 
b/drivers/staging/fbtft/fb_hx8347d.c
index 14692f2..04d7a1b 100644
--- a/drivers/staging/fbtft/fb_hx8347d.c
+++ b/drivers/staging/fbtft/fb_hx8347d.c
@@ -29,7 +29,6 @@
 #define DEFAULT_GAMMA  "0 0 0 0 0 0 0 0 0 0 0 0 0 0\n" \
"0 0 0 0 0 0 0 0 0 0 0 0 0 0"
 
-
 static int init_display(struct fbtft_par *par)
 {

[PATCH 1/4] staging/fbtft : Remove FSF mailing address

2015-09-02 Thread Anish Bhatt 
checkpatch.pl recommends that this is no longer required.
Also replaces ASCII-art copyright notice with simple text

Signed-off-by: Anish Bhatt 
---
 drivers/staging/fbtft/fb_bd663474.c  |  4 
 drivers/staging/fbtft/fb_hx8340bn.c  |  4 
 drivers/staging/fbtft/fb_hx8347d.c   |  4 
 drivers/staging/fbtft/fb_hx8353d.c   |  4 
 drivers/staging/fbtft/fb_hx8357d.c   |  3 ---
 drivers/staging/fbtft/fb_ili9320.c   |  4 
 drivers/staging/fbtft/fb_ili9325.c   |  4 
 drivers/staging/fbtft/fb_ili9340.c   |  4 
 drivers/staging/fbtft/fb_ili9341.c   |  4 
 drivers/staging/fbtft/fb_ili9481.c   |  4 
 drivers/staging/fbtft/fb_ili9486.c   |  4 
 drivers/staging/fbtft/fb_pcd8544.c   |  4 
 drivers/staging/fbtft/fb_ra8875.c| 24 
 drivers/staging/fbtft/fb_s6d02a1.c   |  4 
 drivers/staging/fbtft/fb_s6d1121.c   |  4 
 drivers/staging/fbtft/fb_ssd1289.c   |  4 
 drivers/staging/fbtft/fb_ssd1306.c   |  4 
 drivers/staging/fbtft/fb_st7735r.c   |  4 
 drivers/staging/fbtft/fb_tinylcd.c   |  4 
 drivers/staging/fbtft/fb_tls8204.c   |  4 
 drivers/staging/fbtft/fb_uc1701.c|  4 
 drivers/staging/fbtft/fb_upd161704.c |  4 
 drivers/staging/fbtft/fb_watterott.c |  4 
 drivers/staging/fbtft/fbtft-core.c   |  4 
 drivers/staging/fbtft/fbtft.h|  4 
 drivers/staging/fbtft/fbtft_device.c |  4 
 26 files changed, 4 insertions(+), 119 deletions(-)

diff --git a/drivers/staging/fbtft/fb_bd663474.c 
b/drivers/staging/fbtft/fb_bd663474.c
index 17a2162..deb069f 100644
--- a/drivers/staging/fbtft/fb_bd663474.c
+++ b/drivers/staging/fbtft/fb_bd663474.c
@@ -16,10 +16,6 @@
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
  */
 
 #include 
diff --git a/drivers/staging/fbtft/fb_hx8340bn.c 
b/drivers/staging/fbtft/fb_hx8340bn.c
index 54528aa..c5b2e51 100644
--- a/drivers/staging/fbtft/fb_hx8340bn.c
+++ b/drivers/staging/fbtft/fb_hx8340bn.c
@@ -17,10 +17,6 @@
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
  */
 
 #include 
diff --git a/drivers/staging/fbtft/fb_hx8347d.c 
b/drivers/staging/fbtft/fb_hx8347d.c
index 03ae95b..42fed64 100644
--- a/drivers/staging/fbtft/fb_hx8347d.c
+++ b/drivers/staging/fbtft/fb_hx8347d.c
@@ -14,10 +14,6 @@
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
  */
 
 #include 
diff --git a/drivers/staging/fbtft/fb_hx8353d.c 
b/drivers/staging/fbtft/fb_hx8353d.c
index d7f4308..79e7ebc 100644
--- a/drivers/staging/fbtft/fb_hx8353d.c
+++ b/drivers/staging/fbtft/fb_hx8353d.c
@@ -13,10 +13,6 @@
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
  */
 
 #include 
diff --git a/drivers/staging/fbtft/fb_hx8357d.c 
b/drivers/staging/fbtft/fb_hx8357d.c
index 8c7bb3a..1b0a29d 100644
--- a/drivers/staging/fbtft/fb_hx8357d.c
+++ b/drivers/staging/fbtft/fb_hx8357d.c
@@ -16,9 +16,6 @@
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, see .
  */
 
 #include 
diff --git a/drivers/staging/fbtft/fb_ili9320.c 
b/drivers/staging/fbtft/fb_ili9320.c
index ef4fa6b..edcd79c 100644
--- a/drivers/staging/fbtft/fb_ili9320.c
+++ b/drivers/staging/fbtft/fb_ili9320.c
@@ -12,10 +12,6 @@
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public

[PATCH 2/4] staging/fbtft : Use macro for common fbtft addr win debug print

2015-09-02 Thread Anish Bhatt 
Same fbtft_par_dbg(DEBUG_SET_ADDR_WIN..) debug print is repeated in
every set_addr_win handler, repalce with a macro.

Signed-off-by: Anish Bhatt 
---
 drivers/staging/fbtft/fb_bd663474.c  |  4 ++--
 drivers/staging/fbtft/fb_hx8347d.c   |  3 +--
 drivers/staging/fbtft/fb_hx8353d.c   |  3 +--
 drivers/staging/fbtft/fb_hx8357d.c   |  3 +--
 drivers/staging/fbtft/fb_ili9163.c   |  3 +--
 drivers/staging/fbtft/fb_ili9320.c   |  3 +--
 drivers/staging/fbtft/fb_ili9325.c   |  4 ++--
 drivers/staging/fbtft/fb_ili9340.c   |  3 +--
 drivers/staging/fbtft/fb_ili9341.c   |  3 +--
 drivers/staging/fbtft/fb_ili9481.c   |  3 +--
 drivers/staging/fbtft/fb_ili9486.c   |  3 +--
 drivers/staging/fbtft/fb_pcd8544.c   |  3 +--
 drivers/staging/fbtft/fb_s6d02a1.c   |  3 +--
 drivers/staging/fbtft/fb_s6d1121.c   |  4 ++--
 drivers/staging/fbtft/fb_ssd1289.c   |  3 +--
 drivers/staging/fbtft/fb_ssd1306.c   |  3 +--
 drivers/staging/fbtft/fb_ssd1331.c   |  3 +--
 drivers/staging/fbtft/fb_ssd1351.c   |  3 +--
 drivers/staging/fbtft/fb_st7735r.c   |  3 +--
 drivers/staging/fbtft/fb_tinylcd.c   |  3 +--
 drivers/staging/fbtft/fb_tls8204.c   |  4 +---
 drivers/staging/fbtft/fb_uc1611.c|  4 +---
 drivers/staging/fbtft/fb_uc1701.c|  2 +-
 drivers/staging/fbtft/fb_upd161704.c |  4 ++--
 drivers/staging/fbtft/fbtft-core.c   |  3 ---
 drivers/staging/fbtft/fbtft.h|  5 +
 drivers/staging/fbtft/fbtft_device.c |  4 ++--
 drivers/staging/fbtft/flexfb.c   | 12 
 28 files changed, 39 insertions(+), 62 deletions(-)

diff --git a/drivers/staging/fbtft/fb_bd663474.c 
b/drivers/staging/fbtft/fb_bd663474.c
index deb069f..69eb6d2 100644
--- a/drivers/staging/fbtft/fb_bd663474.c
+++ b/drivers/staging/fbtft/fb_bd663474.c
@@ -118,8 +118,8 @@ static int init_display(struct fbtft_par *par)
 
 static void set_addr_win(struct fbtft_par *par, int xs, int ys, int xe, int ye)
 {
-   fbtft_par_dbg(DEBUG_SET_ADDR_WIN, par,
-   "%s(xs=%d, ys=%d, xe=%d, ye=%d)\n", __func__, xs, ys, xe, ye);
+   fbtft_par_dbg_addr_win();
+
switch (par->info->var.rotate) {
/* R200h = Horizontal GRAM Start Address */
/* R201h = Vertical GRAM Start Address */
diff --git a/drivers/staging/fbtft/fb_hx8347d.c 
b/drivers/staging/fbtft/fb_hx8347d.c
index 42fed64..14692f2 100644
--- a/drivers/staging/fbtft/fb_hx8347d.c
+++ b/drivers/staging/fbtft/fb_hx8347d.c
@@ -88,8 +88,7 @@ static int init_display(struct fbtft_par *par)
 
 static void set_addr_win(struct fbtft_par *par, int xs, int ys, int xe, int ye)
 {
-   fbtft_par_dbg(DEBUG_SET_ADDR_WIN, par,
-   "%s(xs=%d, ys=%d, xe=%d, ye=%d)\n", __func__, xs, ys, xe, ye);
+   fbtft_par_dbg_addr_win();
 
write_reg(par, 0x02, (xs >> 8) & 0xFF);
write_reg(par, 0x03, xs & 0xFF);
diff --git a/drivers/staging/fbtft/fb_hx8353d.c 
b/drivers/staging/fbtft/fb_hx8353d.c
index 79e7ebc..6b6d462 100644
--- a/drivers/staging/fbtft/fb_hx8353d.c
+++ b/drivers/staging/fbtft/fb_hx8353d.c
@@ -74,8 +74,7 @@ static int init_display(struct fbtft_par *par)
 
 static void set_addr_win(struct fbtft_par *par, int xs, int ys, int xe, int ye)
 {
-   fbtft_par_dbg(DEBUG_SET_ADDR_WIN, par,
-   "%s(xs=%d, ys=%d, xe=%d, ye=%d)\n", __func__, xs, ys, xe, ye);
+   fbtft_par_dbg_addr_win();
 
/* column address */
write_reg(par, 0x2a, xs >> 8, xs & 0xff, xe >> 8, xe & 0xff);
diff --git a/drivers/staging/fbtft/fb_hx8357d.c 
b/drivers/staging/fbtft/fb_hx8357d.c
index 1b0a29d..77c2afc 100644
--- a/drivers/staging/fbtft/fb_hx8357d.c
+++ b/drivers/staging/fbtft/fb_hx8357d.c
@@ -142,8 +142,7 @@ static int init_display(struct fbtft_par *par)
 
 static void set_addr_win(struct fbtft_par *par, int xs, int ys, int xe, int ye)
 {
-   fbtft_par_dbg(DEBUG_SET_ADDR_WIN, par,
-   "%s(xs=%d, ys=%d, xe=%d, ye=%d)\n", __func__, xs, ys, xe, ye);
+   fbtft_par_dbg_addr_win();
 
/* Column addr set */
write_reg(par, HX8357_CASET,
diff --git a/drivers/staging/fbtft/fb_ili9163.c 
b/drivers/staging/fbtft/fb_ili9163.c
index ed92a64..7762d19 100644
--- a/drivers/staging/fbtft/fb_ili9163.c
+++ b/drivers/staging/fbtft/fb_ili9163.c
@@ -149,8 +149,7 @@ static int init_display(struct fbtft_par *par)
 static void set_addr_win(struct fbtft_par *par, int xs, int ys,
int xe, int ye)
 {
-   fbtft_par_dbg(DEBUG_SET_ADDR_WIN, par,
-   "%s(xs=%d, ys=%d, xe=%d, ye=%d)\n", __func__, xs, ys, xe, ye);
+   fbtft_par_dbg_addr_win();
 
switch (par->info->var.rotate) {
case 0:
diff --git a/drivers/staging/fbtft/fb_ili9320.c 
b/drivers/staging/fbtft/fb_ili9320.c
index edcd79c..094f729 100644
--- a/drivers/staging/fbtft/fb_ili9320.c
+++ b/drivers/staging/fbtft/fb_ili9320.c
@@ -177,8 +177,7 @@ static int init_display(struct fbtft_par *par)
 
 static void set_addr_win(struct fbtft_par *par, int xs, int ys, int xe, int ye)
 {
-

[PATCH 4/4] staging/fbtft : Use BIT() macro when possible

2015-09-02 Thread Anish Bhatt 
Signed-off-by: Anish Bhatt 
---
 drivers/staging/fbtft/fb_hx8340bn.c | 6 +++---
 drivers/staging/fbtft/fb_hx8353d.c  | 6 +++---
 drivers/staging/fbtft/fb_s6d02a1.c  | 6 +++---
 drivers/staging/fbtft/fb_st7735r.c  | 6 +++---
 4 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/drivers/staging/fbtft/fb_hx8340bn.c 
b/drivers/staging/fbtft/fb_hx8340bn.c
index df2e213..a84701f 100644
--- a/drivers/staging/fbtft/fb_hx8340bn.c
+++ b/drivers/staging/fbtft/fb_hx8340bn.c
@@ -111,9 +111,9 @@ static int set_var(struct fbtft_par *par)
 {
/* MADCTL - Memory data access control */
/* RGB/BGR can be set with H/W pin SRGB and MADCTL BGR bit */
-#define MY (1 << 7)
-#define MX (1 << 6)
-#define MV (1 << 5)
+#define MY BIT(7)
+#define MX BIT(6)
+#define MV BIT(5)
switch (par->info->var.rotate) {
case 0:
write_reg(par, 0x36, par->bgr << 3);
diff --git a/drivers/staging/fbtft/fb_hx8353d.c 
b/drivers/staging/fbtft/fb_hx8353d.c
index 0b7f359..3af7e3a 100644
--- a/drivers/staging/fbtft/fb_hx8353d.c
+++ b/drivers/staging/fbtft/fb_hx8353d.c
@@ -85,9 +85,9 @@ static void set_addr_win(struct fbtft_par *par, int xs, int 
ys, int xe, int ye)
write_reg(par, 0x2c);
 }
 
-#define my (1 << 7)
-#define mx (1 << 6)
-#define mv (1 << 5)
+#define my BIT(7)
+#define mx BIT(6)
+#define mv BIT(5)
 static int set_var(struct fbtft_par *par)
 {
fbtft_par_dbg(DEBUG_INIT_DISPLAY, par, "%s()\n", __func__);
diff --git a/drivers/staging/fbtft/fb_s6d02a1.c 
b/drivers/staging/fbtft/fb_s6d02a1.c
index 2de8062..979b96c 100644
--- a/drivers/staging/fbtft/fb_s6d02a1.c
+++ b/drivers/staging/fbtft/fb_s6d02a1.c
@@ -109,9 +109,9 @@ static void set_addr_win(struct fbtft_par *par, int xs, int 
ys, int xe, int ye)
write_reg(par, 0x2C);
 }
 
-#define MY (1 << 7)
-#define MX (1 << 6)
-#define MV (1 << 5)
+#define MY BIT(7)
+#define MX BIT(6)
+#define MV BIT(5)
 static int set_var(struct fbtft_par *par)
 {
fbtft_par_dbg(DEBUG_INIT_DISPLAY, par, "%s()\n", __func__);
diff --git a/drivers/staging/fbtft/fb_st7735r.c 
b/drivers/staging/fbtft/fb_st7735r.c
index 15bd0f3..df2ae79 100644
--- a/drivers/staging/fbtft/fb_st7735r.c
+++ b/drivers/staging/fbtft/fb_st7735r.c
@@ -103,9 +103,9 @@ static void set_addr_win(struct fbtft_par *par, int xs, int 
ys, int xe, int ye)
write_reg(par, 0x2C);
 }
 
-#define MY (1 << 7)
-#define MX (1 << 6)
-#define MV (1 << 5)
+#define MY BIT(7)
+#define MX BIT(6)
+#define MV BIT(5)
 static int set_var(struct fbtft_par *par)
 {
fbtft_par_dbg(DEBUG_INIT_DISPLAY, par, "%s()\n", __func__);
-- 
2.5.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 0/4] staging/fbtft checkpatch and other fixes

2015-09-02 Thread Anish Bhatt 
* Remove FSF mailing address
* Remove stray unicode characters
* Fix a bunch of whitespace issues
* Use BIT() macros where recommended
* Simplify addr_win debug prints

Anish Bhatt (4):
  staging/fbtft : Remove FSF mailing address from GPL comments
  staging/fbtft : Use macro for common fbtft addr win debug print
  staging:fbtft : Fix whitespace issues
  staging/fbtft : Use BIT() macro when possible

 drivers/staging/fbtft/fb_agm1264k-fl.c |  5 ++---
 drivers/staging/fbtft/fb_bd663474.c|  9 +++--
 drivers/staging/fbtft/fb_hx8340bn.c| 17 ++---
 drivers/staging/fbtft/fb_hx8347d.c | 13 -
 drivers/staging/fbtft/fb_hx8353d.c | 16 +---
 drivers/staging/fbtft/fb_hx8357d.c |  8 ++--
 drivers/staging/fbtft/fb_ili9163.c |  8 
 drivers/staging/fbtft/fb_ili9320.c | 16 +---
 drivers/staging/fbtft/fb_ili9325.c | 17 ++---
 drivers/staging/fbtft/fb_ili9340.c | 10 ++
 drivers/staging/fbtft/fb_ili9341.c | 15 +--
 drivers/staging/fbtft/fb_ili9481.c |  9 ++---
 drivers/staging/fbtft/fb_ili9486.c | 10 ++
 drivers/staging/fbtft/fb_pcd8544.c | 17 ++---
 drivers/staging/fbtft/fb_ra8875.c  | 33 +
 drivers/staging/fbtft/fb_s6d02a1.c | 15 +--
 drivers/staging/fbtft/fb_s6d1121.c | 15 ++-
 drivers/staging/fbtft/fb_ssd1289.c | 15 +--
 drivers/staging/fbtft/fb_ssd1306.c | 19 +++
 drivers/staging/fbtft/fb_ssd1331.c |  5 +
 drivers/staging/fbtft/fb_ssd1351.c | 15 ++-
 drivers/staging/fbtft/fb_st7735r.c | 19 +++
 drivers/staging/fbtft/fb_tinylcd.c | 10 ++
 drivers/staging/fbtft/fb_tls8204.c | 16 +---
 drivers/staging/fbtft/fb_uc1611.c  |  4 +---
 drivers/staging/fbtft/fb_uc1701.c  | 23 ++-
 drivers/staging/fbtft/fb_upd161704.c   |  9 +++--
 drivers/staging/fbtft/fb_watterott.c   |  8 ++--
 drivers/staging/fbtft/fbtft-bus.c  | 13 -
 drivers/staging/fbtft/fbtft-core.c | 23 +--
 drivers/staging/fbtft/fbtft-sysfs.c|  6 ++
 drivers/staging/fbtft/fbtft.h  |  9 +
 drivers/staging/fbtft/fbtft_device.c   | 15 ---
 drivers/staging/fbtft/flexfb.c | 12 
 34 files changed, 147 insertions(+), 307 deletions(-)

-- 
2.5.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 7/8] staging: unisys: stop device registration before visorbus registration

2015-09-02 Thread Greg KH 
On Wed, Aug 26, 2015 at 07:15:26AM -0400, Jes Sorensen wrote:
> Sudip Mukherjee  writes:
> > On Tue, Aug 25, 2015 at 08:33:55AM -0400, Jes Sorensen wrote:
> >> Sudip Mukherjee  writes:
> >> > On Tue, Aug 18, 2015 at 03:14:02PM -0400, Benjamin Romer wrote:
> >> >> In cases where visorbus is compiled directly into the kernel, if
> >> >> visorbus registration fails for any reason, it is still possible for
> >> >> other drivers to call visorbus_register_visor_driver(), which could
> >> >> cause an oops. Prevent this by returning an error code when the bus
> >> >> hasn't been registered.
> >> >> 
> >> >> Signed-off-by: Benjamin Romer 
> >> >> ---
> >> >>  drivers/staging/unisys/visorbus/visorbus_main.c | 3 +++
> >> >>  1 file changed, 3 insertions(+)
> >> >> 
> >> >> diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c 
> >> >> b/drivers/staging/unisys/visorbus/visorbus_main.c
> >> >> index 7905ea9..ad2b1ac 100644
> >> >> --- a/drivers/staging/unisys/visorbus/visorbus_main.c
> >> >> +++ b/drivers/staging/unisys/visorbus/visorbus_main.c
> >> >> @@ -863,6 +863,9 @@ int visorbus_register_visor_driver(struct 
> >> >> visor_driver *drv)
> >> >>  {
> >> >> int rc = 0;
> >> >>  
> >> >> +   if (!visorbus_type.p)
> >> >> +   return -ENODEV; /*can't register on a nonexistent bus*/
> >> >> +
> >> > IIRC, Greg once told that we should not be working with the internal
> >> > data structures of struct bus_type.
> >> 
> >> If you looked at the code you would have noticed this is in fact the bus
> >> driver, and visorbus_type is defined in this file. I guess we could tell
> >> visorbus_main.c to not touch visorbus_type by deleting the file
> >> completely .
> > Yes, this is the bus driver, struct bus_type. Maybe the following might
> > be a better approach where the struct bus_type internals are not touched
> > yet it will server the purpose.
> 
> Replacing it with a global variable? Ehm sorry, but no thanks!
> 
> NACK

It should be static to the bus code.  Don't go poking at any .p
structures in the driver core, that's not ok either, I can't take this
as-is.  You should know if you can properly register a device/driver or
not.

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 2/2] android, lmk: Reverse the order of setting TIF_MEMDIE and sending SIGKILL.

2015-09-02 Thread Greg KH 
On Wed, Aug 26, 2015 at 09:19:48PM +0900, Tetsuo Handa wrote:
> Hello.
> 
> Should selected_tasksize be added to rem even when TIF_MEMDIE was not set?
> 
> Please see a thread from http://www.spinics.net/lists/linux-mm/msg93246.html
> if you want to know why to reverse the order.
> 
> >From 2d4cc11d8128e4c1397631b91fea78da3eaefb47 Mon Sep 17 00:00:00 2001
> From: Tetsuo Handa 
> Date: Wed, 26 Aug 2015 20:52:39 +0900
> Subject: [PATCH 2/2] android, lmk: Reverse the order of setting TIF_MEMDIE 
> and sending SIGKILL.
> 
> If we set TIF_MEMDIE before sending SIGKILL, memory reserves could be
> spent for allocations which are not needed for terminating the victim.
> Reverse the order as with oom_kill_process() does.


I can't take a patch that I have to hand-edit in order to apply it :(

And if we aren't taking patch 1/2, I guess this one isn't needed either?

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 0/8] fix drivers/staging/android several coding style issues

2015-09-02 Thread Greg KH 
On Wed, Aug 26, 2015 at 11:52:09AM +0800, Peng Sun wrote:
> patches based on linux-next next-20150825
> Corrections based on checkpatch.pl with --strict
> 
> Peng Sun (8):
>   fix staging:android style issue:spaces preferred around that '-'
>   fix staging:android style issue:No space is necessary after a cast
>   fix staging:android style issue:Alignment should match open
> parenthesis
>   fix staging:android style issue:Prefer kernel type 'u32' over
> 'uint32_t'
>   fix staging:android style issue:Please use a blank line after
> function/struct/union/enum declarations
>   fix staging:android style issue:Comparison to NULL could be written
>   fix staging:android style issue:definition without comment
>   fix staging:android style issue:Please don't use multiple blank lines

You sent out 3 different series, and I don't know which should be
applied.  So please fix up and resend just the one you want applied.

Note, the "style issue:" shouldn't be in the subject, look at how other
commits are titled.

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v3] staging: dgnc: take lock when storing value in dgnc_poll_tick

2015-09-02 Thread Greg KH 
On Tue, Aug 25, 2015 at 08:09:47PM +0100, Salah Triki wrote:
> poll_tick is declared global, so dgnc_driver_pollrate_store needs to take
> the lock dgnc_poll_lock before modifying this variable. dgnc_poll_lock the
> appropriate lock, since it is intended for poll scheduling and dgnc_poll_tick
> contains the poll rate. dgnc_poll_lock needs to be declared not static and
> extern in order to be visible for dgnc_driver_pollrate_store.

So you only lock it if you change the value?  That's not the way to do
this type of change :(
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 2/4] staging/fbtft : Use macro for common fbtft addr win debug print

2015-09-02 Thread Anish Bhatt 
On Wed, Sep 2, 2015 at 6:12 PM, Greg KH  wrote:
> On Wed, Sep 02, 2015 at 04:29:34PM -0700, Anish Bhatt wrote:
>> Same fbtft_par_dbg(DEBUG_SET_ADDR_WIN..) debug print is repeated in
>> every set_addr_win handler, repalce with a macro.
>
> Ick.
>
>>  static void set_addr_win(struct fbtft_par *par, int xs, int ys, int xe, int 
>> ye)
>>  {
>> - fbtft_par_dbg(DEBUG_SET_ADDR_WIN, par,
>> - "%s(xs=%d, ys=%d, xe=%d, ye=%d)\n", __func__, xs, ys, xe, ye);
>> + fbtft_par_dbg_addr_win();
>
> This should just be deleted entirely, we have function tracing in the
> kernel if you want to use it, no need to write macros to duplicate the
> same thing.
>
> Please just remove these lines.
>
> thanks,
>
> greg k-h

Will split patch 3 and fix this in v2.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v2] staging/fbtft : Remove FSF mailing address

2015-09-02 Thread Anish Bhatt 
checkpatch.pl recommends that this is no longer required.
Also replaces ASCII-art copyright notice with simple text

v2: Fix encoding issues accidentally introduced in git send-email

Signed-off-by: Anish Bhatt 
---
 drivers/staging/fbtft/fb_bd663474.c  |  4 
 drivers/staging/fbtft/fb_hx8340bn.c  |  4 
 drivers/staging/fbtft/fb_hx8347d.c   |  4 
 drivers/staging/fbtft/fb_hx8353d.c   |  4 
 drivers/staging/fbtft/fb_hx8357d.c   |  3 ---
 drivers/staging/fbtft/fb_ili9320.c   |  4 
 drivers/staging/fbtft/fb_ili9325.c   |  4 
 drivers/staging/fbtft/fb_ili9340.c   |  4 
 drivers/staging/fbtft/fb_ili9341.c   |  4 
 drivers/staging/fbtft/fb_ili9481.c   |  4 
 drivers/staging/fbtft/fb_ili9486.c   |  4 
 drivers/staging/fbtft/fb_pcd8544.c   |  4 
 drivers/staging/fbtft/fb_ra8875.c| 24 
 drivers/staging/fbtft/fb_s6d02a1.c   |  4 
 drivers/staging/fbtft/fb_s6d1121.c   |  4 
 drivers/staging/fbtft/fb_ssd1289.c   |  4 
 drivers/staging/fbtft/fb_ssd1306.c   |  4 
 drivers/staging/fbtft/fb_st7735r.c   |  4 
 drivers/staging/fbtft/fb_tinylcd.c   |  4 
 drivers/staging/fbtft/fb_tls8204.c   |  4 
 drivers/staging/fbtft/fb_uc1701.c|  4 
 drivers/staging/fbtft/fb_upd161704.c |  4 
 drivers/staging/fbtft/fb_watterott.c |  4 
 drivers/staging/fbtft/fbtft-core.c   |  4 
 drivers/staging/fbtft/fbtft.h|  4 
 drivers/staging/fbtft/fbtft_device.c |  4 
 26 files changed, 4 insertions(+), 119 deletions(-)

diff --git a/drivers/staging/fbtft/fb_bd663474.c 
b/drivers/staging/fbtft/fb_bd663474.c
index 17a2162..deb069f 100644
--- a/drivers/staging/fbtft/fb_bd663474.c
+++ b/drivers/staging/fbtft/fb_bd663474.c
@@ -16,10 +16,6 @@
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
  */
 
 #include 
diff --git a/drivers/staging/fbtft/fb_hx8340bn.c 
b/drivers/staging/fbtft/fb_hx8340bn.c
index 54528aa..c5b2e51 100644
--- a/drivers/staging/fbtft/fb_hx8340bn.c
+++ b/drivers/staging/fbtft/fb_hx8340bn.c
@@ -17,10 +17,6 @@
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
  */
 
 #include 
diff --git a/drivers/staging/fbtft/fb_hx8347d.c 
b/drivers/staging/fbtft/fb_hx8347d.c
index 03ae95b..42fed64 100644
--- a/drivers/staging/fbtft/fb_hx8347d.c
+++ b/drivers/staging/fbtft/fb_hx8347d.c
@@ -14,10 +14,6 @@
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
  */
 
 #include 
diff --git a/drivers/staging/fbtft/fb_hx8353d.c 
b/drivers/staging/fbtft/fb_hx8353d.c
index d7f4308..79e7ebc 100644
--- a/drivers/staging/fbtft/fb_hx8353d.c
+++ b/drivers/staging/fbtft/fb_hx8353d.c
@@ -13,10 +13,6 @@
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
  */
 
 #include 
diff --git a/drivers/staging/fbtft/fb_hx8357d.c 
b/drivers/staging/fbtft/fb_hx8357d.c
index 8c7bb3a..1b0a29d 100644
--- a/drivers/staging/fbtft/fb_hx8357d.c
+++ b/drivers/staging/fbtft/fb_hx8357d.c
@@ -16,9 +16,6 @@
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, see .
  */
 
 #include 
diff --git a/drivers/staging/fbtft/fb_ili9320.c 
b/drivers/staging/fbtft/fb_ili9320.c
index ef4fa6b..edcd79c 100644
--- a/drivers/staging/fbtft/fb_ili9320.c
+++ b/drivers/staging/fbtft/fb_ili9320.c
@@ -12,10 +12,6 @@
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
- *

Re: [PATCH 3/5] staging: wilc1000: use id value as argument

2015-09-02 Thread Greg KH 
On Thu, Aug 20, 2015 at 04:32:52PM +0900, Tony Cho wrote:
> From: Johnny Kim 
> 
> The driver communicates with the chipset via the address of handlers
> to distinguish async data frame. The SendConfigPkt function gets the
> pointer address indicating the handlers as the last argument, but this
> requires redundant typecasting and does not support the 64 bit machine.
> 
> This patch adds the function which assigns ID values instead of pointer
> representing the driver handler to the address and then uses the ID
> instead of pointer as the last argument of SendConfigPkt. The driver
> also gets the handler's address from the ID in the data frame when it
> receives them.
> 

I don't understand this code at all.  You are randomly adding values to
a list, and then assuming that you can use the index into that list for
some type of representation?  As this is a local list, why not just use
the real variables instead of having a list and dealing with them in
this very ackward manner?

In other words, I don't see the need for the list at all, just use the
real types here, you have all the needed information (hint, if you know
the index, you really know the data as well...)

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 3/3] staging/wilc1000: Use %pM format specifier to print mac address

2015-09-02 Thread Greg Kroah-Hartman 
On Thu, Aug 27, 2015 at 07:10:48PM +0600, Alexander Kuleshov wrote:
> printk() supports %pM format specifier for printing 6-byte MAC/FDDI
> addresses in hex notation small buffers, let's use it intead of %x:%x...
> 
> Signed-off-by: Alexander Kuleshov 
> ---
>  drivers/staging/wilc1000/host_interface.c | 6 +++---
>  drivers/staging/wilc1000/linux_mon.c  | 2 +-
>  drivers/staging/wilc1000/linux_wlan.c | 3 +--
>  3 files changed, 5 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/wilc1000/host_interface.c 
> b/drivers/staging/wilc1000/host_interface.c
> index 6b10bbb..48ee908 100644
> --- a/drivers/staging/wilc1000/host_interface.c
> +++ b/drivers/staging/wilc1000/host_interface.c
> @@ -854,7 +854,7 @@ static s32 Handle_SetMacAddress(void *drvHandler, 
> tstrHostIfSetMacAddress *pstrH
>   strWID.enuWIDtype = WID_STR;
>   strWID.ps8WidVal = mac_buf;
>   strWID.s32ValueSize = ETH_ALEN;
> - PRINT_D(GENERIC_DBG, "mac addr = :%x:%x:%x:%x:%x:%x\n", 
> strWID.ps8WidVal[0], strWID.ps8WidVal[1], strWID.ps8WidVal[2], 
> strWID.ps8WidVal[3], strWID.ps8WidVal[4], strWID.ps8WidVal[5]);
> + PRINT_D(GENERIC_DBG, "mac addr = :%pM\n", strWID.ps8WidVal);
>   /*Sending Cfg*/
>   s32Error = SendConfigPkt(SET_CFG, , 1, true, (u32)pstrWFIDrv);
>   if (s32Error) {
> @@ -1965,8 +1965,8 @@ static s32 Handle_Connect(void *drvHandler, 
> tstrHostIFconnectAttr *pstrHostIFcon
>   if (pstrHostIFconnectAttr->pu8bssid != NULL) {
>   WILC_memcpy(u8ConnectedSSID, pstrHostIFconnectAttr->pu8bssid, 
> ETH_ALEN);
>  
> - PRINT_D(GENERIC_DBG, "save Bssid = %x:%x:%x:%x:%x:%x\n", 
> (pstrHostIFconnectAttr->pu8bssid[0]), (pstrHostIFconnectAttr->pu8bssid[1]), 
> (pstrHostIFconnectAttr->pu8bssid[2]), (pstrHostIFconnectAttr->pu8bssid[3]), 
> (pstrHostIFconnectAttr->pu8bssid[4]), (pstrHostIFconnectAttr->pu8bssid[5]));
> - PRINT_D(GENERIC_DBG, "save bssid = %x:%x:%x:%x:%x:%x\n", 
> (u8ConnectedSSID[0]), (u8ConnectedSSID[1]), (u8ConnectedSSID[2]), 
> (u8ConnectedSSID[3]), (u8ConnectedSSID[4]), (u8ConnectedSSID[5]));
> + PRINT_D(GENERIC_DBG, "save Bssid = %pM\n", 
> pstrHostIFconnectAttr->pu8bssid);
> + PRINT_D(GENERIC_DBG, "save bssid = %pM\n", u8ConnectedSSID);
>   }
>  
>   s32Error = SendConfigPkt(SET_CFG, strWIDList, u32WidsCount, false, 
> (u32)pstrWFIDrv);
> diff --git a/drivers/staging/wilc1000/linux_mon.c 
> b/drivers/staging/wilc1000/linux_mon.c
> index f5296f5..c039898 100644
> --- a/drivers/staging/wilc1000/linux_mon.c
> +++ b/drivers/staging/wilc1000/linux_mon.c
> @@ -336,7 +336,7 @@ static netdev_tx_t WILC_WFI_mon_xmit(struct sk_buff *skb,
>   skb_pull(skb, rtap_len);
>  
>   if (skb->data[0] == 0xc0)
> - PRINT_INFO(HOSTAPD_DBG, "%x:%x:%x:%x:%x%x\n", skb->data[4], 
> skb->data[5], skb->data[6], skb->data[7], skb->data[8], skb->data[9]);
> + PRINT_INFO(HOSTAPD_DBG, "%pM\n", skb->data[4]);

This conversion isn't correct :(
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: goldfish: Prefer kernel type u32 over uint32_t

2015-09-02 Thread Ravi Teja Darbha 
Prefer kernel type u32 over uint32_t to maintain uniformity.

Signed-off-by: Ravi Teja Darbha 
---
 drivers/staging/goldfish/goldfish_nand_reg.h | 10 +-
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/goldfish/goldfish_nand_reg.h 
b/drivers/staging/goldfish/goldfish_nand_reg.h
index fe7f47c..43aeba3 100644
--- a/drivers/staging/goldfish/goldfish_nand_reg.h
+++ b/drivers/staging/goldfish/goldfish_nand_reg.h
@@ -66,11 +66,11 @@ enum nand_reg {
 };
 
 struct cmd_params {
-   uint32_t dev;
-   uint32_t addr_low;
-   uint32_t addr_high;
-   uint32_t transfer_size;
+   u32 dev;
+   u32 addr_low;
+   u32 addr_high;
+   u32 transfer_size;
unsigned long data;
-   uint32_t result;
+   u32 result;
 };
 #endif
-- 
1.9.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v2 1/3] staging: sm7xxfb: move sm712fb out of staging

2015-09-02 Thread Tomi Valkeinen 


On 01/09/15 16:55, Sudip Mukherjee wrote:
> On Tue, Sep 01, 2015 at 04:27:24PM +0300, Tomi Valkeinen wrote:
>>
>>
>> On 18/07/15 07:08, Sudip Mukherjee wrote:
>>> Now since all cleanups are done and the code is ready to be merged lets
>>> move it out of staging into fbdev location.
>>
>> Have you considered writing a DRM driver for this? I'm not happy at all
>> adding new fbdev drivers, as the DRM framework is much better,
>> supported, and continuously improved. With fbdev you end up with things
>> like module parameters used to define video modes etc, which is just ugly.
> Yes, I am working on a DRM driver, but since these are all voluntary
> work it is taking time. And Greg has already merged it.
>>
>> Anyway, some comments below.
> Some replies inline and remaining I will fix and send patches to you.

Wouldn't the time be better spent on the DRM driver?

This driver will be obsolete immediately when there's a DRM driver for
this device, and then it'll be yet another obsoleted fbdev driver we
need to maintain.

>>> +static const struct vesa_mode vesa_mode_table[] = {
>>> +   {"0x301", 640,  480,  8},
>>> +   {"0x303", 800,  600,  8},
>>> +   {"0x305", 1024, 768,  8},
>>> +   {"0x307", 1280, 1024, 8},
>>> +
>>> +   {"0x311", 640,  480,  16},
>>> +   {"0x314", 800,  600,  16},
>>> +   {"0x317", 1024, 768,  16},
>>> +   {"0x31A", 1280, 1024, 16},
>>> +
>>> +   {"0x312", 640,  480,  24},
>>> +   {"0x315", 800,  600,  24},
>>> +   {"0x318", 1024, 768,  24},
>>> +   {"0x31B", 1280, 1024, 24},
>>> +};
>>
>> We have "vesa_modes" in include/linux/fb.h. What is the above table for?
> The resolutions that are supported along with the kernel boot parameter
> to point to the resolution to boot with.

Why does the user need to give such hex values? Why not modes according
to Documentation/fb/modedb.txt?

>>> +
>>> +/**
>>> +SM712 Mode table.
>>> + **/
>>> +static const struct modeinit vgamode[] = {
>>> +   {
> 
>>> +   {   /*  Init_CR90_CRA7 */
>>> +   0x55, 0xD9, 0x5D, 0xE1, 0x86, 0x1B, 0x8E, 0x26,
>>> +   0xDA, 0x8D, 0xDE, 0x94, 0x00, 0x00, 0x18, 0x00,
>>> +   0x03, 0x03, 0x03, 0x03, 0x03, 0x03, 0x15, 0x03,
>>> +   },
>>> +   },
>>> +};
>>
>> What are these tables above for?
> Different register settings based on the display resolution. Do you want
> me to do anything with these vgamode table and the vesa_mode_table?

The vgamode table looks quite horrible. It's unmaintainable, and with a
quick look it seems to have lots of repetition. Large blocks of the data
for different modes are the same.

I don't know what the register there are, but I'd imagine you could
write generic functions like, say, "set_timings", which takes normal
linux videomode struct and writes those settings to the registers.

There should be no such bulk-write register tables in a proper driver,
except in some very special cases.

 Tomi



signature.asc
Description: OpenPGP digital signature
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: rtl8723au: remove unnecessary le32_to_cpu

2015-09-02 Thread Jes Sorensen 
Michał Bartoszkiewicz  writes:
> The values passed to le32_to_cpu are already in the correct byte order.
> This fixes four "cast to restricted __le32" sparse warnings.
>
> Signed-off-by: Michał Bartoszkiewicz 
> ---
>  drivers/staging/rtl8723au/core/rtw_security.c | 8 
>  1 file changed, 4 insertions(+), 4 deletions(-)

Sounds OK to me - the fact we never hit problems with this is a good
indicator the hw crypt functions work.

Cheers,
Jes

>
> diff --git a/drivers/staging/rtl8723au/core/rtw_security.c 
> b/drivers/staging/rtl8723au/core/rtw_security.c
> index 3d40bab..9d1cce1 100644
> --- a/drivers/staging/rtl8723au/core/rtw_security.c
> +++ b/drivers/staging/rtl8723au/core/rtw_security.c
> @@ -245,8 +245,8 @@ void rtw_wep_decrypt23a(struct rtw_adapter *padapter,
>   arcfour_encrypt(, payload, payload, length);
>  
>   /* calculate icv and compare the icv */
> - actual_crc = le32_to_cpu(getcrc32(payload, length - 4));
> - expected_crc = le32_to_cpu(get_unaligned_le32([length - 4]));
> + actual_crc = getcrc32(payload, length - 4);
> + expected_crc = get_unaligned_le32([length - 4]);
>  
>   if (actual_crc != expected_crc) {
>   RT_TRACE(_module_rtl871x_security_c_, _drv_err_,
> @@ -773,8 +773,8 @@ int rtw_tkip_decrypt23a(struct rtw_adapter *padapter,
>   arcfour_init(, rc4key, 16);
>   arcfour_encrypt(, payload, payload, length);
>  
> - actual_crc = le32_to_cpu(getcrc32(payload, length - 4));
> - expected_crc = le32_to_cpu(get_unaligned_le32([length - 4]));
> + actual_crc = getcrc32(payload, length - 4);
> + expected_crc = get_unaligned_le32([length - 4]);
>  
>   if (actual_crc != expected_crc) {
>   RT_TRACE(_module_rtl871x_security_c_, _drv_err_,
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel