Re: [PATCH] Staging: ipx: fixed several no space before tabs coding style issues

2017-12-27 Thread Greg KH 
On Wed, Dec 27, 2017 at 09:25:44PM +, Jianshen Liu wrote:
> Fixed several coding style warnings of "please, no space before tabs".
> 
> Signed-off-by: Jianshen Liu 
> ---
>  drivers/staging/ipx/af_ipx.c| 56 
> -
>  drivers/staging/ipx/ipx_proc.c  |  2 +-
>  drivers/staging/ipx/ipx_route.c |  6 ++---
>  3 files changed, 32 insertions(+), 32 deletions(-)

Please read drivers/staging/ipx/TODO
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 2/2] staging: iio: add spaces around '-' operator

2017-12-27 Thread Julia Lawall 


On Wed, 27 Dec 2017, Ji-Hun Kim wrote:

> Clean up checkpatch warning:
> CHECK: spaces preferred around that '-' (ctx:VxV)
>
> Signed-off-by: Ji-Hun Kim 
> ---
>  drivers/staging/iio/adc/ad7192.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/adc/ad7192.c 
> b/drivers/staging/iio/adc/ad7192.c
> index f015955..c4eff71 100644
> --- a/drivers/staging/iio/adc/ad7192.c
> +++ b/drivers/staging/iio/adc/ad7192.c
> @@ -340,7 +340,7 @@ ad7192_show_scale_available(struct device *dev,
>  }
>
>  static IIO_DEVICE_ATTR_NAMED(in_v_m_v_scale_available,
> -  in_voltage-voltage_scale_available,
> +  in_voltage - voltage_scale_available,

I think this has been discussed at length before, and it is a hyphen not a
subtraction.  IIO_DEVICE_ATTR_NAMED is a macro, as indicated by the
capital letters, and you have to look and see what the code expands into.

julia

>0444, ad7192_show_scale_available, NULL, 0);
>
>  static IIO_DEVICE_ATTR(in_voltage_scale_available, 0444,
> --
> 2.10.1 (Apple Git-78)
>
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: PROBLEM: 4.15.0-rc3 APIC causes lockups on Core 2 Duo laptop

2017-12-27 Thread Alexandru Chirvasitu 
On Thu, Dec 28, 2017 at 10:06:25AM +0800, Dou Liyang wrote:
> Hi Alexandru,
> 
> Thanks for testing !
> At 12/28/2017 12:18 AM, Alexandru Chirvasitu wrote:
> > As per instructions, I did the following:
> > 
> > (1)
> > 
> > Checked out
> > 
> > 464e1d5 Linux 4.15-rc5
> > 
> > (after getting my copy up to date, fetching, pulling ,etc.) and
> > compiled it as-is. Config attached (the one labeled 'np' for 'no
> > patch').
> > 
> > Result:
> > 
> > Boot with no extraparameters locks up after login, as before;
> > 
> > apic=debug does not panic, but locks up after login, as before;
> > 
> I also hope to see the log with "apic=debug" by "journalctl" command,
> though the logs don't have the lockup trace.

Ah, of course. Attached is the output of `journalctl --boot=-1` after
booting, getting locked up, and then rebooting a good kernel.

Slightly different version of 4.15-rc5; this one has both patches
applied, yours and Linus' for kexec, but the latter shouldn't make a
difference.

---

You'll see another trace in there that's been bugging me, about W=X
checking. I'm not qualified to judge how related they are, but during
these past few days I've compiled and tested many kernels, and many of
them have exhibited the W+X thing but *not* the lockups.

I hope to trace that one back to the original commit with another
bisect one of these days, but they do seem to be different issues.

> 
> Thanks,
>   dou.
> > 
> 
> 
> 
-- Logs begin at Sat 2017-12-23 08:45:59 EST, end at Wed 2017-12-27 21:42:46 
EST. --
Dec 27 21:39:03 D-69-91-141-110 kernel: Linux version 4.15.0-rc5-kex-fix+ 
(root@axiomatic) (gcc version 5.4.0 20160609 (Ubuntu 5.4.0-6ubuntu1~16.04.5)) 
#1 SMP Wed Dec 27 17:37:47 EST 2017
Dec 27 21:39:03 D-69-91-141-110 kernel: x86/fpu: x87 FPU will use FXSAVE
Dec 27 21:39:03 D-69-91-141-110 kernel: e820: BIOS-provided physical RAM map:
Dec 27 21:39:03 D-69-91-141-110 kernel: BIOS-e820: [mem 
0x-0x0009fbff] usable
Dec 27 21:39:03 D-69-91-141-110 kernel: BIOS-e820: [mem 
0x0009fc00-0x0009] reserved
Dec 27 21:39:03 D-69-91-141-110 kernel: BIOS-e820: [mem 
0x000e-0x000f] reserved
Dec 27 21:39:03 D-69-91-141-110 kernel: BIOS-e820: [mem 
0x0010-0xb7f9] usable
Dec 27 21:39:03 D-69-91-141-110 kernel: BIOS-e820: [mem 
0xb7fa-0xb7fadfff] ACPI data
Dec 27 21:39:03 D-69-91-141-110 kernel: BIOS-e820: [mem 
0xb7fae000-0xb7fe] ACPI NVS
Dec 27 21:39:03 D-69-91-141-110 kernel: BIOS-e820: [mem 
0xb7ff-0xb7ff] reserved
Dec 27 21:39:03 D-69-91-141-110 kernel: BIOS-e820: [mem 
0xfee0-0xfee00fff] reserved
Dec 27 21:39:03 D-69-91-141-110 kernel: BIOS-e820: [mem 
0xffb8-0x] reserved
Dec 27 21:39:03 D-69-91-141-110 kernel: NX (Execute Disable) protection: active
Dec 27 21:39:03 D-69-91-141-110 kernel: random: fast init done
Dec 27 21:39:03 D-69-91-141-110 kernel: SMBIOS 2.4 present.
Dec 27 21:39:03 D-69-91-141-110 kernel: DMI: ASUSTeK Computer Inc. F5RL 
   /F5RL  , BIOS 210 06/12/2008
Dec 27 21:39:03 D-69-91-141-110 kernel: e820: update [mem 
0x-0x0fff] usable ==> reserved
Dec 27 21:39:03 D-69-91-141-110 kernel: e820: remove [mem 
0x000a-0x000f] usable
Dec 27 21:39:03 D-69-91-141-110 kernel: e820: last_pfn = 0xb7fa0 max_arch_pfn = 
0x100
Dec 27 21:39:03 D-69-91-141-110 kernel: MTRR default type: uncachable
Dec 27 21:39:03 D-69-91-141-110 kernel: MTRR fixed ranges enabled:
Dec 27 21:39:03 D-69-91-141-110 kernel:   0-9 write-back
Dec 27 21:39:03 D-69-91-141-110 kernel:   A-B uncachable
Dec 27 21:39:03 D-69-91-141-110 kernel:   C-C write-protect
Dec 27 21:39:03 D-69-91-141-110 kernel:   D-D uncachable
Dec 27 21:39:03 D-69-91-141-110 kernel:   E-E write-through
Dec 27 21:39:03 D-69-91-141-110 kernel:   F-F write-protect
Dec 27 21:39:03 D-69-91-141-110 kernel: MTRR variable ranges enabled:
Dec 27 21:39:03 D-69-91-141-110 kernel:   0 base 0 mask F8000 
write-back
Dec 27 21:39:03 D-69-91-141-110 kernel:   1 base 08000 mask FE000 
write-back
Dec 27 21:39:03 D-69-91-141-110 kernel:   2 base 0A000 mask FF000 
write-back
Dec 27 21:39:03 D-69-91-141-110 kernel:   3 base 0B000 mask FF800 
write-back
Dec 27 21:39:03 D-69-91-141-110 kernel:   4 base 0B800 mask FFC00 
write-back
Dec 27 21:39:03 D-69-91-141-110 kernel:   5 base 0BC00 mask FFF00 
write-back
Dec 27 21:39:03 D-69-91-141-110 kernel:   6 base 0C000 mask FF000 
write-combining
Dec 27 21:39:03 D-69-91-141-110 kernel:   7 disabled
Dec 27 21:39:03 D-69-91-141-110 kernel: x86/PAT: Configuration [0-7]: WB  WC  
UC- UC  WB  WP  UC- WT  
Dec 27 21:39:03 D-69-91-141-110 kernel: Scan for SMP in [mem 
0x-0x03ff]
Dec 27 21:39:03 D-69-91-141-110 kernel: Scan for SMP in [mem 
0x0009fc00-0x0009]
Dec 27 21:39:03 D-69-91-141-110 kernel:

[PATCH 2/2] staging: iio: add spaces around '-' operator

2017-12-27 Thread Ji-Hun Kim 
Clean up checkpatch warning:
CHECK: spaces preferred around that '-' (ctx:VxV)

Signed-off-by: Ji-Hun Kim 
---
 drivers/staging/iio/adc/ad7192.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
index f015955..c4eff71 100644
--- a/drivers/staging/iio/adc/ad7192.c
+++ b/drivers/staging/iio/adc/ad7192.c
@@ -340,7 +340,7 @@ ad7192_show_scale_available(struct device *dev,
 }
 
 static IIO_DEVICE_ATTR_NAMED(in_v_m_v_scale_available,
-in_voltage-voltage_scale_available,
+in_voltage - voltage_scale_available,
 0444, ad7192_show_scale_available, NULL, 0);
 
 static IIO_DEVICE_ATTR(in_voltage_scale_available, 0444,
-- 
2.10.1 (Apple Git-78)

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 1/2] staging: iio: remove unnecessary parentheses

2017-12-27 Thread Ji-Hun Kim 
Clean up checkpatch warning:
CHECK: Unnecessary parentheses around 'st->devid != ID_AD7195'

Signed-off-by: Ji-Hun Kim 
---
 drivers/staging/iio/adc/ad7192.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
index cadfb96..f015955 100644
--- a/drivers/staging/iio/adc/ad7192.c
+++ b/drivers/staging/iio/adc/ad7192.c
@@ -271,7 +271,7 @@ static int ad7192_setup(struct ad7192_state *st,
if (pdata->sinc3_en)
st->mode |= AD7192_MODE_SINC3;
 
-   if (pdata->refin2_en && (st->devid != ID_AD7195))
+   if (pdata->refin2_en && st->devid != ID_AD7195)
st->conf |= AD7192_CONF_REFSEL;
 
if (pdata->chop_en) {
-- 
2.10.1 (Apple Git-78)

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: PROBLEM: 4.15.0-rc3 APIC causes lockups on Core 2 Duo laptop

2017-12-27 Thread Dou Liyang 

Hi Alexandru,

Thanks for testing !
At 12/28/2017 12:18 AM, Alexandru Chirvasitu wrote:

As per instructions, I did the following:

(1)

Checked out

464e1d5 Linux 4.15-rc5

(after getting my copy up to date, fetching, pulling ,etc.) and
compiled it as-is. Config attached (the one labeled 'np' for 'no
patch').

Result:

Boot with no extraparameters locks up after login, as before;

apic=debug does not panic, but locks up after login, as before;


I also hope to see the log with "apic=debug" by "journalctl" command,
though the logs don't have the lockup trace.

Thanks,
dou.






___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] Staging: ipx: fixed several no space before tabs coding style issues

2017-12-27 Thread Jianshen Liu 
Fixed several coding style warnings of "please, no space before tabs".

Signed-off-by: Jianshen Liu 
---
 drivers/staging/ipx/af_ipx.c| 56 -
 drivers/staging/ipx/ipx_proc.c  |  2 +-
 drivers/staging/ipx/ipx_route.c |  6 ++---
 3 files changed, 32 insertions(+), 32 deletions(-)

diff --git a/drivers/staging/ipx/af_ipx.c b/drivers/staging/ipx/af_ipx.c
index d21a9d1..d8be06c 100644
--- a/drivers/staging/ipx/af_ipx.c
+++ b/drivers/staging/ipx/af_ipx.c
@@ -2,7 +2,7 @@
  * Implements an IPX socket layer.
  *
  * This code is derived from work by
- * Ross Biro   :   Writing the original IP stack
+ * Ross Biro   :   Writing the original IP stack
  * Fred Van Kempen :   Tidying up the TCP/IP
  *
  * Many thanks go to Keith Baker, Institute For Industrial Information
@@ -20,7 +20,7 @@
  * provide warranty for any of this software. This material is provided
  * "AS-IS" and at no charge.
  *
- * Portions Copyright (c) 1995 Caldera, Inc. 
+ * Portions Copyright (c) 1995 Caldera, Inc. 
  * Neither Greg Page nor Caldera, Inc. admit liability nor provide
  * warranty for any of this software. This material is provided
  * "AS-IS" and at no charge.
@@ -758,7 +758,7 @@ static void ipxitf_discover_netnum(struct ipx_interface 
*intrfc,
 
 /**
  * ipxitf_pprop - Process packet propagation IPX packet type 0x14, used for
- *   NetBIOS broadcasts
+ *   NetBIOS broadcasts
  * @intrfc: IPX interface receiving this packet
  * @skb: Received packet
  *
@@ -870,11 +870,11 @@ static struct ipx_interface *ipxitf_alloc(struct 
net_device *dev, __be32 netnum,
if (intrfc) {
intrfc->if_dev  = dev;
intrfc->if_netnum   = netnum;
-   intrfc->if_dlink_type   = dlink_type;
-   intrfc->if_dlink= dlink;
-   intrfc->if_internal = internal;
-   intrfc->if_ipx_offset   = ipx_offset;
-   intrfc->if_sknum= IPX_MIN_EPHEMERAL_SOCKET;
+   intrfc->if_dlink_type   = dlink_type;
+   intrfc->if_dlink= dlink;
+   intrfc->if_internal = internal;
+   intrfc->if_ipx_offset   = ipx_offset;
+   intrfc->if_sknum= IPX_MIN_EPHEMERAL_SOCKET;
INIT_HLIST_HEAD(>if_sklist);
refcount_set(>refcnt, 1);
spin_lock_init(>if_sklist_lock);
@@ -965,23 +965,23 @@ static int ipxitf_create(struct ipx_interface_definition 
*idef)
 
switch (idef->ipx_dlink_type) {
case IPX_FRAME_8022:
-   dlink_type  = htons(ETH_P_802_2);
-   datalink= p8022_datalink;
+   dlink_type  = htons(ETH_P_802_2);
+   datalink= p8022_datalink;
break;
case IPX_FRAME_ETHERII:
if (dev->type != ARPHRD_IEEE802) {
-   dlink_type  = htons(ETH_P_IPX);
-   datalink= pEII_datalink;
+   dlink_type  = htons(ETH_P_IPX);
+   datalink= pEII_datalink;
break;
}
/* fall through */
case IPX_FRAME_SNAP:
-   dlink_type  = htons(ETH_P_SNAP);
-   datalink= pSNAP_datalink;
+   dlink_type  = htons(ETH_P_SNAP);
+   datalink= pSNAP_datalink;
break;
case IPX_FRAME_8023:
-   dlink_type  = htons(ETH_P_802_3);
-   datalink= p8023_datalink;
+   dlink_type  = htons(ETH_P_802_3);
+   datalink= p8023_datalink;
break;
case IPX_FRAME_NONE:
default:
@@ -1522,7 +1522,7 @@ static int ipx_connect(struct socket *sock, struct 
sockaddr *uaddr,
struct ipx_route *rt;
 
sk->sk_state= TCP_CLOSE;
-   sock->state = SS_UNCONNECTED;
+   sock->state = SS_UNCONNECTED;
 
lock_sock(sk);
if (addr_len != sizeof(*addr))
@@ -1534,7 +1534,7 @@ static int ipx_connect(struct socket *sock, struct 
sockaddr *uaddr,
struct sockaddr_ipx uaddr;
 
uaddr.sipx_port = 0;
-   uaddr.sipx_network  = 0;
+   uaddr.sipx_network  = 0;
 
 #ifdef CONFIG_IPX_INTERN
rc = -ENETDOWN;
@@ -1563,8 +1563,8 @@ static int ipx_connect(struct socket *sock, struct 
sockaddr *uaddr,
ipxs->type = addr->sipx_type;
 
if (sock->type == SOCK_DGRAM) {
-   sock->state = SS_CONNECTED;
-   sk->sk_state= TCP_ESTABLISHED;
+   sock->state = SS_CONNECTED;
+   sk->sk_state= TCP_ESTABLISHED;
}
 
if (rt)
@@ -1736,10 +1736,10 @@

Re: [PATCH 1/3] staging: irda: fix type from "unsigned" to "unsigned int"

2017-12-27 Thread Greg KH 
On Tue, Dec 26, 2017 at 09:52:54PM -0800, JI-HUN KIM wrote:
> Clean up checkpatch warning:
> WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
> 
> Signed-off-by: JI-HUN KIM 
> ---
>  drivers/staging/irda/drivers/esi-sir.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Please read drivers/staging/irda/TODO

sorry.

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: You will definetely be interested...

2017-12-27 Thread Word Gospel 
Hi Dear,

Reading your profile has given me courage in search of a reasponsable
and trust worthy Fellow. The past has treated me so awfully but now I
am ready to move on despite of my health condition. I will like to
have a sincere and important discussion with you that will be in your
favor likewise to you and your environment especially to your close
family. Endeavor to reply me and I have attached my picture in case
you long to know who emailed you. I will be waiting to hear from you
as soon as possble.
Thanks for paying attention to my mail and will appreciate so much if
I receive a reply from you for understable details.

Thanks,

Mrs. Rania Hassan
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: You will definetely be interested...

2017-12-27 Thread Sra. Angel Rania 
Hi Dear,

Reading your profile has given me courage in search of a reasponsable
and trust worthy Fellow. The past has treated me so awfully but now I
am ready to move on despite of my health condition. I will like to
have a sincere and important discussion with you that will be in your
favor likewise to you and your environment especially to your close
family. Endeavor to reply me and I have attached my picture in case
you long to know who emailed you. I will be waiting to hear from you
as soon as possble.
Thanks for paying attention to my mail and will appreciate so much if
I receive a reply from you for understable details.

Thanks,

Mrs. Rania Hassan
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: PROBLEM: 4.15.0-rc3 APIC causes lockups on Core 2 Duo laptop

2017-12-27 Thread Dou Liyang 

Hi Alexandru,

At 12/24/2017 04:01 AM, Alexandru Chirvasitu wrote:

On Sat, Dec 23, 2017 at 02:32:52PM +0100, Thomas Gleixner wrote:

On Sat, 23 Dec 2017, Dexuan Cui wrote:


From: Alexandru Chirvasitu [mailto:achirva...@gmail.com]
Sent: Friday, December 22, 2017 14:29

The output of that precise command run just now on a freshly-compiled
copy of that commit is attached.

On Fri, Dec 22, 2017 at 09:31:28PM +, Dexuan Cui wrote:

From: Alexandru Chirvasitu [mailto:achirva...@gmail.com]
Sent: Friday, December 22, 2017 06:21

In the absence of logs, the best I can do at the moment is attach a
picture of the screen I am presented with on the  boot
attempt.
Alex


The panic happens in irq_matrix_assign_system+0x4e/0xd0 in your picture.
IMO we should find which line of code causes the panic. I suppose
"objdump -D kernel/irq/matrix.o" can help to do that.

Thanks,
-- Dexuan


The BUG_ON panic happens at line 147:
BUG_ON(!test_and_clear_bit(bit, cm->alloc_map));



There are 2 bugs in your laptop:

  1. Hard lockups on both CPUs after login
  2. panic with "apic=debug"

For the 2th bug, please try the following patch(need Thomas confirmation
:) ) in Linux 4.15-rc5. I think it can fix the panic.

If the 2th bug fixed, let's back to the 1th bug:

Is Linus current head 4.15-rc5 bad as well?

If yes, Please using "apic=debug" and give the dmesg log.

Thanks,
dou.

8<---

irq/matrix: Remove the overused BUGON() in irq_matrix_assign_system()

Currently, x86 marks the preallocated legacy interrupts when initializing
IRQ(native_init_IRQ), but will clear them if they are not activated in
vector_configure_legacy().

So, in irq_matrix_assign_system(), replacing an legacy vector which may
not allocated in a cpumap->alloc_map[] with a system vector will trigger
the BUGON();

Remove the BUGON().

Signed-off-by: Dou Liyang 
---
 kernel/irq/matrix.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/kernel/irq/matrix.c b/kernel/irq/matrix.c
index 0ba0dd8863a7..876cbeab9ca2 100644
--- a/kernel/irq/matrix.c
+++ b/kernel/irq/matrix.c
@@ -143,11 +143,12 @@ void irq_matrix_assign_system(struct irq_matrix 
*m, unsigned int bit,

BUG_ON(m->online_maps > 1 || (m->online_maps && !replace));

set_bit(bit, m->system_map);
-   if (replace) {
-   BUG_ON(!test_and_clear_bit(bit, cm->alloc_map));
+
+   if (replace && test_and_clear_bit(bit, cm->alloc_map)){
cm->allocated--;
m->total_allocated--;
}
+
if (bit >= m->alloc_start && bit < m->alloc_end)
m->systembits_inalloc++;

--


___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel