[PATCH] Staging : wlan-ng: fix unnecessary parentheses in prism2mgmt.c
This patch fixes up unnecessary parentheses warning found by checkpatch.pl script. Signed-off-by: Yash Omer --- drivers/staging/wlan-ng/prism2mgmt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wlan-ng/prism2mgmt.c b/drivers/staging/wlan-ng/prism2mgmt.c index 236961e3ba0d..90cc6cd8 100644 --- a/drivers/staging/wlan-ng/prism2mgmt.c +++ b/drivers/staging/wlan-ng/prism2mgmt.c @@ -1065,7 +1065,7 @@ int prism2mgmt_autojoin(struct wlandevice *wlandev, void *msgp) /* Set the ssid */ memset(bytebuf, 0, 256); - pstr = (struct p80211pstrd *)&(msg->ssid.data); + pstr = (struct p80211pstrd *)&msg->ssid.data; prism2mgmt_pstr2bytestr(p2bytestr, pstr); result = hfa384x_drvr_setconfig(hw, HFA384x_RID_CNFDESIREDSSID, bytebuf, -- 2.14.3 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] Staging: wlan-ng: fix unnecessary parantheses in prism2mgmt.c
This patch fixes up a unncessary paratheses warning found by checkpatch.pl script. Signed-off-by: Yash Omer --- drivers/staging/wlan-ng/prism2mgmt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wlan-ng/prism2mgmt.c b/drivers/staging/wlan-ng/prism2mgmt.c index e47a839f83a6..236961e3ba0d 100644 --- a/drivers/staging/wlan-ng/prism2mgmt.c +++ b/drivers/staging/wlan-ng/prism2mgmt.c @@ -564,7 +564,7 @@ int prism2mgmt_start(struct wlandevice *wlandev, void *msgp) /*** STATION ***/ /* Set the REQUIRED config items */ /* SSID */ - pstr = (struct p80211pstrd *)&(msg->ssid.data); + pstr = (struct p80211pstrd *)&msg->ssid.data; prism2mgmt_pstr2bytestr(p2bytestr, pstr); result = hfa384x_drvr_setconfig(hw, HFA384x_RID_CNFOWNSSID, bytebuf, HFA384x_RID_CNFOWNSSID_LEN); -- 2.14.3 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[RFC PATCH 0/2] Ion unit test with VGEM
Hi, Ion hasn't had much in the way of unit tests and fixing that is something that needs to happen before it can move out of staging. The difficult part of testing parts of Ion is that it relies on having a kernel driver to actually make some of the dma_buf calls. The vgem DRM driver exists mostly for testing and works great for this case. I went back and forth about trying to put this in the existing graphics test suite but I think having something in the self-tests directory is easier. I'm mostly interested in feedback about the use of the DRM APIs but I appreciate any and all comments. Thanks, Laura Laura Abbott (2): selftests: ion: Remove some prints selftests: ion: Add simple test with the vgem driver tools/testing/selftests/android/ion/Makefile | 3 +- tools/testing/selftests/android/ion/config| 1 + tools/testing/selftests/android/ion/ionmap_test.c | 136 ++ tools/testing/selftests/android/ion/ionutils.c| 6 - 4 files changed, 139 insertions(+), 7 deletions(-) create mode 100644 tools/testing/selftests/android/ion/ionmap_test.c -- 2.14.3 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 2/2] selftests: ion: Add simple test with the vgem driver
Ion is designed to be a framework used by other clients who perform operations on the buffer. Use the DRM vgem client as a simple consumer. In conjunction with the dma-buf sync ioctls, this tests the full attach/map path for the system heap. Signed-off-by: Laura Abbott --- tools/testing/selftests/android/ion/Makefile | 3 +- tools/testing/selftests/android/ion/config| 1 + tools/testing/selftests/android/ion/ionmap_test.c | 136 ++ 3 files changed, 139 insertions(+), 1 deletion(-) create mode 100644 tools/testing/selftests/android/ion/ionmap_test.c diff --git a/tools/testing/selftests/android/ion/Makefile b/tools/testing/selftests/android/ion/Makefile index 96e0c448b39d..d23b6d537d8b 100644 --- a/tools/testing/selftests/android/ion/Makefile +++ b/tools/testing/selftests/android/ion/Makefile @@ -2,7 +2,7 @@ INCLUDEDIR := -I. -I../../../../../drivers/staging/android/uapi/ CFLAGS := $(CFLAGS) $(INCLUDEDIR) -Wall -O2 -g -TEST_GEN_FILES := ionapp_export ionapp_import +TEST_GEN_FILES := ionapp_export ionapp_import ionmap_test all: $(TEST_GEN_FILES) @@ -14,3 +14,4 @@ include ../../lib.mk $(OUTPUT)/ionapp_export: ionapp_export.c ipcsocket.c ionutils.c $(OUTPUT)/ionapp_import: ionapp_import.c ipcsocket.c ionutils.c +$(OUTPUT)/ionmap_test: ionmap_test.c ionutils.c diff --git a/tools/testing/selftests/android/ion/config b/tools/testing/selftests/android/ion/config index 19db6ca9aa2b..b4ad748a9dd9 100644 --- a/tools/testing/selftests/android/ion/config +++ b/tools/testing/selftests/android/ion/config @@ -2,3 +2,4 @@ CONFIG_ANDROID=y CONFIG_STAGING=y CONFIG_ION=y CONFIG_ION_SYSTEM_HEAP=y +CONFIG_DRM_VGEM=y diff --git a/tools/testing/selftests/android/ion/ionmap_test.c b/tools/testing/selftests/android/ion/ionmap_test.c new file mode 100644 index ..dab36b06b37d --- /dev/null +++ b/tools/testing/selftests/android/ion/ionmap_test.c @@ -0,0 +1,136 @@ +#include +#include +#include +#include +#include +#include + +#include +#include +#include + +#include + +#include + +#include "ion.h" +#include "ionutils.h" + +int check_vgem(int fd) +{ + drm_version_t version = { 0 }; + char name[5]; + int ret; + + version.name_len = 4; + version.name = name; + + ret = ioctl(fd, DRM_IOCTL_VERSION, &version); + if (ret) + return 1; + + return strcmp(name, "vgem"); +} + +int open_vgem(void) +{ + int i, fd; + const char *drmstr = "/dev/dri/card"; + + fd = -1; + for (i = 0; i < 16; i++) { + char name[80]; + + sprintf(name, "%s%u", drmstr, i); + + fd = open(name, O_RDWR); + if (fd < 0) + continue; + + if (check_vgem(fd)) { + close(fd); + continue; + } else { + break; + } + + } + return fd; +} + +int import_vgem_fd(int vgem_fd, int dma_buf_fd, uint32_t *handle) +{ + struct drm_prime_handle import_handle = { 0 }; + int ret; + + import_handle.fd = dma_buf_fd; + import_handle.flags = 0; + import_handle.handle = 0; + + ret = ioctl(vgem_fd, DRM_IOCTL_PRIME_FD_TO_HANDLE, &import_handle); + if (ret == 0) + *handle = import_handle.handle; + return ret; +} + +void close_handle(int vgem_fd, uint32_t handle) +{ + struct drm_gem_close close = { 0 }; + + close.handle = handle; + ioctl(vgem_fd, DRM_IOCTL_GEM_CLOSE, &close); +} + +int main() +{ + int ret, vgem_fd; + struct ion_buffer_info info; + uint32_t handle = 0; + struct dma_buf_sync sync = { 0 }; + + info.heap_type = ION_HEAP_TYPE_SYSTEM; + info.heap_size = 4096; + info.flag_type = ION_FLAG_CACHED; + + ret = ion_export_buffer_fd(&info); + if (ret < 0) { + printf("ion buffer alloc failed\n"); + return -1; + } + + vgem_fd = open_vgem(); + if (vgem_fd < 0) { + ret = vgem_fd; + printf("Failed to open vgem\n"); + goto out_ion; + } + + ret = import_vgem_fd(vgem_fd, info.buffd, &handle); + + if (ret < 0) { + printf("Failed to import buffer\n"); + goto out_vgem; + } + + sync.flags = DMA_BUF_SYNC_START | DMA_BUF_SYNC_RW; + ret = ioctl(info.buffd, DMA_BUF_IOCTL_SYNC, &sync); + if (ret) + printf("sync start failed %d\n", errno); + + memset(info.buffer, 0xff, 4096); + + sync.flags = DMA_BUF_SYNC_END | DMA_BUF_SYNC_RW; + ret = ioctl(info.buffd, DMA_BUF_IOCTL_SYNC, &sync); + if (ret) + printf("sync end failed %d\n", errno); + + close_handle(vgem_fd, handle); + ret = 0; + +out_vgem: + close(vgem_fd); +out_ion: + ion_close_buffer_fd(&info); + printf("done.\n"); + return ret; +} -- 2.14.
[PATCH 1/2] selftests: ion: Remove some prints
There's no need to print messages each time we alloc and free. Remove them. Signed-off-by: Laura Abbott --- tools/testing/selftests/android/ion/ionutils.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/tools/testing/selftests/android/ion/ionutils.c b/tools/testing/selftests/android/ion/ionutils.c index ce69c14f51fa..7d1d37c4ef6a 100644 --- a/tools/testing/selftests/android/ion/ionutils.c +++ b/tools/testing/selftests/android/ion/ionutils.c @@ -80,11 +80,6 @@ int ion_export_buffer_fd(struct ion_buffer_info *ion_info) heap_id = MAX_HEAP_COUNT + 1; for (i = 0; i < query.cnt; i++) { if (heap_data[i].type == ion_info->heap_type) { - printf("--\n"); - printf("heap type: %d\n", heap_data[i].type); - printf(" heap id: %d\n", heap_data[i].heap_id); - printf("heap name: %s\n", heap_data[i].name); - printf("--\n"); heap_id = heap_data[i].heap_id; break; } @@ -204,7 +199,6 @@ void ion_close_buffer_fd(struct ion_buffer_info *ion_info) /* Finally, close the client fd */ if (ion_info->ionfd > 0) close(ion_info->ionfd); - printf("<%s>: buffer release successfully\n", __func__); } } -- 2.14.3 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: android: ion: Change dma_buf_kmap()/dma_buf_kmap_atomic() implementation
On 02/12/2018 02:33 PM, Alexey Skidanov wrote: Current ion kernel mapping implementation uses vmap() to map previously allocated buffers into kernel virtual address space. On 32-bit platforms, vmap() might fail on large enough buffers due to the limited available vmalloc space. dma_buf_kmap() should guarantee that only one page is mapped at a time. To fix this, kmap()/kmap_atomic() is used to implement the appropriate interfaces. Signed-off-by: Alexey Skidanov --- drivers/staging/android/ion/ion.c | 97 +++ drivers/staging/android/ion/ion.h | 1 - 2 files changed, 48 insertions(+), 50 deletions(-) diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c index 57e0d80..75830e3 100644 --- a/drivers/staging/android/ion/ion.c +++ b/drivers/staging/android/ion/ion.c @@ -27,6 +27,7 @@ #include #include #include +#include #include "ion.h" @@ -119,8 +120,6 @@ static struct ion_buffer *ion_buffer_create(struct ion_heap *heap, void ion_buffer_destroy(struct ion_buffer *buffer) { - if (WARN_ON(buffer->kmap_cnt > 0)) - buffer->heap->ops->unmap_kernel(buffer->heap, buffer); buffer->heap->ops->free(buffer); kfree(buffer); } @@ -140,34 +139,6 @@ static void _ion_buffer_destroy(struct ion_buffer *buffer) ion_buffer_destroy(buffer); } -static void *ion_buffer_kmap_get(struct ion_buffer *buffer) -{ - void *vaddr; - - if (buffer->kmap_cnt) { - buffer->kmap_cnt++; - return buffer->vaddr; - } - vaddr = buffer->heap->ops->map_kernel(buffer->heap, buffer); - if (WARN_ONCE(!vaddr, - "heap->ops->map_kernel should return ERR_PTR on error")) - return ERR_PTR(-EINVAL); - if (IS_ERR(vaddr)) - return vaddr; - buffer->vaddr = vaddr; - buffer->kmap_cnt++; - return vaddr; -} - -static void ion_buffer_kmap_put(struct ion_buffer *buffer) -{ - buffer->kmap_cnt--; - if (!buffer->kmap_cnt) { - buffer->heap->ops->unmap_kernel(buffer->heap, buffer); - buffer->vaddr = NULL; - } -} - static struct sg_table *dup_sg_table(struct sg_table *table) { struct sg_table *new_table; @@ -305,34 +276,68 @@ static void ion_dma_buf_release(struct dma_buf *dmabuf) _ion_buffer_destroy(buffer); } +static inline int sg_page_count(struct scatterlist *sg) +{ + return PAGE_ALIGN(sg->offset + sg->length) >> PAGE_SHIFT; +} + +static struct page *ion_dma_buf_get_page(struct sg_table *sg_table, +unsigned long offset) +{ + struct page *page; + struct scatterlist *sg; + int i; + unsigned int nr_pages; + + nr_pages = 0; + page = NULL; + /* Find the page with specified offset */ + for_each_sg(sg_table->sgl, sg, sg_table->nents, i) { + if (nr_pages + sg_page_count(sg) > offset) { + page = nth_page(sg_page(sg), offset - nr_pages); + break; + } + + nr_pages += sg_page_count(sg); + } + + return page; +} static void *ion_dma_buf_kmap(struct dma_buf *dmabuf, unsigned long offset) { struct ion_buffer *buffer = dmabuf->priv; - return buffer->vaddr + offset * PAGE_SIZE; + return kmap(ion_dma_buf_get_page(buffer->sg_table, offset)); } This unfortunately doesn't work for uncached buffers. We need to create an uncached alias otherwise we break what little coherency that guarantees. I'm still convinced that we can't actually do the uncached buffers correctly and they should be removed... Thanks, Laura static void ion_dma_buf_kunmap(struct dma_buf *dmabuf, unsigned long offset, void *ptr) { + kunmap(ptr); +} + +static void *ion_dma_buf_kmap_atomic(struct dma_buf *dmabuf, +unsigned long offset) +{ + struct ion_buffer *buffer = dmabuf->priv; + + return kmap_atomic(ion_dma_buf_get_page(buffer->sg_table, + offset)); +} + +static void ion_dma_buf_kunmap_atomic(struct dma_buf *dmabuf, + unsigned long offset, + void *ptr) +{ + kunmap_atomic(ptr); } static int ion_dma_buf_begin_cpu_access(struct dma_buf *dmabuf, enum dma_data_direction direction) { struct ion_buffer *buffer = dmabuf->priv; - void *vaddr; struct ion_dma_buf_attachment *a; - /* -* TODO: Move this elsewhere because we don't always need a vaddr -*/ - if (buffer->heap->ops->map_kernel) { - mutex_lock(&buffer->lock); - vaddr = ion_buffer_kmap_get(buffer); - mutex_unlock(&buffer->lock); - } - mutex_loc
Re: [PATCH] staging: android: ion: Initialize dma_address of new sg list
On 02/12/2018 01:25 PM, Liam Mark wrote: On Mon, 12 Feb 2018, Dan Carpenter wrote: On Fri, Feb 09, 2018 at 10:16:56PM -0800, Liam Mark wrote: Fix the dup_sg_table function to initialize the dma_address of the new sg list entries instead of the source dma_address entries. Fixes: 17fd283f3870 ("staging: android: ion: Duplicate sg_table") Signed-off-by: Liam Mark How did you find this bug? What are the user visible effects of this bug? I'm probably going to ask you to send a v2 patch with a new changelog depending on the answers to these questions. I noticed the bug when reading through the code, I haven’t seen any visible effects of this bug. From looking at the code I don’t see any obvious ways that this bug would introduce any issues with the current code base. Liam Given the way we duplicate the sg_list this should be harmless but you are right it's cleaner if we initialize the new list. You can add my Ack when you update with a new change log clarifying this. Thanks, Laura ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] comedi: fix comedi_nsamples_left.
A rounding error was causing comedi_nsamples_left to return the wrong value when nsamples was not a multiple of the scan length. Cc: # v4.4+ Signed-off-by: Frank Mori Hess --- drivers/staging/comedi/drivers.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers.c b/drivers/staging/comedi/drivers.c index 0b43db6371c6..c11c22bd6d13 100644 --- a/drivers/staging/comedi/drivers.c +++ b/drivers/staging/comedi/drivers.c @@ -484,8 +484,7 @@ unsigned int comedi_nsamples_left(struct comedi_subdevice *s, struct comedi_cmd *cmd = &async->cmd; if (cmd->stop_src == TRIG_COUNT) { - unsigned int nscans = nsamples / cmd->scan_end_arg; - unsigned int scans_left = __comedi_nscans_left(s, nscans); + unsigned int scans_left = __comedi_nscans_left(s, cmd->stop_arg); unsigned int scan_pos = comedi_bytes_to_samples(s, async->scan_progress); unsigned long long samples_left = 0; -- 2.11.0 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Urgent From Hospital
Hello My Beloved this is Ms Marilis Mannik from Estonia writing from the hospital here in Ivory Coast; I want you to know that I’m dying here in this hospital right now which i don't know if i will see some few days to come. My Beloved, i was informed by my doctor that i got poisoned and it affected my liver and i can only live for some days. The reason why i contacted you today is because i know that my step mother wanted to kill me and take my inheritance from my late Father. I have a little adopted child named Andrew C. Mannik that i adopted in this Country when my late Father was alive and $3.5 million Dollars i inherited from my late father. My step mother and her children they are after Andrew right now because they found out that Andrew was aware of the poison, and because i handed the documents of the fund over to him the day my step Mother poisoned my food, for that reason they do not want Andrew to expose them, so they are doing everything possible to kill him. My Beloved, please i want you to help him out of this country with the money, he is the only one taking good care of me here in this hospital right now and even this email you are reading now he is the one helping me out. I want you to get back to me so that he will give you the documents of the fund and he will direct you to a well known lawyer that i have appointed, the lawyer will assist you to change the documents of the fund to your name to enable the bank transfer the money to you.. This is the favor i need when you have gotten the fund: (1) Keep 30% of the money for Andrew until he finish his studies to become a man as he has been there for me as my lovely Son and i promised to support him in life to become a medical Doctor because he always desire for it with the scholarship he had won so far. I want you to take him along with you to your country and establish him as your son. (2) Give 20% of the money to handicap people and charity organization. The remaining 50% should be yours for your help to Andrew. Note; This should be a code between you and my son Andrew in this transaction "Hospital" any mail from him, the Lawyer he will direct you to, without this code "Hospital" is not from the Andrew, the Lawyer or myself as i don't know what will happen to me in the next few hours. Finally, write me back so that Andrew will send you his pictures to be sure of whom you are dealing with. Andrew is 14years now, therefore guide him. And if i don't hear from you i will look for another person or any organization. May Almighty God bless you and use you to accomplish my wish. Pray for me always. Ms Marilis Mannik ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Urgent From Hospital
Hello My Beloved this is Ms Marilis Mannik from Estonia writing from the hospital here in Ivory Coast; I want you to know that I’m dying here in this hospital right now which i don't know if i will see some few days to come. My Beloved, i was informed by my doctor that i got poisoned and it affected my liver and i can only live for some days. The reason why i contacted you today is because i know that my step mother wanted to kill me and take my inheritance from my late Father. I have a little adopted child named Andrew C. Mannik that i adopted in this Country when my late Father was alive and $3.5 million Dollars i inherited from my late father. My step mother and her children they are after Andrew right now because they found out that Andrew was aware of the poison, and because i handed the documents of the fund over to him the day my step Mother poisoned my food, for that reason they do not want Andrew to expose them, so they are doing everything possible to kill him. My Beloved, please i want you to help him out of this country with the money, he is the only one taking good care of me here in this hospital right now and even this email you are reading now he is the one helping me out. I want you to get back to me so that he will give you the documents of the fund and he will direct you to a well known lawyer that i have appointed, the lawyer will assist you to change the documents of the fund to your name to enable the bank transfer the money to you.. This is the favor i need when you have gotten the fund: (1) Keep 30% of the money for Andrew until he finish his studies to become a man as he has been there for me as my lovely Son and i promised to support him in life to become a medical Doctor because he always desire for it with the scholarship he had won so far. I want you to take him along with you to your country and establish him as your son. (2) Give 20% of the money to handicap people and charity organization. The remaining 50% should be yours for your help to Andrew. Note; This should be a code between you and my son Andrew in this transaction "Hospital" any mail from him, the Lawyer he will direct you to, without this code "Hospital" is not from the Andrew, the Lawyer or myself as i don't know what will happen to me in the next few hours. Finally, write me back so that Andrew will send you his pictures to be sure of whom you are dealing with. Andrew is 14years now, therefore guide him. And if i don't hear from you i will look for another person or any organization. May Almighty God bless you and use you to accomplish my wish. Pray for me always. Ms Marilis Mannik ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Urgent From Hospital
Hello My Beloved this is Ms Marilis Mannik from Estonia writing from the hospital here in Ivory Coast; I want you to know that I’m dying here in this hospital right now which i don't know if i will see some few days to come. My Beloved, i was informed by my doctor that i got poisoned and it affected my liver and i can only live for some days. The reason why i contacted you today is because i know that my step mother wanted to kill me and take my inheritance from my late Father. I have a little adopted child named Andrew C. Mannik that i adopted in this Country when my late Father was alive and $3.5 million Dollars i inherited from my late father. My step mother and her children they are after Andrew right now because they found out that Andrew was aware of the poison, and because i handed the documents of the fund over to him the day my step Mother poisoned my food, for that reason they do not want Andrew to expose them, so they are doing everything possible to kill him. My Beloved, please i want you to help him out of this country with the money, he is the only one taking good care of me here in this hospital right now and even this email you are reading now he is the one helping me out. I want you to get back to me so that he will give you the documents of the fund and he will direct you to a well known lawyer that i have appointed, the lawyer will assist you to change the documents of the fund to your name to enable the bank transfer the money to you.. This is the favor i need when you have gotten the fund: (1) Keep 30% of the money for Andrew until he finish his studies to become a man as he has been there for me as my lovely Son and i promised to support him in life to become a medical Doctor because he always desire for it with the scholarship he had won so far. I want you to take him along with you to your country and establish him as your son. (2) Give 20% of the money to handicap people and charity organization. The remaining 50% should be yours for your help to Andrew. Note; This should be a code between you and my son Andrew in this transaction "Hospital" any mail from him, the Lawyer he will direct you to, without this code "Hospital" is not from the Andrew, the Lawyer or myself as i don't know what will happen to me in the next few hours. Finally, write me back so that Andrew will send you his pictures to be sure of whom you are dealing with. Andrew is 14years now, therefore guide him. And if i don't hear from you i will look for another person or any organization. May Almighty God bless you and use you to accomplish my wish. Pray for me always. Ms Marilis Mannik ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] Staging: wlan-ng: Fix Alignment should match open paranthesis in prism2mgmt.c
This is patch fixes up a matching paranthesis alignment issue found by checkpatch.pl script. Signed-off-by: Yash Omer --- drivers/staging/wlan-ng/prism2mgmt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wlan-ng/prism2mgmt.c b/drivers/staging/wlan-ng/prism2mgmt.c index 5be1af20d2d4..974a7572fafc 100644 --- a/drivers/staging/wlan-ng/prism2mgmt.c +++ b/drivers/staging/wlan-ng/prism2mgmt.c @@ -264,8 +264,8 @@ int prism2mgmt_scan(struct wlandevice *wlandev, void *msgp) goto exit; } /* ibss options */ - result = hfa384x_drvr_setconfig16(hw, - HFA384x_RID_CREATEIBSS, + result = hfa384x_drvr_setconfig16 + (hw, HFA384x_RID_CREATEIBSS, HFA384x_CREATEIBSS_JOINCREATEIBSS); if (result) { netdev_err(wlandev->netdev, -- 2.14.3 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
COME AND RECEIVE YOUR FUND NOW?
MR. MICHEAL GODSWILL OF FIRST BANK OF NIGERIA PLC 35 Marina P. O. Box 5216, LAGOS- NIGERIA EMAIL: ( firstbank9...@gmail.com ) DEAR BENEFICIARY This letter is written to you in order to change your life from today. I am Rev Micheal Godwin the Director, International Remittance Department of this Bank, my Boss, Mr. Jacobs M. Ajekigbe, the Managing Director/CEO of this bank is now on compulsory leave and all power have been vested on me to make all international payments. Also, due to reported cases of corrupt practices in other Nigeria Banks including the Central Bank of Nigeria, the Federal Government has revoked/cancelled all power vested on those banks and has appointed our bank (First Bank of Nigeria) to make all foreign payments. Be informed that the Federal Government have approved the release of part-payment of$7.5M(Seven Million Five Hundred Thousand Dollars) out of your total funds, which has been in this bank for many years unclaimed because my boss Mr. Jacobs Ajekigbe, elaboration with the Governor of Central Bank of Nigeria (CBN) have refused to tell you the truth on how to claim your fund this is because he has been using the interest accumulated from your fund every year to enrich himself without your knowledge, I want to help you pull out this fund to your bank account using the easiest and the quickest method, which have not been made known to you before. By this method, you will open a domiciliary account with this bank (First Bank of Nigeria), your fund would be lodged into this domiciliary acc ount and your fund will be paid in directly to any bank of your choice. After the transfer, you will confirm the fund in your bank account within 5hours the same day. No Cost of Transfer (COT) and no stoppage from any Government departments as the transfer will be done within the bank alone and it is very safe. The method which was introduced to you before is the Telegraphic Transfer (TT) for which confirmation was 48hrs, because of the time factor, petitions could come from various organizations stopping your payment and asking you to pay huge fee which would be difficult for you to pay so that they can benefit from the huge interest your fund generates while still in the Bank. This method is not safe for you because it is not done within the bank alone as information of the payment would be sent to the Central Control Unit (CCU) of the Federal Ministry of Finance and office of the Accountant Genera l of the Federation. As a good Christian, I have nothing to gain by keeping your fund, I want to assist you receive your fund before my boss resumes office. You have to follow up and work with me now, so keep this very confidential because of fraudsters and impostors who go about presenting various bank accounts in order to divert another beneficiary's fund. Your present/valid account co-ordinates and amount to be claimed so that I do not transfer your fund to the wrong Bank Account. Await your quick Reply to via private id ( firstbank9...@gmail.com yours truly, Mr.Micheal Godswill ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
COME AND RECEIVE YOUR FUND NOW?
MR. MICHEAL GODSWILL OF FIRST BANK OF NIGERIA PLC 35 Marina P. O. Box 5216, LAGOS- NIGERIA EMAIL: ( firstbank9...@gmail.com ) DEAR BENEFICIARY This letter is written to you in order to change your life from today. I am Rev Micheal Godwin the Director, International Remittance Department of this Bank, my Boss, Mr. Jacobs M. Ajekigbe, the Managing Director/CEO of this bank is now on compulsory leave and all power have been vested on me to make all international payments. Also, due to reported cases of corrupt practices in other Nigeria Banks including the Central Bank of Nigeria, the Federal Government has revoked/cancelled all power vested on those banks and has appointed our bank (First Bank of Nigeria) to make all foreign payments. Be informed that the Federal Government have approved the release of part-payment of$7.5M(Seven Million Five Hundred Thousand Dollars) out of your total funds, which has been in this bank for many years unclaimed because my boss Mr. Jacobs Ajekigbe, elaboration with the Governor of Central Bank of Nigeria (CBN) have refused to tell you the truth on how to claim your fund this is because he has been using the interest accumulated from your fund every year to enrich himself without your knowledge, I want to help you pull out this fund to your bank account using the easiest and the quickest method, which have not been made known to you before. By this method, you will open a domiciliary account with this bank (First Bank of Nigeria), your fund would be lodged into this domiciliary acc ount and your fund will be paid in directly to any bank of your choice. After the transfer, you will confirm the fund in your bank account within 5hours the same day. No Cost of Transfer (COT) and no stoppage from any Government departments as the transfer will be done within the bank alone and it is very safe. The method which was introduced to you before is the Telegraphic Transfer (TT) for which confirmation was 48hrs, because of the time factor, petitions could come from various organizations stopping your payment and asking you to pay huge fee which would be difficult for you to pay so that they can benefit from the huge interest your fund generates while still in the Bank. This method is not safe for you because it is not done within the bank alone as information of the payment would be sent to the Central Control Unit (CCU) of the Federal Ministry of Finance and office of the Accountant Genera l of the Federation. As a good Christian, I have nothing to gain by keeping your fund, I want to assist you receive your fund before my boss resumes office. You have to follow up and work with me now, so keep this very confidential because of fraudsters and impostors who go about presenting various bank accounts in order to divert another beneficiary's fund. Your present/valid account co-ordinates and amount to be claimed so that I do not transfer your fund to the wrong Bank Account. Await your quick Reply to via private id ( firstbank9...@gmail.com yours truly, Mr.Micheal Godswill ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2] media: imx: capture: reformat line to 80 chars or less
Acked-by: Steve Longerbeam On 02/15/2018 01:25 AM, Parthiban Nallathambi wrote: This is a cleanup patch to fix line length issue found by checkpatch.pl script. In this patch, line 144 have been wrapped. Signed-off-by: Parthiban Nallathambi --- Changes in v2: - Changed commit message drivers/staging/media/imx/imx-media-capture.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/media/imx/imx-media-capture.c b/drivers/staging/media/imx/imx-media-capture.c index 576bdc7e9c42..0ccabe04b0e1 100644 --- a/drivers/staging/media/imx/imx-media-capture.c +++ b/drivers/staging/media/imx/imx-media-capture.c @@ -141,7 +141,8 @@ static int capture_enum_frameintervals(struct file *file, void *fh, fie.code = cc->codes[0]; - ret = v4l2_subdev_call(priv->src_sd, pad, enum_frame_interval, NULL, &fie); + ret = v4l2_subdev_call(priv->src_sd, pad, enum_frame_interval, + NULL, &fie); if (ret) return ret; ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2 0/7] crypto: ccree: Introduce Arm TrustZone CryptoCell
On Mon, Jan 22, 2018 at 09:26:58AM +, Gilad Ben-Yossef wrote: > Arm TrustZone CryptoCell is a security hardware IP that > includes support for hardware based hash, digest, cipher > and AEAD operations. This driver provides support for > these as part of the Linux Crypto sub-system. > > The driver spent some time now in the staging tree being > cleaned up and is now submitted for review for the > purpose of moving into the crypto tree. The first patch > therefore renames its copy in the staging directory > Kconfig define and marks it broken, otherwise there is a > build failure due to global symbols collisions. > > Please note that the driver include stubs for yet > unexposed functionality (ivgen and secure HW keys), > which will be added later. > > Signed-off-by: Gilad Ben-Yossef > > Changes from v1: > - Use KConfig directive to stop staging tree version to not > collide during link time as opposed to deleting it as indicated > by Greg KH. > - Switched from legacy ablkcipher to skcipher interface as > indicated by Corentin Labbe. > - Removed unused zero_buff struct as indicated by Corentin Labbe. > - Moved to kzfree for all IV/key buffers as indicated by > Corentin Labbe. > - Moved to using __des3_ede_setkey() in lieu of home grown > version as indicated by Stephan Mueller. > - Fixed multiple small coding style from Dan Carpenter and others. > - Fixed pointer signedness sparse warnings as indicated by Jeremy > Sowden. > - Rename all registered algs driver name to -ccree prefix > > Gilad Ben-Yossef (7): > staging: ccree: rename staging ver and mark as broken > crypto: ccree: introduce CryptoCell driver > crypto: ccree: add skcipher support > crypto: ccree: add ahash support > crypto: ccree: add AEAD support > crypto: ccree: add FIPS support > MAINTAINERS: update ccree entry All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2] media: imx: capture: reformat line to 80 chars or less
This is a cleanup patch to fix line length issue found by checkpatch.pl script. In this patch, line 144 have been wrapped. Signed-off-by: Parthiban Nallathambi --- Changes in v2: - Changed commit message drivers/staging/media/imx/imx-media-capture.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/media/imx/imx-media-capture.c b/drivers/staging/media/imx/imx-media-capture.c index 576bdc7e9c42..0ccabe04b0e1 100644 --- a/drivers/staging/media/imx/imx-media-capture.c +++ b/drivers/staging/media/imx/imx-media-capture.c @@ -141,7 +141,8 @@ static int capture_enum_frameintervals(struct file *file, void *fh, fie.code = cc->codes[0]; - ret = v4l2_subdev_call(priv->src_sd, pad, enum_frame_interval, NULL, &fie); + ret = v4l2_subdev_call(priv->src_sd, pad, enum_frame_interval, + NULL, &fie); if (ret) return ret; -- 2.14.3 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel