RE: [PATCH] Drivers: hv: vmbus: include header for get_irq_regs()
From Sebastian Andrzej Siewior Sent: Thursday, August 30, 2018 12:55 AM > > On !RT the header file get_irq_regs() gets pulled in via other header files. > On > RT it does not and the build fails: > > drivers/hv/vmbus_drv.c:975 implicit declaration of function > ‘get_irq_regs’ [- > Werror=implicit-function-declaration] > drivers/hv/hv.c:115 implicit declaration of function ‘get_irq_regs’ > [-Werror=implicit- > function-declaration] > > Add the header file for get_irq_regs() in a common header so it used by > vmbus_drv.c by hv.c for their get_irq_regs() usage. > get_irq_regs() is not used explicitly in either vmbus_drv.c or in hv.c. And I couldn't make the line numbers in the errors above line up with anything in the source code that might be implicitly using get_irq_regs(). Is it the calls to add_interrupt_randomness()? Did you figure out exactly what line of code is causing the compile error? I'm wondering whether adding the #include of irq.h into hyperv_vmbus.h is really the right solution. More correct might be to have the file where get_irq_regs() is actually used to #include irq_regs.h. Michael ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 00/19] mtd: rawnand: API cleanup (2nd batch)
Hi Boris,
Boris Brezillon wrote on Fri, 7 Sep 2018
00:38:32 +0200:
> Hello,
>
> This is the 2nd batch of API cleanup patches. This time we move
> deprecated hooks/fields to the nand_legacy struct, and then move some
> of the code found in nand_base.c into separate source/header files.
>
> With this new organization, new comers should more easily identify the
> bits they can use in their NAND controller drivers and those that are
> only meant for core code. It also shrink a bit nand_base.c which was
> over 6000 lines of code.
>
> Note that existing coding style issues (reported by checkpatch) in arch
> or driver code are intentionally not fixed to keep the series focused
> on the API/core cleanup.
>
> Regards,
>
> Boris
>
> Boris Brezillon (19):
> mtd: rawnand: Leave chip->IO_ADDR_{R,W} to NULL when unused
> mtd: rawnand: Create a legacy struct and move ->IO_ADDR_{R,W} there
> mtd: rawnand: Deprecate ->{read,write}_{byte,buf}() hooks
> mtd: rawnand: Deprecate ->cmd_ctrl() and ->cmdfunc()
> mtd: rawnand: Deprecate ->dev_ready() and ->waitfunc()
> mtd: rawnand: Deprecate ->block_{bad,markbad}() hooks
> mtd: rawnand: Deprecate ->erase()
> mtd: rawnand: Deprecate ->{set,get}_features() hooks
> mtd: rawnand: Deprecate ->chip_delay
> mtd: rawnand: Move function prototypes after struct declarations
> mtd: rawnand: Get rid of nand_flash_dev forward declation
> mtd: rawnand: Get rid of the duplicate nand_chip forward declaration
> mtd: rawnand: Get rid of a few unused definitions
> mtd: rawnand: Move platform_nand_xxx definitions out of rawnand.h
> mtd: rawnand: Inline onfi_get_async_timing_mode()
> mtd: rawnand: Keep all internal stuff private
> mtd: rawnand: Move legacy code to nand_legacy.c
> mtd: rawnand: Move ONFI code to nand_onfi.c
> mtd: rawnand: Move JEDEC code to nand_jedec.c
>
> Documentation/driver-api/mtdnand.rst | 30 +-
> arch/arm/mach-ep93xx/snappercl15.c |8 +-
> arch/arm/mach-ep93xx/ts72xx.c|9 +-
> arch/arm/mach-imx/mach-qong.c|6 +-
> arch/arm/mach-ixp4xx/ixdp425-setup.c |2 +-
> arch/arm/mach-omap1/board-fsample.c |3 +-
> arch/arm/mach-omap1/board-h2.c |3 +-
> arch/arm/mach-omap1/board-h3.c |2 +-
> arch/arm/mach-omap1/board-nand.c |2 +-
> arch/arm/mach-omap1/board-perseus2.c |3 +-
> arch/arm/mach-orion5x/ts78xx-setup.c |9 +-
> arch/arm/mach-pxa/balloon3.c |5 +-
> arch/arm/mach-pxa/em-x270.c |9 +-
> arch/arm/mach-pxa/palmtx.c |5 +-
> arch/mips/alchemy/devboards/db1200.c |9 +-
> arch/mips/alchemy/devboards/db1300.c |9 +-
> arch/mips/alchemy/devboards/db1550.c |9 +-
> arch/mips/netlogic/xlr/platform-flash.c |3 +-
> arch/mips/pnx833x/common/platform.c |5 +-
> arch/mips/rb532/devices.c|5 +-
> arch/sh/boards/mach-migor/setup.c|8 +-
> drivers/mtd/nand/raw/Makefile|4 +-
> drivers/mtd/nand/raw/ams-delta.c | 22 +-
> drivers/mtd/nand/raw/atmel/nand-controller.c | 22 +-
> drivers/mtd/nand/raw/au1550nd.c | 43 +-
> drivers/mtd/nand/raw/bcm47xxnflash/ops_bcm4706.c | 22 +-
> drivers/mtd/nand/raw/brcmnand/brcmnand.c | 15 +-
> drivers/mtd/nand/raw/cafe_nand.c | 22 +-
> drivers/mtd/nand/raw/cmx270_nand.c | 28 +-
> drivers/mtd/nand/raw/cs553x_nand.c | 42 +-
> drivers/mtd/nand/raw/davinci_nand.c | 34 +-
> drivers/mtd/nand/raw/denali.c| 23 +-
> drivers/mtd/nand/raw/diskonchip.c| 50 +-
> drivers/mtd/nand/raw/fsl_elbc_nand.c | 18 +-
> drivers/mtd/nand/raw/fsl_ifc_nand.c | 24 +-
> drivers/mtd/nand/raw/fsl_upm.c | 30 +-
> drivers/mtd/nand/raw/fsmc_nand.c |1 -
> drivers/mtd/nand/raw/gpio.c | 16 +-
> drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c | 22 +-
> drivers/mtd/nand/raw/hisi504_nand.c | 18 +-
> drivers/mtd/nand/raw/internals.h | 114 ++
> drivers/mtd/nand/raw/jz4740_nand.c | 14 +-
> drivers/mtd/nand/raw/jz4780_nand.c | 10 +-
> drivers/mtd/nand/raw/lpc32xx_mlc.c | 12 +-
> drivers/mtd/nand/raw/lpc32xx_slc.c | 26 +-
> drivers/mtd/nand/raw/mpc5121_nfc.c | 14 +-
> drivers/mtd/nand/raw/mtk_nand.c | 12 +-
> drivers/mtd/nand/raw/mxc_nand.c | 20 +-
> drivers/mtd/nand/raw/nand_amd.c |2 +-
> drivers/mtd/nand/raw/nand_base.c | 1260
> +++---
> drivers/mtd/nand
September 14, 2018
I am Mr. Noah Rivers, a staff of Raiffeisen Bank International AG, London Branch. A client of mine who shared the same last name with you and who, after his retirement lived in the United Kingdom died of a heart condition caused by the death of all the members of his family fourteen years back in the tsunami disaster on the 26th December 2004 in Sumatra Indonesia. He had been battling a heart condition until May 22, 2016 when he passed away. You can find the news on the following link: http://en.wikipedia.org/wiki/2004_Indian_Ocean_earthquake Further details will be given to you at the receipt of your correspondence. Best regards, Noah Rivers ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: mt7621-mmc: Remove do {} while (0) loop for single statement macro
This patch removes do {} while (0) loop for single statement macros.
Issue found by checkpatch.
Signed-off-by: Nishad Kamdar
---
drivers/staging/mt7621-mmc/sd.c | 28 +++-
1 file changed, 7 insertions(+), 21 deletions(-)
diff --git a/drivers/staging/mt7621-mmc/sd.c b/drivers/staging/mt7621-mmc/sd.c
index 7474f9ed7b5b..ec12a3a5a926 100644
--- a/drivers/staging/mt7621-mmc/sd.c
+++ b/drivers/staging/mt7621-mmc/sd.c
@@ -104,14 +104,10 @@ static int cd_active_low = 1;
/* gate means clock power down */
static int g_clk_gate = 0;
#define msdc_gate_clock(id) \
- do { \
- g_clk_gate &= ~(1 << ((id) + PERI_MSDC0_PDN)); \
- } while (0)
+ (g_clk_gate &= ~(1 << ((id) + PERI_MSDC0_PDN)))
/* not like power down register. 1 means clock on. */
#define msdc_ungate_clock(id) \
- do {\
- g_clk_gate |= 1 << ((id) + PERI_MSDC0_PDN); \
- } while (0)
+ (g_clk_gate |= 1 << ((id) + PERI_MSDC0_PDN))
// do we need sync object or not
void msdc_clk_status(int *status)
@@ -170,9 +166,7 @@ static void msdc_clr_fifo(struct msdc_host *host)
} while (0)
#define msdc_irq_restore(val) \
- do {\
- sdr_set_bits(host->base + MSDC_INTEN, val); \
- } while (0)
+ (sdr_set_bits(host->base + MSDC_INTEN, val))
/* clock source for host: global */
#if defined(CONFIG_SOC_MT7620)
@@ -186,26 +180,18 @@ static u32 hclks[] = {5000}; /* +/- by chhung */
//always keep the VMC on.
//
#define msdc_vcore_on(host) \
- do {\
- (void)hwPowerOn(MT65XX_POWER_LDO_VMC, VOL_3300, "SD"); \
- } while (0)
+ ((void)hwPowerOn(MT65XX_POWER_LDO_VMC, VOL_3300, "SD"))
#define msdc_vcore_off(host) \
- do {\
- (void)hwPowerDown(MT65XX_POWER_LDO_VMC, "SD"); \
- } while (0)
+ ((void)hwPowerDown(MT65XX_POWER_LDO_VMC, "SD"))
//
// the vdd output for card: global
// always keep the VMCH on.
//
#define msdc_vdd_on(host) \
- do {\
- (void)hwPowerOn(MT65XX_POWER_LDO_VMCH, VOL_3300, "SD"); \
- } while (0)
+ ((void)hwPowerOn(MT65XX_POWER_LDO_VMCH, VOL_3300, "SD"))
#define msdc_vdd_off(host) \
- do {\
- (void)hwPowerDown(MT65XX_POWER_LDO_VMCH, "SD"); \
- } while (0)
+ ((void)hwPowerDown(MT65XX_POWER_LDO_VMCH, "SD"))
#define sdc_is_busy() (readl(host->base + SDC_STS) & SDC_STS_SDCBUSY)
#define sdc_is_cmd_busy() (readl(host->base + SDC_STS) & SDC_STS_CMDBUSY)
--
2.17.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
