Re: Work on iio: stating: frequency: ad9832

[Alexandru Ardelean]

On Mon, Apr 1, 2019 at 7:13 PM Jonathan Cameron
 wrote:
>
> On Mon, 1 Apr 2019 11:25:29 -0300
> Marcelo Schmitt  wrote:
>
> > Hello,
> >
> > I was looking for some work on staging: iio: ad9832 and made some
> > observations while reading the driver.
> >
> > Apparently it had no devicetree documentation so I tried to elaborate
> > one.
> > It uses a platform_data variable to load external clock
> > frequency (I tried to make it use linux's clock framework).
> Good.
>
> > Some device attributes don't seem to be standardized on
> > Documentation/ABI/testing/sysfs-bus-iio and there's no specific ABI
> > for ad9832 nearby nor at staging/iio/Documentation. So maybe those
> > missing ABI could be documented.
> Beware. It's an old driver, so it may be that we actually want to change
> it's ABI rather than documenting what is there (I have haven't looked!)
>

This one can actually be coupled a bit with the AD9834 driver.
There's been some work on trying to move that one out of staging as well.

You can take a look at the patches sent for that driver.
They should be find-able on patchwork
https://patchwork.kernel.org/project/linux-iio/list/?series=&submitter=&state=*&q=ad9834&archive=both&delegate=

There are ideas worth borrowing from there.

The issue with the AD9834 [if i recall correctly] is that it doesn't
quite fit the classical IIO channel model.
Meaning, you can only activate the output of one channel at one moment
in time, and not both.

> > The device has to set some internal registers to operate correctly,
> > AD9832_FREQXHM and AD9832_PHASEXH, would it be feasible to set iio
> > chanels for this?
>
> What are they?  If they correspond to output channels in some sensible
> way then maybe...
>
> > I couldn't understand why checkpatch.pl gave errors on IIO_DEV_ATTR_*
> > macros. To me they seem to have no problem.
> > Also it has that platform_data to be moved to include/linux/iio. Is
> > there any special reason for it not being there already? Which are
> > the criterions a platform_data need to satisfy to be put there?
> A driver moving out of staging shouldn't have platform data. It needs
> to be converted over to more modern mechanisms.   We don't have a problem
> supporting platform data for devices that have old school device files
> already in tree, but that shouldn't be the case for a driver in staging.
>
> Hence we can clean it up and move forward with just DT bindings.
> >
> > I'm sending a patchset with some things I've already done.
> Cool. I'll look at those later in the week if no one beats me to them.
>
> >
> > Is there something else that could be done in this device driver?
> > Please, tell if I've forgotten something.
>
> I'll take a look, but it may be a little while before I do.
> Hopefully someone else gets there first!
>
> Jonathan
>
> >
> > Any advice is welcome.
> > Thanks,
> >
> > Marcelo
>
>
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v3 05/14] staging: most: enable configfs support

[Greg KH]

On Mon, Apr 01, 2019 at 02:05:30PM +0200, Christian Gromm wrote:
> This patch enables the configfs functionality of the driver by
> registering the configfs subsystems and compiling the configfs
> part of the sources.
> 
> Signed-off-by: Christian Gromm 
> ---
> v2:
>   - remove call to configfs_exit function
> v3:
> 
>  drivers/staging/most/Makefile  |  1 +
>  drivers/staging/most/cdev/cdev.c   |  6 ++
>  drivers/staging/most/core.c|  2 +-
>  drivers/staging/most/sound/sound.c | 11 ++-
>  4 files changed, 18 insertions(+), 2 deletions(-)

You add the file in patch 1, but do not add it to the build until patch
5?  Does that really work?

And what about Kconfig dependancies, don't you need to add a dependancy
on configfs to the most core now?

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v3 07/14] staging: most: core: use device description as name

[Greg KH]

On Mon, Apr 01, 2019 at 02:05:32PM +0200, Christian Gromm wrote:
> This patch uses the device description to clearly identity a device
> attached to the bus. It is needed as the currently useed mdevX
> notation is not sufficiant in case more than one network
> interface controller is being used at the same time.
> 
> Signed-off-by: Christian Gromm 
> ---
> v2:
> v3:
> 
>  drivers/staging/most/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/most/core.c b/drivers/staging/most/core.c
> index a5df53e..e0a6806 100644
> --- a/drivers/staging/most/core.c
> +++ b/drivers/staging/most/core.c
> @@ -1467,7 +1467,7 @@ int most_register_interface(struct most_interface 
> *iface)
>  
>   INIT_LIST_HEAD(&iface->p->channel_list);
>   iface->p->dev_id = id;
> - snprintf(iface->p->name, STRING_SIZE, "mdev%d", id);
> + strcpy(iface->p->name, iface->description);
>   iface->dev.init_name = iface->p->name;
>   iface->dev.bus = &mc.bus;
>   iface->dev.parent = &mc.dev;

Is this a stand-alone bugfix that can be taken now and should also be
added to the stable kernel trees?

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v3 13/14] staging: most: configfs: rename config attributes

[Greg KH]

On Mon, Apr 01, 2019 at 02:05:38PM +0200, Christian Gromm wrote:
> This patch introduces attribute names that are more self explaining.
> 
> Signed-off-by: Christian Gromm 
> ---
> v2:
>   - follow-up adaptions due to changes introduced w/ [PATCH v2 01/14]
> v3:
> 
>  drivers/staging/most/configfs.c | 97 
> +
>  1 file changed, 49 insertions(+), 48 deletions(-)

Why isn't this just part of patch 1/14 here?  No need to create a
problem and then have to fix it up later in the same series :)

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v3 05/14] staging: most: enable configfs support

[Christian.Gromm]

On Di, 2019-04-02 at 09:20 +0200, Greg KH wrote:
> External E-Mail
> 
> 
> On Mon, Apr 01, 2019 at 02:05:30PM +0200, Christian Gromm wrote:
> > 
> > This patch enables the configfs functionality of the driver by
> > registering the configfs subsystems and compiling the configfs
> > part of the sources.
> > 
> > Signed-off-by: Christian Gromm 
> > ---
> > v2:
> > - remove call to configfs_exit function
> > v3:
> > 
> >  drivers/staging/most/Makefile  |  1 +
> >  drivers/staging/most/cdev/cdev.c   |  6 ++
> >  drivers/staging/most/core.c|  2 +-
> >  drivers/staging/most/sound/sound.c | 11 ++-
> >  4 files changed, 18 insertions(+), 2 deletions(-)
> You add the file in patch 1, but do not add it to the build until
> patch
> 5?  Does that really work?
> 
Yes it does, because user space can still use sysfs to configure
the driver until patch 9/14 is being applied (which disables this
function). I've done things this way to provide you with a
clearly laid out patch queue.

> And what about Kconfig dependancies, don't you need to add a
> dependancy
> on configfs to the most core now?
> 

This dependency should be added, right. 

> thanks,
> 
> greg k-h
> ___
> devel mailing list
> de...@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-de
> vel
> 
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v3 07/14] staging: most: core: use device description as name

[Christian.Gromm]

On Di, 2019-04-02 at 09:24 +0200, Greg KH wrote:
> External E-Mail
> 
> 
> On Mon, Apr 01, 2019 at 02:05:32PM +0200, Christian Gromm wrote:
> > 
> > This patch uses the device description to clearly identity a device
> > attached to the bus. It is needed as the currently useed mdevX
> > notation is not sufficiant in case more than one network
> > interface controller is being used at the same time.
> > 
> > Signed-off-by: Christian Gromm 
> > ---
> > v2:
> > v3:
> > 
> >  drivers/staging/most/core.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/staging/most/core.c
> > b/drivers/staging/most/core.c
> > index a5df53e..e0a6806 100644
> > --- a/drivers/staging/most/core.c
> > +++ b/drivers/staging/most/core.c
> > @@ -1467,7 +1467,7 @@ int most_register_interface(struct
> > most_interface *iface)
> >  
> >     INIT_LIST_HEAD(&iface->p->channel_list);
> >     iface->p->dev_id = id;
> > -   snprintf(iface->p->name, STRING_SIZE, "mdev%d", id);
> > +   strcpy(iface->p->name, iface->description);
> >     iface->dev.init_name = iface->p->name;
> >     iface->dev.bus = &mc.bus;
> >     iface->dev.parent = &mc.dev;
> Is this a stand-alone bugfix that can be taken now and should also be
> added to the stable kernel trees?
> 

Stable trees? The driver is not present there yet.

> thanks,
> 
> greg k-h
> ___
> devel mailing list
> de...@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-de
> vel
> 
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v3 13/14] staging: most: configfs: rename config attributes

[Christian.Gromm]

On Di, 2019-04-02 at 09:25 +0200, Greg KH wrote:
> External E-Mail
> 
> 
> On Mon, Apr 01, 2019 at 02:05:38PM +0200, Christian Gromm wrote:
> > 
> > This patch introduces attribute names that are more self
> > explaining.
> > 
> > Signed-off-by: Christian Gromm 
> > ---
> > v2:
> > - follow-up adaptions due to changes introduced w/ [PATCH v2
> > 01/14]
> > v3:
> > 
> >  drivers/staging/most/configfs.c | 97 +--
> > --
> >  1 file changed, 49 insertions(+), 48 deletions(-)
> Why isn't this just part of patch 1/14 here?  No need to create a
> problem and then have to fix it up later in the same series :)
> 

This is not part of patch 1/14, because it does a different thing.
I just wanted to point out that this patch has small changes when
"diffed" against v1. These changes have been introduced when I
rebased the patch set with the changes in 1/14 recommended by Dan
Carpenter. In principle, it does the very same as before. Nothing
has been added.

regards,
Chris 

> thanks,
> 
> greg k-h
> ___
> devel mailing list
> de...@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-de
> vel
> 
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v3 07/14] staging: most: core: use device description as name

[Greg KH]

On Tue, Apr 02, 2019 at 08:10:25AM +, christian.gr...@microchip.com wrote:
> On Di, 2019-04-02 at 09:24 +0200, Greg KH wrote:
> > External E-Mail
> > 
> > 
> > On Mon, Apr 01, 2019 at 02:05:32PM +0200, Christian Gromm wrote:
> > > 
> > > This patch uses the device description to clearly identity a device
> > > attached to the bus. It is needed as the currently useed mdevX
> > > notation is not sufficiant in case more than one network
> > > interface controller is being used at the same time.
> > > 
> > > Signed-off-by: Christian Gromm 
> > > ---
> > > v2:
> > > v3:
> > > 
> > >  drivers/staging/most/core.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/staging/most/core.c
> > > b/drivers/staging/most/core.c
> > > index a5df53e..e0a6806 100644
> > > --- a/drivers/staging/most/core.c
> > > +++ b/drivers/staging/most/core.c
> > > @@ -1467,7 +1467,7 @@ int most_register_interface(struct
> > > most_interface *iface)
> > >  
> > >   INIT_LIST_HEAD(&iface->p->channel_list);
> > >   iface->p->dev_id = id;
> > > - snprintf(iface->p->name, STRING_SIZE, "mdev%d", id);
> > > + strcpy(iface->p->name, iface->description);
> > >   iface->dev.init_name = iface->p->name;
> > >   iface->dev.bus = &mc.bus;
> > >   iface->dev.parent = &mc.dev;
> > Is this a stand-alone bugfix that can be taken now and should also be
> > added to the stable kernel trees?
> > 
> 
> Stable trees? The driver is not present there yet.

This driver has been in the kernel for many years, and this specific
file has been there since 4.16.  We have long term stable releases for
4.19 going at the moment.

If you don't care about the stable releases, that's fine, just asking :)

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v3 13/14] staging: most: configfs: rename config attributes

[Greg KH]

On Tue, Apr 02, 2019 at 08:17:02AM +, christian.gr...@microchip.com wrote:
> On Di, 2019-04-02 at 09:25 +0200, Greg KH wrote:
> > External E-Mail
> > 
> > 
> > On Mon, Apr 01, 2019 at 02:05:38PM +0200, Christian Gromm wrote:
> > > 
> > > This patch introduces attribute names that are more self
> > > explaining.
> > > 
> > > Signed-off-by: Christian Gromm 
> > > ---
> > > v2:
> > >   - follow-up adaptions due to changes introduced w/ [PATCH v2
> > > 01/14]
> > > v3:
> > > 
> > >  drivers/staging/most/configfs.c | 97 +--
> > > --
> > >  1 file changed, 49 insertions(+), 48 deletions(-)
> > Why isn't this just part of patch 1/14 here?  No need to create a
> > problem and then have to fix it up later in the same series :)
> > 
> 
> This is not part of patch 1/14, because it does a different thing.
> I just wanted to point out that this patch has small changes when
> "diffed" against v1. These changes have been introduced when I
> rebased the patch set with the changes in 1/14 recommended by Dan
> Carpenter. In principle, it does the very same as before. Nothing
> has been added.

My point is, why not add the "more self explaining" attribute names the
first time around when you add the configfs.c file?  Why add it and then
later on change it?  What did that benifit anyone?

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v3 07/14] staging: most: core: use device description as name

[Christian.Gromm]

On Di, 2019-04-02 at 11:00 +0200, Greg KH wrote:
> External E-Mail
> 
> 
> On Tue, Apr 02, 2019 at 08:10:25AM +, Christian.Gromm@microchip.c
> om wrote:
> > 
> > On Di, 2019-04-02 at 09:24 +0200, Greg KH wrote:
> > > 
> > > External E-Mail
> > > 
> > > 
> > > On Mon, Apr 01, 2019 at 02:05:32PM +0200, Christian Gromm wrote:
> > > > 
> > > > 
> > > > This patch uses the device description to clearly identity a
> > > > device
> > > > attached to the bus. It is needed as the currently useed mdevX
> > > > notation is not sufficiant in case more than one network
> > > > interface controller is being used at the same time.
> > > > 
> > > > Signed-off-by: Christian Gromm 
> > > > ---
> > > > v2:
> > > > v3:
> > > > 
> > > >  drivers/staging/most/core.c | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > 
> > > > diff --git a/drivers/staging/most/core.c
> > > > b/drivers/staging/most/core.c
> > > > index a5df53e..e0a6806 100644
> > > > --- a/drivers/staging/most/core.c
> > > > +++ b/drivers/staging/most/core.c
> > > > @@ -1467,7 +1467,7 @@ int most_register_interface(struct
> > > > most_interface *iface)
> > > >  
> > > >     INIT_LIST_HEAD(&iface->p->channel_list);
> > > >     iface->p->dev_id = id;
> > > > -   snprintf(iface->p->name, STRING_SIZE, "mdev%d", id);
> > > > +   strcpy(iface->p->name, iface->description);
> > > >     iface->dev.init_name = iface->p->name;
> > > >     iface->dev.bus = &mc.bus;
> > > >     iface->dev.parent = &mc.dev;
> > > Is this a stand-alone bugfix that can be taken now and should
> > > also be
> > > added to the stable kernel trees?
> > > 
> > Stable trees? The driver is not present there yet.
> This driver has been in the kernel for many years, and this specific
> file has been there since 4.16.  We have long term stable releases
> for
> 4.19 going at the moment.
> 
> If you don't care about the stable releases, that's fine, just asking
> :)
> 

Actually I do care (you know that). Just not sure if I understood what
you was trying to tell me. To me "stable" means "not staging area". 
That's why I was confused.

So yes please, add it.

thanks,
Chris
 

> thanks,
> 
> greg k-h
> 
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v3 13/14] staging: most: configfs: rename config attributes

[Christian.Gromm]

On Di, 2019-04-02 at 11:01 +0200, Greg KH wrote:
> External E-Mail
> 
> 
> On Tue, Apr 02, 2019 at 08:17:02AM +, Christian.Gromm@microchip.c
> om wrote:
> > 
> > On Di, 2019-04-02 at 09:25 +0200, Greg KH wrote:
> > > 
> > > External E-Mail
> > > 
> > > 
> > > On Mon, Apr 01, 2019 at 02:05:38PM +0200, Christian Gromm wrote:
> > > > 
> > > > 
> > > > This patch introduces attribute names that are more self
> > > > explaining.
> > > > 
> > > > Signed-off-by: Christian Gromm 
> > > > ---
> > > > v2:
> > > > - follow-up adaptions due to changes introduced w/
> > > > [PATCH v2
> > > > 01/14]
> > > > v3:
> > > > 
> > > >  drivers/staging/most/configfs.c | 97 +--
> > > > 
> > > > --
> > > >  1 file changed, 49 insertions(+), 48 deletions(-)
> > > Why isn't this just part of patch 1/14 here?  No need to create a
> > > problem and then have to fix it up later in the same series :)
> > > 
> > This is not part of patch 1/14, because it does a different thing.
> > I just wanted to point out that this patch has small changes when
> > "diffed" against v1. These changes have been introduced when I
> > rebased the patch set with the changes in 1/14 recommended by Dan
> > Carpenter. In principle, it does the very same as before. Nothing
> > has been added.
> My point is, why not add the "more self explaining" attribute names
> the
> first time around when you add the configfs.c file?  Why add it and
> then
> later on change it?  What did that benifit anyone?
> 

Got your point. I'll fix it up. But then the patch series would be
shorter as this patch is going to be merged with the first one.

What does this mean to the reroll count? Can I do a v4 that has less
patches than its predecessor?

thanks,
Chris


> thanks,
> 
> greg k-h
> 
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 00/16] staging: fix up remaining SPDX problems in drivers/staging

[Greg Kroah-Hartman]

There are still some remaining SPDX file identifiers missing in the
drivers/staging/ tree.  When a new-developer comes along and tries to
fix up checkpatch.pl issues, and sends in a SPDX change, it is almost
always wrong as the developer doesn't really know the meaning behind the
tags or what needs to be done.

To fix this all up, just resolve all of the remaining SPDX identifier
issues in drivers/staging all at once.  Yes, this involved deleting an
entire driver, whose license was very odd and questionable, but once
that license is properly resolved, we can add it back if needed.

Greg Kroah-Hartman (16):
  staging: add missing SPDX lines to Kconfig files
  staging: add missing SPDX lines to Makefile files
  staging: m57621-mmc: delete driver from the tree.
  staging: sm750fb: add proper SPDX identifier to driver
  staging: vc04_services: add proper SPDX identifier for dual licensed
files
  staging: vc04_services: remove remaining redundant license text
  staging: comedi: quatec_daqp_cs: add proper SPDX identifier to driver
  staging: iio: add proper SPDX identifiers to remaining driver files
  staging: rtl8192u: add proper SPDX identifiers on files that did not
have them.
  staging: ralink-gdma: add proper SPDX identifiers on ralink-gdma file
  staging: rtl8192e: add proper SPDX identifiers on files that did not
have them.
  staging: rtl8192e: delete license file.
  staging: media: zoran: add proper SPDX identifiers on files that did
not have them.
  staging: media: soc_camera: add proper SPDX identifiers on files that
did not have them.
  staging: media: imx: add proper SPDX identifiers on files that did not
have them.
  staging: media: tegra-vde: add proper SPDX identifiers on file that
did not have it.

 drivers/staging/Kconfig   |3 +-
 drivers/staging/Makefile  |1 -
 drivers/staging/android/Kconfig   |1 +
 drivers/staging/android/Makefile  |1 +
 drivers/staging/android/ion/Kconfig   |1 +
 drivers/staging/axis-fifo/Kconfig |1 +
 drivers/staging/axis-fifo/Makefile|1 +
 drivers/staging/board/Kconfig |1 +
 drivers/staging/board/Makefile|1 +
 drivers/staging/clocking-wizard/Kconfig   |1 +
 drivers/staging/clocking-wizard/Makefile  |1 +
 drivers/staging/comedi/Kconfig|1 +
 .../comedi/drivers/ni_routing/tools/Makefile  |1 +
 .../staging/comedi/drivers/quatech_daqp_cs.c  |1 +
 drivers/staging/comedi/kcomedilib/Makefile|1 +
 drivers/staging/emxx_udc/Kconfig  |1 +
 drivers/staging/emxx_udc/Makefile |1 +
 drivers/staging/fbtft/Kconfig |1 +
 drivers/staging/fsl-dpaa2/Kconfig |1 +
 drivers/staging/fsl-dpaa2/Makefile|1 +
 drivers/staging/fwserial/Kconfig  |1 +
 drivers/staging/fwserial/Makefile |1 +
 drivers/staging/gasket/Kconfig|1 +
 drivers/staging/gasket/Makefile   |1 +
 drivers/staging/gdm724x/Kconfig   |1 +
 drivers/staging/goldfish/Kconfig  |1 +
 drivers/staging/goldfish/Makefile |1 +
 drivers/staging/greybus/Kconfig   |1 +
 drivers/staging/gs_fpgaboot/Kconfig   |1 +
 drivers/staging/gs_fpgaboot/Makefile  |1 +
 drivers/staging/iio/Kconfig   |1 +
 drivers/staging/iio/accel/Kconfig |1 +
 drivers/staging/iio/accel/Makefile|1 +
 drivers/staging/iio/accel/adis16203.c |3 +-
 drivers/staging/iio/accel/adis16240.c |3 +-
 drivers/staging/iio/adc/Kconfig   |1 +
 drivers/staging/iio/adc/ad7192.c  |3 +-
 drivers/staging/iio/adc/ad7192.h  |3 +-
 drivers/staging/iio/adc/ad7280a.c |3 +-
 drivers/staging/iio/adc/ad7280a.h |3 +-
 drivers/staging/iio/adc/ad7780.c  |3 +-
 drivers/staging/iio/adc/ad7816.c  |3 +-
 drivers/staging/iio/addac/Kconfig |1 +
 drivers/staging/iio/addac/Makefile|1 +
 drivers/staging/iio/addac/adt7316-i2c.c   |3 +-
 drivers/staging/iio/addac/adt7316-spi.c   |3 +-
 drivers/staging/iio/addac/adt7316.c   |4 +-
 drivers/staging/iio/addac/adt7316.h   |3 +-
 drivers/staging/iio/cdc/Kconfig   |1 +
 drivers/staging/iio/cdc/Makefile  |1 +
 drivers/staging/iio/cdc/ad7150.c  |3 +-
 drivers/staging/iio/cdc/ad7746.c  |3 +-
 drivers/staging/iio/cdc/ad7746.h  |3 +-
 drivers/staging/iio/frequency/Kconfig |1 +
 drivers/staging/iio/frequency/Makefile|1 +
 drivers/staging/iio/frequency/ad9832.c|3 +-
 drivers/staging/iio/frequency/ad9832.h|3 +-
 drivers/staging/iio/fr

[PATCH 14/16] staging: media: soc_camera: add proper SPDX identifiers on files that did not have them.

[Greg Kroah-Hartman]

There were a few files for the soc_camera drivers that did not have SPDX
identifiers on them, so fix that up.  At the same time, remove the "free
form" text that specified the license of the file, as that is impossible
for any tool to properly parse.

Cc: Mauro Carvalho Chehab 
Cc: Shawn Guo 
Cc: Sascha Hauer 
Cc: Fabio Estevam 
Cc: NXP Linux Team 
Cc: Sakari Ailus 
Cc: Hans Verkuil 
Cc: linux-me...@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman 
---
 drivers/staging/media/soc_camera/imx074.c   | 6 +-
 drivers/staging/media/soc_camera/mt9t031.c  | 6 +-
 drivers/staging/media/soc_camera/soc_camera.c   | 6 +-
 drivers/staging/media/soc_camera/soc_mediabus.c | 6 +-
 drivers/staging/media/soc_camera/soc_mt9v022.c  | 6 +-
 drivers/staging/media/soc_camera/soc_ov5642.c   | 6 +-
 drivers/staging/media/soc_camera/soc_ov9740.c   | 6 +-
 7 files changed, 7 insertions(+), 35 deletions(-)

diff --git a/drivers/staging/media/soc_camera/imx074.c 
b/drivers/staging/media/soc_camera/imx074.c
index 1676c166dc83..d907aa62f898 100644
--- a/drivers/staging/media/soc_camera/imx074.c
+++ b/drivers/staging/media/soc_camera/imx074.c
@@ -1,15 +1,11 @@
+// SPDX-License-Identifier: GPL-2.0
 /*
  * Driver for IMX074 CMOS Image Sensor from Sony
  *
  * Copyright (C) 2010, Guennadi Liakhovetski 
  *
  * Partially inspired by the IMX074 driver from the Android / MSM tree
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License version 2 as
- * published by the Free Software Foundation.
  */
-
 #include 
 #include 
 #include 
diff --git a/drivers/staging/media/soc_camera/mt9t031.c 
b/drivers/staging/media/soc_camera/mt9t031.c
index 4ff179302b4f..615ae9df2c57 100644
--- a/drivers/staging/media/soc_camera/mt9t031.c
+++ b/drivers/staging/media/soc_camera/mt9t031.c
@@ -1,13 +1,9 @@
+// SPDX-License-Identifier: GPL-2.0
 /*
  * Driver for MT9T031 CMOS Image Sensor from Micron
  *
  * Copyright (C) 2008, Guennadi Liakhovetski, DENX Software Engineering 

- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License version 2 as
- * published by the Free Software Foundation.
  */
-
 #include 
 #include 
 #include 
diff --git a/drivers/staging/media/soc_camera/soc_camera.c 
b/drivers/staging/media/soc_camera/soc_camera.c
index 1ab86a7499b9..a6232dcd59bc 100644
--- a/drivers/staging/media/soc_camera/soc_camera.c
+++ b/drivers/staging/media/soc_camera/soc_camera.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0
 /*
  * camera image capture (abstract) bus driver
  *
@@ -10,12 +11,7 @@
  * SoCs. Later it should also be used for i.MX31 SoCs from Freescale.
  * It can handle multiple cameras and / or multiple buses, which can
  * be used, e.g., in stereo-vision applications.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License version 2 as
- * published by the Free Software Foundation.
  */
-
 #include 
 #include 
 #include 
diff --git a/drivers/staging/media/soc_camera/soc_mediabus.c 
b/drivers/staging/media/soc_camera/soc_mediabus.c
index be74008ec0ca..2aa646c89c1f 100644
--- a/drivers/staging/media/soc_camera/soc_mediabus.c
+++ b/drivers/staging/media/soc_camera/soc_mediabus.c
@@ -1,13 +1,9 @@
+// SPDX-License-Identifier: GPL-2.0
 /*
  * soc-camera media bus helper routines
  *
  * Copyright (C) 2009, Guennadi Liakhovetski 
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License version 2 as
- * published by the Free Software Foundation.
  */
-
 #include 
 #include 
 
diff --git a/drivers/staging/media/soc_camera/soc_mt9v022.c 
b/drivers/staging/media/soc_camera/soc_mt9v022.c
index 6d922b17ea94..e7e0d3d29499 100644
--- a/drivers/staging/media/soc_camera/soc_mt9v022.c
+++ b/drivers/staging/media/soc_camera/soc_mt9v022.c
@@ -1,13 +1,9 @@
+// SPDX-License-Identifier: GPL-2.0
 /*
  * Driver for MT9V022 CMOS Image Sensor from Micron
  *
  * Copyright (C) 2008, Guennadi Liakhovetski 
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License version 2 as
- * published by the Free Software Foundation.
  */
-
 #include 
 #include 
 #include 
diff --git a/drivers/staging/media/soc_camera/soc_ov5642.c 
b/drivers/staging/media/soc_camera/soc_ov5642.c
index 0931898c79dd..94696d7baf83 100644
--- a/drivers/staging/media/soc_camera/soc_ov5642.c
+++ b/drivers/staging/media/soc_camera/soc_ov5642.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0
 /*
  * Driver for OV5642 CMOS Image Sensor from Omnivision
  *
@@ -8,12 +9,7 @@
  *
  * Based on Omnivision OV7670 Camera Driver
  * Copyright (C) 2006-7 Jonathan Corbet 
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public Licen

[PATCH 01/16] staging: add missing SPDX lines to Kconfig files

[Greg Kroah-Hartman]

There are a few remaining drivers/staging/*/Kconfig files that do not
have SPDX identifiers in them.  Add the correct GPL-2.0 identifier to
them to make scanning tools happy.

Signed-off-by: Greg Kroah-Hartman 
---
 drivers/staging/Kconfig  | 1 +
 drivers/staging/android/Kconfig  | 1 +
 drivers/staging/android/ion/Kconfig  | 1 +
 drivers/staging/axis-fifo/Kconfig| 1 +
 drivers/staging/board/Kconfig| 1 +
 drivers/staging/clocking-wizard/Kconfig  | 1 +
 drivers/staging/comedi/Kconfig   | 1 +
 drivers/staging/emxx_udc/Kconfig | 1 +
 drivers/staging/fbtft/Kconfig| 1 +
 drivers/staging/fsl-dpaa2/Kconfig| 1 +
 drivers/staging/fwserial/Kconfig | 1 +
 drivers/staging/gasket/Kconfig   | 1 +
 drivers/staging/gdm724x/Kconfig  | 1 +
 drivers/staging/goldfish/Kconfig | 1 +
 drivers/staging/greybus/Kconfig  | 1 +
 drivers/staging/gs_fpgaboot/Kconfig  | 1 +
 drivers/staging/iio/Kconfig  | 1 +
 drivers/staging/iio/accel/Kconfig| 1 +
 drivers/staging/iio/adc/Kconfig  | 1 +
 drivers/staging/iio/addac/Kconfig| 1 +
 drivers/staging/iio/cdc/Kconfig  | 1 +
 drivers/staging/iio/frequency/Kconfig| 1 +
 drivers/staging/iio/impedance-analyzer/Kconfig   | 1 +
 drivers/staging/iio/meter/Kconfig| 1 +
 drivers/staging/iio/resolver/Kconfig | 1 +
 drivers/staging/ks7010/Kconfig   | 1 +
 drivers/staging/media/Kconfig| 1 +
 drivers/staging/media/bcm2048/Kconfig| 1 +
 drivers/staging/media/davinci_vpfe/Kconfig   | 1 +
 drivers/staging/media/imx/Kconfig| 1 +
 drivers/staging/media/ipu3/Kconfig   | 1 +
 drivers/staging/media/mt9t031/Kconfig| 1 +
 drivers/staging/media/rockchip/vpu/Kconfig   | 1 +
 drivers/staging/media/soc_camera/Kconfig | 1 +
 drivers/staging/media/sunxi/Kconfig  | 1 +
 drivers/staging/media/sunxi/cedrus/Kconfig   | 1 +
 drivers/staging/media/tegra-vde/Kconfig  | 1 +
 drivers/staging/media/zoran/Kconfig  | 1 +
 drivers/staging/most/Kconfig | 1 +
 drivers/staging/most/cdev/Kconfig| 1 +
 drivers/staging/most/dim2/Kconfig| 1 +
 drivers/staging/most/i2c/Kconfig | 1 +
 drivers/staging/most/net/Kconfig | 1 +
 drivers/staging/most/sound/Kconfig   | 1 +
 drivers/staging/most/usb/Kconfig | 1 +
 drivers/staging/most/video/Kconfig   | 1 +
 drivers/staging/mt7621-dma/Kconfig   | 1 +
 drivers/staging/mt7621-dts/Kconfig   | 1 +
 drivers/staging/mt7621-mmc/Kconfig   | 1 +
 drivers/staging/mt7621-pci-phy/Kconfig   | 1 +
 drivers/staging/mt7621-pci/Kconfig   | 1 +
 drivers/staging/mt7621-pinctrl/Kconfig   | 1 +
 drivers/staging/mt7621-spi/Kconfig   | 1 +
 drivers/staging/netlogic/Kconfig | 1 +
 drivers/staging/nvec/Kconfig | 1 +
 drivers/staging/octeon-usb/Kconfig   | 1 +
 drivers/staging/octeon/Kconfig   | 1 +
 drivers/staging/olpc_dcon/Kconfig| 1 +
 drivers/staging/pi433/Kconfig| 1 +
 drivers/staging/ralink-gdma/Kconfig  | 1 +
 drivers/staging/rtl8188eu/Kconfig| 1 +
 drivers/staging/rtl8192e/Kconfig | 1 +
 drivers/staging/rtl8192e/rtl8192e/Kconfig| 1 +
 drivers/staging/rtl8192u/Kconfig | 1 +
 drivers/staging/rtl8712/Kconfig  | 1 +
 drivers/staging/rtl8723bs/Kconfig| 1 +
 drivers/staging/rtlwifi/Kconfig  | 1 +
 drivers/staging/rts5208/Kconfig  | 1 +
 drivers/staging/sm750fb/Kconfig  | 1 +
 drivers/staging/speakup/Kconfig  | 1 +
 drivers/staging/unisys/Kconfig   | 1 +
 drivers/staging/unisys/visorhba/Kconfig  | 1 +
 drivers/staging/unisys/visorinput/Kconfig| 1 +
 drivers/staging/unisys/visornic/Kconfig  | 1 +
 drivers/staging/vboxvideo/Kconfig| 1 +
 drivers/staging/vc04_services/Kconfig| 1 +
 drivers/staging/vc04_services/bcm2835-audio/Kconfig  | 1 +
 drivers/staging/vc04_services/bcm2835-camera/Kconfig | 1 +
 drivers/staging/vme/devices/Kconfig  | 1 +
 drivers/staging/vt6655/Kconfig 

[PATCH 10/16] staging: ralink-gdma: add proper SPDX identifiers on ralink-gdma file

[Greg Kroah-Hartman]

The ralink-gdma.c driver did not have a SPDX identifier on it, so fix
that up.  At the same time, remove the "free form" text that specified
the license of the file, as that is impossible for any tool to properly
parse.

Cc: Lars-Peter Clausen 
Signed-off-by: Greg Kroah-Hartman 
---
 drivers/staging/ralink-gdma/ralink-gdma.c | 7 +--
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/staging/ralink-gdma/ralink-gdma.c 
b/drivers/staging/ralink-gdma/ralink-gdma.c
index b6d484532269..a032e5f966b3 100644
--- a/drivers/staging/ralink-gdma/ralink-gdma.c
+++ b/drivers/staging/ralink-gdma/ralink-gdma.c
@@ -1,12 +1,7 @@
+// SPDX-License-Identifier: GPL-2.0+
 /*
  *  Copyright (C) 2013, Lars-Peter Clausen 
  *  GDMA4740 DMAC support
- *
- *  This program is free software; you can redistribute it and/or modify it
- *  under  the terms of the GNU General Public License as published by 
the
- *  Free Software Foundation;  either version 2 of the License, or (at your
- *  option) any later version.
- *
  */
 
 #include 
-- 
2.21.0

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 04/16] staging: sm750fb: add proper SPDX identifier to driver

[Greg Kroah-Hartman]

By default all files without license information are under the default
license of the kernel, which is GPL version 2.  Because of this, add the
GPL-2.0 identifier to the sm750fb driver which did not have any license
identifiers in it at all.

Cc: Sudip Mukherjee 
Cc: Teddy Wang 
Signed-off-by: Greg Kroah-Hartman 
---
 drivers/staging/sm750fb/ddk750.h   | 1 +
 drivers/staging/sm750fb/ddk750_swi2c.c | 1 +
 drivers/staging/sm750fb/ddk750_swi2c.h | 1 +
 drivers/staging/sm750fb/sm750.c| 1 +
 4 files changed, 4 insertions(+)

diff --git a/drivers/staging/sm750fb/ddk750.h b/drivers/staging/sm750fb/ddk750.h
index 734010324a8f..482c1c6ba422 100644
--- a/drivers/staging/sm750fb/ddk750.h
+++ b/drivers/staging/sm750fb/ddk750.h
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Copyright (c) 2007 by Silicon Motion, Inc. (SMI)
  *
diff --git a/drivers/staging/sm750fb/ddk750_swi2c.c 
b/drivers/staging/sm750fb/ddk750_swi2c.c
index 19c5ffc72b16..5c0ac747ea2b 100644
--- a/drivers/staging/sm750fb/ddk750_swi2c.c
+++ b/drivers/staging/sm750fb/ddk750_swi2c.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0
 /*
  * Copyright (c) 2007 by Silicon Motion, Inc. (SMI)
  *
diff --git a/drivers/staging/sm750fb/ddk750_swi2c.h 
b/drivers/staging/sm750fb/ddk750_swi2c.h
index 3b8a96d6d25a..5868feea791b 100644
--- a/drivers/staging/sm750fb/ddk750_swi2c.h
+++ b/drivers/staging/sm750fb/ddk750_swi2c.h
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Copyright (c) 2007 by Silicon Motion, Inc. (SMI)
  *
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index e1a892e3b3ad..105089b97bf5 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0
 #include 
 #include 
 #include 
-- 
2.21.0

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 03/16] staging: m57621-mmc: delete driver from the tree.

[Greg Kroah-Hartman]

The license text in this driver is "interesting" and not really obvious
that it is supposed to be able to be distributed in the kernel source
tree.  Yes, the MODULE_LICENSE() text says GPL, so it's probably ok, but
to be safe, I am deleting this driver.  I will be glad to add it back if
the license is properly sorted out, but for now, this isn't worth the
potential risk, I should have never taken it in the first place.

Cc: Matthias Brugger 
Cc: NeilBrown 
Cc: George Hilliard 
Cc: "Christian Lütke-Stetzkamp" 
Cc: Nishad Kamdar 
Cc: Sergej Perschin 
Cc: John Crispin 
Signed-off-by: Greg Kroah-Hartman 
---
 drivers/staging/Kconfig|2 -
 drivers/staging/Makefile   |1 -
 drivers/staging/mt7621-mmc/Kconfig |9 -
 drivers/staging/mt7621-mmc/Makefile|   42 -
 drivers/staging/mt7621-mmc/TODO|8 -
 drivers/staging/mt7621-mmc/board.h |   63 -
 drivers/staging/mt7621-mmc/dbg.c   |  311 
 drivers/staging/mt7621-mmc/dbg.h   |  106 --
 drivers/staging/mt7621-mmc/mt6575_sd.h |  485 ---
 drivers/staging/mt7621-mmc/sd.c| 1859 
 10 files changed, 2886 deletions(-)
 delete mode 100644 drivers/staging/mt7621-mmc/Kconfig
 delete mode 100644 drivers/staging/mt7621-mmc/Makefile
 delete mode 100644 drivers/staging/mt7621-mmc/TODO
 delete mode 100644 drivers/staging/mt7621-mmc/board.h
 delete mode 100644 drivers/staging/mt7621-mmc/dbg.c
 delete mode 100644 drivers/staging/mt7621-mmc/dbg.h
 delete mode 100644 drivers/staging/mt7621-mmc/mt6575_sd.h
 delete mode 100644 drivers/staging/mt7621-mmc/sd.c

diff --git a/drivers/staging/Kconfig b/drivers/staging/Kconfig
index 37121f495cd7..6319369cca89 100644
--- a/drivers/staging/Kconfig
+++ b/drivers/staging/Kconfig
@@ -113,8 +113,6 @@ source "drivers/staging/mt7621-dma/Kconfig"
 
 source "drivers/staging/ralink-gdma/Kconfig"
 
-source "drivers/staging/mt7621-mmc/Kconfig"
-
 source "drivers/staging/mt7621-dts/Kconfig"
 
 source "drivers/staging/gasket/Kconfig"
diff --git a/drivers/staging/Makefile b/drivers/staging/Makefile
index d1b17ddcd354..763d18f56b10 100644
--- a/drivers/staging/Makefile
+++ b/drivers/staging/Makefile
@@ -46,7 +46,6 @@ obj-$(CONFIG_PINCTRL_RT2880)  += mt7621-pinctrl/
 obj-$(CONFIG_SPI_MT7621)   += mt7621-spi/
 obj-$(CONFIG_SOC_MT7621)   += mt7621-dma/
 obj-$(CONFIG_DMA_RALINK)   += ralink-gdma/
-obj-$(CONFIG_MTK_MMC)  += mt7621-mmc/
 obj-$(CONFIG_SOC_MT7621)   += mt7621-dts/
 obj-$(CONFIG_STAGING_GASKET_FRAMEWORK) += gasket/
 obj-$(CONFIG_XIL_AXIS_FIFO)+= axis-fifo/
diff --git a/drivers/staging/mt7621-mmc/Kconfig 
b/drivers/staging/mt7621-mmc/Kconfig
deleted file mode 100644
index 6ede50e9ddc0..
--- a/drivers/staging/mt7621-mmc/Kconfig
+++ /dev/null
@@ -1,9 +0,0 @@
-# SPDX-License-Identifier: GPL-2.0
-config MTK_MMC
-   tristate "MTK SD/MMC"
-   depends on RALINK && MMC
-
-config MTK_AEE_KDUMP
-   bool "MTK AEE KDUMP"
-   depends on MTK_MMC
-
diff --git a/drivers/staging/mt7621-mmc/Makefile 
b/drivers/staging/mt7621-mmc/Makefile
deleted file mode 100644
index caead0b54703..
--- a/drivers/staging/mt7621-mmc/Makefile
+++ /dev/null
@@ -1,42 +0,0 @@
-# Copyright Statement:
-#
-# This software/firmware and related documentation ("MediaTek Software") are
-# protected under relevant copyright laws. The information contained herein
-# is confidential and proprietary to MediaTek Inc. and/or its licensors.
-# Without the prior written permission of MediaTek inc. and/or its licensors,
-# any reproduction, modification, use or disclosure of MediaTek Software,
-# and information contained herein, in whole or in part, shall be strictly 
prohibited.
-#
-# MediaTek Inc. (C) 2010. All rights reserved.
-#
-# BY OPENING THIS FILE, RECEIVER HEREBY UNEQUIVOCALLY ACKNOWLEDGES AND AGREES
-# THAT THE SOFTWARE/FIRMWARE AND ITS DOCUMENTATIONS ("MEDIATEK SOFTWARE")
-# RECEIVED FROM MEDIATEK AND/OR ITS REPRESENTATIVES ARE PROVIDED TO RECEIVER ON
-# AN "AS-IS" BASIS ONLY. MEDIATEK EXPRESSLY DISCLAIMS ANY AND ALL WARRANTIES,
-# EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE IMPLIED WARRANTIES OF
-# MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE OR NONINFRINGEMENT.
-# NEITHER DOES MEDIATEK PROVIDE ANY WARRANTY WHATSOEVER WITH RESPECT TO THE
-# SOFTWARE OF ANY THIRD PARTY WHICH MAY BE USED BY, INCORPORATED IN, OR
-# SUPPLIED WITH THE MEDIATEK SOFTWARE, AND RECEIVER AGREES TO LOOK ONLY TO SUCH
-# THIRD PARTY FOR ANY WARRANTY CLAIM RELATING THERETO. RECEIVER EXPRESSLY 
ACKNOWLEDGES
-# THAT IT IS RECEIVER'S SOLE RESPONSIBILITY TO OBTAIN FROM ANY THIRD PARTY ALL 
PROPER LICENSES
-# CONTAINED IN MEDIATEK SOFTWARE. MEDIATEK SHALL ALSO NOT BE RESPONSIBLE FOR 
ANY MEDIATEK
-# SOFTWARE RELEASES MADE TO RECEIVER'S SPECIFICATION OR TO CONFORM TO A 
PARTICULAR
-# STANDARD OR OPEN FORUM. RECEIVER'S SOLE AND EXCLUSIVE REMEDY AND MEDIATEK'S 
ENTIRE AND
-# CUMULATIVE LIABILITY WITH RESPECT TO THE MEDIATEK SOFTWARE RELEASED 
HEREUN

[PATCH 12/16] staging: rtl8192e: delete license file.

[Greg Kroah-Hartman]

There is no need for yet-another-copy of the gpl to be in the kernel
source tree, especially for just a single driver.  This got added as
part of the import of the driver from when it was a stand-along chunk of
code.

Signed-off-by: Greg Kroah-Hartman 
---
 drivers/staging/rtl8192e/license | 339 ---
 1 file changed, 339 deletions(-)
 delete mode 100644 drivers/staging/rtl8192e/license

diff --git a/drivers/staging/rtl8192e/license b/drivers/staging/rtl8192e/license
deleted file mode 100644
index 4bea9fa60daa..
--- a/drivers/staging/rtl8192e/license
+++ /dev/null
@@ -1,339 +0,0 @@
-
-"This software program is licensed subject to the GNU General Public License
-(GPL). Version 2, June 1991, available at
-http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 16/16] staging: media: tegra-vde: add proper SPDX identifiers on file that did not have it.

[Greg Kroah-Hartman]

There was a single file for the tegra-vde driver that did not have SPDX
identifiers on it, so fix that up.  At the same time, remove the "free
form" text that specified the license of the file, as that is impossible
for any tool to properly parse.

Cc: Dmitry Osipenko 
Cc: Mauro Carvalho Chehab 
Cc: Thierry Reding 
Cc: Jonathan Hunter 
Cc: linux-me...@vger.kernel.org
Cc: linux-te...@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman 
---
 drivers/staging/media/tegra-vde/uapi.h | 11 ++-
 1 file changed, 2 insertions(+), 9 deletions(-)

diff --git a/drivers/staging/media/tegra-vde/uapi.h 
b/drivers/staging/media/tegra-vde/uapi.h
index 4bce08a7a54c..a0dad1ed94ef 100644
--- a/drivers/staging/media/tegra-vde/uapi.h
+++ b/drivers/staging/media/tegra-vde/uapi.h
@@ -1,12 +1,5 @@
-/*
- * Copyright (C) 2016-2017 Dmitry Osipenko 
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License
- * as published by the Free Software Foundation; either version
- * 2 of the License, or (at your option) any later version.
- */
-
+/* SPDX-License-Identifier: GPL-2.0+ */
+/* Copyright (C) 2016-2017 Dmitry Osipenko  */
 #ifndef _UAPI_TEGRA_VDE_H_
 #define _UAPI_TEGRA_VDE_H_
 
-- 
2.21.0

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 15/16] staging: media: imx: add proper SPDX identifiers on files that did not have them.

[Greg Kroah-Hartman]

There were a few files for the imx media drivers that did not have SPDX
identifiers on them, so fix that up.  At the same time, remove the "free
form" text that specified the license of the file, as that is impossible
for any tool to properly parse.

Cc: Steve Longerbeam 
Cc: Philipp Zabel 
Cc: Mauro Carvalho Chehab 
Cc: Shawn Guo 
Cc: Sascha Hauer 
Cc: Fabio Estevam 
Cc: NXP Linux Team 
Cc: linux-me...@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman 
---
 drivers/staging/media/imx/imx-ic-common.c | 6 +-
 drivers/staging/media/imx/imx-ic-prp.c| 6 +-
 drivers/staging/media/imx/imx-ic-prpencvf.c   | 6 +-
 drivers/staging/media/imx/imx-ic.h| 6 +-
 drivers/staging/media/imx/imx-media-capture.c | 6 +-
 drivers/staging/media/imx/imx-media-csi.c | 6 +-
 drivers/staging/media/imx/imx-media-dev.c | 6 +-
 drivers/staging/media/imx/imx-media-fim.c | 6 +-
 drivers/staging/media/imx/imx-media-internal-sd.c | 6 +-
 drivers/staging/media/imx/imx-media-of.c  | 6 +-
 drivers/staging/media/imx/imx-media-utils.c   | 6 +-
 drivers/staging/media/imx/imx-media-vdic.c| 6 +-
 drivers/staging/media/imx/imx-media.h | 6 +-
 drivers/staging/media/imx/imx6-mipi-csi2.c| 6 +-
 14 files changed, 14 insertions(+), 70 deletions(-)

diff --git a/drivers/staging/media/imx/imx-ic-common.c 
b/drivers/staging/media/imx/imx-ic-common.c
index 765919487a73..7e2455097315 100644
--- a/drivers/staging/media/imx/imx-ic-common.c
+++ b/drivers/staging/media/imx/imx-ic-common.c
@@ -1,12 +1,8 @@
+// SPDX-License-Identifier: GPL-2.0+
 /*
  * V4L2 Image Converter Subdev for Freescale i.MX5/6 SOC
  *
  * Copyright (c) 2014-2016 Mentor Graphics Inc.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
  */
 #include 
 #include 
diff --git a/drivers/staging/media/imx/imx-ic-prp.c 
b/drivers/staging/media/imx/imx-ic-prp.c
index 3d43cdcb4bb9..10ffe00f1a54 100644
--- a/drivers/staging/media/imx/imx-ic-prp.c
+++ b/drivers/staging/media/imx/imx-ic-prp.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0+
 /*
  * V4L2 Capture IC Preprocess Subdev for Freescale i.MX5/6 SOC
  *
@@ -6,11 +7,6 @@
  * for resizing, colorspace conversion, and rotation.
  *
  * Copyright (c) 2012-2017 Mentor Graphics Inc.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
  */
 #include 
 #include 
diff --git a/drivers/staging/media/imx/imx-ic-prpencvf.c 
b/drivers/staging/media/imx/imx-ic-prpencvf.c
index 5c8e6ad8c025..1ba4a5154fb5 100644
--- a/drivers/staging/media/imx/imx-ic-prpencvf.c
+++ b/drivers/staging/media/imx/imx-ic-prpencvf.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0+
 /*
  * V4L2 Capture IC Preprocess Subdev for Freescale i.MX5/6 SOC
  *
@@ -6,11 +7,6 @@
  * for resizing, colorspace conversion, and rotation.
  *
  * Copyright (c) 2012-2017 Mentor Graphics Inc.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
  */
 #include 
 #include 
diff --git a/drivers/staging/media/imx/imx-ic.h 
b/drivers/staging/media/imx/imx-ic.h
index 6b2267bda8ab..0dbcf2a7ab5f 100644
--- a/drivers/staging/media/imx/imx-ic.h
+++ b/drivers/staging/media/imx/imx-ic.h
@@ -1,12 +1,8 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
 /*
  * V4L2 Image Converter Subdev for Freescale i.MX5/6 SOC
  *
  * Copyright (c) 2016 Mentor Graphics Inc.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
  */
 #ifndef _IMX_IC_H
 #define _IMX_IC_H
diff --git a/drivers/staging/media/imx/imx-media-capture.c 
b/drivers/staging/media/imx/imx-media-capture.c
index facce18975d8..b7ce9d439279 100644
--- a/drivers/staging/media/imx/imx-media-capture.c
+++ b/drivers/staging/media/imx/imx-media-capture.c
@@ -1,12 +1,8 @@
+// SPDX-License-Identifier: GPL-2.0+
 /*
  * Video Capture Subdev for Freescale i.MX5/6 SOC
  *
  * Copyright (c) 2012-2016 Mentor Graphics Inc.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
  */
 #include 
 #includ

[PATCH 02/16] staging: add missing SPDX lines to Makefile files

[Greg Kroah-Hartman]

There are a few remaining drivers/staging/*/Makefile files that do not
have SPDX identifiers in them.  Add the correct GPL-2.0 identifier to
them to make scanning tools happy.

Signed-off-by: Greg Kroah-Hartman 
---
 drivers/staging/android/Makefile | 1 +
 drivers/staging/axis-fifo/Makefile   | 1 +
 drivers/staging/board/Makefile   | 1 +
 drivers/staging/clocking-wizard/Makefile | 1 +
 drivers/staging/comedi/drivers/ni_routing/tools/Makefile | 1 +
 drivers/staging/comedi/kcomedilib/Makefile   | 1 +
 drivers/staging/emxx_udc/Makefile| 1 +
 drivers/staging/fsl-dpaa2/Makefile   | 1 +
 drivers/staging/fwserial/Makefile| 1 +
 drivers/staging/gasket/Makefile  | 1 +
 drivers/staging/goldfish/Makefile| 1 +
 drivers/staging/gs_fpgaboot/Makefile | 1 +
 drivers/staging/iio/accel/Makefile   | 1 +
 drivers/staging/iio/addac/Makefile   | 1 +
 drivers/staging/iio/cdc/Makefile | 1 +
 drivers/staging/iio/frequency/Makefile   | 1 +
 drivers/staging/iio/impedance-analyzer/Makefile  | 1 +
 drivers/staging/iio/resolver/Makefile| 1 +
 drivers/staging/ks7010/Makefile  | 1 +
 drivers/staging/media/bcm2048/Makefile   | 1 +
 drivers/staging/media/davinci_vpfe/Makefile  | 1 +
 drivers/staging/media/ipu3/Makefile  | 1 +
 drivers/staging/media/mt9t031/Makefile   | 1 +
 drivers/staging/media/rockchip/vpu/Makefile  | 1 +
 drivers/staging/media/sunxi/Makefile | 1 +
 drivers/staging/media/sunxi/cedrus/Makefile  | 1 +
 drivers/staging/media/tegra-vde/Makefile | 1 +
 drivers/staging/most/cdev/Makefile   | 1 +
 drivers/staging/most/dim2/Makefile   | 1 +
 drivers/staging/most/i2c/Makefile| 1 +
 drivers/staging/most/net/Makefile| 1 +
 drivers/staging/most/sound/Makefile  | 1 +
 drivers/staging/most/usb/Makefile| 1 +
 drivers/staging/most/video/Makefile  | 1 +
 drivers/staging/mt7621-dma/Makefile  | 1 +
 drivers/staging/mt7621-dts/Makefile  | 1 +
 drivers/staging/mt7621-pci-phy/Makefile  | 1 +
 drivers/staging/mt7621-pci/Makefile  | 1 +
 drivers/staging/mt7621-pinctrl/Makefile  | 1 +
 drivers/staging/mt7621-spi/Makefile  | 1 +
 drivers/staging/netlogic/Makefile| 1 +
 drivers/staging/olpc_dcon/Makefile   | 1 +
 drivers/staging/pi433/Makefile   | 1 +
 drivers/staging/ralink-gdma/Makefile | 1 +
 drivers/staging/rtlwifi/Makefile | 1 +
 drivers/staging/rtlwifi/btcoexist/Makefile   | 1 +
 drivers/staging/rtlwifi/rtl8822be/Makefile   | 1 +
 drivers/staging/rts5208/Makefile | 1 +
 drivers/staging/sm750fb/Makefile | 1 +
 drivers/staging/unisys/Makefile  | 1 +
 drivers/staging/unisys/visorhba/Makefile | 1 +
 drivers/staging/unisys/visorinput/Makefile   | 1 +
 drivers/staging/unisys/visornic/Makefile | 1 +
 drivers/staging/vc04_services/bcm2835-audio/Makefile | 1 +
 drivers/staging/vme/Makefile | 1 +
 drivers/staging/vme/devices/Makefile | 1 +
 56 files changed, 56 insertions(+)

diff --git a/drivers/staging/android/Makefile b/drivers/staging/android/Makefile
index 90e6154f11a4..14bd9c6ce10d 100644
--- a/drivers/staging/android/Makefile
+++ b/drivers/staging/android/Makefile
@@ -1,3 +1,4 @@
+# SPDX-License-Identifier: GPL-2.0
 ccflags-y += -I$(src)  # needed for trace events
 
 obj-y  += ion/
diff --git a/drivers/staging/axis-fifo/Makefile 
b/drivers/staging/axis-fifo/Makefile
index fe62cd1ac5de..c626005c99db 100644
--- a/drivers/staging/axis-fifo/Makefile
+++ b/drivers/staging/axis-fifo/Makefile
@@ -1 +1,2 @@
+# SPDX-License-Identifier: GPL-2.0
 obj-$(CONFIG_XIL_AXIS_FIFO) += axis-fifo.o
diff --git a/drivers/staging/board/Makefile b/drivers/staging/board/Makefile
index 6842745feb94..ed7839752e12 100644
--- a/drivers/staging/board/Makefile
+++ b/drivers/staging/board/Makefile
@@ -1,3 +1,4 @@
+# SPDX-License-Identifier: GPL-2.0
 obj-y  := board.o
 obj-$(CONFIG_ARCH_EMEV2)   += kzm9d.o
 obj-$(CONFIG_ARCH_R8A7740) += armadillo800eva.o
diff --git a/drivers/staging/clocking-wizard/Makefile 
b/drivers/staging/clocking-wizard/Makefile
index 5ad352f521fe..b1f915224d96 1006

[PATCH 13/16] staging: media: zoran: add proper SPDX identifiers on files that did not have them.

[Greg Kroah-Hartman]

There were a few files for the zoran driver that did not have SPDX
identifiers on them, so fix that up.  At the same time, remove the "free
form" text that specified the license of the file, as that is impossible
for any tool to properly parse.

Cc: Mauro Carvalho Chehab 
Cc: Hans Verkuil 
Cc: linux-me...@vger.kernel.org
Cc: mjpeg-us...@lists.sourceforge.net
Signed-off-by: Greg Kroah-Hartman 
---
 drivers/staging/media/zoran/videocodec.h   | 17 +
 drivers/staging/media/zoran/zoran.h| 12 +---
 drivers/staging/media/zoran/zoran_card.c   | 12 +---
 drivers/staging/media/zoran/zoran_card.h   | 12 +---
 drivers/staging/media/zoran/zoran_device.c | 12 +---
 drivers/staging/media/zoran/zoran_device.h | 12 +---
 drivers/staging/media/zoran/zoran_driver.c | 13 +
 drivers/staging/media/zoran/zoran_procfs.c | 12 +---
 drivers/staging/media/zoran/zoran_procfs.h | 12 +---
 drivers/staging/media/zoran/zr36016.c  | 18 +-
 drivers/staging/media/zoran/zr36016.h  | 18 +-
 drivers/staging/media/zoran/zr36050.c  | 18 +-
 drivers/staging/media/zoran/zr36050.h  | 18 +-
 drivers/staging/media/zoran/zr36057.h  | 12 +---
 drivers/staging/media/zoran/zr36060.c  | 18 +-
 drivers/staging/media/zoran/zr36060.h  | 18 +-
 16 files changed, 16 insertions(+), 218 deletions(-)

diff --git a/drivers/staging/media/zoran/videocodec.h 
b/drivers/staging/media/zoran/videocodec.h
index 8ed5a0f7ac01..4946791fce0d 100644
--- a/drivers/staging/media/zoran/videocodec.h
+++ b/drivers/staging/media/zoran/videocodec.h
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
 /*
  * VIDEO MOTION CODECs internal API for video devices
  *
@@ -5,22 +6,6 @@
  * bound to a master device.
  *
  * (c) 2002 Wolfgang Scherr 
- *
- * $Id: videocodec.h,v 1.1.2.4 2003/01/14 21:15:03 rbultje Exp $
- *
- * 
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * 
  */
 
 /* === */
diff --git a/drivers/staging/media/zoran/zoran.h 
b/drivers/staging/media/zoran/zoran.h
index e84fb604a689..1b2e1fb3555f 100644
--- a/drivers/staging/media/zoran/zoran.h
+++ b/drivers/staging/media/zoran/zoran.h
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
 /*
  * zoran - Iomega Buz driver
  *
@@ -12,18 +13,7 @@
  * bttv - Bt848 frame grabber driver
  * Copyright (C) 1996,97,98 Ralph  Metzler (r...@thp.uni-koeln.de)
  *& Marcus Metzler (m...@thp.uni-koeln.de)
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
  */
-
 #ifndef _BUZ_H_
 #define _BUZ_H_
 
diff --git a/drivers/staging/media/zoran/zoran_card.c 
b/drivers/staging/media/zoran/zoran_card.c
index ea10523194e8..dad5d1412033 100644
--- a/drivers/staging/media/zoran/zoran_card.c
+++ b/drivers/staging/media/zoran/zoran_card.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0+
 /*
  * Zoran zr36057/zr36067 PCI controller driver, for the
  * Pinnacle/Miro DC10/DC10+/DC30/DC30+, Iomega Buz, Linux
@@ -11,18 +12,7 @@
  *   Ronald Bultje
  *   Laurent Pinchart 
  *   Mailinglist  
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
  */
-
 #include 
 
 #include 
diff --git a/drivers/staging/media/zoran/zoran_card.h 
b/drivers/staging/media/zoran/zoran_card.h
index 0cdb7d34926d..600b9a3f320c 100644
--- a/drivers/staging/media/zoran/zoran_card.h
+++ b/drivers

[PATCH 09/16] staging: rtl8192u: add proper SPDX identifiers on files that did not have them.

[Greg Kroah-Hartman]

There were a few files for the rtl8192u driver that did not have SPDX
identifiers on them, so fix that up.  At the same time, remove the "free
form" text that specified the license of the file, as that is impossible
for any tool to properly parse.

Cc: John Whitmore 
Cc: Bhanusree Pola 
Cc: Sanjana Sanikommu 
Cc: Jia-Ju Bai 
Signed-off-by: Greg Kroah-Hartman 
---
 drivers/staging/rtl8192u/ieee80211/ieee80211.h  |  6 +-
 .../rtl8192u/ieee80211/ieee80211_crypt.c|  7 +--
 .../rtl8192u/ieee80211/ieee80211_crypt.h|  6 +-
 .../rtl8192u/ieee80211/ieee80211_crypt_ccmp.c   |  6 +-
 .../rtl8192u/ieee80211/ieee80211_crypt_tkip.c   |  6 +-
 .../rtl8192u/ieee80211/ieee80211_crypt_wep.c|  6 +-
 .../staging/rtl8192u/ieee80211/ieee80211_rx.c   |  6 +-
 .../rtl8192u/ieee80211/ieee80211_softmac.c  |  3 +--
 .../rtl8192u/ieee80211/ieee80211_softmac_wx.c   |  3 +--
 .../staging/rtl8192u/ieee80211/ieee80211_tx.c   | 17 +
 .../staging/rtl8192u/ieee80211/ieee80211_wx.c   | 17 +
 drivers/staging/rtl8192u/r8180_93cx6.c  |  2 +-
 drivers/staging/rtl8192u/r8190_rtl8256.c|  2 +-
 drivers/staging/rtl8192u/r8192U_core.c  | 16 +---
 drivers/staging/rtl8192u/r8192U_hw.h|  2 +-
 drivers/staging/rtl8192u/r8192U_wx.c|  2 +-
 drivers/staging/rtl8192u/r8192U_wx.h|  2 +-
 17 files changed, 17 insertions(+), 92 deletions(-)

diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211.h 
b/drivers/staging/rtl8192u/ieee80211/ieee80211.h
index 638cad6df1c4..d36963469015 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211.h
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211.h
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Merged with mainline ieee80211.h in Aug 2004.  Original ieee802_11
  * remains copyright by the original authors
@@ -15,11 +16,6 @@
  *
  * Modified for Realtek's wi-fi cards by Andrea Merello
  * 
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License version 2 as
- * published by the Free Software Foundation. See README and COPYING for
- * more details.
  */
 #ifndef IEEE80211_H
 #define IEEE80211_H
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c 
b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
index 6f457812e5a3..36987fccac5d 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
@@ -1,14 +1,9 @@
+// SPDX-License-Identifier: GPL-2.0
 /*
  * Host AP crypto routines
  *
  * Copyright (c) 2002-2003, Jouni Malinen 
  * Portions Copyright (C) 2004, Intel Corporation 
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License version 2 as
- * published by the Free Software Foundation. See README and COPYING for
- * more details.
- *
  */
 
 #include 
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.h 
b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.h
index 1f2aea7e0e55..d3bd5598b25b 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.h
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.h
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Original code based on Host AP (software wireless LAN access point) driver
  * for Intersil Prism2/2.5/3.
@@ -10,11 +11,6 @@
  * 
  *
  * Copyright (c) 2004, Intel Corporation
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License version 2 as
- * published by the Free Software Foundation. See README and COPYING for
- * more details.
  */
 
 /*
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c 
b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c
index 3534ddb900d1..f2d64ab563c3 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c
@@ -1,12 +1,8 @@
+// SPDX-License-Identifier: GPL-2.0
 /*
  * Host AP crypt: host-based CCMP encryption implementation for Host AP driver
  *
  * Copyright (c) 2003-2004, Jouni Malinen 
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License version 2 as
- * published by the Free Software Foundation. See README and COPYING for
- * more details.
  */
 
 #include 
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c 
b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c
index 829fa4bd253c..d260b47d9f04 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c
@@ -1,12 +1,8 @@
+// SPDX-License-Identifier: GPL-2.0
 /*
  * Host AP crypt: host-based TKIP encryption implementation for Host AP driver
  *
  * Copyright (c) 2003-2004, Jouni Malinen 
- *
-

[PATCH 07/16] staging: comedi: quatec_daqp_cs: add proper SPDX identifier to driver

[Greg Kroah-Hartman]

By default all files without license information are under the default
license of the kernel, which is GPL version 2.  Because of this, add the
GPL-2.0 identifier to the quatec_daqp_cs driver which did not have any license
identifiers in it at all.

Cc: Ian Abbott 
Cc: H Hartley Sweeten 
Cc: Brent Baccala 
Cc: David A. Schleef 
Signed-off-by: Greg Kroah-Hartman 
---
 drivers/staging/comedi/drivers/quatech_daqp_cs.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/comedi/drivers/quatech_daqp_cs.c 
b/drivers/staging/comedi/drivers/quatech_daqp_cs.c
index 257b0daff01f..6daaacf7a26a 100644
--- a/drivers/staging/comedi/drivers/quatech_daqp_cs.c
+++ b/drivers/staging/comedi/drivers/quatech_daqp_cs.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0
 /*
  * quatech_daqp_cs.c
  * Quatech DAQP PCMCIA data capture cards COMEDI client driver
-- 
2.21.0

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 06/16] staging: vc04_services: remove remaining redundant license text

[Greg Kroah-Hartman]

Now that the SPDX tag is in all vc04_services files, that identifies the
license in a specific and legally-defined manner.  So the extra GPL and
BSD text wording can be removed as it is no longer needed at all.

This is done on a quest to remove the 700+ different ways that files in
the kernel describe the license text.

No copyright headers or other non-license-description text was removed.

Cc: Eric Anholt 
Cc: Stefan Wahren 
Cc: Tuomas Tynkkynen 
Cc: Aymen Qader 
Cc: "Tobias Büttner" 
Cc: Dominic Braun 
Cc: Nicolas Saenz Julienne 
Cc: Alejandro Ismael Silva 
Cc: Phil Elwell 
Cc: Luis Chamberlain 
Cc: Arnd Bergmann 
Signed-off-by: Greg Kroah-Hartman 
---
 .../vc04_services/interface/vchi/vchi.h   | 33 +--
 .../vc04_services/interface/vchi/vchi_cfg.h   | 33 +--
 .../interface/vchi/vchi_common.h  | 33 +--
 .../vc04_services/interface/vchiq_arm/vchiq.h | 33 +--
 .../interface/vchiq_arm/vchiq_2835_arm.c  | 33 +--
 .../interface/vchiq_arm/vchiq_arm.c   | 31 +
 .../interface/vchiq_arm/vchiq_arm.h   | 31 +
 .../interface/vchiq_arm/vchiq_cfg.h   | 33 +--
 .../interface/vchiq_arm/vchiq_connected.c | 33 +--
 .../interface/vchiq_arm/vchiq_connected.h | 33 +--
 .../interface/vchiq_arm/vchiq_core.c  | 33 +--
 .../interface/vchiq_arm/vchiq_core.h  | 33 +--
 .../interface/vchiq_arm/vchiq_debugfs.c   | 31 +
 .../interface/vchiq_arm/vchiq_debugfs.h   | 33 +--
 .../interface/vchiq_arm/vchiq_if.h| 33 +--
 .../interface/vchiq_arm/vchiq_ioctl.h | 33 +--
 .../interface/vchiq_arm/vchiq_pagelist.h  | 33 +--
 .../interface/vchiq_arm/vchiq_shim.c  | 33 +--
 .../interface/vchiq_arm/vchiq_util.c  | 33 +--
 .../interface/vchiq_arm/vchiq_util.h  | 33 +--
 20 files changed, 20 insertions(+), 634 deletions(-)

diff --git a/drivers/staging/vc04_services/interface/vchi/vchi.h 
b/drivers/staging/vc04_services/interface/vchi/vchi.h
index a662e1bf7341..f85562b9ba9e 100644
--- a/drivers/staging/vc04_services/interface/vchi/vchi.h
+++ b/drivers/staging/vc04_services/interface/vchi/vchi.h
@@ -1,36 +1,5 @@
 /* SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause */
-/**
- * Copyright (c) 2010-2012 Broadcom. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- *notice, this list of conditions, and the following disclaimer,
- *without modification.
- * 2. Redistributions in binary form must reproduce the above copyright
- *notice, this list of conditions and the following disclaimer in the
- *documentation and/or other materials provided with the distribution.
- * 3. The names of the above-listed copyright holders may not be used
- *to endorse or promote products derived from this software without
- *specific prior written permission.
- *
- * ALTERNATIVELY, this software may be distributed under the terms of the
- * GNU General Public License ("GPL") version 2, as published by the Free
- * Software Foundation.
- *
- * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS
- * IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
- * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
- * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR
- * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
- * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
- * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
- * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF
- * LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
- * NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
- * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- */
+/* Copyright (c) 2010-2012 Broadcom. All rights reserved. */
 
 #ifndef VCHI_H_
 #define VCHI_H_
diff --git a/drivers/staging/vc04_services/interface/vchi/vchi_cfg.h 
b/drivers/staging/vc04_services/interface/vchi/vchi_cfg.h
index d9f16a544412..89aa4e6122cd 100644
--- a/drivers/staging/vc04_services/interface/vchi/vchi_cfg.h
+++ b/drivers/staging/vc04_services/interface/vchi/vchi_cfg.h
@@ -1,36 +1,5 @@
 /* SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause */
-/**
- * Copyright (c) 2010-2012 Broadcom. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistribution

Re: [PATCH v3 13/14] staging: most: configfs: rename config attributes

[Greg KH]

On Tue, Apr 02, 2019 at 09:45:35AM +, christian.gr...@microchip.com wrote:
> On Di, 2019-04-02 at 11:01 +0200, Greg KH wrote:
> > External E-Mail
> > 
> > 
> > On Tue, Apr 02, 2019 at 08:17:02AM +, Christian.Gromm@microchip.c
> > om wrote:
> > > 
> > > On Di, 2019-04-02 at 09:25 +0200, Greg KH wrote:
> > > > 
> > > > External E-Mail
> > > > 
> > > > 
> > > > On Mon, Apr 01, 2019 at 02:05:38PM +0200, Christian Gromm wrote:
> > > > > 
> > > > > 
> > > > > This patch introduces attribute names that are more self
> > > > > explaining.
> > > > > 
> > > > > Signed-off-by: Christian Gromm 
> > > > > ---
> > > > > v2:
> > > > >   - follow-up adaptions due to changes introduced w/
> > > > > [PATCH v2
> > > > > 01/14]
> > > > > v3:
> > > > > 
> > > > >  drivers/staging/most/configfs.c | 97 +--
> > > > > 
> > > > > --
> > > > >  1 file changed, 49 insertions(+), 48 deletions(-)
> > > > Why isn't this just part of patch 1/14 here?  No need to create a
> > > > problem and then have to fix it up later in the same series :)
> > > > 
> > > This is not part of patch 1/14, because it does a different thing.
> > > I just wanted to point out that this patch has small changes when
> > > "diffed" against v1. These changes have been introduced when I
> > > rebased the patch set with the changes in 1/14 recommended by Dan
> > > Carpenter. In principle, it does the very same as before. Nothing
> > > has been added.
> > My point is, why not add the "more self explaining" attribute names
> > the
> > first time around when you add the configfs.c file?  Why add it and
> > then
> > later on change it?  What did that benifit anyone?
> > 
> 
> Got your point. I'll fix it up. But then the patch series would be
> shorter as this patch is going to be merged with the first one.

That's fine.

> What does this mean to the reroll count? Can I do a v4 that has less
> patches than its predecessor?

Yes you can :)

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 11/16] staging: rtl8192e: add proper SPDX identifiers on files that did not have them.

[Greg Kroah-Hartman]

There were a few files for the rtl8192e driver that did not have SPDX
identifiers on them, so fix that up.  At the same time, remove the "free
form" text that specified the license of the file, as that is impossible
for any tool to properly parse.

Signed-off-by: Greg Kroah-Hartman 
---
 .../staging/rtl8192e/rtl8192e/r8190P_def.h| 18 ---
 .../rtl8192e/rtl8192e/r8190P_rtl8256.c| 17 --
 .../rtl8192e/rtl8192e/r8190P_rtl8256.h| 17 --
 .../staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c | 17 --
 .../staging/rtl8192e/rtl8192e/r8192E_cmdpkt.h | 16 --
 .../staging/rtl8192e/rtl8192e/r8192E_dev.c| 19 
 .../staging/rtl8192e/rtl8192e/r8192E_dev.h| 22 ---
 .../rtl8192e/rtl8192e/r8192E_firmware.c   | 17 --
 .../rtl8192e/rtl8192e/r8192E_firmware.h   | 16 --
 drivers/staging/rtl8192e/rtl8192e/r8192E_hw.h | 18 ---
 .../staging/rtl8192e/rtl8192e/r8192E_hwimg.c  | 18 ---
 .../staging/rtl8192e/rtl8192e/r8192E_hwimg.h  | 16 --
 .../staging/rtl8192e/rtl8192e/r8192E_phy.c| 17 --
 .../staging/rtl8192e/rtl8192e/r8192E_phy.h| 16 --
 .../staging/rtl8192e/rtl8192e/r8192E_phyreg.h | 16 --
 drivers/staging/rtl8192e/rtl8192e/rtl_cam.c   | 19 
 drivers/staging/rtl8192e/rtl8192e/rtl_cam.h   | 19 
 drivers/staging/rtl8192e/rtl8192e/rtl_core.c  | 19 
 drivers/staging/rtl8192e/rtl8192e/rtl_core.h  | 20 -
 drivers/staging/rtl8192e/rtl8192e/rtl_dm.c| 16 --
 drivers/staging/rtl8192e/rtl8192e/rtl_dm.h| 16 --
 .../staging/rtl8192e/rtl8192e/rtl_eeprom.c| 19 
 .../staging/rtl8192e/rtl8192e/rtl_eeprom.h| 21 --
 .../staging/rtl8192e/rtl8192e/rtl_ethtool.c   | 18 +++
 drivers/staging/rtl8192e/rtl8192e/rtl_pci.c   | 19 
 drivers/staging/rtl8192e/rtl8192e/rtl_pci.h   | 19 
 drivers/staging/rtl8192e/rtl8192e/rtl_pm.c| 17 --
 drivers/staging/rtl8192e/rtl8192e/rtl_pm.h| 17 --
 drivers/staging/rtl8192e/rtl8192e/rtl_ps.c| 19 
 drivers/staging/rtl8192e/rtl8192e/rtl_ps.h| 19 
 drivers/staging/rtl8192e/rtl8192e/rtl_wx.c| 17 --
 drivers/staging/rtl8192e/rtl8192e/rtl_wx.h| 17 --
 drivers/staging/rtl8192e/rtl819x_BA.h | 16 --
 drivers/staging/rtl8192e/rtl819x_BAProc.c | 16 --
 drivers/staging/rtl8192e/rtl819x_HT.h | 16 --
 drivers/staging/rtl8192e/rtl819x_HTProc.c | 16 --
 drivers/staging/rtl8192e/rtl819x_Qos.h| 16 --
 drivers/staging/rtl8192e/rtl819x_TS.h | 16 --
 drivers/staging/rtl8192e/rtl819x_TSProc.c | 16 --
 drivers/staging/rtl8192e/rtllib.h |  6 +
 drivers/staging/rtl8192e/rtllib_crypt_tkip.c  |  6 +
 drivers/staging/rtl8192e/rtllib_crypt_wep.c   |  6 +
 drivers/staging/rtl8192e/rtllib_debug.h   | 22 ---
 drivers/staging/rtl8192e/rtllib_module.c  | 19 +++-
 drivers/staging/rtl8192e/rtllib_rx.c  | 20 +
 drivers/staging/rtl8192e/rtllib_softmac.c |  5 +
 drivers/staging/rtl8192e/rtllib_softmac_wx.c  |  5 +
 drivers/staging/rtl8192e/rtllib_tx.c  | 22 +++
 drivers/staging/rtl8192e/rtllib_wx.c  | 19 +++-
 49 files changed, 179 insertions(+), 634 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl8192e/r8190P_def.h 
b/drivers/staging/rtl8192e/rtl8192e/r8190P_def.h
index 03421033d14a..53fd79a28189 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8190P_def.h
+++ b/drivers/staging/rtl8192e/rtl8192e/r8190P_def.h
@@ -1,19 +1,9 @@
-/**
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
  * Copyright(c) 2008 - 2010 Realtek Corporation. All rights reserved.
  *
- * This program is distributed in the hope that it will be useful, but WITHOUT
- * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
- * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
- * more details.
- *
- * The full GNU General Public License is included in this distribution in the
- * file called LICENSE.
- *
- * Contact Information:
- * wlanfae 
- */
-
-
+ * Contact Information: wlanfae 
+ */
 #ifndef R8190P_DEF_H
 #define R8190P_DEF_H
 
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c 
b/drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c
index 85f93056d28b..7876b389913a 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c
@@ -1,18 +1,9 @@
-/***

Re: [PATCH v3 07/14] staging: most: core: use device description as name

[Greg KH]

On Tue, Apr 02, 2019 at 09:21:09AM +, christian.gr...@microchip.com wrote:
> On Di, 2019-04-02 at 11:00 +0200, Greg KH wrote:
> > External E-Mail
> > 
> > 
> > On Tue, Apr 02, 2019 at 08:10:25AM +, Christian.Gromm@microchip.c
> > om wrote:
> > > 
> > > On Di, 2019-04-02 at 09:24 +0200, Greg KH wrote:
> > > > 
> > > > External E-Mail
> > > > 
> > > > 
> > > > On Mon, Apr 01, 2019 at 02:05:32PM +0200, Christian Gromm wrote:
> > > > > 
> > > > > 
> > > > > This patch uses the device description to clearly identity a
> > > > > device
> > > > > attached to the bus. It is needed as the currently useed mdevX
> > > > > notation is not sufficiant in case more than one network
> > > > > interface controller is being used at the same time.
> > > > > 
> > > > > Signed-off-by: Christian Gromm 
> > > > > ---
> > > > > v2:
> > > > > v3:
> > > > > 
> > > > >  drivers/staging/most/core.c | 2 +-
> > > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > > 
> > > > > diff --git a/drivers/staging/most/core.c
> > > > > b/drivers/staging/most/core.c
> > > > > index a5df53e..e0a6806 100644
> > > > > --- a/drivers/staging/most/core.c
> > > > > +++ b/drivers/staging/most/core.c
> > > > > @@ -1467,7 +1467,7 @@ int most_register_interface(struct
> > > > > most_interface *iface)
> > > > >  
> > > > >   INIT_LIST_HEAD(&iface->p->channel_list);
> > > > >   iface->p->dev_id = id;
> > > > > - snprintf(iface->p->name, STRING_SIZE, "mdev%d", id);
> > > > > + strcpy(iface->p->name, iface->description);
> > > > >   iface->dev.init_name = iface->p->name;
> > > > >   iface->dev.bus = &mc.bus;
> > > > >   iface->dev.parent = &mc.dev;
> > > > Is this a stand-alone bugfix that can be taken now and should
> > > > also be
> > > > added to the stable kernel trees?
> > > > 
> > > Stable trees? The driver is not present there yet.
> > This driver has been in the kernel for many years, and this specific
> > file has been there since 4.16.  We have long term stable releases
> > for
> > 4.19 going at the moment.
> > 
> > If you don't care about the stable releases, that's fine, just asking
> > :)
> > 
> 
> Actually I do care (you know that). Just not sure if I understood what
> you was trying to tell me. To me "stable" means "not staging area". 
> That's why I was confused.
> 
> So yes please, add it.

Great, can you please add the "cc: stable..." tag to the signed-off-by
area of the patch as documented in:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html

so it gets picked up properly?

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 05/16] staging: vc04_services: add proper SPDX identifier for dual licensed files

[Greg Kroah-Hartman]

There are a number of vc04_services files that are dual licensed under
the GPL2 and BSD-3 licenses.  They currently do not have a SPDX
identifier on them, so fix that up and add the proper identifier so that
tools can pick it up easily.

Cc: Eric Anholt 
Cc: Stefan Wahren 
Cc: Tuomas Tynkkynen 
Cc: Aymen Qader 
Cc: "Tobias Büttner" 
Cc: Dominic Braun 
Cc: Nicolas Saenz Julienne 
Cc: Alejandro Ismael Silva 
Cc: Phil Elwell 
Cc: Luis Chamberlain 
Cc: Arnd Bergmann 
Signed-off-by: Greg Kroah-Hartman 
---
 drivers/staging/vc04_services/interface/vchi/vchi.h  | 1 +
 drivers/staging/vc04_services/interface/vchi/vchi_cfg.h  | 1 +
 drivers/staging/vc04_services/interface/vchi/vchi_common.h   | 1 +
 drivers/staging/vc04_services/interface/vchiq_arm/vchiq.h| 1 +
 .../staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c   | 1 +
 drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c| 1 +
 drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.h| 1 +
 drivers/staging/vc04_services/interface/vchiq_arm/vchiq_cfg.h| 1 +
 .../staging/vc04_services/interface/vchiq_arm/vchiq_connected.c  | 1 +
 .../staging/vc04_services/interface/vchiq_arm/vchiq_connected.h  | 1 +
 drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c   | 1 +
 drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h   | 1 +
 .../staging/vc04_services/interface/vchiq_arm/vchiq_debugfs.c| 1 +
 .../staging/vc04_services/interface/vchiq_arm/vchiq_debugfs.h| 1 +
 drivers/staging/vc04_services/interface/vchiq_arm/vchiq_if.h | 1 +
 drivers/staging/vc04_services/interface/vchiq_arm/vchiq_ioctl.h  | 1 +
 .../staging/vc04_services/interface/vchiq_arm/vchiq_pagelist.h   | 1 +
 drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c   | 1 +
 drivers/staging/vc04_services/interface/vchiq_arm/vchiq_util.c   | 1 +
 drivers/staging/vc04_services/interface/vchiq_arm/vchiq_util.h   | 1 +
 20 files changed, 20 insertions(+)

diff --git a/drivers/staging/vc04_services/interface/vchi/vchi.h 
b/drivers/staging/vc04_services/interface/vchi/vchi.h
index df7f8ef478af..a662e1bf7341 100644
--- a/drivers/staging/vc04_services/interface/vchi/vchi.h
+++ b/drivers/staging/vc04_services/interface/vchi/vchi.h
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause */
 /**
  * Copyright (c) 2010-2012 Broadcom. All rights reserved.
  *
diff --git a/drivers/staging/vc04_services/interface/vchi/vchi_cfg.h 
b/drivers/staging/vc04_services/interface/vchi/vchi_cfg.h
index 0d3c468c3504..d9f16a544412 100644
--- a/drivers/staging/vc04_services/interface/vchi/vchi_cfg.h
+++ b/drivers/staging/vc04_services/interface/vchi/vchi_cfg.h
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause */
 /**
  * Copyright (c) 2010-2012 Broadcom. All rights reserved.
  *
diff --git a/drivers/staging/vc04_services/interface/vchi/vchi_common.h 
b/drivers/staging/vc04_services/interface/vchi/vchi_common.h
index 1672848d5c83..fdb17a80fa5c 100644
--- a/drivers/staging/vc04_services/interface/vchi/vchi_common.h
+++ b/drivers/staging/vc04_services/interface/vchi/vchi_common.h
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause */
 /**
  * Copyright (c) 2010-2012 Broadcom. All rights reserved.
  *
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq.h 
b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq.h
index 21adf89a9065..4b6e657081f1 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq.h
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq.h
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause */
 /**
  * Copyright (c) 2010-2012 Broadcom. All rights reserved.
  *
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c 
b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c
index dd4898861b83..70d7f6ff1483 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause
 /**
  * Copyright (c) 2010-2012 Broadcom. All rights reserved.
  *
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c 
b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
index 6dad624d0e49..c95b7eaf7343 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause
 /**
  * Copyright (c) 2014 Raspberry Pi (Trading) Ltd. All rights reserved.
  * Copyright (c) 2010-2012 Broadcom. All rights reserved.
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.h 
b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.h
index cdb963054975..fc732ca76ca5 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.h
+++ b/drivers/staging/vc04_services/inter

[PATCH 08/16] staging: iio: add proper SPDX identifiers to remaining driver files

[Greg Kroah-Hartman]

There are a number of IIO staging drivers that do not have a proper SPDX
identifier on it.  So fix that up and at the same time, remove the "free
form" license text, as that's pretty much impossible for any tool to
parse.

Cc: Lars-Peter Clausen 
Cc: Michael Hennerich 
Cc: Jonathan Cameron 
Cc: Hartmut Knaack 
Cc: Peter Meerwald-Stadler 
Signed-off-by: Greg Kroah-Hartman 
---
 drivers/staging/iio/accel/adis16203.c   | 3 +--
 drivers/staging/iio/accel/adis16240.c   | 3 +--
 drivers/staging/iio/adc/ad7192.c| 3 +--
 drivers/staging/iio/adc/ad7192.h| 3 +--
 drivers/staging/iio/adc/ad7280a.c   | 3 +--
 drivers/staging/iio/adc/ad7280a.h   | 3 +--
 drivers/staging/iio/adc/ad7780.c| 3 +--
 drivers/staging/iio/adc/ad7816.c| 3 +--
 drivers/staging/iio/addac/adt7316-i2c.c | 3 +--
 drivers/staging/iio/addac/adt7316-spi.c | 3 +--
 drivers/staging/iio/addac/adt7316.c | 4 +---
 drivers/staging/iio/addac/adt7316.h | 3 +--
 drivers/staging/iio/cdc/ad7150.c| 3 +--
 drivers/staging/iio/cdc/ad7746.c| 3 +--
 drivers/staging/iio/cdc/ad7746.h| 3 +--
 drivers/staging/iio/frequency/ad9832.c  | 3 +--
 drivers/staging/iio/frequency/ad9832.h  | 3 +--
 drivers/staging/iio/frequency/ad9834.c  | 3 +--
 drivers/staging/iio/frequency/ad9834.h  | 3 +--
 drivers/staging/iio/frequency/dds.h | 3 +--
 drivers/staging/iio/impedance-analyzer/ad5933.c | 3 +--
 drivers/staging/iio/meter/ade7854-i2c.c | 3 +--
 drivers/staging/iio/meter/ade7854-spi.c | 3 +--
 drivers/staging/iio/meter/ade7854.c | 3 +--
 drivers/staging/iio/resolver/ad2s1210.c | 6 +-
 25 files changed, 25 insertions(+), 54 deletions(-)

diff --git a/drivers/staging/iio/accel/adis16203.c 
b/drivers/staging/iio/accel/adis16203.c
index 5cc96c8086b5..70381756a64a 100644
--- a/drivers/staging/iio/accel/adis16203.c
+++ b/drivers/staging/iio/accel/adis16203.c
@@ -1,9 +1,8 @@
+// SPDX-License-Identifier: GPL-2.0+
 /*
  * ADIS16203 Programmable 360 Degrees Inclinometer
  *
  * Copyright 2010 Analog Devices Inc.
- *
- * Licensed under the GPL-2 or later.
  */
 
 #include 
diff --git a/drivers/staging/iio/accel/adis16240.c 
b/drivers/staging/iio/accel/adis16240.c
index 24e525f1ef25..b80e0d248b0f 100644
--- a/drivers/staging/iio/accel/adis16240.c
+++ b/drivers/staging/iio/accel/adis16240.c
@@ -1,9 +1,8 @@
+// SPDX-License-Identifier: GPL-2.0+
 /*
  * ADIS16240 Programmable Impact Sensor and Recorder driver
  *
  * Copyright 2010 Analog Devices Inc.
- *
- * Licensed under the GPL-2 or later.
  */
 
 #include 
diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
index acdbc07fd259..dfb79fbf63f4 100644
--- a/drivers/staging/iio/adc/ad7192.c
+++ b/drivers/staging/iio/adc/ad7192.c
@@ -1,9 +1,8 @@
+// SPDX-License-Identifier: GPL-2.0
 /*
  * AD7190 AD7192 AD7193 AD7195 SPI ADC driver
  *
  * Copyright 2011-2015 Analog Devices Inc.
- *
- * Licensed under the GPL-2.
  */
 
 #include 
diff --git a/drivers/staging/iio/adc/ad7192.h b/drivers/staging/iio/adc/ad7192.h
index 7433a43c2611..e382b22c460b 100644
--- a/drivers/staging/iio/adc/ad7192.h
+++ b/drivers/staging/iio/adc/ad7192.h
@@ -1,9 +1,8 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * AD7190 AD7192 AD7195 SPI ADC driver
  *
  * Copyright 2011 Analog Devices Inc.
- *
- * Licensed under the GPL-2.
  */
 #ifndef IIO_ADC_AD7192_H_
 #define IIO_ADC_AD7192_H_
diff --git a/drivers/staging/iio/adc/ad7280a.c 
b/drivers/staging/iio/adc/ad7280a.c
index d9df12665176..47cfe920b2ae 100644
--- a/drivers/staging/iio/adc/ad7280a.c
+++ b/drivers/staging/iio/adc/ad7280a.c
@@ -1,9 +1,8 @@
+// SPDX-License-Identifier: GPL-2.0
 /*
  * AD7280A Lithium Ion Battery Monitoring System
  *
  * Copyright 2011 Analog Devices Inc.
- *
- * Licensed under the GPL-2.
  */
 
 #include 
diff --git a/drivers/staging/iio/adc/ad7280a.h 
b/drivers/staging/iio/adc/ad7280a.h
index ccfb90d20e71..23f18bb9e279 100644
--- a/drivers/staging/iio/adc/ad7280a.h
+++ b/drivers/staging/iio/adc/ad7280a.h
@@ -1,9 +1,8 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * AD7280A Lithium Ion Battery Monitoring System
  *
  * Copyright 2011 Analog Devices Inc.
- *
- * Licensed under the GPL-2.
  */
 
 #ifndef IIO_ADC_AD7280_H_
diff --git a/drivers/staging/iio/adc/ad7780.c b/drivers/staging/iio/adc/ad7780.c
index c4a85789c2db..c15389f562b2 100644
--- a/drivers/staging/iio/adc/ad7780.c
+++ b/drivers/staging/iio/adc/ad7780.c
@@ -1,9 +1,8 @@
+// SPDX-License-Identifier: GPL-2.0
 /*
  * AD7170/AD7171 and AD7780/AD7781 SPI ADC driver
  *
  * Copyright 2011 Analog Devices Inc.
- *
- * Licensed under the GPL-2.
  */
 
 #include 
diff --git a/drivers/staging/iio/adc/ad7816.c b/drivers/staging/iio/adc/ad7816.c
index ee50e7296795..a0e13f29ec07 100644
--- a/drivers/staging/iio/adc/ad7816.c
+++ b/drivers/staging/iio/adc

Re: [PATCH 06/16] staging: vc04_services: remove remaining redundant license text

[Stefan Wahren]

Am 02.04.19 um 12:31 schrieb Greg Kroah-Hartman:
> Now that the SPDX tag is in all vc04_services files, that identifies the
> license in a specific and legally-defined manner.  So the extra GPL and
> BSD text wording can be removed as it is no longer needed at all.
>
> This is done on a quest to remove the 700+ different ways that files in
> the kernel describe the license text.
>
> No copyright headers or other non-license-description text was removed.
>
> Cc: Eric Anholt 
> Cc: Stefan Wahren 
> Cc: Tuomas Tynkkynen 
> Cc: Aymen Qader 
> Cc: "Tobias Büttner" 
> Cc: Dominic Braun 
> Cc: Nicolas Saenz Julienne 
> Cc: Alejandro Ismael Silva 
> Cc: Phil Elwell 
> Cc: Luis Chamberlain 
> Cc: Arnd Bergmann 
> Signed-off-by: Greg Kroah-Hartman 

Acked-by: Stefan Wahren 

Thanks

Stefan

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 05/16] staging: vc04_services: add proper SPDX identifier for dual licensed files

[Stefan Wahren]

Am 02.04.19 um 12:31 schrieb Greg Kroah-Hartman:
> There are a number of vc04_services files that are dual licensed under
> the GPL2 and BSD-3 licenses.  They currently do not have a SPDX
> identifier on them, so fix that up and add the proper identifier so that
> tools can pick it up easily.
>
> Cc: Eric Anholt 
> Cc: Stefan Wahren 
> Cc: Tuomas Tynkkynen 
> Cc: Aymen Qader 
> Cc: "Tobias Büttner" 
> Cc: Dominic Braun 
> Cc: Nicolas Saenz Julienne 
> Cc: Alejandro Ismael Silva 
> Cc: Phil Elwell 
> Cc: Luis Chamberlain 
> Cc: Arnd Bergmann 
> Signed-off-by: Greg Kroah-Hartman 
> ---
Acked-by: Stefan Wahren 
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 03/16] staging: m57621-mmc: delete driver from the tree.

[Greg Kroah-Hartman]

On Tue, Apr 02, 2019 at 06:16:47AM -0500, George Hilliard wrote:
> On Tue, Apr 2, 2019, 5:32 AM Greg Kroah-Hartman 
> wrote:
> 
> > The license text in this driver is "interesting" and not really obvious
> > that it is supposed to be able to be distributed in the kernel source
> > tree.  Yes, the MODULE_LICENSE() text says GPL, so it's probably ok, but
> > to be safe, I am deleting this driver.  I will be glad to add it back if
> > the license is properly sorted out, but for now, this isn't worth the
> > potential risk, I should have never taken it in the first place.
> >
> 
> So, for what it's worth, this driver has an obvious heritage of having been
> modified from the main Mediatek MMC driver. Now, of course it's *possible*
> to distribute GPL-incompatible changes to a GPL program, but the only
> *compliant* way to distribute these changes would have been the GPL.
> 
> So there's a very good chance that it's intended to be GPL.  (Which is
> good, because I need this driver!)  I suppose we need to reach out to the
> original contributor.

I agree that the intent is probably GPL, especially given the
MODULE_LICENSE string, and in general how mediatek handles their kernel
code (they properly opensource it all.)  I think that someone got a
little bit "heavy handed" on the comment blocks at the top of all of
these files though, and that is what makes this whole thing questionable
and needs to be addressed.

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 3/3] dt-bindings: iio: adc: Add AD7616 ADC documentation

[Beniamin Bia]

Document support for AD7616 Analog to Digital Converter.

Signed-off-by: Beniamin Bia 
---
 Documentation/devicetree/bindings/iio/adc/adi,ad7606.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7606.txt 
b/Documentation/devicetree/bindings/iio/adc/adi,ad7606.txt
index d7b6241ca881..d8652460198e 100644
--- a/Documentation/devicetree/bindings/iio/adc/adi,ad7606.txt
+++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7606.txt
@@ -7,6 +7,7 @@ Required properties for the AD7606:
* "adi,ad7606-8"
* "adi,ad7606-6"
* "adi,ad7606-4"
+   * "adi,ad7616"
 - reg: SPI chip select number for the device
 - spi-max-frequency: Max SPI frequency to use
see: Documentation/devicetree/bindings/spi/spi-bus.txt
-- 
2.17.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 2/3] iio: adc: ad7616: Add support for AD7616 ADC

[Beniamin Bia]

The AD7616 is a 12-bit ADC with 16 channels.

The AD7616 can be configured to work in hardware mode by controlling it via
gpio pins and read data via spi. No support for software mode yet, but it
is a work in progress.

This device requires a reset in order to update oversampling, so chip info
has got a new attribute to mark this.

The current assumption that this driver makes for AD7616, is that it's
working in Hardware Mode with Serial, Burst and Sequencer modes activated.
To activate them, following pins must be pulled high:
-SER/PAR
-SEQEN
And following must be pulled low:
-WR/BURST
-DB4/SEQEN

Datasheets:
Link: 
https://www.analog.com/media/en/technical-documentation/data-sheets/ad7616.pdf

Signed-off-by: Beniamin Bia 
Signed-off-by: Alexandru Ardelean 
---
 drivers/iio/adc/ad7606.c | 46 
 drivers/iio/adc/ad7606.h |  9 ---
 drivers/iio/adc/ad7606_spi.c |  2 ++
 3 files changed, 54 insertions(+), 3 deletions(-)

diff --git a/drivers/iio/adc/ad7606.c b/drivers/iio/adc/ad7606.c
index 6b87ed410c93..24c70c3cefb4 100644
--- a/drivers/iio/adc/ad7606.c
+++ b/drivers/iio/adc/ad7606.c
@@ -39,6 +39,10 @@ static const unsigned int ad7606_oversampling_avail[7] = {
1, 2, 4, 8, 16, 32, 64,
 };
 
+static const unsigned int ad7616_oversampling_avail[8] = {
+   1, 2, 4, 8, 16, 32, 64, 128,
+};
+
 static int ad7606_reset(struct ad7606_state *st)
 {
if (st->gpio_reset) {
@@ -220,6 +224,11 @@ static int ad7606_write_raw(struct iio_dev *indio_dev,
mutex_lock(&st->lock);
gpiod_set_array_value(ARRAY_SIZE(values), st->gpio_os->desc,
  st->gpio_os->info, values);
+
+   /* AD7616 requires a reset to update value */
+   if (st->chip_info->os_req_reset)
+   ad7606_reset(st);
+
st->oversampling = st->oversampling_avail[i];
mutex_unlock(&st->lock);
 
@@ -314,6 +323,36 @@ static const struct iio_chan_spec ad7606_channels[] = {
AD7606_CHANNEL(7),
 };
 
+/*
+ * The current assumption that this driver makes for AD7616, is that it's
+ * working in Hardware Mode with Serial, Burst and Sequencer modes activated.
+ * To activate them, following pins must be pulled high:
+ * -SER/PAR
+ * -SEQEN
+ * And following pins must be pulled low:
+ * -WR/BURST
+ * -DB4/SER1W
+ */
+static const struct iio_chan_spec ad7616_channels[] = {
+   IIO_CHAN_SOFT_TIMESTAMP(16),
+   AD7606_CHANNEL(0),
+   AD7606_CHANNEL(1),
+   AD7606_CHANNEL(2),
+   AD7606_CHANNEL(3),
+   AD7606_CHANNEL(4),
+   AD7606_CHANNEL(5),
+   AD7606_CHANNEL(6),
+   AD7606_CHANNEL(7),
+   AD7606_CHANNEL(8),
+   AD7606_CHANNEL(9),
+   AD7606_CHANNEL(10),
+   AD7606_CHANNEL(11),
+   AD7606_CHANNEL(12),
+   AD7606_CHANNEL(13),
+   AD7606_CHANNEL(14),
+   AD7606_CHANNEL(15),
+};
+
 static const struct ad7606_chip_info ad7606_chip_info_tbl[] = {
/* More devices added in future */
[ID_AD7605_4] = {
@@ -338,6 +377,13 @@ static const struct ad7606_chip_info 
ad7606_chip_info_tbl[] = {
.oversampling_avail = ad7606_oversampling_avail,
.oversampling_num = ARRAY_SIZE(ad7606_oversampling_avail),
},
+   [ID_AD7616] = {
+   .channels = ad7616_channels,
+   .num_channels = 17,
+   .oversampling_avail = ad7616_oversampling_avail,
+   .oversampling_num = ARRAY_SIZE(ad7616_oversampling_avail),
+   .os_req_reset = true,
+   },
 };
 
 static int ad7606_request_gpios(struct ad7606_state *st)
diff --git a/drivers/iio/adc/ad7606.h b/drivers/iio/adc/ad7606.h
index 8c91bd427c4e..f9ef52131e74 100644
--- a/drivers/iio/adc/ad7606.h
+++ b/drivers/iio/adc/ad7606.h
@@ -15,12 +15,14 @@
  * @oversampling_avail pointer to the array which stores the available
  * oversampling ratios.
  * @oversampling_num   number of elements stored in oversampling_avail array
+ * @os_req_reset   some devices require a reset to update oversampling
  */
 struct ad7606_chip_info {
const struct iio_chan_spec  *channels;
unsigned intnum_channels;
const unsigned int  *oversampling_avail;
unsigned intoversampling_num;
+   boolos_req_reset;
 };
 
 /**
@@ -76,9 +78,9 @@ struct ad7606_state {
/*
 * DMA (thus cache coherency maintenance) requires the
 * transfer buffers to live in their own cache lines.
-* 8 * 16-bit samples + 64-bit timestamp
+* 16 * 16-bit samples + 64-bit timestamp
 */
-   unsigned short  data[12] cacheline_aligned;
+   unsigned short  data[20] cacheline_aligned;
 };
 
 /**
@@ -98,7 +100,8 @@ enum ad7606_supported_device_ids {
ID_AD76

[PATCH] staging: most: core: use device description as name

[Christian Gromm]

This patch uses the device description to clearly identity a device
attached to the bus. It is needed as the currently useed mdevX
notation is not sufficiant in case more than one network
interface controller is being used at the same time.

Cc: sta...@vger.kernel.org
Signed-off-by: Christian Gromm 
---

 drivers/staging/most/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/most/core.c b/drivers/staging/most/core.c
index a5df53e..e0a6806 100644
--- a/drivers/staging/most/core.c
+++ b/drivers/staging/most/core.c
@@ -1467,7 +1467,7 @@ int most_register_interface(struct most_interface *iface)
 
INIT_LIST_HEAD(&iface->p->channel_list);
iface->p->dev_id = id;
-   snprintf(iface->p->name, STRING_SIZE, "mdev%d", id);
+   strcpy(iface->p->name, iface->description);
iface->dev.init_name = iface->p->name;
iface->dev.bus = &mc.bus;
iface->dev.parent = &mc.dev;
-- 
2.7.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v3 1/2] media: v4l: Add definitions for the HEVC slice format and controls

[Hans Verkuil]

On 2/14/19 10:53 AM, Paul Kocialkowski wrote:
> This introduces the required definitions for HEVC decoding support with
> stateless VPUs. The controls associated to the HEVC slice format provide
> the required meta-data for decoding slices extracted from the bitstream.
> 
> This interface comes with the following limitations:
> * No custom quantization matrices (scaling lists);
> * Support for a single temporal layer only;
> * No slice entry point offsets support;
> * No conformance window support;
> * No VUI parameters support;
> * No support for SPS extensions: range, multilayer, 3d, scc, 4 bits;
> * No support for PPS extensions: range, multilayer, 3d, scc, 4 bits.
> 
> Signed-off-by: Paul Kocialkowski 
> ---
>  Documentation/media/uapi/v4l/biblio.rst   |   9 +
>  .../media/uapi/v4l/ext-ctrls-codec.rst| 418 ++
>  .../media/uapi/v4l/pixfmt-compressed.rst  |  15 +
>  .../media/uapi/v4l/vidioc-queryctrl.rst   |  18 +
>  .../media/videodev2.h.rst.exceptions  |   3 +
>  drivers/media/v4l2-core/v4l2-ctrls.c  |  26 ++
>  drivers/media/v4l2-core/v4l2-ioctl.c  |   1 +
>  include/media/hevc-ctrls.h| 181 
>  include/media/v4l2-ctrls.h|   7 +
>  include/uapi/linux/videodev2.h|   1 +
>  10 files changed, 679 insertions(+)
>  create mode 100644 include/media/hevc-ctrls.h
> 
> diff --git a/Documentation/media/uapi/v4l/biblio.rst 
> b/Documentation/media/uapi/v4l/biblio.rst
> index 3fc3f7ff338a..b4b3fcec55dd 100644
> --- a/Documentation/media/uapi/v4l/biblio.rst
> +++ b/Documentation/media/uapi/v4l/biblio.rst
> @@ -131,6 +131,15 @@ ITU H.264
>  
>  :author:International Telecommunication Union (http://www.itu.ch)
>  
> +.. _hevc:
> +
> +ITU H.265/HEVC
> +==
> +
> +:title: ITU-T Rec. H.265 | ISO/IEC 23008-2 "High Efficiency Video Coding"
> +
> +:author:International Telecommunication Union (http://www.itu.ch), 
> International Organisation for Standardisation (http://www.iso.ch)
> +
>  .. _jfif:
>  
>  JFIF
> diff --git a/Documentation/media/uapi/v4l/ext-ctrls-codec.rst 
> b/Documentation/media/uapi/v4l/ext-ctrls-codec.rst
> index d152474c18bc..3714dfd1449b 100644
> --- a/Documentation/media/uapi/v4l/ext-ctrls-codec.rst
> +++ b/Documentation/media/uapi/v4l/ext-ctrls-codec.rst
> @@ -2067,6 +2067,424 @@ enum v4l2_mpeg_video_h264_hierarchical_coding_type -
>- 0x0002
>-
>  
> +.. _v4l2-mpeg-hevc:
> +
> +``V4L2_CID_MPEG_VIDEO_HEVC_SPS (struct)``
> +Specifies the Sequence Parameter Set fields (as extracted from the
> +bitstream) for the associated HEVC slice data.
> +These bitstream parameters are defined according to :ref:`hevc`.
> +They are described in section 7.4.3.2 "Sequence parameter set RBSP
> +semantics" of the specification.
> +
> +.. c:type:: v4l2_ctrl_hevc_sps
> +
> +.. cssclass:: longtable
> +
> +.. flat-table:: struct v4l2_ctrl_hevc_sps
> +:header-rows:  0
> +:stub-columns: 0
> +:widths:   1 1 2
> +
> +* - __u8
> +  - ``chroma_format_idc``
> +  -
> +* - __u8
> +  - ``separate_colour_plane_flag``
> +  -
> +* - __u16
> +  - ``pic_width_in_luma_samples``
> +  -
> +* - __u16
> +  - ``pic_height_in_luma_samples``
> +  -
> +* - __u8
> +  - ``bit_depth_luma_minus8``
> +  -
> +* - __u8
> +  - ``bit_depth_chroma_minus8``
> +  -
> +* - __u8
> +  - ``log2_max_pic_order_cnt_lsb_minus4``
> +  -
> +* - __u8
> +  - ``sps_max_dec_pic_buffering_minus1``
> +  -
> +* - __u8
> +  - ``sps_max_num_reorder_pics``
> +  -
> +* - __u8
> +  - ``sps_max_latency_increase_plus1``
> +  -
> +* - __u8
> +  - ``log2_min_luma_coding_block_size_minus3``
> +  -
> +* - __u8
> +  - ``log2_diff_max_min_luma_coding_block_size``
> +  -
> +* - __u8
> +  - ``log2_min_luma_transform_block_size_minus2``
> +  -
> +* - __u8
> +  - ``log2_diff_max_min_luma_transform_block_size``
> +  -
> +* - __u8
> +  - ``max_transform_hierarchy_depth_inter``
> +  -
> +* - __u8
> +  - ``max_transform_hierarchy_depth_intra``
> +  -
> +* - __u8
> +  - ``scaling_list_enabled_flag``
> +  -
> +* - __u8
> +  - ``amp_enabled_flag``
> +  -
> +* - __u8
> +  - ``sample_adaptive_offset_enabled_flag``
> +  -
> +* - __u8
> +  - ``pcm_enabled_flag``
> +  -
> +* - __u8
> +  - ``pcm_sample_bit_depth_luma_minus1``
> +  -
> +* - __u8
> +  - ``pcm_sample_bit_depth_chroma_minus1``
> +  -
> +* - __u8
> +  - ``log2_min_pcm_luma_coding_block_size_minus3``
> +  -
> +* - __u8
> +  - ``log2_diff_max_min_pcm_luma_coding_block_size``
> +  -
> +* - __u8
> +  - ``pcm_loop_filter_disabled_flag``
> +  -
> +* - __u8
> +  - ``num_short_term_ref_pic_sets``
> +  -
> +* - __u8
> +  - ``long_term_re

Re: [PATCH 02/16] staging: add missing SPDX lines to Makefile files

[Mukesh Ojha]

On 4/2/2019 4:01 PM, Greg Kroah-Hartman wrote:

There are a few remaining drivers/staging/*/Makefile files that do not
have SPDX identifiers in them.  Add the correct GPL-2.0 identifier to
them to make scanning tools happy.

Signed-off-by: Greg Kroah-Hartman 


Lesson learnt :-)

Reviewed-by: Mukesh Ojha 


Cheers,
-Mukesh

---
  drivers/staging/android/Makefile | 1 +
  drivers/staging/axis-fifo/Makefile   | 1 +
  drivers/staging/board/Makefile   | 1 +
  drivers/staging/clocking-wizard/Makefile | 1 +
  drivers/staging/comedi/drivers/ni_routing/tools/Makefile | 1 +
  drivers/staging/comedi/kcomedilib/Makefile   | 1 +
  drivers/staging/emxx_udc/Makefile| 1 +
  drivers/staging/fsl-dpaa2/Makefile   | 1 +
  drivers/staging/fwserial/Makefile| 1 +
  drivers/staging/gasket/Makefile  | 1 +
  drivers/staging/goldfish/Makefile| 1 +
  drivers/staging/gs_fpgaboot/Makefile | 1 +
  drivers/staging/iio/accel/Makefile   | 1 +
  drivers/staging/iio/addac/Makefile   | 1 +
  drivers/staging/iio/cdc/Makefile | 1 +
  drivers/staging/iio/frequency/Makefile   | 1 +
  drivers/staging/iio/impedance-analyzer/Makefile  | 1 +
  drivers/staging/iio/resolver/Makefile| 1 +
  drivers/staging/ks7010/Makefile  | 1 +
  drivers/staging/media/bcm2048/Makefile   | 1 +
  drivers/staging/media/davinci_vpfe/Makefile  | 1 +
  drivers/staging/media/ipu3/Makefile  | 1 +
  drivers/staging/media/mt9t031/Makefile   | 1 +
  drivers/staging/media/rockchip/vpu/Makefile  | 1 +
  drivers/staging/media/sunxi/Makefile | 1 +
  drivers/staging/media/sunxi/cedrus/Makefile  | 1 +
  drivers/staging/media/tegra-vde/Makefile | 1 +
  drivers/staging/most/cdev/Makefile   | 1 +
  drivers/staging/most/dim2/Makefile   | 1 +
  drivers/staging/most/i2c/Makefile| 1 +
  drivers/staging/most/net/Makefile| 1 +
  drivers/staging/most/sound/Makefile  | 1 +
  drivers/staging/most/usb/Makefile| 1 +
  drivers/staging/most/video/Makefile  | 1 +
  drivers/staging/mt7621-dma/Makefile  | 1 +
  drivers/staging/mt7621-dts/Makefile  | 1 +
  drivers/staging/mt7621-pci-phy/Makefile  | 1 +
  drivers/staging/mt7621-pci/Makefile  | 1 +
  drivers/staging/mt7621-pinctrl/Makefile  | 1 +
  drivers/staging/mt7621-spi/Makefile  | 1 +
  drivers/staging/netlogic/Makefile| 1 +
  drivers/staging/olpc_dcon/Makefile   | 1 +
  drivers/staging/pi433/Makefile   | 1 +
  drivers/staging/ralink-gdma/Makefile | 1 +
  drivers/staging/rtlwifi/Makefile | 1 +
  drivers/staging/rtlwifi/btcoexist/Makefile   | 1 +
  drivers/staging/rtlwifi/rtl8822be/Makefile   | 1 +
  drivers/staging/rts5208/Makefile | 1 +
  drivers/staging/sm750fb/Makefile | 1 +
  drivers/staging/unisys/Makefile  | 1 +
  drivers/staging/unisys/visorhba/Makefile | 1 +
  drivers/staging/unisys/visorinput/Makefile   | 1 +
  drivers/staging/unisys/visornic/Makefile | 1 +
  drivers/staging/vc04_services/bcm2835-audio/Makefile | 1 +
  drivers/staging/vme/Makefile | 1 +
  drivers/staging/vme/devices/Makefile | 1 +
  56 files changed, 56 insertions(+)

diff --git a/drivers/staging/android/Makefile b/drivers/staging/android/Makefile
index 90e6154f11a4..14bd9c6ce10d 100644
--- a/drivers/staging/android/Makefile
+++ b/drivers/staging/android/Makefile
@@ -1,3 +1,4 @@
+# SPDX-License-Identifier: GPL-2.0
  ccflags-y += -I$(src) # needed for trace events
  
  obj-y	+= ion/

diff --git a/drivers/staging/axis-fifo/Makefile 
b/drivers/staging/axis-fifo/Makefile
index fe62cd1ac5de..c626005c99db 100644
--- a/drivers/staging/axis-fifo/Makefile
+++ b/drivers/staging/axis-fifo/Makefile
@@ -1 +1,2 @@
+# SPDX-License-Identifier: GPL-2.0
  obj-$(CONFIG_XIL_AXIS_FIFO) += axis-fifo.o
diff --git a/drivers/staging/board/Makefile b/drivers/staging/board/Makefile
index 6842745feb94..ed7839752e12 100644
--- a/drivers/staging/board/Makefile
+++ b/drivers/staging/board/Makefile
@@ -1,3 +1,4 @@
+# SPDX-License-Identifier: GPL-2.0
  obj-y := board.o
  obj-$(CONFIG_ARCH_EMEV2)  += kzm9d.o
  obj-$(CONFIG_ARCH_R8A7740)+= arma

[PATCH] staging: pi433: Return thread immediately when kthread_should_stop() call.

[Sidong Yang]

When kthread_stop() called by removing module, running thread should
return immediately. Otherwise, It is very dangerous that thread may access
any released data like struct pi433_device.

Signed-off-by: Sidong Yang 
---
 drivers/staging/pi433/pi433_if.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
index ab90d6f80931..16dc380eb176 100644
--- a/drivers/staging/pi433/pi433_if.c
+++ b/drivers/staging/pi433/pi433_if.c
@@ -736,7 +736,7 @@ pi433_tx_thread(void *data)
 device->free_in_fifo == FIFO_SIZE ||
 kthread_should_stop());
if (kthread_should_stop())
-   dev_dbg(device->dev, "ABORT\n");
+   return 0;
 
/* STOP_TRANSMISSION */
dev_dbg(device->dev, "thread: Packet sent. Set mode to stby.");
-- 
2.11.0

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Your Outward Payment Advice, ACC: 01XXXXX3404 dated 02-April-2019

[eAdvices . UAE]

Dear Customer,
Thank you for banking with Standard Chartered Bank

Attached is your Debit Advice as per your request. Kindly note 
that your e-Advice is in PDF format.
If you are unable to open the attachment please download Adobe 
Acrobat Reader by clicking at:
www.adobe.com

The PDF file is password protected. Please use your eleven (11) 
digits Account Number (without any
space or special character) as password to open this file.

This is a system generated mail. We request you not to reply to 
this message. If you have any query,
please call our Contact Centre.
https://mail.google.com/mail/#inbox?compose=14e7c486d62a0b0e
UAE Call Centre : 600 5222 88.

Cash Management Operations
Standard Chartered Bank
Disclaimer

This email and any attachments are confidential and may also be 
privileged. If you are not the
intended recipient, please delete all copies and notify the 
sender immediately. You may wish to
refer to the incorporation details of Standard Chartered PLC, 
Standard Chartered Bank and their
subsidiaries at https://www.sc.com/en/incorporation-details.html

OT_DR_OT02091507110183_110720151227372737.xlsx
Description: Binary data
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Your Outward Payment Advice, ACC: 01XXXXX3404 dated 02-April-2019

[eAdvices . UAE]

Dear Customer,
Thank you for banking with Standard Chartered Bank

Attached is your Debit Advice as per your request. Kindly note 
that your e-Advice is in PDF format.
If you are unable to open the attachment please download Adobe 
Acrobat Reader by clicking at:
www.adobe.com

The PDF file is password protected. Please use your eleven (11) 
digits Account Number (without any
space or special character) as password to open this file.

This is a system generated mail. We request you not to reply to 
this message. If you have any query,
please call our Contact Centre.
https://mail.google.com/mail/#inbox?compose=14e7c486d62a0b0e
UAE Call Centre : 600 5222 88.

Cash Management Operations
Standard Chartered Bank
Disclaimer

This email and any attachments are confidential and may also be 
privileged. If you are not the
intended recipient, please delete all copies and notify the 
sender immediately. You may wish to
refer to the incorporation details of Standard Chartered PLC, 
Standard Chartered Bank and their
subsidiaries at https://www.sc.com/en/incorporation-details.html

OT_DR_OT02091507110183_110720151227372737.xlsx
Description: Binary data
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 1/3] iio: adc: ad7606: Move oversampling options in chip info and rework *_avail attributes

[Beniamin Bia]

From: Stefan Popa 

Available oversampling ratios and scales can be shown by calling a
common ad7606_show_avail function which takes as parameters the array
which stores the values, together with the size of the array.

Oversampling options are now defined in chip info
structure and they are loaded at probe.

Has_Oversampling attribute was removed because oversampling_num was added
and it is not needed anymore.

The purpose of this patch is to deal with the scale_avail and
oversampling_avail arrays in a generic way. This makes it easier to add
support for new devices which will work with different scales and
oversampling ratios. It is also an intermediate step for adding support
for ad7616 which has different oversampling sampling ratios available.

Signed-off-by: Stefan Popa 
Signed-off-by: Beniamin Bia 
---
 drivers/iio/adc/ad7606.c | 74 
 drivers/iio/adc/ad7606.h | 16 +++--
 2 files changed, 67 insertions(+), 23 deletions(-)

diff --git a/drivers/iio/adc/ad7606.c b/drivers/iio/adc/ad7606.c
index ebb8de03bbce..6b87ed410c93 100644
--- a/drivers/iio/adc/ad7606.c
+++ b/drivers/iio/adc/ad7606.c
@@ -31,7 +31,7 @@
  * Scales are computed as 5000/32768 and 1/32768 respectively,
  * so that when applied to the raw values they provide mV values
  */
-static const unsigned int scale_avail[2] = {
+static const unsigned int ad7606_scale_avail[2] = {
152588, 305176
 };
 
@@ -154,7 +154,7 @@ static int ad7606_read_raw(struct iio_dev *indio_dev,
return IIO_VAL_INT;
case IIO_CHAN_INFO_SCALE:
*val = 0;
-   *val2 = scale_avail[st->range];
+   *val2 = st->scale_avail[st->range];
return IIO_VAL_INT_PLUS_MICRO;
case IIO_CHAN_INFO_OVERSAMPLING_RATIO:
*val = st->oversampling;
@@ -163,21 +163,31 @@ static int ad7606_read_raw(struct iio_dev *indio_dev,
return -EINVAL;
 }
 
-static ssize_t in_voltage_scale_available_show(struct device *dev,
-  struct device_attribute *attr,
-  char *buf)
+static ssize_t ad7606_show_avail(char *buf, const unsigned int *vals,
+unsigned int n, bool micros)
 {
-   int i, len = 0;
-
-   for (i = 0; i < ARRAY_SIZE(scale_avail); i++)
-   len += scnprintf(buf + len, PAGE_SIZE - len, "0.%06u ",
-scale_avail[i]);
+   size_t len = 0;
+   int i;
 
+   for (i = 0; i < n; i++) {
+   len += scnprintf(buf + len, PAGE_SIZE - len,
+   micros ? "0.%06u " : "%u ", vals[i]);
+   }
buf[len - 1] = '\n';
 
return len;
 }
 
+static ssize_t in_voltage_scale_available_show(struct device *dev,
+  struct device_attribute *attr,
+  char *buf)
+{
+   struct iio_dev *indio_dev = dev_to_iio_dev(dev);
+   struct ad7606_state *st = iio_priv(indio_dev);
+
+   return ad7606_show_avail(buf, st->scale_avail, st->num_scales, true);
+}
+
 static IIO_DEVICE_ATTR_RO(in_voltage_scale_available, 0);
 
 static int ad7606_write_raw(struct iio_dev *indio_dev,
@@ -193,7 +203,7 @@ static int ad7606_write_raw(struct iio_dev *indio_dev,
switch (mask) {
case IIO_CHAN_INFO_SCALE:
mutex_lock(&st->lock);
-   i = find_closest(val2, scale_avail, ARRAY_SIZE(scale_avail));
+   i = find_closest(val2, st->scale_avail, st->num_scales);
gpiod_set_value(st->gpio_range, i);
st->range = i;
mutex_unlock(&st->lock);
@@ -202,15 +212,15 @@ static int ad7606_write_raw(struct iio_dev *indio_dev,
case IIO_CHAN_INFO_OVERSAMPLING_RATIO:
if (val2)
return -EINVAL;
-   i = find_closest(val, ad7606_oversampling_avail,
-ARRAY_SIZE(ad7606_oversampling_avail));
+   i = find_closest(val, st->oversampling_avail,
+st->num_os_ratios);
 
values[0] = i;
 
mutex_lock(&st->lock);
gpiod_set_array_value(ARRAY_SIZE(values), st->gpio_os->desc,
  st->gpio_os->info, values);
-   st->oversampling = ad7606_oversampling_avail[i];
+   st->oversampling = st->oversampling_avail[i];
mutex_unlock(&st->lock);
 
return 0;
@@ -219,11 +229,23 @@ static int ad7606_write_raw(struct iio_dev *indio_dev,
}
 }
 
-static IIO_CONST_ATTR(oversampling_ratio_available, "1 2 4 8 16 32 64");
+static ssize_t ad7606_oversampling_ratio_avail(struct device *dev,
+  struct device_attribute *attr,
+  char *buf)
+{
+   struct iio_dev *indio_dev = dev_to_iio_

Re: [PATCH 16/16] staging: media: tegra-vde: add proper SPDX identifiers on file that did not have it.

[Thierry Reding]

On Tue, Apr 02, 2019 at 12:32:03PM +0200, Greg Kroah-Hartman wrote:
> There was a single file for the tegra-vde driver that did not have SPDX
> identifiers on it, so fix that up.  At the same time, remove the "free
> form" text that specified the license of the file, as that is impossible
> for any tool to properly parse.
> 
> Cc: Dmitry Osipenko 
> Cc: Mauro Carvalho Chehab 
> Cc: Thierry Reding 
> Cc: Jonathan Hunter 
> Cc: linux-me...@vger.kernel.org
> Cc: linux-te...@vger.kernel.org
> Signed-off-by: Greg Kroah-Hartman 
> ---
>  drivers/staging/media/tegra-vde/uapi.h | 11 ++-
>  1 file changed, 2 insertions(+), 9 deletions(-)

Acked-by: Thierry Reding 


signature.asc
Description: PGP signature
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 2/4] staging: iio: ad9832: add SPDX identifier

[Marcelo Schmitt]

On 04/01, Greg KH wrote:
> On Mon, Apr 01, 2019 at 08:36:50PM +0530, Mukesh Ojha wrote:
> > 
> > On 4/1/2019 8:07 PM, Marcelo Schmitt wrote:
> > > Add SPDX identifier of GPL-2.0 for the ad9832 driver.
> > > 
> > > Signed-off-by: Marcelo Schmitt 
> > > ---
> > >   drivers/staging/iio/frequency/ad9832.c | 3 +--
> > >   1 file changed, 1 insertion(+), 2 deletions(-)
> > > 
> > > diff --git a/drivers/staging/iio/frequency/ad9832.c 
> > > b/drivers/staging/iio/frequency/ad9832.c
> > > index 50a583020072..d8d4a7936275 100644
> > > --- a/drivers/staging/iio/frequency/ad9832.c
> > > +++ b/drivers/staging/iio/frequency/ad9832.c
> > > @@ -1,9 +1,8 @@
> > > +// SPDX-License-Identifier: GPL-2.0
> > 
> > FYI
> > 
> > Use C notations here as per https://lkml.org/lkml/2019/2/13/570.
> > 
> > 

OK, I'll check it out.

> > 
> > Once you fix it then you can take mine
> > Reviewed-by: Mukesh Ojha 
> 
> Did you read the documentation about how to put a proper SPDX line in
> the kernel documentation?  For .c files, you have to use "//", not "/* */"
> 
> Please read:
>   Documentation/process/license-rules.rst
> and see the section "Style" for all of the details.

Thanks, I'll read it to understand the details.

> 
> thanks,
> 
> greg k-h

Thanks for the advises,

Marcelo
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: Work on iio: stating: frequency: ad9832

[Marcelo Schmitt]

On 04/02, Alexandru Ardelean wrote:
> On Mon, Apr 1, 2019 at 7:13 PM Jonathan Cameron
>  wrote:
> >
> > On Mon, 1 Apr 2019 11:25:29 -0300
> > Marcelo Schmitt  wrote:
> >
> > > Hello,
> > >
> > > I was looking for some work on staging: iio: ad9832 and made some
> > > observations while reading the driver.
> > >
> > > Apparently it had no devicetree documentation so I tried to elaborate
> > > one.
> > > It uses a platform_data variable to load external clock
> > > frequency (I tried to make it use linux's clock framework).
> > Good.
> >
> > > Some device attributes don't seem to be standardized on
> > > Documentation/ABI/testing/sysfs-bus-iio and there's no specific ABI
> > > for ad9832 nearby nor at staging/iio/Documentation. So maybe those
> > > missing ABI could be documented.
> > Beware. It's an old driver, so it may be that we actually want to change
> > it's ABI rather than documenting what is there (I have haven't looked!)
> >

OK, I'll take more time studying the device's datasheet to better 
understand the current ABI.

> 
> This one can actually be coupled a bit with the AD9834 driver.
> There's been some work on trying to move that one out of staging as well.
> 
> You can take a look at the patches sent for that driver.
> They should be find-able on patchwork
> https://patchwork.kernel.org/project/linux-iio/list/?series=&submitter=&state=*&q=ad9834&archive=both&delegate=
> 
> There are ideas worth borrowing from there.
> 
> The issue with the AD9834 [if i recall correctly] is that it doesn't
> quite fit the classical IIO channel model.
> Meaning, you can only activate the output of one channel at one moment
> in time, and not both.

OK, I'll have a look at it.

> 
> > > The device has to set some internal registers to operate correctly,
> > > AD9832_FREQXHM and AD9832_PHASEXH, would it be feasible to set iio
> > > chanels for this?
> >
> > What are they?  If they correspond to output channels in some sensible
> > way then maybe...
> >
> > > I couldn't understand why checkpatch.pl gave errors on IIO_DEV_ATTR_*
> > > macros. To me they seem to have no problem.
> > > Also it has that platform_data to be moved to include/linux/iio. Is
> > > there any special reason for it not being there already? Which are
> > > the criterions a platform_data need to satisfy to be put there?
> > A driver moving out of staging shouldn't have platform data. It needs
> > to be converted over to more modern mechanisms.   We don't have a problem
> > supporting platform data for devices that have old school device files
> > already in tree, but that shouldn't be the case for a driver in staging.
> >
> > Hence we can clean it up and move forward with just DT bindings.
> > >

Understood. Thanks for the explanation.

> > > I'm sending a patchset with some things I've already done.
> > Cool. I'll look at those later in the week if no one beats me to them.
> >
> > >
> > > Is there something else that could be done in this device driver?
> > > Please, tell if I've forgotten something.
> >
> > I'll take a look, but it may be a little while before I do.
> > Hopefully someone else gets there first!
> >
> > Jonathan
> >
> > >
> > > Any advice is welcome.
> > > Thanks,
> > >
> > > Marcelo
> >
> >

Thanks for the pieces of advice.

Marcelo
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 4/4] staging: iio: ad9832: add devicetree documentation

[Marcelo Schmitt]

On 04/02, Alexandru Ardelean wrote:
> On Mon, Apr 1, 2019 at 5:38 PM Marcelo Schmitt
>  wrote:
> >
> > Add a devicetree documentation for the ad9832 direct digital
> > synthesizer, waveform generator.
> >
> > Signed-off-by: Marcelo Schmitt 
> > ---
> >  .../bindings/iio/frequency/ad9832.txt | 26 +++
> >  1 file changed, 26 insertions(+)
> >  create mode 100644 
> > Documentation/devicetree/bindings/iio/frequency/ad9832.txt
> >
> > diff --git a/Documentation/devicetree/bindings/iio/frequency/ad9832.txt 
> > b/Documentation/devicetree/bindings/iio/frequency/ad9832.txt
> > new file mode 100644
> > index ..6a35fdff5a48
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/iio/frequency/ad9832.txt
> > @@ -0,0 +1,26 @@
> > +Analog Devices AD9832 Direct Digital Synthesizer, Waveform Generator
> > +
> > +Data sheet:
> > +https://www.analog.com/media/en/technical-documentation/data-sheets/AD9832.pdf
> > +
> > +Required properties:
> > +   - compatible : Must be "adi,ad9832"
> > +   - reg : SPI chip select number for the device
> > +   - spi-max-frequency = Max SPI frequency to use (< 2500)
> > +   - clocks : The clock reference for the DDS output
> > +   - clock-names : Must be "mclk"
> 
> It's always a good idea to reference other base dt docs.
> For SPI you could:
> 
> ```
> For more information on SPI properties, please consult
>  Documentation/devicetree/bindings/spi/spi-bus.txt
> ```
> 
> For clock:
> ```
> For more information on clock bindings properties, please consult
>  Documentation/devicetree/bindings/clock/clock-bindings.txt
> ```
> 
> For regulator:
> ```
> For more information on regulator bindings properties, please consult
>  Documentation/devicetree/bindings/regulator/regulator.txt
> ```

Thanks for the advice. I'll have a look at them.

> 
> > +
> > +Optional properties:
> > +   - avdd-supply:  Definition of the regulator used as analog supply
> > +   - dvdd-supply : Definition of the regulator used as digital supply
> > +
> > +Example:
> > +   adi9832-dds@0 {
> > +   compatible = "adi,ad9832";
> > +   reg = <0>;
> > +   spi-max-frequency = <2500>;
> > +   clocks = <&ad9832_mclk>;
> > +   clock-names = "mclk";
> > +   avdd-suppy = <&avdd>;
> > +   dvdd-suppy = <&dvdd>;
> > +   };
> > --
> > 2.20.1
> >
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[driver-core:driver-core-testing 4/14] arch/ia64/kernel/acpi.c:669:38: error: passing argument 2 of 'acpi_table_parse' from incompatible pointer type

[kbuild test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git 
driver-core-testing
head:   5e29ef654e7be73a579b96c1b912dac5cea33046
commit: 088d0b345be1952be1a5004fb78cfffa0835cbe1 [4/14] acpi: Create subtable 
parsing infrastructure
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 8.1.0
reproduce:
wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 088d0b345be1952be1a5004fb78cfffa0835cbe1
# save the attached .config to linux build tree
GCC_VERSION=8.1.0 make.cross ARCH=ia64 

All errors (new ones prefixed by >>):

   arch/ia64/kernel/acpi.c: In function 'early_acpi_boot_init':
>> arch/ia64/kernel/acpi.c:669:38: error: passing argument 2 of 
>> 'acpi_table_parse' from incompatible pointer type 
>> [-Werror=incompatible-pointer-types]
 if (acpi_table_parse(ACPI_SIG_MADT, acpi_parse_madt)) {
 ^~~
   In file included from arch/ia64/kernel/acpi.c:43:
   include/linux/acpi.h:241:55: note: expected 'acpi_tbl_table_handler' {aka 
'int (*)(struct acpi_table_header *)'} but argument is of type 'int (*)(union 
acpi_subtable_headers *)'
int acpi_table_parse(char *id, acpi_tbl_table_handler handler);
   ~~~^~~
   arch/ia64/kernel/acpi.c: In function 'acpi_boot_init':
   arch/ia64/kernel/acpi.c:710:38: error: passing argument 2 of 
'acpi_table_parse' from incompatible pointer type 
[-Werror=incompatible-pointer-types]
 if (acpi_table_parse(ACPI_SIG_MADT, acpi_parse_madt)) {
 ^~~
   In file included from arch/ia64/kernel/acpi.c:43:
   include/linux/acpi.h:241:55: note: expected 'acpi_tbl_table_handler' {aka 
'int (*)(struct acpi_table_header *)'} but argument is of type 'int (*)(union 
acpi_subtable_headers *)'
int acpi_table_parse(char *id, acpi_tbl_table_handler handler);
   ~~~^~~
   cc1: some warnings being treated as errors

vim +/acpi_table_parse +669 arch/ia64/kernel/acpi.c

^1da177e Linus Torvalds 2005-04-16  660  
62ee0540 Doug Chapman   2008-11-05  661  int __init early_acpi_boot_init(void)
62ee0540 Doug Chapman   2008-11-05  662  {
62ee0540 Doug Chapman   2008-11-05  663 int ret;
62ee0540 Doug Chapman   2008-11-05  664  
62ee0540 Doug Chapman   2008-11-05  665 /*
62ee0540 Doug Chapman   2008-11-05  666  * do a partial walk of MADT to 
determine how many CPUs
62ee0540 Doug Chapman   2008-11-05  667  * we have including offline 
CPUs
62ee0540 Doug Chapman   2008-11-05  668  */
62ee0540 Doug Chapman   2008-11-05 @669 if 
(acpi_table_parse(ACPI_SIG_MADT, acpi_parse_madt)) {
62ee0540 Doug Chapman   2008-11-05  670 printk(KERN_ERR PREFIX 
"Can't find MADT\n");
62ee0540 Doug Chapman   2008-11-05  671 return 0;
62ee0540 Doug Chapman   2008-11-05  672 }
62ee0540 Doug Chapman   2008-11-05  673  
62ee0540 Doug Chapman   2008-11-05  674 ret = 
acpi_table_parse_madt(ACPI_MADT_TYPE_LOCAL_SAPIC,
62ee0540 Doug Chapman   2008-11-05  675 acpi_parse_lsapic, 
NR_CPUS);
62ee0540 Doug Chapman   2008-11-05  676 if (ret < 1)
62ee0540 Doug Chapman   2008-11-05  677 printk(KERN_ERR PREFIX
62ee0540 Doug Chapman   2008-11-05  678"Error parsing 
MADT - no LAPIC entries\n");
247dba58 Baoquan He 2014-05-05  679 else
247dba58 Baoquan He 2014-05-05  680 acpi_lapic = 1;
62ee0540 Doug Chapman   2008-11-05  681  

:: The code at line 669 was first introduced by commit
:: 62ee0540f5e5a804b79cae8b3c0185a85f02436b [IA64] fix boot panic caused by 
offline CPUs

:: TO: Doug Chapman 
:: CC: Tony Luck 

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation


.config.gz
Description: application/gzip
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 15/16] staging: media: imx: add proper SPDX identifiers on files that did not have them.

[Steve Longerbeam]

Acked-by: Steve Longerbeam 


On 4/2/19 3:32 AM, Greg Kroah-Hartman wrote:

There were a few files for the imx media drivers that did not have SPDX
identifiers on them, so fix that up.  At the same time, remove the "free
form" text that specified the license of the file, as that is impossible
for any tool to properly parse.

Cc: Steve Longerbeam 
Cc: Philipp Zabel 
Cc: Mauro Carvalho Chehab 
Cc: Shawn Guo 
Cc: Sascha Hauer 
Cc: Fabio Estevam 
Cc: NXP Linux Team 
Cc: linux-me...@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman 
---
  drivers/staging/media/imx/imx-ic-common.c | 6 +-
  drivers/staging/media/imx/imx-ic-prp.c| 6 +-
  drivers/staging/media/imx/imx-ic-prpencvf.c   | 6 +-
  drivers/staging/media/imx/imx-ic.h| 6 +-
  drivers/staging/media/imx/imx-media-capture.c | 6 +-
  drivers/staging/media/imx/imx-media-csi.c | 6 +-
  drivers/staging/media/imx/imx-media-dev.c | 6 +-
  drivers/staging/media/imx/imx-media-fim.c | 6 +-
  drivers/staging/media/imx/imx-media-internal-sd.c | 6 +-
  drivers/staging/media/imx/imx-media-of.c  | 6 +-
  drivers/staging/media/imx/imx-media-utils.c   | 6 +-
  drivers/staging/media/imx/imx-media-vdic.c| 6 +-
  drivers/staging/media/imx/imx-media.h | 6 +-
  drivers/staging/media/imx/imx6-mipi-csi2.c| 6 +-
  14 files changed, 14 insertions(+), 70 deletions(-)

diff --git a/drivers/staging/media/imx/imx-ic-common.c 
b/drivers/staging/media/imx/imx-ic-common.c
index 765919487a73..7e2455097315 100644
--- a/drivers/staging/media/imx/imx-ic-common.c
+++ b/drivers/staging/media/imx/imx-ic-common.c
@@ -1,12 +1,8 @@
+// SPDX-License-Identifier: GPL-2.0+
  /*
   * V4L2 Image Converter Subdev for Freescale i.MX5/6 SOC
   *
   * Copyright (c) 2014-2016 Mentor Graphics Inc.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
   */
  #include 
  #include 
diff --git a/drivers/staging/media/imx/imx-ic-prp.c 
b/drivers/staging/media/imx/imx-ic-prp.c
index 3d43cdcb4bb9..10ffe00f1a54 100644
--- a/drivers/staging/media/imx/imx-ic-prp.c
+++ b/drivers/staging/media/imx/imx-ic-prp.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0+
  /*
   * V4L2 Capture IC Preprocess Subdev for Freescale i.MX5/6 SOC
   *
@@ -6,11 +7,6 @@
   * for resizing, colorspace conversion, and rotation.
   *
   * Copyright (c) 2012-2017 Mentor Graphics Inc.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
   */
  #include 
  #include 
diff --git a/drivers/staging/media/imx/imx-ic-prpencvf.c 
b/drivers/staging/media/imx/imx-ic-prpencvf.c
index 5c8e6ad8c025..1ba4a5154fb5 100644
--- a/drivers/staging/media/imx/imx-ic-prpencvf.c
+++ b/drivers/staging/media/imx/imx-ic-prpencvf.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0+
  /*
   * V4L2 Capture IC Preprocess Subdev for Freescale i.MX5/6 SOC
   *
@@ -6,11 +7,6 @@
   * for resizing, colorspace conversion, and rotation.
   *
   * Copyright (c) 2012-2017 Mentor Graphics Inc.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
   */
  #include 
  #include 
diff --git a/drivers/staging/media/imx/imx-ic.h 
b/drivers/staging/media/imx/imx-ic.h
index 6b2267bda8ab..0dbcf2a7ab5f 100644
--- a/drivers/staging/media/imx/imx-ic.h
+++ b/drivers/staging/media/imx/imx-ic.h
@@ -1,12 +1,8 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
  /*
   * V4L2 Image Converter Subdev for Freescale i.MX5/6 SOC
   *
   * Copyright (c) 2016 Mentor Graphics Inc.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
   */
  #ifndef _IMX_IC_H
  #define _IMX_IC_H
diff --git a/drivers/staging/media/imx/imx-media-capture.c 
b/drivers/staging/media/imx/imx-media-capture.c
index facce18975d8..b7ce9d439279 100644
--- a/drivers/staging/media/imx/imx-media-capture.c
+++ b/drivers/staging/media/imx/imx-media-capture.c
@@ -1,12 +1,8 @@
+// SPDX-License-Identifier: GPL-2.0+
  /*
   * Video Capture Subdev for Freescale i.MX5/6 SOC
   *
   * Copyright (c) 2012-2016 Mentor Graphics Inc.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * th

Your Outward Payment Advice, ACC: 01XXXXX3404 dated 02-April-2019

[eAdvices . UAE]

Dear Customer,
Thank you for banking with Standard Chartered Bank

Attached is your Debit Advice as per your request. Kindly note 
that your e-Advice is in PDF format.
If you are unable to open the attachment please download Adobe 
Acrobat Reader by clicking at:
www.adobe.com

The PDF file is password protected. Please use your eleven (11) 
digits Account Number (without any
space or special character) as password to open this file.

This is a system generated mail. We request you not to reply to 
this message. If you have any query,
please call our Contact Centre.
https://mail.google.com/mail/#inbox?compose=14e7c486d62a0b0e
UAE Call Centre : 600 5222 88.

Cash Management Operations
Standard Chartered Bank
Disclaimer

This email and any attachments are confidential and may also be 
privileged. If you are not the
intended recipient, please delete all copies and notify the 
sender immediately. You may wish to
refer to the incorporation details of Standard Chartered PLC, 
Standard Chartered Bank and their
subsidiaries at https://www.sc.com/en/incorporation-details.html

OT_DR_OT02091507110183_110720151227372737.xlsx
Description: Binary data
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 03/16] staging: m57621-mmc: delete driver from the tree.

[NeilBrown]

On Tue, Apr 02 2019, George Hilliard wrote:

> On Tue, Apr 2, 2019, 5:32 AM Greg Kroah-Hartman 
> wrote:
>
>> The license text in this driver is "interesting" and not really obvious
>> that it is supposed to be able to be distributed in the kernel source
>> tree.  Yes, the MODULE_LICENSE() text says GPL, so it's probably ok, but
>> to be safe, I am deleting this driver.  I will be glad to add it back if
>> the license is properly sorted out, but for now, this isn't worth the
>> potential risk, I should have never taken it in the first place.
>>
>
> So, for what it's worth, this driver has an obvious heritage of having been
> modified from the main Mediatek MMC driver. Now, of course it's *possible*
> to distribute GPL-incompatible changes to a GPL program, but the only
> *compliant* way to distribute these changes would have been the GPL.
>
> So there's a very good chance that it's intended to be GPL.  (Which is
> good, because I need this driver!)  I suppose we need to reach out to the
> original contributor.

People keep telling me that drivers/mmc/host/mtk-sd.c should be able to
handle the same hardware as this driver, with a little bit of work.
Unfortunately they haven't told me what the little bit of work involves.

Have you explored that possibility at all?  I might try to have a look
if I can make time.

NeilBrown


signature.asc
Description: PGP signature
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: iio: frequency: ad9834: Remove unnecessary parentheses

[Melissa Wen]

Remove unneeded parentheses around the arguments of ||. This reduces
clutter and code behave in the same way. Change suggested by
checkpatch.pl.

CHECK: Unnecessary parentheses around 'st->devid == ID_AD9833'
CHECK: Unnecessary parentheses around 'st->devid == ID_AD9837'

Signed-off-by: Melissa Wen 
---
 drivers/staging/iio/frequency/ad9834.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/iio/frequency/ad9834.c 
b/drivers/staging/iio/frequency/ad9834.c
index 0b0287503fb4..9cc6e751b479 100644
--- a/drivers/staging/iio/frequency/ad9834.c
+++ b/drivers/staging/iio/frequency/ad9834.c
@@ -286,7 +286,7 @@ ssize_t ad9834_show_out0_wavetype_available(struct device 
*dev,
struct ad9834_state *st = iio_priv(indio_dev);
char *str;
 
-   if ((st->devid == ID_AD9833) || (st->devid == ID_AD9837))
+   if (st->devid == ID_AD9833 || st->devid == ID_AD9837)
str = "sine triangle square";
else if (st->control & AD9834_OPBITEN)
str = "sine";
-- 
2.20.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 03/16] staging: m57621-mmc: delete driver from the tree.

[Christian Lütke-Stetzkamp]

On Wed, Apr 03, 2019 at 06:51:49AM +1100, NeilBrown wrote:
> People keep telling me that drivers/mmc/host/mtk-sd.c should be able to
> handle the same hardware as this driver, with a little bit of work.
> Unfortunately they haven't told me what the little bit of work involves.
> 
> Have you explored that possibility at all?  I might try to have a look
> if I can make time.

I have started to look into it, when I was working on that
driver. First sorry for me doing nothing in the last few
month. Generally the two drivers seem to be very similar, the main
difference is the code for tuning. In the staging driver. this is a
total mess. It tries to account for tuning itself, so it also tries to
account which command was executed (succesfully) before a tuning is
necessary and reexecutes it, when it was the APP_CMD. But there are
still some differences in the tuning code, that are not due to
handling it in the driver.

If have mainly understand how to remove the 'in driver handling' of
the tuning and thing I could prepare a patch for that. But the
differences in the tuning code itself, I do not understand
completely.

There are two other larger differences that I found during my
work. One is that drivers/mmc/host/mtk-sd.c has much more features,
like voltage and clock handling and some support for high speed
modes. I don't know if these features are required/useful for this
device. The other thing is the card detect handling. This driver is
doing the card detect / read only detection on its own, where the in
tree one just uses some default gpio functions there and I don't know
weather this must be changed or weather there is a gpio driver for the
mt7621.

That is all I currently remember. Hope it helps.

Christian
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 03/16] staging: m57621-mmc: delete driver from the tree.

[NeilBrown]

On Tue, Apr 02 2019, Christian Lütke-Stetzkamp wrote:

> On Wed, Apr 03, 2019 at 06:51:49AM +1100, NeilBrown wrote:
>> People keep telling me that drivers/mmc/host/mtk-sd.c should be able to
>> handle the same hardware as this driver, with a little bit of work.
>> Unfortunately they haven't told me what the little bit of work involves.
>> 
>> Have you explored that possibility at all?  I might try to have a look
>> if I can make time.
>
> I have started to look into it, when I was working on that
> driver. First sorry for me doing nothing in the last few
> month. Generally the two drivers seem to be very similar, the main
> difference is the code for tuning. In the staging driver. this is a
> total mess. It tries to account for tuning itself, so it also tries to
> account which command was executed (succesfully) before a tuning is
> necessary and reexecutes it, when it was the APP_CMD. But there are
> still some differences in the tuning code, that are not due to
> handling it in the driver.
>
> If have mainly understand how to remove the 'in driver handling' of
> the tuning and thing I could prepare a patch for that. But the
> differences in the tuning code itself, I do not understand
> completely.
>
> There are two other larger differences that I found during my
> work. One is that drivers/mmc/host/mtk-sd.c has much more features,
> like voltage and clock handling and some support for high speed
> modes. I don't know if these features are required/useful for this
> device. The other thing is the card detect handling. This driver is
> doing the card detect / read only detection on its own, where the in
> tree one just uses some default gpio functions there and I don't know
> weather this must be changed or weather there is a gpio driver for the
> mt7621.
>
> That is all I currently remember. Hope it helps.
>
> Christian

Thanks, it might be.
Other info I have received at
   https://github.com/gnubee-git/GnuBee_Docs/issues/75#issuecomment-479216537

is that there might be something worth examining at

 
https://github.com/jonpry/openwrt_mt7688/commit/a85e6d99899f3dc1204cd5bfba944e17bfa6178f
 
https://github.com/jonpry/openwrt_mt7688/commit/24878467a650d765b747618de1a575e79114b764

A few notes: The MMC driver there is basically the 4.9 mtk-sd
one with all the patches from maybe 4.17 or 4.18 backported.

and that a diff against current mainline here:

  https://gist.github.com/neheb/3d9e4cbf966f8487114df19b49f28214

might be useful.

I'll look more on the weekend if no-one beats me to it.

NeilBrown



signature.asc
Description: PGP signature
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] media: zoran: remove unnecessary space

[Gilberto Martinez Jr]

fix the following errors from checkpath:

WARNING: Unnecessary space before function pointer arguments
+   void (*init) (struct zoran *zr);

Signed-off-by: Gilberto Martinez Jr 
---
 drivers/staging/media/zoran/zoran.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/media/zoran/zoran.h 
b/drivers/staging/media/zoran/zoran.h
index 35f74ce53eeb..dc91e5196b12 100644
--- a/drivers/staging/media/zoran/zoran.h
+++ b/drivers/staging/media/zoran/zoran.h
@@ -262,7 +262,7 @@ struct card_info {
/* avs6eyes mux setting */
u8 input_mux;
 
-   void (*init) (struct zoran *zr);
+   void (*init)(struct zoran *zr);
 };
 
 struct zoran {
-- 
2.17.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] Staging: rtl8192e: Fix spaces around "+"

[Hildo Guillardi Júnior]

Fix checkpatch error:
CHECK: spaces preferred around that '+' (ctx:VxV)
99: FILE: drivers/staging/rtl8192e/rtllib_module.c:99:
+   memset(ieee, 0, sizeof(struct rtllib_device)+sizeof_priv);

Signed-off-by: Hildo Guillardi Júnior 
---
 drivers/staging/rtl8192e/rtllib_module.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8192e/rtllib_module.c 
b/drivers/staging/rtl8192e/rtllib_module.c
index cdf4c9060c51..a19b56320f2e 100644
--- a/drivers/staging/rtl8192e/rtllib_module.c
+++ b/drivers/staging/rtl8192e/rtllib_module.c
@@ -96,7 +96,7 @@ struct net_device *alloc_rtllib(int sizeof_priv)
return NULL;
}
ieee = (struct rtllib_device *)netdev_priv_rsl(dev);
-   memset(ieee, 0, sizeof(struct rtllib_device)+sizeof_priv);
+   memset(ieee, 0, sizeof(struct rtllib_device) + sizeof_priv);
ieee->dev = dev;
 
err = rtllib_networks_allocate(ieee);
-- 
2.17.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: gdm724x: Add parenthesis to Macro arguments

[Andre Dainez]

Fix checkpatch errors:

CHECK: Macro argument 'len' may be better as '(len)' to avoid precedence issues
CHECK: Macro argument 'nlh' may be better as '(nlh)' to avoid precedence issues

Signed-off-by: Andre Dainez 
---
 drivers/staging/gdm724x/netlink_k.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/gdm724x/netlink_k.c 
b/drivers/staging/gdm724x/netlink_k.c
index 92440c3..36d88f4 100644
--- a/drivers/staging/gdm724x/netlink_k.c
+++ b/drivers/staging/gdm724x/netlink_k.c
@@ -19,8 +19,8 @@ static DEFINE_MUTEX(netlink_mutex);
 #define ND_NLMSG_SPACE(len)(NLMSG_SPACE(len) + ND_IFINDEX_LEN)
 #define ND_NLMSG_DATA(nlh) ((void *)((char *)NLMSG_DATA(nlh) + \
  ND_IFINDEX_LEN))
-#define ND_NLMSG_S_LEN(len)(len + ND_IFINDEX_LEN)
-#define ND_NLMSG_R_LEN(nlh)(nlh->nlmsg_len - ND_IFINDEX_LEN)
+#define ND_NLMSG_S_LEN(len)((len) + ND_IFINDEX_LEN)
+#define ND_NLMSG_R_LEN(nlh)((nlh)->nlmsg_len - ND_IFINDEX_LEN)
 #define ND_NLMSG_IFIDX(nlh)NLMSG_DATA(nlh)
 #define ND_MAX_MSG_LEN (1024 * 32)
 
-- 
2.7.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: vchiq_arm: remove space after open '('

[Mario Balan]

Fix checkpatch error "ERROR: space prohibited after that open
parenthesis '('" in vchiq_arm.c:563.

Signed-off-by: Mario Balan 
---
 drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c 
b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
index 6dad624d0e49..a3eb99664a1c 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
@@ -560,7 +560,7 @@ add_completion(VCHIQ_INSTANCE_T instance, VCHIQ_REASON_T 
reason,
vchiq_log_trace(vchiq_arm_log_level,
"%s - completion queue full", __func__);
DEBUG_COUNT(COMPLETION_QUEUE_FULL_COUNT);
-   if (wait_for_completion_killable( &instance->remove_event)) {
+   if (wait_for_completion_killable(&instance->remove_event)) {
vchiq_log_info(vchiq_arm_log_level,
"service_callback interrupted");
return VCHIQ_RETRY;
-- 
2.11.0

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: gdm724x: Add parenthesis to Macro arguments

[Greg KH]

On Tue, Apr 02, 2019 at 10:04:05PM -0300, Andre Dainez wrote:
> Fix checkpatch errors:
> 
> CHECK: Macro argument 'len' may be better as '(len)' to avoid precedence 
> issues
> CHECK: Macro argument 'nlh' may be better as '(nlh)' to avoid precedence 
> issues
> 
> Signed-off-by: Andre Dainez 
> ---
>  drivers/staging/gdm724x/netlink_k.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/gdm724x/netlink_k.c 
> b/drivers/staging/gdm724x/netlink_k.c
> index 92440c3..36d88f4 100644
> --- a/drivers/staging/gdm724x/netlink_k.c
> +++ b/drivers/staging/gdm724x/netlink_k.c
> @@ -19,8 +19,8 @@ static DEFINE_MUTEX(netlink_mutex);
>  #define ND_NLMSG_SPACE(len)  (NLMSG_SPACE(len) + ND_IFINDEX_LEN)
>  #define ND_NLMSG_DATA(nlh)   ((void *)((char *)NLMSG_DATA(nlh) + \
> ND_IFINDEX_LEN))
> -#define ND_NLMSG_S_LEN(len)  (len + ND_IFINDEX_LEN)
> -#define ND_NLMSG_R_LEN(nlh)  (nlh->nlmsg_len - ND_IFINDEX_LEN)
> +#define ND_NLMSG_S_LEN(len)  ((len) + ND_IFINDEX_LEN)

This makes sense, but:

> +#define ND_NLMSG_R_LEN(nlh)  ((nlh)->nlmsg_len - ND_IFINDEX_LEN)

That does not, correct?
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel