[PATCH] staging: android: ion: Replace strncpy() for stracpy()
Using strncpy() does not always terminate the destination string.
stracpy() is a alternative function that does, by using this new
function we will no longer need to insert a null separator.
Signed-off-by: Adam Zerella
---
drivers/staging/android/ion/ion.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/android/ion/ion.c
b/drivers/staging/android/ion/ion.c
index e6b1ca141b93..17901bd626be 100644
--- a/drivers/staging/android/ion/ion.c
+++ b/drivers/staging/android/ion/ion.c
@@ -433,8 +433,7 @@ static int ion_query_heaps(struct ion_heap_query *query)
max_cnt = query->cnt;
plist_for_each_entry(heap, >heaps, node) {
- strncpy(hdata.name, heap->name, MAX_HEAP_NAME);
- hdata.name[sizeof(hdata.name) - 1] = '\0';
+ stracpy(hdata.name, heap->name, MAX_HEAP_NAME);
hdata.type = heap->type;
hdata.heap_id = heap->id;
--
2.21.0
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 2/2 v2] staging: exfat: cleanup casts
Use constants and fix checkpatch.pl warnings:
CHECK: No space is necessary after a cast
Signed-off-by: Valentin Vidic
---
v2: Use constants where possible
drivers/staging/exfat/exfat_core.c | 94 ++---
drivers/staging/exfat/exfat_super.c | 66 ++--
2 files changed, 80 insertions(+), 80 deletions(-)
diff --git a/drivers/staging/exfat/exfat_core.c
b/drivers/staging/exfat/exfat_core.c
index 8fb4ce16010c..6eee2aa06bd7 100644
--- a/drivers/staging/exfat/exfat_core.c
+++ b/drivers/staging/exfat/exfat_core.c
@@ -204,7 +204,7 @@ s32 fat_alloc_cluster(struct super_block *sb, s32 num_alloc,
if ((--num_alloc) == 0) {
p_fs->clu_srch_ptr = new_clu;
- if (p_fs->used_clusters != (u32) ~0)
+ if (p_fs->used_clusters != UINT_MAX)
p_fs->used_clusters += num_clusters;
return num_clusters;
@@ -215,7 +215,7 @@ s32 fat_alloc_cluster(struct super_block *sb, s32 num_alloc,
}
p_fs->clu_srch_ptr = new_clu;
- if (p_fs->used_clusters != (u32) ~0)
+ if (p_fs->used_clusters != UINT_MAX)
p_fs->used_clusters += num_clusters;
return num_clusters;
@@ -273,7 +273,7 @@ s32 exfat_alloc_cluster(struct super_block *sb, s32
num_alloc,
if ((--num_alloc) == 0) {
p_fs->clu_srch_ptr = hint_clu;
- if (p_fs->used_clusters != (u32) ~0)
+ if (p_fs->used_clusters != UINT_MAX)
p_fs->used_clusters += num_clusters;
p_chain->size += num_clusters;
@@ -293,7 +293,7 @@ s32 exfat_alloc_cluster(struct super_block *sb, s32
num_alloc,
}
p_fs->clu_srch_ptr = hint_clu;
- if (p_fs->used_clusters != (u32) ~0)
+ if (p_fs->used_clusters != UINT_MAX)
p_fs->used_clusters += num_clusters;
p_chain->size += num_clusters;
@@ -337,7 +337,7 @@ void fat_free_cluster(struct super_block *sb, struct
chain_t *p_chain,
} while (clu != CLUSTER_32(~0));
- if (p_fs->used_clusters != (u32) ~0)
+ if (p_fs->used_clusters != UINT_MAX)
p_fs->used_clusters -= num_clusters;
}
@@ -396,7 +396,7 @@ void exfat_free_cluster(struct super_block *sb, struct
chain_t *p_chain,
} while ((clu != CLUSTER_32(0)) && (clu != CLUSTER_32(~0)));
}
- if (p_fs->used_clusters != (u32) ~0)
+ if (p_fs->used_clusters != UINT_MAX)
p_fs->used_clusters -= num_clusters;
}
@@ -473,7 +473,7 @@ s32 exfat_count_used_clusters(struct super_block *sb)
map_i = map_b = 0;
for (i = 2; i < p_fs->num_clusters; i += 8) {
- k = *(((u8 *) p_fs->vol_amap[map_i]->b_data) + map_b);
+ k = *(((u8 *)p_fs->vol_amap[map_i]->b_data) + map_b);
count += used_bit[k];
if ((++map_b) >= p_bd->sector_size) {
@@ -536,7 +536,7 @@ s32 load_alloc_bitmap(struct super_block *sb)
if (ep->flags == 0x0) {
p_fs->map_clu = GET32_A(ep->start_clu);
- map_size = (u32) GET64_A(ep->size);
+ map_size = (u32)GET64_A(ep->size);
p_fs->map_sectors = ((map_size - 1) >>
p_bd->sector_size_bits) + 1;
@@ -601,7 +601,7 @@ s32 set_alloc_bitmap(struct super_block *sb, u32 clu)
sector = START_SECTOR(p_fs->map_clu) + i;
- exfat_bitmap_set((u8 *) p_fs->vol_amap[i]->b_data, b);
+ exfat_bitmap_set((u8 *)p_fs->vol_amap[i]->b_data, b);
return sector_write(sb, sector, p_fs->vol_amap[i], 0);
}
@@ -623,7 +623,7 @@ s32 clr_alloc_bitmap(struct super_block *sb, u32 clu)
sector = START_SECTOR(p_fs->map_clu) + i;
- exfat_bitmap_clear((u8 *) p_fs->vol_amap[i]->b_data, b);
+ exfat_bitmap_clear((u8 *)p_fs->vol_amap[i]->b_data, b);
return sector_write(sb, sector, p_fs->vol_amap[i], 0);
@@ -655,7 +655,7 @@ u32 test_alloc_bitmap(struct super_block *sb, u32 clu)
map_b = (clu >> 3) & p_bd->sector_size_mask;
for (i = 2; i < p_fs->num_clusters; i += 8) {
- k = *(((u8 *) p_fs->vol_amap[map_i]->b_data) + map_b);
+ k = *(((u8 *)p_fs->vol_amap[map_i]->b_data) + map_b);
if (clu_mask > 0) {
k |= clu_mask;
clu_mask = 0;
@@ -728,7 +728,7 @@ static s32 __load_upcase_table(struct super_block *sb,
sector_t sector,
sector++;
for (i = 0; i < p_bd->sector_size && index <= 0x; i += 2) {
- uni = GET16(((u8 *) tmp_bh->b_data) + i);
+ uni = GET16(((u8 *)tmp_bh->b_data) + i);
checksum = ((checksum & 1) ? 0x8000 :
[PATCH] Staging: wlan-ng: parenthesis at end of line fix
Fixed open parenthesis at the end of the line on line 327. Signed-off-by: Sandro Volery --- drivers/staging/wlan-ng/cfg80211.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c index eee1998c4b18..0a4c7415f773 100644 --- a/drivers/staging/wlan-ng/cfg80211.c +++ b/drivers/staging/wlan-ng/cfg80211.c @@ -324,7 +324,8 @@ static int prism2_scan(struct wiphy *wiphy, (i < request->n_channels) && i < ARRAY_SIZE(prism2_channels); i++) msg1.channellist.data.data[i] = - ieee80211_frequency_to_channel( + ieee80211_frequency_to_channel + ( request->channels[i]->center_freq); msg1.channellist.data.len = request->n_channels; -- 2.23.0 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 2/2] staging: exfat: cleanup spacing for casts
On Sat, 2019-09-07 at 18:58 +, Valentin Vidic wrote:
> Fixes checkpatch.pl warnings:
>
> CHECK: No space is necessary after a cast
Please always try to improve the code rather
than shutup checkpatch warnings.
> diff --git a/drivers/staging/exfat/exfat_core.c
> b/drivers/staging/exfat/exfat_core.c
[]
> @@ -204,7 +204,7 @@ s32 fat_alloc_cluster(struct super_block *sb, s32
> num_alloc,
>
> if ((--num_alloc) == 0) {
> p_fs->clu_srch_ptr = new_clu;
> - if (p_fs->used_clusters != (u32) ~0)
> + if (p_fs->used_clusters != (u32)~0)
Probably better as UINT_MAX
etc...
> @@ -3678,7 +3678,7 @@ static int parse_options(char *options, int silent, int
> *debug,
> opts->fs_uid = current_uid();
> opts->fs_gid = current_gid();
> opts->fs_fmask = opts->fs_dmask = current->fs->umask;
> - opts->allow_utime = (unsigned short) -1;
> + opts->allow_utime = (unsigned short)-1;
and maybe U16_MAX
> @@ -3770,7 +3770,7 @@ static int parse_options(char *options, int silent, int
> *debug,
> }
>
> out:
> - if (opts->allow_utime == (unsigned short) -1)
> + if (opts->allow_utime == (unsigned short)-1)
> opts->allow_utime = ~opts->fs_dmask & 0022;
>
> return 0;
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 1/2] staging: exfat: cleanup spacing for operators
Fixes checkpatch.pl warnings:
CHECK: spaces preferred around that '-' (ctx:VxV)
CHECK: spaces preferred around that '+' (ctx:VxV)
CHECK: spaces preferred around that '*' (ctx:VxV)
CHECK: spaces preferred around that '|' (ctx:VxV)
Signed-off-by: Valentin Vidic
---
drivers/staging/exfat/exfat.h | 2 +-
drivers/staging/exfat/exfat_core.c | 76 ++---
drivers/staging/exfat/exfat_super.c | 44 -
3 files changed, 61 insertions(+), 61 deletions(-)
diff --git a/drivers/staging/exfat/exfat.h b/drivers/staging/exfat/exfat.h
index 0aa14dea4e09..6c12f2d79f4d 100644
--- a/drivers/staging/exfat/exfat.h
+++ b/drivers/staging/exfat/exfat.h
@@ -159,7 +159,7 @@
/* Upcase table macro */
#define HIGH_INDEX_BIT (8)
#define HIGH_INDEX_MASK(0xFF00)
-#define LOW_INDEX_BIT (16-HIGH_INDEX_BIT)
+#define LOW_INDEX_BIT (16 - HIGH_INDEX_BIT)
#define UTBL_ROW_COUNT BIT(LOW_INDEX_BIT)
#define UTBL_COL_COUNT BIT(HIGH_INDEX_BIT)
diff --git a/drivers/staging/exfat/exfat_core.c
b/drivers/staging/exfat/exfat_core.c
index 995358cc7c79..8fb4ce16010c 100644
--- a/drivers/staging/exfat/exfat_core.c
+++ b/drivers/staging/exfat/exfat_core.c
@@ -230,7 +230,7 @@ s32 exfat_alloc_cluster(struct super_block *sb, s32
num_alloc,
hint_clu = p_chain->dir;
if (hint_clu == CLUSTER_32(~0)) {
- hint_clu = test_alloc_bitmap(sb, p_fs->clu_srch_ptr-2);
+ hint_clu = test_alloc_bitmap(sb, p_fs->clu_srch_ptr - 2);
if (hint_clu == CLUSTER_32(~0))
return 0;
} else if (hint_clu >= p_fs->num_clusters) {
@@ -242,7 +242,7 @@ s32 exfat_alloc_cluster(struct super_block *sb, s32
num_alloc,
p_chain->dir = CLUSTER_32(~0);
- while ((new_clu = test_alloc_bitmap(sb, hint_clu-2)) != CLUSTER_32(~0))
{
+ while ((new_clu = test_alloc_bitmap(sb, hint_clu - 2)) !=
CLUSTER_32(~0)) {
if (new_clu != hint_clu) {
if (p_chain->flags == 0x03) {
exfat_chain_cont_cluster(sb, p_chain->dir,
@@ -251,7 +251,7 @@ s32 exfat_alloc_cluster(struct super_block *sb, s32
num_alloc,
}
}
- if (set_alloc_bitmap(sb, new_clu-2) != FFS_SUCCESS)
+ if (set_alloc_bitmap(sb, new_clu - 2) != FFS_SUCCESS)
return -1;
num_clusters++;
@@ -324,7 +324,7 @@ void fat_free_cluster(struct super_block *sb, struct
chain_t *p_chain,
if (do_relse) {
sector = START_SECTOR(clu);
for (i = 0; i < p_fs->sectors_per_clu; i++)
- buf_release(sb, sector+i);
+ buf_release(sb, sector + i);
}
prev = clu;
@@ -367,10 +367,10 @@ void exfat_free_cluster(struct super_block *sb, struct
chain_t *p_chain,
if (do_relse) {
sector = START_SECTOR(clu);
for (i = 0; i < p_fs->sectors_per_clu; i++)
- buf_release(sb, sector+i);
+ buf_release(sb, sector + i);
}
- if (clr_alloc_bitmap(sb, clu-2) != FFS_SUCCESS)
+ if (clr_alloc_bitmap(sb, clu - 2) != FFS_SUCCESS)
break;
clu++;
@@ -384,10 +384,10 @@ void exfat_free_cluster(struct super_block *sb, struct
chain_t *p_chain,
if (do_relse) {
sector = START_SECTOR(clu);
for (i = 0; i < p_fs->sectors_per_clu; i++)
- buf_release(sb, sector+i);
+ buf_release(sb, sector + i);
}
- if (clr_alloc_bitmap(sb, clu-2) != FFS_SUCCESS)
+ if (clr_alloc_bitmap(sb, clu - 2) != FFS_SUCCESS)
break;
if (FAT_read(sb, clu, ) == -1)
@@ -491,7 +491,7 @@ void exfat_chain_cont_cluster(struct super_block *sb, u32
chain, s32 len)
return;
while (len > 1) {
- if (FAT_write(sb, chain, chain+1) < 0)
+ if (FAT_write(sb, chain, chain + 1) < 0)
break;
chain++;
len--;
@@ -538,7 +538,7 @@ s32 load_alloc_bitmap(struct super_block *sb)
p_fs->map_clu = GET32_A(ep->start_clu);
map_size = (u32) GET64_A(ep->size);
- p_fs->map_sectors = ((map_size-1) >>
p_bd->sector_size_bits) + 1;
+ p_fs->map_sectors = ((map_size - 1) >>
p_bd->sector_size_bits) + 1;
p_fs->vol_amap =
[PATCH 2/2] staging: exfat: cleanup spacing for casts
Fixes checkpatch.pl warnings:
CHECK: No space is necessary after a cast
Signed-off-by: Valentin Vidic
---
drivers/staging/exfat/exfat_core.c | 88 ++---
drivers/staging/exfat/exfat_super.c | 66 +++---
2 files changed, 77 insertions(+), 77 deletions(-)
diff --git a/drivers/staging/exfat/exfat_core.c
b/drivers/staging/exfat/exfat_core.c
index 8fb4ce16010c..64b89ae5af84 100644
--- a/drivers/staging/exfat/exfat_core.c
+++ b/drivers/staging/exfat/exfat_core.c
@@ -204,7 +204,7 @@ s32 fat_alloc_cluster(struct super_block *sb, s32 num_alloc,
if ((--num_alloc) == 0) {
p_fs->clu_srch_ptr = new_clu;
- if (p_fs->used_clusters != (u32) ~0)
+ if (p_fs->used_clusters != (u32)~0)
p_fs->used_clusters += num_clusters;
return num_clusters;
@@ -215,7 +215,7 @@ s32 fat_alloc_cluster(struct super_block *sb, s32 num_alloc,
}
p_fs->clu_srch_ptr = new_clu;
- if (p_fs->used_clusters != (u32) ~0)
+ if (p_fs->used_clusters != (u32)~0)
p_fs->used_clusters += num_clusters;
return num_clusters;
@@ -273,7 +273,7 @@ s32 exfat_alloc_cluster(struct super_block *sb, s32
num_alloc,
if ((--num_alloc) == 0) {
p_fs->clu_srch_ptr = hint_clu;
- if (p_fs->used_clusters != (u32) ~0)
+ if (p_fs->used_clusters != (u32)~0)
p_fs->used_clusters += num_clusters;
p_chain->size += num_clusters;
@@ -293,7 +293,7 @@ s32 exfat_alloc_cluster(struct super_block *sb, s32
num_alloc,
}
p_fs->clu_srch_ptr = hint_clu;
- if (p_fs->used_clusters != (u32) ~0)
+ if (p_fs->used_clusters != (u32)~0)
p_fs->used_clusters += num_clusters;
p_chain->size += num_clusters;
@@ -337,7 +337,7 @@ void fat_free_cluster(struct super_block *sb, struct
chain_t *p_chain,
} while (clu != CLUSTER_32(~0));
- if (p_fs->used_clusters != (u32) ~0)
+ if (p_fs->used_clusters != (u32)~0)
p_fs->used_clusters -= num_clusters;
}
@@ -396,7 +396,7 @@ void exfat_free_cluster(struct super_block *sb, struct
chain_t *p_chain,
} while ((clu != CLUSTER_32(0)) && (clu != CLUSTER_32(~0)));
}
- if (p_fs->used_clusters != (u32) ~0)
+ if (p_fs->used_clusters != (u32)~0)
p_fs->used_clusters -= num_clusters;
}
@@ -473,7 +473,7 @@ s32 exfat_count_used_clusters(struct super_block *sb)
map_i = map_b = 0;
for (i = 2; i < p_fs->num_clusters; i += 8) {
- k = *(((u8 *) p_fs->vol_amap[map_i]->b_data) + map_b);
+ k = *(((u8 *)p_fs->vol_amap[map_i]->b_data) + map_b);
count += used_bit[k];
if ((++map_b) >= p_bd->sector_size) {
@@ -536,7 +536,7 @@ s32 load_alloc_bitmap(struct super_block *sb)
if (ep->flags == 0x0) {
p_fs->map_clu = GET32_A(ep->start_clu);
- map_size = (u32) GET64_A(ep->size);
+ map_size = (u32)GET64_A(ep->size);
p_fs->map_sectors = ((map_size - 1) >>
p_bd->sector_size_bits) + 1;
@@ -601,7 +601,7 @@ s32 set_alloc_bitmap(struct super_block *sb, u32 clu)
sector = START_SECTOR(p_fs->map_clu) + i;
- exfat_bitmap_set((u8 *) p_fs->vol_amap[i]->b_data, b);
+ exfat_bitmap_set((u8 *)p_fs->vol_amap[i]->b_data, b);
return sector_write(sb, sector, p_fs->vol_amap[i], 0);
}
@@ -623,7 +623,7 @@ s32 clr_alloc_bitmap(struct super_block *sb, u32 clu)
sector = START_SECTOR(p_fs->map_clu) + i;
- exfat_bitmap_clear((u8 *) p_fs->vol_amap[i]->b_data, b);
+ exfat_bitmap_clear((u8 *)p_fs->vol_amap[i]->b_data, b);
return sector_write(sb, sector, p_fs->vol_amap[i], 0);
@@ -655,7 +655,7 @@ u32 test_alloc_bitmap(struct super_block *sb, u32 clu)
map_b = (clu >> 3) & p_bd->sector_size_mask;
for (i = 2; i < p_fs->num_clusters; i += 8) {
- k = *(((u8 *) p_fs->vol_amap[map_i]->b_data) + map_b);
+ k = *(((u8 *)p_fs->vol_amap[map_i]->b_data) + map_b);
if (clu_mask > 0) {
k |= clu_mask;
clu_mask = 0;
@@ -728,7 +728,7 @@ static s32 __load_upcase_table(struct super_block *sb,
sector_t sector,
sector++;
for (i = 0; i < p_bd->sector_size && index <= 0x; i += 2) {
- uni = GET16(((u8 *) tmp_bh->b_data) + i);
+ uni = GET16(((u8 *)tmp_bh->b_data) + i);
checksum = ((checksum & 1) ? 0x8000 : 0) +
(checksum >> 1)
DŮLEŽITÉ! Byli jste nahráni ʍasturbovat! Mám Driverdev Devel.mp4!
PRO: driverdev-devel@linuxdriverproject.org Ahoj, Naposledy jste navštívili Ƿorno stránky s dospívajícími, stáhli jste a nainstalovali software, který jsem vytvořil. Můj program zapnul fotoaparát a zaznamenal proces vaší ʍasturbace. Můj software také popadl všechny vaše e-mailové seznamy kontaktů a seznam vašich přátel na Facebooku. Mám - Driverdev Devel.mp4 - s vámi ʍasturbuje na teenageři, stejně jako soubor se všemi kontakty na mém počítači. Jste velmi zvrhlí! Pokud chcete, abych odstranil oba soubory a uchoval tajemství, musíte mi poslat platbu Bitcoinem. Dávám vám 72 hodin na platbu. Pokud nevíte, jak s Bitcoinem platit, navštivte Google a hledejte. Přeneste 50.000 CZK = 0.2050352 BTC na tuto adresu Bitcoin co nejdříve: 3J9oy2ungqnghbyBL8DN7bgVvj7XcWbt9f (kopírování a vkládání) 1 BTC = 244.000 CZK právě teď, takže odešlete přesně 0.2050352 BTC na výše uvedenou adresu. Nesnaž se mě podvádět! Jakmile otevřete tento e-mail, budu vědět, že jste jej otevřeli. Sleduji všechny akce ve vašem zařízení. Tato adresa Bitcoinu je propojena pouze s vámi, takže budu vědět, kdy odešlete správnou částku. Když zaplatíte v plné výši, odstraním oba soubory a deaktivuji program. Pokud platbu neposíláte, pošlu vaše ʍasturbační vίdeo všem vašim přátelům a spolupracovníkům z vašich kontaktních seznamů, které jsem napadl. Zde jsou opět platební údaje: *** Odeslat 50.000 CZK: 0.2050352 BTC k této adrese Bitcoin: 3J9oy2ungqnghbyBL8DN7bgVvj7XcWbt9f (kopírování a vkládání) *** Můžete navštívit policii, ale nikdo vám nemůže pomoci. Vím, co dělám. Nežiji ve vaší zemi a vím, jak zůstat anonymní. Nesnažte se mě oklamat - okamžitě to budu vědět - můj špionážní software nahrává všechny navštívené webové stránky a všechny klávesy, které stisknete. Pokud ano - pošlu tento ošklivý záznam všem, koho znáte, včetně vaší rodiny. Nepodváděj mě! Nezapomeňte na hanbu a pokud tuto zprávu ignorujete, váš život bude zničen. Čekám na vaši platbu Bitcoinem. Zbývá vám 72 hodin. Aʼnonymní Hʌcker P.S. Pokud potřebujete více času na nákup a odeslání BTC, otevřete svůj poznámkový blok a napište - 48H ++ - a uložte. Tímto způsobem mě můžete kontaktovat. Uvažuji o tom, že vám ještě 48 hodin před odesláním vίdea vašim kontaktům, ale pouze tehdy, když vίdím, že se opravdu snažíte koupit bitcoin. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Fixed parentheses malpractice in apex_driver.c
On Sat, Sep 07, 2019 at 04:48:21PM +0200, Sandro Volery wrote: > > Joe's comments are, of course, correct as well. > > > > regards, > > dan carpenter > > > > I'll take a look at Joe's suggestions too sometime tonight. I'd feel kinda > bad tho if I just apply his work and send it in? Don't feel bad. Just do it. Give him credit in the commit message if you want. "Thanks to Joe Perches for his help." I sometimes give people word for word patches and they don't copy it exactly and I wonder if this is why... My exact patch was the best one. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Fixed parentheses malpractice in apex_driver.c
> On 7 Sep 2019, at 16:39, Dan Carpenter wrote: > > You need a subject prefix. It should be something like: > > [PATCH] Staging: gasket: Fix parentheses malpractice in apex_driver.c > Thanks for the reply! I'll try to do that better for my next patch. > Generally "Fix" is considered better style than "Fixed". We aren't > going to care about that in staging, but the patch prefix is mandatory > so you will need to redo it anyway and might as well fix that as well. > >> On Fri, Sep 06, 2019 at 08:38:01PM +0200, volery wrote: >> There were some parentheses at the end of lines, which I took care of. >> This is my first patch. > ^^ > Put this sort of comments after the --- cut off line > >> >> Signed-off-by: Sandro Volery >> --- > ^^^ > Put it here. It will be removed when we apply the patch so it won't > be recorded in the git log. > Alright :) >> drivers/staging/gasket/apex_driver.c | 9 ++--- >> 1 file changed, 6 insertions(+), 3 deletions(-) > > Joe's comments are, of course, correct as well. > > regards, > dan carpenter > I'll take a look at Joe's suggestions too sometime tonight. I'd feel kinda bad tho if I just apply his work and send it in? - Sandro Volery ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Fixed parentheses malpractice in apex_driver.c
You need a subject prefix. It should be something like: [PATCH] Staging: gasket: Fix parentheses malpractice in apex_driver.c Generally "Fix" is considered better style than "Fixed". We aren't going to care about that in staging, but the patch prefix is mandatory so you will need to redo it anyway and might as well fix that as well. On Fri, Sep 06, 2019 at 08:38:01PM +0200, volery wrote: > There were some parentheses at the end of lines, which I took care of. > This is my first patch. ^^ Put this sort of comments after the --- cut off line > > Signed-off-by: Sandro Volery > --- ^^^ Put it here. It will be removed when we apply the patch so it won't be recorded in the git log. > drivers/staging/gasket/apex_driver.c | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) Joe's comments are, of course, correct as well. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
