Re: [PATCH] binder: fix test regression due to sender_euid change
On Fri, Nov 12, 2021 at 1:07 PM Todd Kjos wrote:
>
> This is a partial revert of commit
> 29bc22ac5e5b ("binder: use euid from cred instead of using task").
> Setting sender_euid using proc->cred caused some Android system test
> regressions that need further investigation. It is a partial
> reversion because subsequent patches rely on proc->cred.
>
> Cc: sta...@vger.kernel.org # 4.4+
> Fixes: 29bc22ac5e5b ("binder: use euid from cred instead of using task")
> Signed-off-by: Todd Kjos
> Change-Id: I9b1769a3510fed250bb21859ef8beebabe034c66
> ---
> - the issue was introduced in 5.16-rc1, so please apply to 5.16
> - this should apply cleanly to all stable branches back to 4.4
> that contain "binder: use euid from cred instead of using task"
>
>
> drivers/android/binder.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
This looks okay to me. I assume this is going in via GregKH's tree?
Acked-by: Paul Moore
> diff --git a/drivers/android/binder.c b/drivers/android/binder.c
> index 49fb74196d02..cffbe57a8e08 100644
> --- a/drivers/android/binder.c
> +++ b/drivers/android/binder.c
> @@ -2710,7 +2710,7 @@ static void binder_transaction(struct binder_proc *proc,
> t->from = thread;
> else
> t->from = NULL;
> - t->sender_euid = proc->cred->euid;
> + t->sender_euid = task_euid(proc->tsk);
> t->to_proc = target_proc;
> t->to_thread = target_thread;
> t->code = tr->code;
> --
> 2.34.0.rc1.387.gb447b232ab-goog
--
paul moore
www.paul-moore.com
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v3] staging: vt6655: refactor camelcase uCurrRSSI to current_rssi
> What caused you to pick that one? My mistake :( I was reading "Submitting patches: the essential guide to getting your code into the kernel" and I was confuse dby this line "See the T: entry for the subsystem in the MAINTAINERS file to find that tree, or simply ask the maintainer if the tree is not listed there." supposing that master branch was the correct one. I'm moving on "staging-next" branch as you suggest. Regards, Alberto ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v3] staging: vt6655: refactor camelcase uCurrRSSI to current_rssi
On Fri, Nov 19, 2021 at 02:36:44PM +0100, Alberto Merciai wrote: > driver-core$ ./scripts/get_maintainer.pl drivers/staging/vt6655/device.h > Forest Bond (odd fixer:STAGING - VIA VT665X > DRIVERS) > Greg Kroah-Hartman (supporter:STAGING SUBSYSTEM) > Alberto Merciai > (commit_signer:2/2=100%,authored:2/2=100%,added_lines:2/2=100%,removed_lines:2/2=100%) > de...@driverdev.osuosl.org (open list:STAGING SUBSYSTEM) > linux-ker...@vger.kernel.org (open list) What kernel version is that? The driverdev mailing list is very old and should not be used anymore. Please always work against the latest version of the kernel, and for development stuff, linux-next is usually best so you do not duplicate any work that anyone else has done. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v3] staging: vt6655: refactor camelcase uCurrRSSI to current_rssi
driver-core$ ./scripts/get_maintainer.pl drivers/staging/vt6655/device.h Forest Bond (odd fixer:STAGING - VIA VT665X DRIVERS) Greg Kroah-Hartman (supporter:STAGING SUBSYSTEM) Alberto Merciai (commit_signer:2/2=100%,authored:2/2=100%,added_lines:2/2=100%,removed_lines:2/2=100%) de...@driverdev.osuosl.org (open list:STAGING SUBSYSTEM) linux-ker...@vger.kernel.org (open list) Regards, Alberto On Fri, Nov 19, 2021 at 07:38:32AM +0100, Greg KH wrote: > On Thu, Nov 18, 2021 at 09:27:18PM +0100, Alberto Merciai wrote: > > Replace camelcase variable "uCurrRSSI" (current Received Signal Strength > > Indicator) into linux kernel coding style equivalent > > variable "current_rssi". > > > > Signed-off-by: Alberto Merciai > > --- > > > > v2 > > - correct mailing list > > No, you did not use the correct mailing list. > > What is the output of scripts/get_maintainer.pl on your patch? > > thanks, > > greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v3] staging: vt6655: refactor camelcase uCurrRSSI to current_rssi
A: http://en.wikipedia.org/wiki/Top_post Q: Were do I find info about this thing called top-posting? A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Fri, Nov 19, 2021 at 01:23:51PM +0100, Alberto Merciai wrote: > I'm using the master branch of > https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git/ Very odd, why? That git tree has nothing to do with the staging development process, and especially not the master branch. What caused you to pick that one? thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v3] staging: vt6655: refactor camelcase uCurrRSSI to current_rssi
I'm using the master branch of https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git/ Alberto On Fri, Nov 19, 2021 at 11:51:38AM +0300, Dan Carpenter wrote: > On Thu, Nov 18, 2021 at 09:27:18PM +0100, Alberto Merciai wrote: > > Replace camelcase variable "uCurrRSSI" (current Received Signal Strength > > Indicator) into linux kernel coding style equivalent > > variable "current_rssi". > > > > Signed-off-by: Alberto Merciai > > --- > > > > v2 > > - correct mailing list > > Are you using the staging-next tree? > > regards, > dan carpenter > ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v3] staging: vt6655: refactor camelcase uCurrRSSI to current_rssi
On Thu, Nov 18, 2021 at 09:27:18PM +0100, Alberto Merciai wrote: > Replace camelcase variable "uCurrRSSI" (current Received Signal Strength > Indicator) into linux kernel coding style equivalent > variable "current_rssi". > > Signed-off-by: Alberto Merciai > --- > > v2 > - correct mailing list Are you using the staging-next tree? regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: vt6655: refactor camelcase byMaxPwrLevel to max_pwr_level
Replace hungarian notated variable "byMaxPwrLevel" with "max_pwr_level"
compliant with linux kernel coding style.
Signed-off-by: Alberto Merciai
---
drivers/staging/vt6655/device.h | 2 +-
drivers/staging/vt6655/rf.c | 10 +-
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/vt6655/device.h b/drivers/staging/vt6655/device.h
index f5dee7ad99cd..d2be83b611ae 100644
--- a/drivers/staging/vt6655/device.h
+++ b/drivers/staging/vt6655/device.h
@@ -159,7 +159,7 @@ struct vnt_private {
unsigned char byLocalID;
unsigned char byRFType;
- unsigned char byMaxPwrLevel;
+ unsigned char max_pwr_level;
unsigned char byZoneType;
bool bZoneRegExist;
unsigned char byOriginalZonetype;
diff --git a/drivers/staging/vt6655/rf.c b/drivers/staging/vt6655/rf.c
index 747d79265a7c..e8a9444c6833 100644
--- a/drivers/staging/vt6655/rf.c
+++ b/drivers/staging/vt6655/rf.c
@@ -611,11 +611,11 @@ bool RFbInit(struct vnt_private *priv)
switch (priv->byRFType) {
case RF_AIROHA:
case RF_AL2230S:
- priv->byMaxPwrLevel = AL2230_PWR_IDX_LEN;
+ priv->max_pwr_level = AL2230_PWR_IDX_LEN;
ret = RFbAL2230Init(priv);
break;
case RF_AIROHA7230:
- priv->byMaxPwrLevel = AL7230_PWR_IDX_LEN;
+ priv->max_pwr_level = AL7230_PWR_IDX_LEN;
ret = s_bAL7230Init(priv);
break;
case RF_NOTHING:
@@ -788,8 +788,8 @@ bool RFbSetPower(struct vnt_private *priv, unsigned int
rate, u16 uCH)
else
byDec = byPwr + 10;
- if (byDec >= priv->byMaxPwrLevel)
- byDec = priv->byMaxPwrLevel - 1;
+ if (byDec >= priv->max_pwr_level)
+ byDec = priv->max_pwr_level - 1;
byPwr = byDec;
break;
@@ -831,7 +831,7 @@ bool RFbRawSetPower(struct vnt_private *priv, unsigned char
byPwr,
bool ret = true;
unsigned long dwMax7230Pwr = 0;
- if (byPwr >= priv->byMaxPwrLevel)
+ if (byPwr >= priv->max_pwr_level)
return false;
switch (priv->byRFType) {
--
2.25.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
