Re: [PATCH v2] Staging: comedi: das08_cs: Fix block comments use * on subsequent lines.
On Tue, Sep 6, 2016 at 4:18 PM, Ian Abbott <abbo...@mev.co.uk> wrote: > On 05/09/16 17:45, Amit Ghadge wrote: >> >> Fixes checkpatch warning in das08_cs.c file: >> WARNING: Block comments use * on subsequent lines >> >> Added * in blank line in comment block. >> >> Signed-off-by: Amit Ghadge <amitg@gmail.com> >> --- >> drivers/staging/comedi/drivers/das08_cs.c | 76 >> +++ >> 1 file changed, 38 insertions(+), 38 deletions(-) > > > Thanks, but this has already been fixed by an earlier commit by H Hartley > Sweeten in the staging-next branch of the staging repository, and in the > master branch of the linux-next repository. > > -- > -=( Ian Abbott @ MEV Ltd.E-mail: <abbo...@mev.co.uk> )=- > -=( Web: http://www.mev.co.uk/ )=- Thanks Ian, ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2] Staging: comedi: das08_cs: Fix block comments use * on subsequent lines.
Fixes checkpatch warning in das08_cs.c file: WARNING: Block comments use * on subsequent lines Added * in blank line in comment block. Signed-off-by: Amit Ghadge <amitg@gmail.com> --- drivers/staging/comedi/drivers/das08_cs.c | 76 +++ 1 file changed, 38 insertions(+), 38 deletions(-) diff --git a/drivers/staging/comedi/drivers/das08_cs.c b/drivers/staging/comedi/drivers/das08_cs.c index 9c02b17..1ccaca7 100644 --- a/drivers/staging/comedi/drivers/das08_cs.c +++ b/drivers/staging/comedi/drivers/das08_cs.c @@ -1,43 +1,43 @@ /* -comedi/drivers/das08_cs.c -DAS08 driver - -COMEDI - Linux Control and Measurement Device Interface -Copyright (C) 2000 David A. Schleef <d...@schleef.org> -Copyright (C) 2001,2002,2003 Frank Mori Hess <fmh...@users.sourceforge.net> - -This program is free software; you can redistribute it and/or modify -it under the terms of the GNU General Public License as published by -the Free Software Foundation; either version 2 of the License, or -(at your option) any later version. - -This program is distributed in the hope that it will be useful, -but WITHOUT ANY WARRANTY; without even the implied warranty of -MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -GNU General Public License for more details. - -PCMCIA support code for this driver is adapted from the dummy_cs.c -driver of the Linux PCMCIA Card Services package. - -The initial developer of the original code is David A. Hinds -<dahi...@users.sourceforge.net>. Portions created by David A. Hinds -are Copyright (C) 1999 David A. Hinds. All Rights Reserved. -*/ + * comedi/drivers/das08_cs.c + * DAS08 driver + * + * COMEDI - Linux Control and Measurement Device Interface + * Copyright (C) 2000 David A. Schleef <d...@schleef.org> + * Copyright (C) 2001,2002,2003 Frank Mori Hess <fmh...@users.sourceforge.net> + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * PCMCIA support code for this driver is adapted from the dummy_cs.c + * driver of the Linux PCMCIA Card Services package. + * + * The initial developer of the original code is David A. Hinds + * <dahi...@users.sourceforge.net>. Portions created by David A. Hinds + * are Copyright (C) 1999 David A. Hinds. All Rights Reserved. + */ /* -Driver: das08_cs -Description: DAS-08 PCMCIA boards -Author: Warren Jasper, ds, Frank Hess -Devices: [ComputerBoards] PCM-DAS08 (pcm-das08) -Status: works - -This is the PCMCIA-specific support split off from the -das08 driver. - -Options (for pcm-das08): - NONE - -Command support does not exist, but could be added for this board. -*/ + * Driver: das08_cs + * Description: DAS-08 PCMCIA boards + * Author: Warren Jasper, ds, Frank Hess + * Devices: [ComputerBoards] PCM-DAS08 (pcm-das08) + * Status: works + * + * This is the PCMCIA-specific support split off from the + * das08 driver. + * + * Options (for pcm-das08): + * NONE + * + * Command support does not exist, but could be added for this board. + */ #include -- 2.5.5 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.
On Mon, Sep 5, 2016 at 9:42 PM, Ian Abbott <abbo...@mev.co.uk> wrote: > On 05/09/16 17:05, Amit Ghadge wrote: >> >> This is a patch to the ni_daq_dio24.c that fixes checkpatch warning: >> WARNING: Block comments use * on subsequent lines >> >> Added * in blank line in comment block. >> >> Signed-off-by: Amit Ghadge <amitg@gmail.com> >> --- >> drivers/staging/comedi/drivers/ni_daq_dio24.c | 60 >> +-- >> 1 file changed, 30 insertions(+), 30 deletions(-) > > > I guess this replaces the other "v2" patch (which had a problem with blank > lines in the comment blocks). It looks okay, but could you repost it as > "v3" to avoid confusion with the other patch? > > > -- > -=( Ian Abbott @ MEV Ltd.E-mail: <abbo...@mev.co.uk> )=- > -=( Web: http://www.mev.co.uk/ )=- I have just send latest patch with "V3" Amit G ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v3] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.
This is a patch to the ni_daq_dio24.c that fixes checkpatch warning: WARNING: Block comments use * on subsequent lines Added * in blank line in comment block. Signed-off-by: Amit Ghadge <amitg@gmail.com> --- drivers/staging/comedi/drivers/ni_daq_dio24.c | 60 +-- 1 file changed, 30 insertions(+), 30 deletions(-) diff --git a/drivers/staging/comedi/drivers/ni_daq_dio24.c b/drivers/staging/comedi/drivers/ni_daq_dio24.c index d9de83a..32eaf2c 100644 --- a/drivers/staging/comedi/drivers/ni_daq_dio24.c +++ b/drivers/staging/comedi/drivers/ni_daq_dio24.c @@ -1,35 +1,35 @@ /* -comedi/drivers/ni_daq_dio24.c -Driver for National Instruments PCMCIA DAQ-Card DIO-24 -Copyright (C) 2002 Daniel Vecino Castel <dvec...@able.es> - -PCMCIA crap at end of file is adapted from dummy_cs.c 1.31 -2001/08/24 12:13:13 from the pcmcia package. -The initial developer of the pcmcia dummy_cs.c code is David A. Hinds -<dahi...@users.sourceforge.net>. Portions created by David A. Hinds -are Copyright (C) 1999 David A. Hinds. All Rights Reserved. - -This program is free software; you can redistribute it and/or modify -it under the terms of the GNU General Public License as published by -the Free Software Foundation; either version 2 of the License, or -(at your option) any later version. - -This program is distributed in the hope that it will be useful, -but WITHOUT ANY WARRANTY; without even the implied warranty of -MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -GNU General Public License for more details. -*/ + * comedi/drivers/ni_daq_dio24.c + * Driver for National Instruments PCMCIA DAQ-Card DIO-24 + * Copyright (C) 2002 Daniel Vecino Castel <dvec...@able.es> + * + * PCMCIA crap at end of file is adapted from dummy_cs.c 1.31 + * 2001/08/24 12:13:13 from the pcmcia package. + * The initial developer of the pcmcia dummy_cs.c code is David A. Hinds + * <dahi...@users.sourceforge.net>. Portions created by David A. Hinds + * are Copyright (C) 1999 David A. Hinds. All Rights Reserved. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ /* -Driver: ni_daq_dio24 -Description: National Instruments PCMCIA DAQ-Card DIO-24 -Author: Daniel Vecino Castel <dvec...@able.es> -Devices: [National Instruments] PCMCIA DAQ-Card DIO-24 (ni_daq_dio24) -Status: ? -Updated: Thu, 07 Nov 2002 21:53:06 -0800 - -This is just a wrapper around the 8255.o driver to properly handle -the PCMCIA interface. -*/ + * Driver: ni_daq_dio24 + * Description: National Instruments PCMCIA DAQ-Card DIO-24 + * Author: Daniel Vecino Castel <dvec...@able.es> + * Devices: [National Instruments] PCMCIA DAQ-Card DIO-24 (ni_daq_dio24) + * Status: ? + * Updated: Thu, 07 Nov 2002 21:53:06 -0800 + * + * This is just a wrapper around the 8255.o driver to properly handle + * the PCMCIA interface. + */ #include #include "../comedi_pcmcia.h" -- 2.5.5 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.
This is a patch to the ni_daq_dio24.c that fixes checkpatch warning: WARNING: Block comments use * on subsequent lines Added * in blank line in comment block. Signed-off-by: Amit Ghadge <amitg@gmail.com> --- drivers/staging/comedi/drivers/ni_daq_dio24.c | 60 +-- 1 file changed, 30 insertions(+), 30 deletions(-) diff --git a/drivers/staging/comedi/drivers/ni_daq_dio24.c b/drivers/staging/comedi/drivers/ni_daq_dio24.c index d9de83a..32eaf2c 100644 --- a/drivers/staging/comedi/drivers/ni_daq_dio24.c +++ b/drivers/staging/comedi/drivers/ni_daq_dio24.c @@ -1,35 +1,35 @@ /* -comedi/drivers/ni_daq_dio24.c -Driver for National Instruments PCMCIA DAQ-Card DIO-24 -Copyright (C) 2002 Daniel Vecino Castel <dvec...@able.es> - -PCMCIA crap at end of file is adapted from dummy_cs.c 1.31 -2001/08/24 12:13:13 from the pcmcia package. -The initial developer of the pcmcia dummy_cs.c code is David A. Hinds -<dahi...@users.sourceforge.net>. Portions created by David A. Hinds -are Copyright (C) 1999 David A. Hinds. All Rights Reserved. - -This program is free software; you can redistribute it and/or modify -it under the terms of the GNU General Public License as published by -the Free Software Foundation; either version 2 of the License, or -(at your option) any later version. - -This program is distributed in the hope that it will be useful, -but WITHOUT ANY WARRANTY; without even the implied warranty of -MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -GNU General Public License for more details. -*/ + * comedi/drivers/ni_daq_dio24.c + * Driver for National Instruments PCMCIA DAQ-Card DIO-24 + * Copyright (C) 2002 Daniel Vecino Castel <dvec...@able.es> + * + * PCMCIA crap at end of file is adapted from dummy_cs.c 1.31 + * 2001/08/24 12:13:13 from the pcmcia package. + * The initial developer of the pcmcia dummy_cs.c code is David A. Hinds + * <dahi...@users.sourceforge.net>. Portions created by David A. Hinds + * are Copyright (C) 1999 David A. Hinds. All Rights Reserved. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ /* -Driver: ni_daq_dio24 -Description: National Instruments PCMCIA DAQ-Card DIO-24 -Author: Daniel Vecino Castel <dvec...@able.es> -Devices: [National Instruments] PCMCIA DAQ-Card DIO-24 (ni_daq_dio24) -Status: ? -Updated: Thu, 07 Nov 2002 21:53:06 -0800 - -This is just a wrapper around the 8255.o driver to properly handle -the PCMCIA interface. -*/ + * Driver: ni_daq_dio24 + * Description: National Instruments PCMCIA DAQ-Card DIO-24 + * Author: Daniel Vecino Castel <dvec...@able.es> + * Devices: [National Instruments] PCMCIA DAQ-Card DIO-24 (ni_daq_dio24) + * Status: ? + * Updated: Thu, 07 Nov 2002 21:53:06 -0800 + * + * This is just a wrapper around the 8255.o driver to properly handle + * the PCMCIA interface. + */ #include #include "../comedi_pcmcia.h" -- 2.5.5 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.
This is a patch to the ni_daq_dio24.c that fixes checkpatch warning: WARNING: Block comments use * on subsequent lines Added * in blank line in comment block. Signed-off-by: Amit Ghadge <amitg@gmail.com> --- drivers/staging/comedi/drivers/ni_daq_dio24.c | 52 +-- 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/drivers/staging/comedi/drivers/ni_daq_dio24.c b/drivers/staging/comedi/drivers/ni_daq_dio24.c index d9de83a..ff3716c 100644 --- a/drivers/staging/comedi/drivers/ni_daq_dio24.c +++ b/drivers/staging/comedi/drivers/ni_daq_dio24.c @@ -1,35 +1,35 @@ /* -comedi/drivers/ni_daq_dio24.c -Driver for National Instruments PCMCIA DAQ-Card DIO-24 -Copyright (C) 2002 Daniel Vecino Castel <dvec...@able.es> + * comedi/drivers/ni_daq_dio24.c + * Driver for National Instruments PCMCIA DAQ-Card DIO-24 + * Copyright (C) 2002 Daniel Vecino Castel <dvec...@able.es> -PCMCIA crap at end of file is adapted from dummy_cs.c 1.31 -2001/08/24 12:13:13 from the pcmcia package. -The initial developer of the pcmcia dummy_cs.c code is David A. Hinds -<dahi...@users.sourceforge.net>. Portions created by David A. Hinds -are Copyright (C) 1999 David A. Hinds. All Rights Reserved. + * PCMCIA crap at end of file is adapted from dummy_cs.c 1.31 + * 2001/08/24 12:13:13 from the pcmcia package. + * The initial developer of the pcmcia dummy_cs.c code is David A. Hinds + * <dahi...@users.sourceforge.net>. Portions created by David A. Hinds + * are Copyright (C) 1999 David A. Hinds. All Rights Reserved. -This program is free software; you can redistribute it and/or modify -it under the terms of the GNU General Public License as published by -the Free Software Foundation; either version 2 of the License, or -(at your option) any later version. + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. -This program is distributed in the hope that it will be useful, -but WITHOUT ANY WARRANTY; without even the implied warranty of -MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -GNU General Public License for more details. -*/ + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ /* -Driver: ni_daq_dio24 -Description: National Instruments PCMCIA DAQ-Card DIO-24 -Author: Daniel Vecino Castel <dvec...@able.es> -Devices: [National Instruments] PCMCIA DAQ-Card DIO-24 (ni_daq_dio24) -Status: ? -Updated: Thu, 07 Nov 2002 21:53:06 -0800 + * Driver: ni_daq_dio24 + * Description: National Instruments PCMCIA DAQ-Card DIO-24 + * Author: Daniel Vecino Castel <dvec...@able.es> + * Devices: [National Instruments] PCMCIA DAQ-Card DIO-24 (ni_daq_dio24) + * Status: ? + * Updated: Thu, 07 Nov 2002 21:53:06 -0800 -This is just a wrapper around the 8255.o driver to properly handle -the PCMCIA interface. -*/ + * This is just a wrapper around the 8255.o driver to properly handle + * the PCMCIA interface. + */ #include #include "../comedi_pcmcia.h" -- 2.5.5 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 1/2] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.
On Mon, Sep 5, 2016 at 6:45 PM, Ian Abbott <abbo...@mev.co.uk> wrote: > On 03/09/16 21:11, Amit Ghadge wrote: >> >> This is a patch to the ni_daq_dio24.c that fixes checkpatch warning: >> >> WARNING: Block comments use * on subsequent lines >> >> Signed-off-by: Amit Ghadge <amitg@gmail.com> >> --- >> drivers/staging/comedi/drivers/ni_daq_dio24.c | 52 >> +-- >> 1 file changed, 26 insertions(+), 26 deletions(-) >> >> diff --git a/drivers/staging/comedi/drivers/ni_daq_dio24.c >> b/drivers/staging/comedi/drivers/ni_daq_dio24.c >> index d9de83a..ff3716c 100644 >> --- a/drivers/staging/comedi/drivers/ni_daq_dio24.c >> +++ b/drivers/staging/comedi/drivers/ni_daq_dio24.c >> @@ -1,35 +1,35 @@ >> /* >> -comedi/drivers/ni_daq_dio24.c >> -Driver for National Instruments PCMCIA DAQ-Card DIO-24 >> -Copyright (C) 2002 Daniel Vecino Castel <dvec...@able.es> >> + * comedi/drivers/ni_daq_dio24.c >> + * Driver for National Instruments PCMCIA DAQ-Card DIO-24 >> + * Copyright (C) 2002 Daniel Vecino Castel <dvec...@able.es> >> >> -PCMCIA crap at end of file is adapted from dummy_cs.c 1.31 >> -2001/08/24 12:13:13 from the pcmcia package. >> -The initial developer of the pcmcia dummy_cs.c code is David A. Hinds >> -<dahi...@users.sourceforge.net>. Portions created by David A. Hinds >> -are Copyright (C) 1999 David A. Hinds. All Rights Reserved. >> + * PCMCIA crap at end of file is adapted from dummy_cs.c 1.31 >> + * 2001/08/24 12:13:13 from the pcmcia package. >> + * The initial developer of the pcmcia dummy_cs.c code is David A. Hinds >> + * <dahi...@users.sourceforge.net>. Portions created by David A. Hinds >> + * are Copyright (C) 1999 David A. Hinds. All Rights Reserved. >> >> -This program is free software; you can redistribute it and/or modify >> -it under the terms of the GNU General Public License as published by >> -the Free Software Foundation; either version 2 of the License, or >> -(at your option) any later version. >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License as published by >> + * the Free Software Foundation; either version 2 of the License, or >> + * (at your option) any later version. >> >> -This program is distributed in the hope that it will be useful, >> -but WITHOUT ANY WARRANTY; without even the implied warranty of >> -MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> -GNU General Public License for more details. >> -*/ >> + * This program is distributed in the hope that it will be useful, >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> + * GNU General Public License for more details. >> + */ > > > The blank lines in that comment block should also have the " *" so it has an > unbroken, vertical line of "*" down the left side of the comment block. > >> /* >> -Driver: ni_daq_dio24 >> -Description: National Instruments PCMCIA DAQ-Card DIO-24 >> -Author: Daniel Vecino Castel <dvec...@able.es> >> -Devices: [National Instruments] PCMCIA DAQ-Card DIO-24 (ni_daq_dio24) >> -Status: ? >> -Updated: Thu, 07 Nov 2002 21:53:06 -0800 >> + * Driver: ni_daq_dio24 >> + * Description: National Instruments PCMCIA DAQ-Card DIO-24 >> + * Author: Daniel Vecino Castel <dvec...@able.es> >> + * Devices: [National Instruments] PCMCIA DAQ-Card DIO-24 (ni_daq_dio24) >> + * Status: ? >> + * Updated: Thu, 07 Nov 2002 21:53:06 -0800 >> >> -This is just a wrapper around the 8255.o driver to properly handle >> -the PCMCIA interface. >> -*/ >> + * This is just a wrapper around the 8255.o driver to properly handle >> + * the PCMCIA interface. >> + */ > > > Same thing there. > > -- > -=( Ian Abbott @ MEV Ltd.E-mail: <abbo...@mev.co.uk> )=- > -=( Web: http://www.mev.co.uk/ )=- I will be send updated patch. Amit G ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 2/2] Staging: comedi: ni_670x.c: Fix warnings and check.
On Mon, Sep 5, 2016 at 7:02 PM, Ian Abbott <abbo...@mev.co.uk> wrote:
> On 03/09/16 21:11, Amit Ghadge wrote:
>>
>> Fixes checkpatch warning:
>> WARNING: Block comments use * on subsequent lines
>>
>> Replace (1<<7) by BIT(7) in the file ni_670x.c to get rid
>> of checkpatch.pl "CHECK" output "Prefer using the BIT macro".
>> Replace Avoid CamelCase range_0_20mA to range_0_20ma.
>>
>> Signed-off-by: Amit Ghadge <amitg@gmail.com>
>> ---
>> drivers/staging/comedi/drivers/ni_670x.c | 66
>>
>> 1 file changed, 32 insertions(+), 34 deletions(-)
>>
>> diff --git a/drivers/staging/comedi/drivers/ni_670x.c
>> b/drivers/staging/comedi/drivers/ni_670x.c
>> index 3e7271880..86d26aa 100644
>> --- a/drivers/staging/comedi/drivers/ni_670x.c
>> +++ b/drivers/staging/comedi/drivers/ni_670x.c
>> @@ -1,40 +1,38 @@
>> /*
>> -comedi/drivers/ni_670x.c
>> -Hardware driver for NI 670x devices
>> -
>> -COMEDI - Linux Control and Measurement Device Interface
>> -Copyright (C) 1997-2001 David A. Schleef <d...@schleef.org>
>> -
>> -This program is free software; you can redistribute it and/or modify
>> -it under the terms of the GNU General Public License as published by
>> -the Free Software Foundation; either version 2 of the License, or
>> -(at your option) any later version.
>> -
>> -This program is distributed in the hope that it will be useful,
>> -but WITHOUT ANY WARRANTY; without even the implied warranty of
>> -MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>> -GNU General Public License for more details.
>> -*/
>> + * comedi/drivers/ni_670x.c
>> + * Hardware driver for NI 670x devices
>> +
>> + * COMEDI - Linux Control and Measurement Device Interface
>> + * Copyright (C) 1997-2001 David A. Schleef <d...@schleef.org>
>> +
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License as published by
>> + * the Free Software Foundation; either version 2 of the License, or
>> + * (at your option) any later version.
>> +
>> + * This program is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>> + * GNU General Public License for more details.
>> + */
>> /*
>> -Driver: ni_670x
>> -Description: National Instruments 670x
>> -Author: Bart Joris <bjo...@advalvas.be>
>> -Updated: Wed, 11 Dec 2002 18:25:35 -0800
>> -Devices: [National Instruments] PCI-6703 (ni_670x), PCI-6704
>> -Status: unknown
>> -
>> -Commands are not supported.
>> -*/
>> -
>> + * Driver: ni_670x
>> + * Description: National Instruments 670x
>> + * Author: Bart Joris <bjo...@advalvas.be>
>> + * Updated: Wed, 11 Dec 2002 18:25:35 -0800
>> + * Devices: [National Instruments] PCI-6703 (ni_670x), PCI-6704
>> + * Status: unknown
>> +
>> + * Commands are not supported.
>> + */
>> /*
>> - Bart Joris <bjo...@advalvas.be> Last updated on 20/08/2001
>> -
>> - Manuals:
>> + * Bart Joris <bjo...@advalvas.be> Last updated on 20/08/2001
>>
>> - 322110a.pdf PCI/PXI-6704 User Manual
>> - 322110b.pdf PCI/PXI-6703/6704 User Manual
>> + * Manuals:
>>
>> -*/
>> + * 322110a.pdf PCI/PXI-6704 User Manual
>> + * 322110b.pdf PCI/PXI-6703/6704 User Manual
>> + */
>
>
> In addition to the problems mentioned by Greg, the blank lines in those
> comment blocks also need a " *" to give an unbroken line of "*" down the
> left hand side of the comment block.
>
>> #include
>> #include
>> @@ -147,7 +145,7 @@ static int ni_670x_dio_insn_config(struct
>> comedi_device *dev,
>>
>> /* ripped from mite.h and mite_setup2() to avoid mite dependency */
>> #define MITE_IODWBSR 0xc0 /* IO Device Window Base Size Register */
>> -#define WENAB (1 << 7) /* window enable */
>> +#define WENAB BIT(7) /* window enable */
>>
>> static int ni_670x_mite_init(struct pci_dev *pcidev)
>> {
>> @@ -222,7 +220,7 @@ static int ni_670x_auto_attach(struct comedi_device
>> *dev,
>> s->range_table_list = range_table_list;
>> for (i = 0; i < 16; i++) {
>> range_tab
[PATCH] Staging: rtl8188eu: ioctl_linux: Clean up if function returned NULL on failure.
Clean some all functions to return NULL on failure.
Used !x instead of x==NULL.
Signed-off-by: Amit Ghadge <amitg@gmail.com>
---
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 34 +-
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
b/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
index 5672f01..40e7fd0 100644
--- a/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
+++ b/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c
@@ -400,7 +400,7 @@ static int wpa_set_encryption(struct net_device *dev,
struct ieee_param *param,
wep_key_len = wep_key_len <= 5 ? 5 : 13;
wep_total_len = wep_key_len + offsetof(struct
ndis_802_11_wep, KeyMaterial);
pwep = (struct ndis_802_11_wep
*)rtw_malloc(wep_total_len);
- if (pwep == NULL) {
+ if (!pwep) {
RT_TRACE(_module_rtl871x_ioctl_os_c, _drv_err_,
(" wpa_set_encryption: pwep allocate fail !!!\n"));
goto exit;
}
@@ -441,7 +441,7 @@ static int wpa_set_encryption(struct net_device *dev,
struct ieee_param *param,
if (check_fwstate(pmlmepriv, WIFI_STATION_STATE |
WIFI_MP_STATE)) { /* sta mode */
psta = rtw_get_stainfo(pstapriv, get_bssid(pmlmepriv));
- if (psta == NULL) {
+ if (!psta) {
;
} else {
if (strcmp(param->u.crypt.alg, "none") != 0)
@@ -476,7 +476,7 @@ static int wpa_set_encryption(struct net_device *dev,
struct ieee_param *param,
}
}
pbcmc_sta = rtw_get_bcmc_stainfo(padapter);
- if (pbcmc_sta == NULL) {
+ if (!pbcmc_sta) {
;
} else {
/* Jeff: don't disable ieee8021x_blocked while
clearing key */
@@ -502,9 +502,9 @@ static int rtw_set_wpa_ie(struct adapter *padapter, char
*pie, unsigned short ie
int group_cipher = 0, pairwise_cipher = 0;
int ret = 0;
- if ((ielen > MAX_WPA_IE_LEN) || (pie == NULL)) {
+ if ((ielen > MAX_WPA_IE_LEN) || (!pie)) {
_clr_fwstate_(>mlmepriv, WIFI_UNDER_WPS);
- if (pie == NULL)
+ if (!pie)
return ret;
else
return -EINVAL;
@@ -512,7 +512,7 @@ static int rtw_set_wpa_ie(struct adapter *padapter, char
*pie, unsigned short ie
if (ielen) {
buf = kmemdup(pie, ielen, GFP_KERNEL);
- if (buf == NULL) {
+ if (!buf) {
ret = -ENOMEM;
goto exit;
}
@@ -1049,7 +1049,7 @@ static int rtw_wx_set_mlme(struct net_device *dev,
struct adapter *padapter = (struct adapter *)rtw_netdev_priv(dev);
struct iw_mlme *mlme = (struct iw_mlme *)extra;
- if (mlme == NULL)
+ if (!mlme)
return -1;
DBG_88E("%s\n", __func__);
@@ -1896,7 +1896,7 @@ static int rtw_wx_set_enc_ext(struct net_device *dev,
param_len = sizeof(struct ieee_param) + pext->key_len;
param = (struct ieee_param *)rtw_malloc(param_len);
- if (param == NULL)
+ if (!param)
return -1;
memset(param, 0, param_len);
@@ -2061,7 +2061,7 @@ static int wpa_supplicant_ioctl(struct net_device *dev,
struct iw_point *p)
}
param = (struct ieee_param *)rtw_malloc(p->length);
- if (param == NULL) {
+ if (!param) {
ret = -ENOMEM;
goto out;
}
@@ -2254,13 +2254,13 @@ static int rtw_set_encryption(struct net_device *dev,
struct ieee_param *param,
}
}
- if (strcmp(param->u.crypt.alg, "none") == 0 && (psta == NULL)) {
+ if (strcmp(param->u.crypt.alg, "none") == 0 && (!psta)) {
/* todo:clear default encryption keys */
DBG_88E("clear default encryption keys, keyid =%d\n",
param->u.crypt.idx);
goto exit;
}
- if (strcmp(param->u.crypt.alg, "WEP") == 0 && (psta == NULL)) {
+ if (strcmp(param->u.crypt.alg, "WEP") == 0 && (!psta)) {
DBG_88E("r871x_set_encryption, crypt.alg = WEP\n");
wep_key_idx = param->u.crypt.idx;
wep_key_len = param->u.crypt.key_len;
@@ -2274,7 +2274,7 @@ static int rtw_set_encryption(struct net_device *dev,
struct ieee_param *param,
wep_key_len = wep_key_len &
[PATCH] Staging: comedi: das08_cs: Fix block comments use * on subsequent lines.
Fixes checkpatch warning in das08_cs.c file: WARNING: Block comments use * on subsequent lines Signed-off-by: Amit Ghadge <amitg@gmail.com> --- drivers/staging/comedi/drivers/das08_cs.c | 70 +++ 1 file changed, 35 insertions(+), 35 deletions(-) diff --git a/drivers/staging/comedi/drivers/das08_cs.c b/drivers/staging/comedi/drivers/das08_cs.c index 9c02b17..1c5a0d8 100644 --- a/drivers/staging/comedi/drivers/das08_cs.c +++ b/drivers/staging/comedi/drivers/das08_cs.c @@ -1,43 +1,43 @@ /* -comedi/drivers/das08_cs.c -DAS08 driver - -COMEDI - Linux Control and Measurement Device Interface -Copyright (C) 2000 David A. Schleef <d...@schleef.org> -Copyright (C) 2001,2002,2003 Frank Mori Hess <fmh...@users.sourceforge.net> - -This program is free software; you can redistribute it and/or modify -it under the terms of the GNU General Public License as published by -the Free Software Foundation; either version 2 of the License, or -(at your option) any later version. - -This program is distributed in the hope that it will be useful, -but WITHOUT ANY WARRANTY; without even the implied warranty of -MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -GNU General Public License for more details. - -PCMCIA support code for this driver is adapted from the dummy_cs.c -driver of the Linux PCMCIA Card Services package. - -The initial developer of the original code is David A. Hinds -<dahi...@users.sourceforge.net>. Portions created by David A. Hinds -are Copyright (C) 1999 David A. Hinds. All Rights Reserved. -*/ + * comedi/drivers/das08_cs.c + * DAS08 driver + + * COMEDI - Linux Control and Measurement Device Interface + * Copyright (C) 2000 David A. Schleef <d...@schleef.org> + * Copyright (C) 2001,2002,2003 Frank Mori Hess <fmh...@users.sourceforge.net> + + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + + * PCMCIA support code for this driver is adapted from the dummy_cs.c + * driver of the Linux PCMCIA Card Services package. + + * The initial developer of the original code is David A. Hinds + * <dahi...@users.sourceforge.net>. Portions created by David A. Hinds + * are Copyright (C) 1999 David A. Hinds. All Rights Reserved. + */ /* -Driver: das08_cs -Description: DAS-08 PCMCIA boards -Author: Warren Jasper, ds, Frank Hess -Devices: [ComputerBoards] PCM-DAS08 (pcm-das08) -Status: works + * Driver: das08_cs + * Description: DAS-08 PCMCIA boards + * Author: Warren Jasper, ds, Frank Hess + * Devices: [ComputerBoards] PCM-DAS08 (pcm-das08) + * Status: works -This is the PCMCIA-specific support split off from the -das08 driver. + * This is the PCMCIA-specific support split off from the + * das08 driver. -Options (for pcm-das08): - NONE + * Options (for pcm-das08): + * NONE -Command support does not exist, but could be added for this board. -*/ + * Command support does not exist, but could be added for this board. + */ #include -- 2.5.5 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.
On Sep 4, 2016 5:19 PM, "kbuild test robot" <l...@intel.com> wrote:
>
> Hi Amit,
>
> [auto build test ERROR on v4.8-rc4]
> [cannot apply to staging/staging-testing next-20160825]
> [if your patch is applied to the wrong git tree, please drop us a note to
> help improve the system]
> [Suggest to use git(>=2.9.0) format-patch --base= (or --base=auto for
> convenience) to record what (public, well-known) commit your patch series was
> built on]
> [Check https://git-scm.com/docs/git-format-patch for more information]
>
> url:
> https://github.com/0day-ci/linux/commits/Amit-Ghadge/Staging-comedi-ni_daq_dio24-c-Fix-block-comments-use-on-subsequent-lines/20160904-170303
> config: i386-allmodconfig (attached as .config)
> compiler: gcc-6 (Debian 6.1.1-9) 6.1.1 20160705
> reproduce:
> # save the attached .config to linux build tree
> make ARCH=i386
>
> All error/warnings (new ones prefixed by >>):
>
> >> drivers/staging/comedi/range.c:35:49: error: implicit declaration of
> >> function 'RANGE_mA' [-Werror=implicit-function-declaration]
> const struct comedi_lrange range_0_20mA = { 1, {RANGE_mA(0, 20)} };
> ^~~~
> >> drivers/staging/comedi/range.c:35:49: error: initializer element is not
> >> constant
>drivers/staging/comedi/range.c:35:49: note: (near initialization for
> 'range_0_20mA.range[0].min')
>drivers/staging/comedi/range.c:37:49: error: initializer element is not
> constant
> const struct comedi_lrange range_4_20mA = { 1, {RANGE_mA(4, 20)} };
> ^~~~
>drivers/staging/comedi/range.c:37:49: note: (near initialization for
> 'range_4_20mA.range[0].min')
>drivers/staging/comedi/range.c:39:49: error: initializer element is not
> constant
> const struct comedi_lrange range_0_32mA = { 1, {RANGE_mA(0, 32)} };
> ^~~~
>drivers/staging/comedi/range.c:39:49: note: (near initialization for
> 'range_0_32mA.range[0].min')
>cc1: some warnings being treated as errors
> --
> >> drivers/staging/comedi/drivers/pcl726.c:82:3: error: 'range_4_20mA'
> >> undeclared here (not in a function)
> _4_20mA,
> ^~~~
> >> drivers/staging/comedi/drivers/pcl726.c:90:2: error: initializer element
> >> is not constant
> _4_20mA
> ^
>drivers/staging/comedi/drivers/pcl726.c:90:2: note: (near initialization
> for 'rangelist_727[3]')
>drivers/staging/comedi/drivers/pcl726.c:98:2: error: initializer element
> is not constant
> _4_20mA,
> ^
>drivers/staging/comedi/drivers/pcl726.c:98:2: note: (near initialization
> for 'rangelist_728[4]')
> >> drivers/staging/comedi/drivers/pcl726.c:99:3: error: 'range_0_20mA'
> >> undeclared here (not in a function)
> _0_20mA
> ^~~~
>drivers/staging/comedi/drivers/pcl726.c:99:2: error: initializer element
> is not constant
> _0_20mA
> ^
>drivers/staging/comedi/drivers/pcl726.c:99:2: note: (near initialization
> for 'rangelist_728[5]')
> --
> >> drivers/staging/comedi/drivers/dac02.c:66:3: error: implicit declaration
> >> of function 'RANGE_mA' [-Werror=implicit-function-declaration]
> RANGE_mA(4, 20),
> ^~~~
> >> drivers/staging/comedi/drivers/dac02.c:66:3: error: initializer element is
> >> not constant
>drivers/staging/comedi/drivers/dac02.c:66:3: note: (near initialization
> for 'das02_ao_ranges.range[4].min')
> >> drivers/staging/comedi/drivers/dac02.c:67:3: warning: braces around scalar
> >> initializer
> RANGE_ext(0, 1)
> ^
>drivers/staging/comedi/drivers/dac02.c:67:3: note: (near initialization
> for 'das02_ao_ranges.range[4].max')
>In file included from drivers/staging/comedi/drivers/dac02.c:38:0:
> >> drivers/staging/comedi/drivers/../comedidev.h:584:38: warning: excess
> >> elements in scalar initializer
> #define RANGE_ext(a, b) {(a) * 1e6, (b) * 1e6, RF_EXTERNAL}
> ^
> >> drivers/staging/comedi/drivers/dac02.c:67:3: note: in expansion of macro
> >> 'RANGE_ext'
> RANGE_ext(0, 1)
> ^
>drivers/staging/comedi/drivers/../comedidev.h:584:38: note: (near
> initialization for 'das02_ao_ranges.range[4].max')
> #define RANGE_ext(a, b) {(a) * 1e6, (b) * 1e6, RF_EXTERNAL}
> ^
> >> drivers/staging/comedi/drivers/dac02.c:67:3: note: in expansion of macro
> >> 'RANGE_ex
Re: [PATCH 2/2] Staging: comedi: ni_670x.c: Fix warnings and check.
I will be send individual patches. I was try, make M=drivers/staging/comedi/ No issue generated, Is there have any other option to test these changes? Amit G On Sun, Sep 4, 2016 at 2:05 PM, Greg KH <gre...@linuxfoundation.org> wrote: > On Sun, Sep 04, 2016 at 01:41:03AM +0530, Amit Ghadge wrote: >> Fixes checkpatch warning: >> WARNING: Block comments use * on subsequent lines >> >> Replace (1<<7) by BIT(7) in the file ni_670x.c to get rid >> of checkpatch.pl "CHECK" output "Prefer using the BIT macro". >> Replace Avoid CamelCase range_0_20mA to range_0_20ma. > > That's multiple things in the same patch, and you didn't even test build > your change :( > > Please do better than this in the future. > > greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.
On Sun, Sep 4, 2016 at 3:12 PM, Giedrius Statkevičius <giedrius.statkevic...@gmail.com> wrote: > On Sun, Sep 4, 2016 at 12:08 PM, Amit Ghadge <amitg@gmail.com> wrote: >> This is a patch to the ni_daq_dio24.c that fixes checkpatch warning: >> WARNING: Block comments use * on subsequent lines >> >> Signed-off-by: Amit Ghadge <amitg@gmail.com> >> --- > [...] > > Why are you sending so many copies of the same patch? Accidentally I used same git branch and try to send multiple patches but other patch has some issue, So I have exclude the other patch. Amit ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.
This is a patch to the ni_daq_dio24.c that fixes checkpatch warning: WARNING: Block comments use * on subsequent lines Signed-off-by: Amit Ghadge <amitg@gmail.com> --- drivers/staging/comedi/drivers/ni_daq_dio24.c | 52 +-- 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/drivers/staging/comedi/drivers/ni_daq_dio24.c b/drivers/staging/comedi/drivers/ni_daq_dio24.c index d9de83a..ff3716c 100644 --- a/drivers/staging/comedi/drivers/ni_daq_dio24.c +++ b/drivers/staging/comedi/drivers/ni_daq_dio24.c @@ -1,35 +1,35 @@ /* -comedi/drivers/ni_daq_dio24.c -Driver for National Instruments PCMCIA DAQ-Card DIO-24 -Copyright (C) 2002 Daniel Vecino Castel <dvec...@able.es> + * comedi/drivers/ni_daq_dio24.c + * Driver for National Instruments PCMCIA DAQ-Card DIO-24 + * Copyright (C) 2002 Daniel Vecino Castel <dvec...@able.es> -PCMCIA crap at end of file is adapted from dummy_cs.c 1.31 -2001/08/24 12:13:13 from the pcmcia package. -The initial developer of the pcmcia dummy_cs.c code is David A. Hinds -<dahi...@users.sourceforge.net>. Portions created by David A. Hinds -are Copyright (C) 1999 David A. Hinds. All Rights Reserved. + * PCMCIA crap at end of file is adapted from dummy_cs.c 1.31 + * 2001/08/24 12:13:13 from the pcmcia package. + * The initial developer of the pcmcia dummy_cs.c code is David A. Hinds + * <dahi...@users.sourceforge.net>. Portions created by David A. Hinds + * are Copyright (C) 1999 David A. Hinds. All Rights Reserved. -This program is free software; you can redistribute it and/or modify -it under the terms of the GNU General Public License as published by -the Free Software Foundation; either version 2 of the License, or -(at your option) any later version. + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. -This program is distributed in the hope that it will be useful, -but WITHOUT ANY WARRANTY; without even the implied warranty of -MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -GNU General Public License for more details. -*/ + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ /* -Driver: ni_daq_dio24 -Description: National Instruments PCMCIA DAQ-Card DIO-24 -Author: Daniel Vecino Castel <dvec...@able.es> -Devices: [National Instruments] PCMCIA DAQ-Card DIO-24 (ni_daq_dio24) -Status: ? -Updated: Thu, 07 Nov 2002 21:53:06 -0800 + * Driver: ni_daq_dio24 + * Description: National Instruments PCMCIA DAQ-Card DIO-24 + * Author: Daniel Vecino Castel <dvec...@able.es> + * Devices: [National Instruments] PCMCIA DAQ-Card DIO-24 (ni_daq_dio24) + * Status: ? + * Updated: Thu, 07 Nov 2002 21:53:06 -0800 -This is just a wrapper around the 8255.o driver to properly handle -the PCMCIA interface. -*/ + * This is just a wrapper around the 8255.o driver to properly handle + * the PCMCIA interface. + */ #include #include "../comedi_pcmcia.h" -- 2.5.5 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.
On Sun, Sep 4, 2016 at 2:30 PM, Amit Ghadge <amitg@gmail.com> wrote:
> This is a patch to the ni_daq_dio24.c that fixes checkpatch warning:
>
> WARNING: Block comments use * on subsequent lines
>
> Signed-off-by: Amit Ghadge <amitg@gmail.com>
> ---
> drivers/staging/comedi/comedidev.h| 8 ++---
> drivers/staging/comedi/drivers/ni_daq_dio24.c | 52
> +--
> 2 files changed, 30 insertions(+), 30 deletions(-)
>
> diff --git a/drivers/staging/comedi/comedidev.h
> b/drivers/staging/comedi/comedidev.h
> index dcb6376..612a844 100644
> --- a/drivers/staging/comedi/comedidev.h
> +++ b/drivers/staging/comedi/comedidev.h
> @@ -582,7 +582,7 @@ int comedi_check_chanlist(struct comedi_subdevice *s,
>
> #define RANGE(a, b){(a) * 1e6, (b) * 1e6, 0}
> #define RANGE_ext(a, b){(a) * 1e6, (b) * 1e6, RF_EXTERNAL}
> -#define RANGE_mA(a, b) {(a) * 1e6, (b) * 1e6, UNIT_mA}
> +#define RANGE_MA(a, b) {(a) * 1e6, (b) * 1e6, UNIT_MA}
> #define RANGE_unitless(a, b) {(a) * 1e6, (b) * 1e6, 0}
> #define BIP_RANGE(a) {-(a) * 1e6, (a) * 1e6, 0}
> #define UNI_RANGE(a) {0, (a) * 1e6, 0}
> @@ -593,9 +593,9 @@ extern const struct comedi_lrange range_bipolar2_5;
> extern const struct comedi_lrange range_unipolar10;
> extern const struct comedi_lrange range_unipolar5;
> extern const struct comedi_lrange range_unipolar2_5;
> -extern const struct comedi_lrange range_0_20mA;
> -extern const struct comedi_lrange range_4_20mA;
> -extern const struct comedi_lrange range_0_32mA;
> +extern const struct comedi_lrange range_0_20ma;
> +extern const struct comedi_lrange range_4_20ma;
> +extern const struct comedi_lrange range_0_32ma;
> extern const struct comedi_lrange range_unknown;
>
> #define range_digital range_unipolar5
> diff --git a/drivers/staging/comedi/drivers/ni_daq_dio24.c
> b/drivers/staging/comedi/drivers/ni_daq_dio24.c
> index d9de83a..ff3716c 100644
> --- a/drivers/staging/comedi/drivers/ni_daq_dio24.c
> +++ b/drivers/staging/comedi/drivers/ni_daq_dio24.c
> @@ -1,35 +1,35 @@
> /*
> -comedi/drivers/ni_daq_dio24.c
> -Driver for National Instruments PCMCIA DAQ-Card DIO-24
> -Copyright (C) 2002 Daniel Vecino Castel <dvec...@able.es>
> + * comedi/drivers/ni_daq_dio24.c
> + * Driver for National Instruments PCMCIA DAQ-Card DIO-24
> + * Copyright (C) 2002 Daniel Vecino Castel <dvec...@able.es>
>
> -PCMCIA crap at end of file is adapted from dummy_cs.c 1.31
> -2001/08/24 12:13:13 from the pcmcia package.
> -The initial developer of the pcmcia dummy_cs.c code is David A. Hinds
> -<dahi...@users.sourceforge.net>. Portions created by David A. Hinds
> -are Copyright (C) 1999 David A. Hinds. All Rights Reserved.
> + * PCMCIA crap at end of file is adapted from dummy_cs.c 1.31
> + * 2001/08/24 12:13:13 from the pcmcia package.
> + * The initial developer of the pcmcia dummy_cs.c code is David A. Hinds
> + * <dahi...@users.sourceforge.net>. Portions created by David A. Hinds
> + * are Copyright (C) 1999 David A. Hinds. All Rights Reserved.
>
> -This program is free software; you can redistribute it and/or modify
> -it under the terms of the GNU General Public License as published by
> -the Free Software Foundation; either version 2 of the License, or
> -(at your option) any later version.
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
>
> -This program is distributed in the hope that it will be useful,
> -but WITHOUT ANY WARRANTY; without even the implied warranty of
> -MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> -GNU General Public License for more details.
> -*/
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + */
> /*
> -Driver: ni_daq_dio24
> -Description: National Instruments PCMCIA DAQ-Card DIO-24
> -Author: Daniel Vecino Castel <dvec...@able.es>
> -Devices: [National Instruments] PCMCIA DAQ-Card DIO-24 (ni_daq_dio24)
> -Status: ?
> -Updated: Thu, 07 Nov 2002 21:53:06 -0800
> + * Driver: ni_daq_dio24
> + * Description: National Instruments PCMCIA DAQ-Card DIO-24
> + * Author: Daniel Vecino Castel <dvec...@able.es>
> + * Devices: [National Instruments] PCMCIA DAQ-Card DIO-24 (ni_daq_
[PATCH] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.
This is a patch to the ni_daq_dio24.c that fixes checkpatch warning:
WARNING: Block comments use * on subsequent lines
Signed-off-by: Amit Ghadge <amitg@gmail.com>
---
drivers/staging/comedi/comedidev.h| 8 ++---
drivers/staging/comedi/drivers/ni_daq_dio24.c | 52 +--
2 files changed, 30 insertions(+), 30 deletions(-)
diff --git a/drivers/staging/comedi/comedidev.h
b/drivers/staging/comedi/comedidev.h
index dcb6376..612a844 100644
--- a/drivers/staging/comedi/comedidev.h
+++ b/drivers/staging/comedi/comedidev.h
@@ -582,7 +582,7 @@ int comedi_check_chanlist(struct comedi_subdevice *s,
#define RANGE(a, b){(a) * 1e6, (b) * 1e6, 0}
#define RANGE_ext(a, b){(a) * 1e6, (b) * 1e6, RF_EXTERNAL}
-#define RANGE_mA(a, b) {(a) * 1e6, (b) * 1e6, UNIT_mA}
+#define RANGE_MA(a, b) {(a) * 1e6, (b) * 1e6, UNIT_MA}
#define RANGE_unitless(a, b) {(a) * 1e6, (b) * 1e6, 0}
#define BIP_RANGE(a) {-(a) * 1e6, (a) * 1e6, 0}
#define UNI_RANGE(a) {0, (a) * 1e6, 0}
@@ -593,9 +593,9 @@ extern const struct comedi_lrange range_bipolar2_5;
extern const struct comedi_lrange range_unipolar10;
extern const struct comedi_lrange range_unipolar5;
extern const struct comedi_lrange range_unipolar2_5;
-extern const struct comedi_lrange range_0_20mA;
-extern const struct comedi_lrange range_4_20mA;
-extern const struct comedi_lrange range_0_32mA;
+extern const struct comedi_lrange range_0_20ma;
+extern const struct comedi_lrange range_4_20ma;
+extern const struct comedi_lrange range_0_32ma;
extern const struct comedi_lrange range_unknown;
#define range_digital range_unipolar5
diff --git a/drivers/staging/comedi/drivers/ni_daq_dio24.c
b/drivers/staging/comedi/drivers/ni_daq_dio24.c
index d9de83a..ff3716c 100644
--- a/drivers/staging/comedi/drivers/ni_daq_dio24.c
+++ b/drivers/staging/comedi/drivers/ni_daq_dio24.c
@@ -1,35 +1,35 @@
/*
-comedi/drivers/ni_daq_dio24.c
-Driver for National Instruments PCMCIA DAQ-Card DIO-24
-Copyright (C) 2002 Daniel Vecino Castel <dvec...@able.es>
+ * comedi/drivers/ni_daq_dio24.c
+ * Driver for National Instruments PCMCIA DAQ-Card DIO-24
+ * Copyright (C) 2002 Daniel Vecino Castel <dvec...@able.es>
-PCMCIA crap at end of file is adapted from dummy_cs.c 1.31
-2001/08/24 12:13:13 from the pcmcia package.
-The initial developer of the pcmcia dummy_cs.c code is David A. Hinds
-<dahi...@users.sourceforge.net>. Portions created by David A. Hinds
-are Copyright (C) 1999 David A. Hinds. All Rights Reserved.
+ * PCMCIA crap at end of file is adapted from dummy_cs.c 1.31
+ * 2001/08/24 12:13:13 from the pcmcia package.
+ * The initial developer of the pcmcia dummy_cs.c code is David A. Hinds
+ * <dahi...@users.sourceforge.net>. Portions created by David A. Hinds
+ * are Copyright (C) 1999 David A. Hinds. All Rights Reserved.
-This program is free software; you can redistribute it and/or modify
-it under the terms of the GNU General Public License as published by
-the Free Software Foundation; either version 2 of the License, or
-(at your option) any later version.
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
-This program is distributed in the hope that it will be useful,
-but WITHOUT ANY WARRANTY; without even the implied warranty of
-MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
-GNU General Public License for more details.
-*/
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ */
/*
-Driver: ni_daq_dio24
-Description: National Instruments PCMCIA DAQ-Card DIO-24
-Author: Daniel Vecino Castel <dvec...@able.es>
-Devices: [National Instruments] PCMCIA DAQ-Card DIO-24 (ni_daq_dio24)
-Status: ?
-Updated: Thu, 07 Nov 2002 21:53:06 -0800
+ * Driver: ni_daq_dio24
+ * Description: National Instruments PCMCIA DAQ-Card DIO-24
+ * Author: Daniel Vecino Castel <dvec...@able.es>
+ * Devices: [National Instruments] PCMCIA DAQ-Card DIO-24 (ni_daq_dio24)
+ * Status: ?
+ * Updated: Thu, 07 Nov 2002 21:53:06 -0800
-This is just a wrapper around the 8255.o driver to properly handle
-the PCMCIA interface.
-*/
+ * This is just a wrapper around the 8255.o driver to properly handle
+ * the PCMCIA interface.
+ */
#include
#include "../comedi_pcmcia.h"
--
2.5.5
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 1/2] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.
This is a patch to the ni_daq_dio24.c that fixes checkpatch warning: WARNING: Block comments use * on subsequent lines Signed-off-by: Amit Ghadge <amitg@gmail.com> --- drivers/staging/comedi/drivers/ni_daq_dio24.c | 52 +-- 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/drivers/staging/comedi/drivers/ni_daq_dio24.c b/drivers/staging/comedi/drivers/ni_daq_dio24.c index d9de83a..ff3716c 100644 --- a/drivers/staging/comedi/drivers/ni_daq_dio24.c +++ b/drivers/staging/comedi/drivers/ni_daq_dio24.c @@ -1,35 +1,35 @@ /* -comedi/drivers/ni_daq_dio24.c -Driver for National Instruments PCMCIA DAQ-Card DIO-24 -Copyright (C) 2002 Daniel Vecino Castel <dvec...@able.es> + * comedi/drivers/ni_daq_dio24.c + * Driver for National Instruments PCMCIA DAQ-Card DIO-24 + * Copyright (C) 2002 Daniel Vecino Castel <dvec...@able.es> -PCMCIA crap at end of file is adapted from dummy_cs.c 1.31 -2001/08/24 12:13:13 from the pcmcia package. -The initial developer of the pcmcia dummy_cs.c code is David A. Hinds -<dahi...@users.sourceforge.net>. Portions created by David A. Hinds -are Copyright (C) 1999 David A. Hinds. All Rights Reserved. + * PCMCIA crap at end of file is adapted from dummy_cs.c 1.31 + * 2001/08/24 12:13:13 from the pcmcia package. + * The initial developer of the pcmcia dummy_cs.c code is David A. Hinds + * <dahi...@users.sourceforge.net>. Portions created by David A. Hinds + * are Copyright (C) 1999 David A. Hinds. All Rights Reserved. -This program is free software; you can redistribute it and/or modify -it under the terms of the GNU General Public License as published by -the Free Software Foundation; either version 2 of the License, or -(at your option) any later version. + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. -This program is distributed in the hope that it will be useful, -but WITHOUT ANY WARRANTY; without even the implied warranty of -MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -GNU General Public License for more details. -*/ + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ /* -Driver: ni_daq_dio24 -Description: National Instruments PCMCIA DAQ-Card DIO-24 -Author: Daniel Vecino Castel <dvec...@able.es> -Devices: [National Instruments] PCMCIA DAQ-Card DIO-24 (ni_daq_dio24) -Status: ? -Updated: Thu, 07 Nov 2002 21:53:06 -0800 + * Driver: ni_daq_dio24 + * Description: National Instruments PCMCIA DAQ-Card DIO-24 + * Author: Daniel Vecino Castel <dvec...@able.es> + * Devices: [National Instruments] PCMCIA DAQ-Card DIO-24 (ni_daq_dio24) + * Status: ? + * Updated: Thu, 07 Nov 2002 21:53:06 -0800 -This is just a wrapper around the 8255.o driver to properly handle -the PCMCIA interface. -*/ + * This is just a wrapper around the 8255.o driver to properly handle + * the PCMCIA interface. + */ #include #include "../comedi_pcmcia.h" -- 2.5.5 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 2/2] Staging: comedi: pcl726.c, ni_670x.c: Fix warnings and check.
pcl726.c:
Replace CamelCase range_0_20mA by range_0_20ma
ni_670x.c:
Fixes checkpatch warning:
WARNING: Block comments use * on subsequent lines
Replace (1<<7) by BIT(7) in the file ni_670x.c to get rid
of checkpatch.pl "CHECK" output "Prefer using the BIT macro".
Replace CamelCase range_0_20mA to range_0_20ma.
Signed-off-by: Amit Ghadge <amitg@gmail.com>
---
drivers/staging/comedi/drivers/ni_670x.c | 66
drivers/staging/comedi/drivers/pcl726.c | 2 +-
2 files changed, 33 insertions(+), 35 deletions(-)
diff --git a/drivers/staging/comedi/drivers/ni_670x.c
b/drivers/staging/comedi/drivers/ni_670x.c
index 3e7271880..86d26aa 100644
--- a/drivers/staging/comedi/drivers/ni_670x.c
+++ b/drivers/staging/comedi/drivers/ni_670x.c
@@ -1,40 +1,38 @@
/*
-comedi/drivers/ni_670x.c
-Hardware driver for NI 670x devices
-
-COMEDI - Linux Control and Measurement Device Interface
-Copyright (C) 1997-2001 David A. Schleef <d...@schleef.org>
-
-This program is free software; you can redistribute it and/or modify
-it under the terms of the GNU General Public License as published by
-the Free Software Foundation; either version 2 of the License, or
-(at your option) any later version.
-
-This program is distributed in the hope that it will be useful,
-but WITHOUT ANY WARRANTY; without even the implied warranty of
-MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
-GNU General Public License for more details.
-*/
+ * comedi/drivers/ni_670x.c
+ * Hardware driver for NI 670x devices
+
+ * COMEDI - Linux Control and Measurement Device Interface
+ * Copyright (C) 1997-2001 David A. Schleef <d...@schleef.org>
+
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ */
/*
-Driver: ni_670x
-Description: National Instruments 670x
-Author: Bart Joris <bjo...@advalvas.be>
-Updated: Wed, 11 Dec 2002 18:25:35 -0800
-Devices: [National Instruments] PCI-6703 (ni_670x), PCI-6704
-Status: unknown
-
-Commands are not supported.
-*/
-
+ * Driver: ni_670x
+ * Description: National Instruments 670x
+ * Author: Bart Joris <bjo...@advalvas.be>
+ * Updated: Wed, 11 Dec 2002 18:25:35 -0800
+ * Devices: [National Instruments] PCI-6703 (ni_670x), PCI-6704
+ * Status: unknown
+
+ * Commands are not supported.
+ */
/*
- Bart Joris <bjo...@advalvas.be> Last updated on 20/08/2001
-
- Manuals:
+ * Bart Joris <bjo...@advalvas.be> Last updated on 20/08/2001
- 322110a.pdf PCI/PXI-6704 User Manual
- 322110b.pdf PCI/PXI-6703/6704 User Manual
+ * Manuals:
-*/
+ * 322110a.pdf PCI/PXI-6704 User Manual
+ * 322110b.pdf PCI/PXI-6703/6704 User Manual
+ */
#include
#include
@@ -147,7 +145,7 @@ static int ni_670x_dio_insn_config(struct comedi_device
*dev,
/* ripped from mite.h and mite_setup2() to avoid mite dependency */
#define MITE_IODWBSR 0xc0 /* IO Device Window Base Size Register */
-#define WENAB (1 << 7) /* window enable */
+#define WENAB BIT(7) /* window enable */
static int ni_670x_mite_init(struct pci_dev *pcidev)
{
@@ -222,7 +220,7 @@ static int ni_670x_auto_attach(struct comedi_device *dev,
s->range_table_list = range_table_list;
for (i = 0; i < 16; i++) {
range_table_list[i] = _bipolar10;
- range_table_list[16 + i] = _0_20mA;
+ range_table_list[16 + i] = _0_20ma;
}
} else {
s->range_table = _bipolar10;
diff --git a/drivers/staging/comedi/drivers/pcl726.c
b/drivers/staging/comedi/drivers/pcl726.c
index 256850c..8664cb2 100644
--- a/drivers/staging/comedi/drivers/pcl726.c
+++ b/drivers/staging/comedi/drivers/pcl726.c
@@ -96,7 +96,7 @@ static const struct comedi_lrange *const rangelist_728[] = {
_bipolar5,
_bipolar10,
_4_20mA,
- _0_20mA
+ _0_20ma
};
struct pcl726_board {
--
2.5.5
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 1/2] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.
This is a patch to the ni_daq_dio24.c that fixes checkpatch warning: WARNING: Block comments use * on subsequent lines Signed-off-by: Amit Ghadge <amitg@gmail.com> --- drivers/staging/comedi/drivers/ni_daq_dio24.c | 52 +-- 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/drivers/staging/comedi/drivers/ni_daq_dio24.c b/drivers/staging/comedi/drivers/ni_daq_dio24.c index d9de83a..ff3716c 100644 --- a/drivers/staging/comedi/drivers/ni_daq_dio24.c +++ b/drivers/staging/comedi/drivers/ni_daq_dio24.c @@ -1,35 +1,35 @@ /* -comedi/drivers/ni_daq_dio24.c -Driver for National Instruments PCMCIA DAQ-Card DIO-24 -Copyright (C) 2002 Daniel Vecino Castel <dvec...@able.es> + * comedi/drivers/ni_daq_dio24.c + * Driver for National Instruments PCMCIA DAQ-Card DIO-24 + * Copyright (C) 2002 Daniel Vecino Castel <dvec...@able.es> -PCMCIA crap at end of file is adapted from dummy_cs.c 1.31 -2001/08/24 12:13:13 from the pcmcia package. -The initial developer of the pcmcia dummy_cs.c code is David A. Hinds -<dahi...@users.sourceforge.net>. Portions created by David A. Hinds -are Copyright (C) 1999 David A. Hinds. All Rights Reserved. + * PCMCIA crap at end of file is adapted from dummy_cs.c 1.31 + * 2001/08/24 12:13:13 from the pcmcia package. + * The initial developer of the pcmcia dummy_cs.c code is David A. Hinds + * <dahi...@users.sourceforge.net>. Portions created by David A. Hinds + * are Copyright (C) 1999 David A. Hinds. All Rights Reserved. -This program is free software; you can redistribute it and/or modify -it under the terms of the GNU General Public License as published by -the Free Software Foundation; either version 2 of the License, or -(at your option) any later version. + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. -This program is distributed in the hope that it will be useful, -but WITHOUT ANY WARRANTY; without even the implied warranty of -MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -GNU General Public License for more details. -*/ + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ /* -Driver: ni_daq_dio24 -Description: National Instruments PCMCIA DAQ-Card DIO-24 -Author: Daniel Vecino Castel <dvec...@able.es> -Devices: [National Instruments] PCMCIA DAQ-Card DIO-24 (ni_daq_dio24) -Status: ? -Updated: Thu, 07 Nov 2002 21:53:06 -0800 + * Driver: ni_daq_dio24 + * Description: National Instruments PCMCIA DAQ-Card DIO-24 + * Author: Daniel Vecino Castel <dvec...@able.es> + * Devices: [National Instruments] PCMCIA DAQ-Card DIO-24 (ni_daq_dio24) + * Status: ? + * Updated: Thu, 07 Nov 2002 21:53:06 -0800 -This is just a wrapper around the 8255.o driver to properly handle -the PCMCIA interface. -*/ + * This is just a wrapper around the 8255.o driver to properly handle + * the PCMCIA interface. + */ #include #include "../comedi_pcmcia.h" -- 2.5.5 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 2/2] Staging: comedi: ni_670x.c: Fix warnings and check.
Fixes checkpatch warning:
WARNING: Block comments use * on subsequent lines
Replace (1<<7) by BIT(7) in the file ni_670x.c to get rid
of checkpatch.pl "CHECK" output "Prefer using the BIT macro".
Replace Avoid CamelCase range_0_20mA to range_0_20ma.
Signed-off-by: Amit Ghadge <amitg@gmail.com>
---
drivers/staging/comedi/drivers/ni_670x.c | 66
1 file changed, 32 insertions(+), 34 deletions(-)
diff --git a/drivers/staging/comedi/drivers/ni_670x.c
b/drivers/staging/comedi/drivers/ni_670x.c
index 3e7271880..86d26aa 100644
--- a/drivers/staging/comedi/drivers/ni_670x.c
+++ b/drivers/staging/comedi/drivers/ni_670x.c
@@ -1,40 +1,38 @@
/*
-comedi/drivers/ni_670x.c
-Hardware driver for NI 670x devices
-
-COMEDI - Linux Control and Measurement Device Interface
-Copyright (C) 1997-2001 David A. Schleef <d...@schleef.org>
-
-This program is free software; you can redistribute it and/or modify
-it under the terms of the GNU General Public License as published by
-the Free Software Foundation; either version 2 of the License, or
-(at your option) any later version.
-
-This program is distributed in the hope that it will be useful,
-but WITHOUT ANY WARRANTY; without even the implied warranty of
-MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
-GNU General Public License for more details.
-*/
+ * comedi/drivers/ni_670x.c
+ * Hardware driver for NI 670x devices
+
+ * COMEDI - Linux Control and Measurement Device Interface
+ * Copyright (C) 1997-2001 David A. Schleef <d...@schleef.org>
+
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ */
/*
-Driver: ni_670x
-Description: National Instruments 670x
-Author: Bart Joris <bjo...@advalvas.be>
-Updated: Wed, 11 Dec 2002 18:25:35 -0800
-Devices: [National Instruments] PCI-6703 (ni_670x), PCI-6704
-Status: unknown
-
-Commands are not supported.
-*/
-
+ * Driver: ni_670x
+ * Description: National Instruments 670x
+ * Author: Bart Joris <bjo...@advalvas.be>
+ * Updated: Wed, 11 Dec 2002 18:25:35 -0800
+ * Devices: [National Instruments] PCI-6703 (ni_670x), PCI-6704
+ * Status: unknown
+
+ * Commands are not supported.
+ */
/*
- Bart Joris <bjo...@advalvas.be> Last updated on 20/08/2001
-
- Manuals:
+ * Bart Joris <bjo...@advalvas.be> Last updated on 20/08/2001
- 322110a.pdf PCI/PXI-6704 User Manual
- 322110b.pdf PCI/PXI-6703/6704 User Manual
+ * Manuals:
-*/
+ * 322110a.pdf PCI/PXI-6704 User Manual
+ * 322110b.pdf PCI/PXI-6703/6704 User Manual
+ */
#include
#include
@@ -147,7 +145,7 @@ static int ni_670x_dio_insn_config(struct comedi_device
*dev,
/* ripped from mite.h and mite_setup2() to avoid mite dependency */
#define MITE_IODWBSR 0xc0 /* IO Device Window Base Size Register */
-#define WENAB (1 << 7) /* window enable */
+#define WENAB BIT(7) /* window enable */
static int ni_670x_mite_init(struct pci_dev *pcidev)
{
@@ -222,7 +220,7 @@ static int ni_670x_auto_attach(struct comedi_device *dev,
s->range_table_list = range_table_list;
for (i = 0; i < 16; i++) {
range_table_list[i] = _bipolar10;
- range_table_list[16 + i] = _0_20mA;
+ range_table_list[16 + i] = _0_20ma;
}
} else {
s->range_table = _bipolar10;
--
2.5.5
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.
This is a patch to the ni_daq_dio24.c that fixes checkpatch warning: WARNING: Block comments use * on subsequent lines Signed-off-by: Amit Ghadge <amitg@gmail.com> --- drivers/staging/comedi/drivers/ni_daq_dio24.c | 52 +-- 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/drivers/staging/comedi/drivers/ni_daq_dio24.c b/drivers/staging/comedi/drivers/ni_daq_dio24.c index d9de83a..ff3716c 100644 --- a/drivers/staging/comedi/drivers/ni_daq_dio24.c +++ b/drivers/staging/comedi/drivers/ni_daq_dio24.c @@ -1,35 +1,35 @@ /* -comedi/drivers/ni_daq_dio24.c -Driver for National Instruments PCMCIA DAQ-Card DIO-24 -Copyright (C) 2002 Daniel Vecino Castel <dvec...@able.es> + * comedi/drivers/ni_daq_dio24.c + * Driver for National Instruments PCMCIA DAQ-Card DIO-24 + * Copyright (C) 2002 Daniel Vecino Castel <dvec...@able.es> -PCMCIA crap at end of file is adapted from dummy_cs.c 1.31 -2001/08/24 12:13:13 from the pcmcia package. -The initial developer of the pcmcia dummy_cs.c code is David A. Hinds -<dahi...@users.sourceforge.net>. Portions created by David A. Hinds -are Copyright (C) 1999 David A. Hinds. All Rights Reserved. + * PCMCIA crap at end of file is adapted from dummy_cs.c 1.31 + * 2001/08/24 12:13:13 from the pcmcia package. + * The initial developer of the pcmcia dummy_cs.c code is David A. Hinds + * <dahi...@users.sourceforge.net>. Portions created by David A. Hinds + * are Copyright (C) 1999 David A. Hinds. All Rights Reserved. -This program is free software; you can redistribute it and/or modify -it under the terms of the GNU General Public License as published by -the Free Software Foundation; either version 2 of the License, or -(at your option) any later version. + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. -This program is distributed in the hope that it will be useful, -but WITHOUT ANY WARRANTY; without even the implied warranty of -MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -GNU General Public License for more details. -*/ + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ /* -Driver: ni_daq_dio24 -Description: National Instruments PCMCIA DAQ-Card DIO-24 -Author: Daniel Vecino Castel <dvec...@able.es> -Devices: [National Instruments] PCMCIA DAQ-Card DIO-24 (ni_daq_dio24) -Status: ? -Updated: Thu, 07 Nov 2002 21:53:06 -0800 + * Driver: ni_daq_dio24 + * Description: National Instruments PCMCIA DAQ-Card DIO-24 + * Author: Daniel Vecino Castel <dvec...@able.es> + * Devices: [National Instruments] PCMCIA DAQ-Card DIO-24 (ni_daq_dio24) + * Status: ? + * Updated: Thu, 07 Nov 2002 21:53:06 -0800 -This is just a wrapper around the 8255.o driver to properly handle -the PCMCIA interface. -*/ + * This is just a wrapper around the 8255.o driver to properly handle + * the PCMCIA interface. + */ #include #include "../comedi_pcmcia.h" -- 2.5.5 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] [PATCH] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.
This is a patch to the ni_daq_dio24.c that fixes checkpatch warning: WARNING: Block comments use * on subsequent lines Signed-off-by: Amit Ghadge <amitg@gmail.com> --- drivers/staging/comedi/drivers/ni_daq_dio24.c | 52 +-- 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/drivers/staging/comedi/drivers/ni_daq_dio24.c b/drivers/staging/comedi/drivers/ni_daq_dio24.c index d9de83a..ff3716c 100644 --- a/drivers/staging/comedi/drivers/ni_daq_dio24.c +++ b/drivers/staging/comedi/drivers/ni_daq_dio24.c @@ -1,35 +1,35 @@ /* -comedi/drivers/ni_daq_dio24.c -Driver for National Instruments PCMCIA DAQ-Card DIO-24 -Copyright (C) 2002 Daniel Vecino Castel <dvec...@able.es> + * comedi/drivers/ni_daq_dio24.c + * Driver for National Instruments PCMCIA DAQ-Card DIO-24 + * Copyright (C) 2002 Daniel Vecino Castel <dvec...@able.es> -PCMCIA crap at end of file is adapted from dummy_cs.c 1.31 -2001/08/24 12:13:13 from the pcmcia package. -The initial developer of the pcmcia dummy_cs.c code is David A. Hinds -<dahi...@users.sourceforge.net>. Portions created by David A. Hinds -are Copyright (C) 1999 David A. Hinds. All Rights Reserved. + * PCMCIA crap at end of file is adapted from dummy_cs.c 1.31 + * 2001/08/24 12:13:13 from the pcmcia package. + * The initial developer of the pcmcia dummy_cs.c code is David A. Hinds + * <dahi...@users.sourceforge.net>. Portions created by David A. Hinds + * are Copyright (C) 1999 David A. Hinds. All Rights Reserved. -This program is free software; you can redistribute it and/or modify -it under the terms of the GNU General Public License as published by -the Free Software Foundation; either version 2 of the License, or -(at your option) any later version. + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. -This program is distributed in the hope that it will be useful, -but WITHOUT ANY WARRANTY; without even the implied warranty of -MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -GNU General Public License for more details. -*/ + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ /* -Driver: ni_daq_dio24 -Description: National Instruments PCMCIA DAQ-Card DIO-24 -Author: Daniel Vecino Castel <dvec...@able.es> -Devices: [National Instruments] PCMCIA DAQ-Card DIO-24 (ni_daq_dio24) -Status: ? -Updated: Thu, 07 Nov 2002 21:53:06 -0800 + * Driver: ni_daq_dio24 + * Description: National Instruments PCMCIA DAQ-Card DIO-24 + * Author: Daniel Vecino Castel <dvec...@able.es> + * Devices: [National Instruments] PCMCIA DAQ-Card DIO-24 (ni_daq_dio24) + * Status: ? + * Updated: Thu, 07 Nov 2002 21:53:06 -0800 -This is just a wrapper around the 8255.o driver to properly handle -the PCMCIA interface. -*/ + * This is just a wrapper around the 8255.o driver to properly handle + * the PCMCIA interface. + */ #include #include "../comedi_pcmcia.h" -- 2.5.5 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Staging: comedi: quatech_daqp_cs.c: fixed a warning issue
On Tue, May 17, 2016 at 06:47:56AM -0700, Greg KH wrote: > A: http://en.wikipedia.org/wiki/Top_post > Q: Were do I find info about this thing called top-posting? > A: Because it messes up the order in which people normally read text. > Q: Why is top-posting such a bad thing? > A: Top-posting. > Q: What is the most annoying thing in e-mail? > > A: No. > Q: Should I include quotations after my reply? > > http://daringfireball.net/2007/07/on_top Thanks for this valuable information. > > On Tue, May 17, 2016 at 09:31:56AM +0530, Amit Ghadge wrote: > > Hello Greg KH, > > > > I make patch same like other, I'm new and I nerver see changelog in other > > patches. > > > > Where to add changelog? I followed you are tutorial. > > It's the area in the email before the patch, it ends up in the changelog > when the patch is committed to the kernel tree. You wrote something > this time, but it was vague and didn't make sense. Please fix that up > and resend. I resend this patch with patch description. > > greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] Staging: comedi: quatech_daqp_cs.c: Fix a unsigned warning issue
This is a patch to the quatech_daqp_cs.c file that fixes by using
unsigned int instead of unsigned, following warning found by checkpatch.
* WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
Signed-off-by: Amit Ghadge <amitg@gmail.com>
---
drivers/staging/comedi/drivers/quatech_daqp_cs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/quatech_daqp_cs.c
b/drivers/staging/comedi/drivers/quatech_daqp_cs.c
index e9e4313..802f51e 100644
--- a/drivers/staging/comedi/drivers/quatech_daqp_cs.c
+++ b/drivers/staging/comedi/drivers/quatech_daqp_cs.c
@@ -643,7 +643,7 @@ static int daqp_ao_insn_write(struct comedi_device *dev,
outb(0, dev->iobase + DAQP_AUX_REG);
for (i = 0; i > insn->n; i++) {
- unsigned val = data[i];
+ unsigned int val = data[i];
int ret;
/* D/A transfer rate is about 8ms */
--
2.5.5
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Staging: comedi: quatech_daqp_cs.c: fixed a warning issue
Hello Greg KH, I make patch same like other, I'm new and I nerver see changelog in other patches. Where to add changelog? I followed you are tutorial. Thanks, Amit Ghadge On Mon, May 16, 2016 at 08:34:55PM -0700, Greg KH wrote: > > A: No. > Q: Should I include quotations after my reply? > > http://daringfireball.net/2007/07/on_top > > On Tue, May 17, 2016 at 08:55:56AM +0530, Amit Ghadge wrote: > > I check with "./scripts/checkpatch.pl --file --terse > > drivers/staging/comedi/drivers/quatech_daqp_cs.c" and show the warning > > message, > > > > drivers/staging/comedi/drivers/quatech_daqp_cs.c:646: WARNING: Prefer > > 'unsigned int' to bare use of 'unsigned' > > > > This patch reduced the warning message. > > Why didn't you put that information in the changelog area? > > Please do so. > > greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Staging: comedi: quatech_daqp_cs.c: fixed a warning issue
I check with "./scripts/checkpatch.pl --file --terse drivers/staging/comedi/drivers/quatech_daqp_cs.c" and show the warning message, "drivers/staging/comedi/drivers/quatech_daqp_cs.c:646: WARNING: Prefer 'unsigned int' to bare use of 'unsigned'" This patch reduced the warning message. On Mon, May 16, 2016 at 11:19:05AM -0700, Greg KH wrote: > On Mon, May 16, 2016 at 11:04:31PM +0530, Amit Ghadge wrote: > > Fixed a warning issue to use 'unsigned int'. > > > > build warning? I don't see that anywhere in the build output. > > Please be specific. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] Staging: comedi: quatech_daqp_cs.c: fixed a warning issue
Fixed a warning issue to use 'unsigned int'.
Signed-off-by: Amit Ghadge <amitg@gmail.com>
---
drivers/staging/comedi/drivers/quatech_daqp_cs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/quatech_daqp_cs.c
b/drivers/staging/comedi/drivers/quatech_daqp_cs.c
index e9e4313..802f51e 100644
--- a/drivers/staging/comedi/drivers/quatech_daqp_cs.c
+++ b/drivers/staging/comedi/drivers/quatech_daqp_cs.c
@@ -643,7 +643,7 @@ static int daqp_ao_insn_write(struct comedi_device *dev,
outb(0, dev->iobase + DAQP_AUX_REG);
for (i = 0; i > insn->n; i++) {
- unsigned val = data[i];
+ unsigned int val = data[i];
int ret;
/* D/A transfer rate is about 8ms */
--
2.5.5
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] Staging: comedi: quatech_daqp_cs.c: fixed a warning added missing 'int' in 'unsigned'.
Signed-off-by: Amit Ghadge <amitg@gmail.com>
---
drivers/staging/comedi/drivers/quatech_daqp_cs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/quatech_daqp_cs.c
b/drivers/staging/comedi/drivers/quatech_daqp_cs.c
index e9e4313..802f51e 100644
--- a/drivers/staging/comedi/drivers/quatech_daqp_cs.c
+++ b/drivers/staging/comedi/drivers/quatech_daqp_cs.c
@@ -643,7 +643,7 @@ static int daqp_ao_insn_write(struct comedi_device *dev,
outb(0, dev->iobase + DAQP_AUX_REG);
for (i = 0; i > insn->n; i++) {
- unsigned val = data[i];
+ unsigned int val = data[i];
int ret;
/* D/A transfer rate is about 8ms */
--
2.5.0
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
