[PATCH v3] staging: wimax: Fix block comment style issue in stack.c
This change fixes a checkpatch warning for "Block comments use
* on subsequent lines". It removes the unnecessary block comment.
Signed-off-by: Amrit Khera
---
Changes in v3:
- Updated commit message, as suggested by Greg KH
- Removed the whole comment, as suggested by Dan Carpenter
drivers/staging/wimax/stack.c | 14 --
1 file changed, 14 deletions(-)
diff --git a/drivers/staging/wimax/stack.c b/drivers/staging/wimax/stack.c
index ace24a6dfd2d..0d2e3d5f3691 100644
--- a/drivers/staging/wimax/stack.c
+++ b/drivers/staging/wimax/stack.c
@@ -55,20 +55,6 @@ MODULE_PARM_DESC(debug,
"are the different debug submodules and VALUE are the "
"initial debug value to set.");
-/*
- * Authoritative source for the RE_STATE_CHANGE attribute policy
- *
- * We don't really use it here, but /me likes to keep the definition
- * close to where the data is generated.
- */
-/*
-static const struct nla_policy wimax_gnl_re_status_change[WIMAX_GNL_ATTR_MAX +
1] = {
- [WIMAX_GNL_STCH_STATE_OLD] = { .type = NLA_U8 },
- [WIMAX_GNL_STCH_STATE_NEW] = { .type = NLA_U8 },
-};
-*/
-
-
/*
* Allocate a Report State Change message
*
--
2.20.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2] staging: wimax: Fix block comment style issue in stack.c
This change fixes a checkpatch warning for "Block comments
use * on subsequent lines".
Signed-off-by: Amrit Khera
---
Changes in v2:
- Removed the comment entirely, as suggested by Greg KH
drivers/staging/wimax/stack.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/drivers/staging/wimax/stack.c b/drivers/staging/wimax/stack.c
index ace24a6dfd2d..345a022810ef 100644
--- a/drivers/staging/wimax/stack.c
+++ b/drivers/staging/wimax/stack.c
@@ -57,17 +57,7 @@ MODULE_PARM_DESC(debug,
/*
* Authoritative source for the RE_STATE_CHANGE attribute policy
- *
- * We don't really use it here, but /me likes to keep the definition
- * close to where the data is generated.
*/
-/*
-static const struct nla_policy wimax_gnl_re_status_change[WIMAX_GNL_ATTR_MAX +
1] = {
- [WIMAX_GNL_STCH_STATE_OLD] = { .type = NLA_U8 },
- [WIMAX_GNL_STCH_STATE_NEW] = { .type = NLA_U8 },
-};
-*/
-
/*
* Allocate a Report State Change message
--
2.20.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: wimax: Fix block comment style issue in stack.c
This change fixes a checkpatch warning for "Block comments
use * on subsequent lines".
Signed-off-by: Amrit Khera
---
drivers/staging/wimax/stack.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/wimax/stack.c b/drivers/staging/wimax/stack.c
index ace24a6dfd2d..78142615 100644
--- a/drivers/staging/wimax/stack.c
+++ b/drivers/staging/wimax/stack.c
@@ -62,11 +62,12 @@ MODULE_PARM_DESC(debug,
* close to where the data is generated.
*/
/*
-static const struct nla_policy wimax_gnl_re_status_change[WIMAX_GNL_ATTR_MAX +
1] = {
- [WIMAX_GNL_STCH_STATE_OLD] = { .type = NLA_U8 },
- [WIMAX_GNL_STCH_STATE_NEW] = { .type = NLA_U8 },
-};
-*/
+ * static const struct nla_policy
+ * wimax_gnl_re_status_change[WIMAX_GNL_ATTR_MAX + 1] = {
+ * [WIMAX_GNL_STCH_STATE_OLD] = { .type = NLA_U8 },
+ * [WIMAX_GNL_STCH_STATE_NEW] = { .type = NLA_U8 },
+ * };
+ */
/*
--
2.20.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: greybus: Fix blank line style issue in sdio.c
This change fixes a checkpatch check for "Please don't use
multiple blank lines".
Signed-off-by: Amrit Khera
---
drivers/staging/greybus/sdio.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/greybus/sdio.c b/drivers/staging/greybus/sdio.c
index 0939f4a4c963..37bf04c22dbc 100644
--- a/drivers/staging/greybus/sdio.c
+++ b/drivers/staging/greybus/sdio.c
@@ -33,7 +33,6 @@ struct gb_sdio_host {
boolread_only;
};
-
#define GB_SDIO_RSP_R1_R5_R6_R7(GB_SDIO_RSP_PRESENT | GB_SDIO_RSP_CRC
| \
GB_SDIO_RSP_OPCODE)
#define GB_SDIO_RSP_R3_R4 (GB_SDIO_RSP_PRESENT)
--
2.20.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2] staging: android: Fix const keyword style issue in ashmem.c
On Fri, Feb 19, 2021 at 01:12:49PM +0100, Greg KH wrote: > On Fri, Feb 19, 2021 at 05:12:38PM +0530, Amrit Khera wrote: > > This change fixes a checkpatch warning for "struct file_operations > > should normally be const". > > > > Signed-off-by: Amrit Khera > > --- > > Changes in v2: > > - Wrapped the commit description > > - Build tested > > If you tested it, what changed in the diff itself? Looks the same to > me... > After further investigating I found that the particular kernel module was not set in the config file. This did not build it when I built the kernel. This was making me think that the module was building correctly. After updating the config, the build indeed breaks. The reason is that the const keyword cannot be applied here without changing the structure and flow of the code as the particular variable is later being set in a condition. Hence, I will be dropping this path for now. Apologies for the inconvenience caused and thank you for the prompt replies. Best Regards, Amrit Khera ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2] staging: android: Fix const keyword style issue in ashmem.c
This change fixes a checkpatch warning for "struct file_operations
should normally be const".
Signed-off-by: Amrit Khera
---
Changes in v2:
- Wrapped the commit description
- Build tested
---
drivers/staging/android/ashmem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c
index d66a64e42273..7854fd410efa 100644
--- a/drivers/staging/android/ashmem.c
+++ b/drivers/staging/android/ashmem.c
@@ -376,7 +376,7 @@ ashmem_vmfile_get_unmapped_area(struct file *file, unsigned
long addr,
static int ashmem_mmap(struct file *file, struct vm_area_struct *vma)
{
- static struct file_operations vmfile_fops;
+ static const struct file_operations vmfile_fops;
struct ashmem_area *asma = file->private_data;
int ret = 0;
--
2.20.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: android: Fix const keyword style issue in ashmem.c
This change fixes a checkpatch warning for "struct file_operations should
normally be const".
Signed-off-by: Amrit Khera
---
drivers/staging/android/ashmem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c
index d66a64e42273..7854fd410efa 100644
--- a/drivers/staging/android/ashmem.c
+++ b/drivers/staging/android/ashmem.c
@@ -376,7 +376,7 @@ ashmem_vmfile_get_unmapped_area(struct file *file, unsigned
long addr,
static int ashmem_mmap(struct file *file, struct vm_area_struct *vma)
{
- static struct file_operations vmfile_fops;
+ static const struct file_operations vmfile_fops;
struct ashmem_area *asma = file->private_data;
int ret = 0;
--
2.20.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
