Re: [PATCH v2] staging: intel-gwdpa: gswip: Introduce Gigabit Ethernet Switch (GSWIP) device driver
Hi Dan, On 11/12/2019 6:58 PM, Dan Carpenter wrote: This should just be sent to netdev. I spotted a couple bugs. 1) enable/disable we flipped xgmac_set_xgmii_2500_speed() 2) retries wasn't reset in a couple places. I had a few tiny style nits as well but there is no reason to send it to staging. regards, dan carpenter Thanks for the review and comments. We will fix the bug and address the comments. Best regards, Chng Jack Ping ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v1] staging: intel-dpa: gswip: Introduce Gigabit Ethernet Switch (GSWIP) device driver
On Mon, Nov 04, 2019 at 01:20:09PM +0100, Greg KH wrote: On Mon, Nov 04, 2019 at 07:22:20PM +0800, Jack Ping CHNG wrote: This driver enables the Intel's LGM SoC GSWIP block. GSWIP is a core module tailored for L2/L3/L4+ data plane and QoS functions. It allows CPUs and other accelerators connected to the SoC datapath to enqueue and dequeue packets through DMAs. Most configuration values are stored in tables such as Parsing and Classification Engine tables, Buffer Manager tables and Pseudo MAC tables. Why is this being submitted to staging? What is wrong with the "real" part of the kernel for this? Or even, what is wrong with the current driver? drivers/net/dsa/lantiq_gswip.c? GSWIP (a new HW IP) is part of Intel Datapath Architecture drivers design for new Intel network/GW SoC (LGM). Currently there are few other drivers (for different HW blocks in the datapath) which are still under internal code review. Once it is done we are planning to submit staging folder. Since the development is ongoing, we thought it is best to submit GSWIP first in drivers/staging/intel-dpa folder. In the meantime, we will prepare a more detail TODO list for intel-dpa folder and a README to introduce the dpa. Jack, your patch does not seem to of made it to any of the lists. So i cannot comment on it contents. If this is a switch driver, please ensure you Cc: the usual suspects for switch drivers. Andrew Sure, I will resubmit my patch. Best regards, Chng Jack Ping ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Hello Dear
Hello dear, i hope this letter meets you well? my name is Jack, I know this may seem inappropriate so i ask for your forgiveness, i wish to get to know you better, if I may be so bold. I consider myself an easy-going man, adventurous, honest and fun loving person but I am currently looking for a relationship in which I will feel loved. I promise to answer any question that you may want to ask me...all i need is just your attention and the chance to know you more. Please tell me more about yourself, if you do not mind. Hope to hear back from you soon and i hope this letter will be the beginning of a lasting communication between us. Jack. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Hello Dear
Hello dear, i hope this letter meets you well? my name is Jack, I know this may seem inappropriate so i ask for your forgiveness, i wish to get to know you better, if I may be so bold. I consider myself an easy-going man, adventurous, honest and fun loving person but I am currently looking for a relationship in which I will feel loved. I promise to answer any question that you may want to ask me...all i need is just your attention and the chance to know you more. Please tell me more about yourself, if you do not mind. Hope to hear back from you soon and i hope this letter will be the beginning of a lasting communication between us. Jack. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Hello Beautiful
Hi Dear, my name is Jack and i am seeking for a relationship in which i will feel loved after a series of failed relationships. I am hoping that you would be interested and we could possibly get to know each other more if you do not mind. I am open to answering questions from you as i think my approach is a little inappropriate to begin with. Hope to hear back from you. Jack. Nota de confidencialidad: Este mensaje y todo documento adjunto puede contener informacion confidencial y protegida legalmente bajo secreto profesional. La transmision de esta informacion es privada y esta dirigida unicamente a la persona o entidad indicada, y su acceso por cualquier otra persona no esta autorizado. Si usted ha recibido este mensaje por error, por favor informeselo al remitente y borrelo. El contenido de este mensaje corresponde a la opinion de su autor pero no refleja necesariamente la de Polakof y Cia. S.A., quien tampoco asume responsabilidad por alteraciones que afecten a este mensaje luego de su envio. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
mobile apps for you
Do you need mobile apps development? We can do it for you. We are an India base company. Here are the details about us: Years in business: 8 Staffs: 125 App developed: 350 We work on Android, iOS, Ionic, and PhoneGap platforms, we have clients across different kind of industries. Such like retail, media and entertainment, BFSI, hospitality, social media, eCommerce, food and beverages, etc. We do below: Mobile Apps Mobile App UI/UX designing App Maintenance and Support Website or ecommerce portal development Please reply back if you are interested in what we do. We will share our portfolios to you. Regards, Jack ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
the mobile apps
Do you need mobile apps development? We can do it for you. We are an India base company. Here are the details about us: Years in business: 8 Staffs: 125 App developed: 350 We work on Android, iOS, Ionic, and PhoneGap platforms, we have clients across different kind of industries. Such like retail, media and entertainment, BFSI, hospitality, social media, eCommerce, food and beverages, etc. We do below: Mobile Apps Mobile App UI/UX designing App Maintenance and Support Website or ecommerce portal development Please reply back if you are interested in what we do. We will share our portfolios to you. Regards, Jack ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] Staging: bcm: fix spaces before commas in Bcmchar.c
This is a patch to the Bcmchar.c file that fixes a space before comma warning
found by checkpatch.pl.
Signed-off-by: Jack Wilson
---
drivers/staging/bcm/Bcmchar.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/bcm/Bcmchar.c b/drivers/staging/bcm/Bcmchar.c
index 88ce2da..37a184a 100644
--- a/drivers/staging/bcm/Bcmchar.c
+++ b/drivers/staging/bcm/Bcmchar.c
@@ -1647,7 +1647,7 @@ static int bcm_char_ioctl_flash2x_section_read(void
__user *argp,
read_offset = flash_2x_read.offset;
OutPutBuff = io_buff.OutputBuffer;
- read_buff = kzalloc(buff_size , GFP_KERNEL);
+ read_buff = kzalloc(buff_size, GFP_KERNEL);
if (read_buff == NULL) {
BCM_DEBUG_PRINT(ad, DBG_TYPE_PRINTK, 0, 0,
@@ -2192,7 +2192,7 @@ static int bcm_char_ioctl_nvm_raw_read(void __user *argp,
read_offset = nvm_read.uiOffset;
OutPutBuff = nvm_read.pBuffer;
- read_buff = kzalloc(buff_size , GFP_KERNEL);
+ read_buff = kzalloc(buff_size, GFP_KERNEL);
if (read_buff == NULL) {
BCM_DEBUG_PRINT(ad, DBG_TYPE_PRINTK, 0, 0,
"Memory allocation failed for Flash 2.x Read
Structure");
--
1.9.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: Drivers: scsi: FLUSH timeout
On 09/21/2013 07:24 AM, KY Srinivasan wrote: > > >> -Original Message- >> From: Greg KH [mailto:gre...@linuxfoundation.org] >> Sent: Friday, September 20, 2013 1:32 PM >> To: KY Srinivasan >> Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; >> oher...@suse.com; jbottom...@parallels.com; h...@infradead.org; linux- >> s...@vger.kernel.org >> Subject: Re: Drivers: scsi: FLUSH timeout >> >> On Fri, Sep 20, 2013 at 12:32:27PM -0700, K. Y. Srinivasan wrote: >>> The SD_FLUSH_TIMEOUT value is currently hardcoded. >> >> Hardcoded where? Please, more context. > > This is defined in scsi/sd.h: > > #define SD_FLUSH_TIMEOUT(60 * HZ) >> >>> On our cloud, we sometimes hit this timeout. I was wondering if we >>> could make this a module parameter. If this is acceptable, I can send >>> you a patch for this. >> >> A module parameter don't make sense for a per-device value, does it? > Currently, the 60 second timeout is applied across devices. Ideally, I want > to be > able to control the FLUSH TIMEOUT as we currently do I/O timeout. If this is > acceptable, I can work on a patch for that as well. > > Regards, > > K. Y >> >> greg k-h > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Hi, Back to 2010, Mike(cc-ed) try to add a flush time out interface, similar to what you want here, no idea why it's just ignored? http://www.spinics.net/lists/linux-scsi/msg45017.html Jack ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
