Re: [BUG] staging: r8822be: RTL8822be can't find any wireless AP
2018-07-05 17:32 GMT+08:00 Dan Carpenter : > On Thu, Jul 05, 2018 at 05:26:28PM +0800, Jian-Hong Pan wrote: >> 2018-07-05 15:36 GMT+08:00 Pkshih : >> > On Wed, 2018-07-04 at 10:33 -0500, Daniel Drake wrote: >> >> On Wed, Jul 4, 2018 at 10:13 AM, Larry Finger >> >> wrote: >> >> > We will have to agree to disagree. >> >> > >> >> > I have no idea what the vendors are doing that cause some motherboards >> >> > to >> >> > need a different aspm value. What I do know is that we have had to live >> >> > with >> >> > the idiocy of some vendors saving a few pennies by only including a >> >> > single >> >> > antenna, rather than two, and then making a problem by miscoding the >> >> > EFUSE >> >> > bit that indicates which connector is actually in use. As we have no >> >> > means >> >> > that I know about to detect which boxes have the problem, a module >> >> > parameter >> >> > was created, just as in this case. >> >> > >> >> > I agree that drivers should work "out of the box", but finite resources >> >> > and >> >> > lack of vendor cooperation make this a goal that may not be attainable. >> >> >> >> As you touched on, the ideal situation is that Realtek solve the >> >> issue. Ping-Ke Shih is on CC and I am adding a few more contacts from >> >> the commit log. The context is that the r8822 driver fails on several >> >> platforms unless setting aspm=0 (the default is 1). >> > >> > It's hard to have all laptop or motherboards and all rtl8822be modules in >> > my side, >> > so what I can do is to analyze the issue when user encountered. >> > >> >> >> >> https://gist.github.com/dsd/20c05f0c6d66ee2ef9bfbb17f93f18ba >> >> https://bugzilla.kernel.org/show_bug.cgi?id=199651 >> >> >> >> >> >> If we don't get a timely fix from Realtek though, I think there is a >> >> key difference between the antenna selection headache and this one. In >> >> the antenna case, there isn't a good value that you can set that will >> >> work on all systems. If you change the default behaviour you will >> >> solve the issue for some users while simultanously introducing the >> >> problem on other systems that were previously fine. >> >> >> >> However in this case, it's highly likely that setting aspm=0 (off) by >> >> default would work for everyone. It has the disadvantage of using a >> >> bit more power, but especially with the indications that this issue >> >> affects a significant number of systems, I think that having the >> >> driver working out of the box everywhere is more important. The module >> >> parameter can be left in place so that unaffected users that want to >> >> save power can set aspm=1. >> >> >> > >> > I think this issue may be due to L1 latency, so below patch would be >> > helpful but not sure because I don't have the same laptop. >> > Is there anyone can help to test? >> >> I do not know why I cannot apply this patch directly. So, I apply >> each line manually. >> >> However, here is a good news. I tested this fix, and it works >> correctly on ASUS X530UN. System can scan and get the access points >> list. Finally, it also connects to the access point. >> Maybe, you can have a formal patch for this. >> > > That's good news. What does the "dmesg | grep r8822be" say now? dev@endless:~/linux-eos$ dmesg | grep r8822be [8.538404] r8822be: module is from the staging directory, the quality is unknown, you have been warned. [8.541706] r8822be :02:00.0: enabling device ( -> 0003) [8.571568] r8822be: Using firmware rtlwifi/rtl8822befw.bin [8.572370] r8822be: rtlwifi: wireless switch is on [8.573338] r8822be :02:00.0 wlp2s0: renamed from wlan0 [ 11.346560] Modules linked in: nouveau(+) snd_hda_codec_hdmi snd_hda_codec_realtek snd_hda_codec_generic snd_hda_intel mxm_wmi snd_hda_codec r8822be(C) x86_pkg_temp_thermal snd_hwdep snd_hda_core efivarfs i915 The warning message comes from nouveau. That is no matter. Here is the full dmesg https://gist.github.com/starnight/29b1ead5659868fcfb7f172e51a96535#file-gistfile1-txt Regards, Jian-Hong Pan ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [BUG] staging: r8822be: RTL8822be can't find any wireless AP
2018-07-05 15:36 GMT+08:00 Pkshih : > On Wed, 2018-07-04 at 10:33 -0500, Daniel Drake wrote: >> On Wed, Jul 4, 2018 at 10:13 AM, Larry Finger >> wrote: >> > We will have to agree to disagree. >> > >> > I have no idea what the vendors are doing that cause some motherboards to >> > need a different aspm value. What I do know is that we have had to live >> > with >> > the idiocy of some vendors saving a few pennies by only including a single >> > antenna, rather than two, and then making a problem by miscoding the EFUSE >> > bit that indicates which connector is actually in use. As we have no means >> > that I know about to detect which boxes have the problem, a module >> > parameter >> > was created, just as in this case. >> > >> > I agree that drivers should work "out of the box", but finite resources and >> > lack of vendor cooperation make this a goal that may not be attainable. >> >> As you touched on, the ideal situation is that Realtek solve the >> issue. Ping-Ke Shih is on CC and I am adding a few more contacts from >> the commit log. The context is that the r8822 driver fails on several >> platforms unless setting aspm=0 (the default is 1). > > It's hard to have all laptop or motherboards and all rtl8822be modules in my > side, > so what I can do is to analyze the issue when user encountered. > >> >> https://gist.github.com/dsd/20c05f0c6d66ee2ef9bfbb17f93f18ba >> https://bugzilla.kernel.org/show_bug.cgi?id=199651 >> >> >> If we don't get a timely fix from Realtek though, I think there is a >> key difference between the antenna selection headache and this one. In >> the antenna case, there isn't a good value that you can set that will >> work on all systems. If you change the default behaviour you will >> solve the issue for some users while simultanously introducing the >> problem on other systems that were previously fine. >> >> However in this case, it's highly likely that setting aspm=0 (off) by >> default would work for everyone. It has the disadvantage of using a >> bit more power, but especially with the indications that this issue >> affects a significant number of systems, I think that having the >> driver working out of the box everywhere is more important. The module >> parameter can be left in place so that unaffected users that want to >> save power can set aspm=1. >> > > I think this issue may be due to L1 latency, so below patch would be > helpful but not sure because I don't have the same laptop. > Is there anyone can help to test? I do not know why I cannot apply this patch directly. So, I apply each line manually. However, here is a good news. I tested this fix, and it works correctly on ASUS X530UN. System can scan and get the access points list. Finally, it also connects to the access point. Maybe, you can have a formal patch for this. Thanks, Jian-Hong Pan > > diff --git a/drivers/staging/rtlwifi/rtl8822be/hw.c > b/drivers/staging/rtlwifi/rtl8822be/hw.c > index 7947edb239a1..88ba5b2fea6a 100644 > --- a/drivers/staging/rtlwifi/rtl8822be/hw.c > +++ b/drivers/staging/rtlwifi/rtl8822be/hw.c > @@ -803,7 +803,7 @@ static void _rtl8822be_enable_aspm_back_door(struct > ieee80211_hw *hw) > return; > > pci_read_config_byte(rtlpci->pdev, 0x70f, ); > - pci_write_config_byte(rtlpci->pdev, 0x70f, tmp | BIT(7)); > + pci_write_config_byte(rtlpci->pdev, 0x70f, tmp | ASPM_L1_LATENCY << > 3); > > pci_read_config_byte(rtlpci->pdev, 0x719, ); > pci_write_config_byte(rtlpci->pdev, 0x719, tmp | BIT(3) | BIT(4)); > diff --git a/drivers/staging/rtlwifi/wifi.h b/drivers/staging/rtlwifi/wifi.h > index 012fb618840b..a45f0eb69d3f 100644 > --- a/drivers/staging/rtlwifi/wifi.h > +++ b/drivers/staging/rtlwifi/wifi.h > @@ -88,6 +88,7 @@ > #define RTL_USB_MAX_RX_COUNT 100 > #define QBSS_LOAD_SIZE 5 > #define MAX_WMMELE_LENGTH 64 > +#define ASPM_L1_LATENCY7 > > #define TOTAL_CAM_ENTRY32 > > > --- > PK > ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[BUG] staging: r8822be: RTL8822be can't find any wireless AP
Hi, We have an ASUS X530UN (Intel(R) Core(TM) i7-8550U CPU @ 1.80GHz) laptop equipped with Realtek rtl8822be wireless which cannot find any access point after WiFi is launched. Realtek rtl8822be wireless' information: dev@endless:~/linux-eos$ sudo lspci -nnvs 02:00.0 02:00.0 Network controller [0280]: Realtek Semiconductor Co., Ltd. Device [10ec:b822] (rev ff) (prog-if ff) !!! Unknown header type 7f Kernel driver in use: r8822be Kernel modules: r8822be System always hits the error: "halmac_init_hal failed" in dmesg after WiFi is launched. [ 8.591333] r8822be: module is from the staging directory, the quality is unknown, you have been warned. [ 8.593122] r8822be :02:00.0: enabling device ( -> 0003) [ 8.669163] r8822be: Using firmware rtlwifi/rtl8822befw.bin [ 9.289939] r8822be: rtlwifi: wireless switch is on [ 10.056426] r8822be :02:00.0 wlp2s0: renamed from wlan0 ... [ 11.952534] r8822be: halmac_init_hal failed [ 11.955933] r8822be: halmac_init_hal failed [ 11.956227] r8822be: halmac_init_hal failed [ 22.007942] r8822be: halmac_init_hal failed We noticed the r8822be module parameter "aspm"'s default value is 1. Here is the parameter list of r8822be: dev@endless:~$ sudo grep "" /sys/module/r8822be/parameters/* /sys/module/r8822be/parameters/aspm:1 /sys/module/r8822be/parameters/debug_level:0 /sys/module/r8822be/parameters/debug_mask:0 /sys/module/r8822be/parameters/disable_watchdog:N /sys/module/r8822be/parameters/dma64:N /sys/module/r8822be/parameters/fwlps:Y /sys/module/r8822be/parameters/ips:Y /sys/module/r8822be/parameters/msi:Y /sys/module/r8822be/parameters/swenc:N /sys/module/r8822be/parameters/swlps:N If I make a module options like "options r8822be aspm=0" which disables ASPM and reboot, the WiFi works correctly. It can find the access points, then connects. Here is the parameter list of r8822be: dev@endless:~$ sudo grep "" /sys/module/r8822be/parameters/* /sys/module/r8822be/parameters/aspm:0 /sys/module/r8822be/parameters/debug_level:0 /sys/module/r8822be/parameters/debug_mask:0 /sys/module/r8822be/parameters/disable_watchdog:N /sys/module/r8822be/parameters/dma64:N /sys/module/r8822be/parameters/fwlps:Y /sys/module/r8822be/parameters/ips:Y /sys/module/r8822be/parameters/msi:Y /sys/module/r8822be/parameters/swenc:N /sys/module/r8822be/parameters/swlps:N This issue can be reproduced on Linux stable 4.16.17, 4.17.2 and 4.18.0-rc3. (I list versions that we have tried) Besides, I also notice there is a comment in drivers/staging/rtlwifi/rtl8822be/sw.c rtl8822be_init_aspm_vars function. /* * This setting works for those device with * backdoor ASPM setting such as EPHY setting. * 0 - Not support ASPM, * 1 - Support ASPM, * 2 - According to chipset. */ The value 2 for ASPM interests me. It says "Enable or disable ASPM according to chipset." I tried the setting value 2 for ASPM. Here is the parameter list of r8822be: dev@endless:~$ sudo grep "" /sys/module/r8822be/parameters/* /sys/module/r8822be/parameters/aspm:2 /sys/module/r8822be/parameters/debug_level:0 /sys/module/r8822be/parameters/debug_mask:0 /sys/module/r8822be/parameters/disable_watchdog:N /sys/module/r8822be/parameters/dma64:N /sys/module/r8822be/parameters/fwlps:Y /sys/module/r8822be/parameters/ips:Y /sys/module/r8822be/parameters/msi:Y /sys/module/r8822be/parameters/swenc:N /sys/module/r8822be/parameters/swlps:N The value 2 for ASPM also works correctly on ASUS X530UN. Jian-Hong Pan ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
