Re: [PATCH] staging: rtl8192e: fix array of flexible structures
On Wed, Apr 28, 2021 at 08:01:21AM +0200, Greg KH wrote:
On Wed, Apr 28, 2021 at 12:28:44AM +0530, Jitendra wrote:
On Tue, Apr 27, 2021 at 08:10:20PM +0200, Greg KH wrote:
> On Tue, Apr 27, 2021 at 11:19:45PM +0530, Jitendra Khasdev wrote:
> > This patch fixes sparse warning "array of flexible structures"
> > for rtllib.h.
> >
> > eg. drivers/staging/rtl8192e/rtllib.h:832:48: warning: array of
> > flexible structures
> >
> > Signed-off-by: Jitendra Khasdev
> > ---
> > drivers/staging/rtl8192e/rtllib.h | 10 +-
> > 1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/staging/rtl8192e/rtllib.h
b/drivers/staging/rtl8192e/rtllib.h
> > index 4cabaf2..c7cb318 100644
> > --- a/drivers/staging/rtl8192e/rtllib.h
> > +++ b/drivers/staging/rtl8192e/rtllib.h
> > @@ -802,7 +802,7 @@ struct rtllib_authentication {
> > __le16 transaction;
> > __le16 status;
> > /*challenge*/
> > - struct rtllib_info_element info_element[];
> > + struct rtllib_info_element *info_element;
>
> You just changed the definition of this structure, and the other
> structures here. Are you sure this is working properly?
>
I have compiled the driver and install it on my vm, but I don't this specific
hardware, so couldn't test it.
I fixed in context of sparse.
Please verify that this change is correct by looking at how the
structures are being created (i.e. is this being treated as a flexible
array or a pointer?)
I think we have been through this before and that sparse is not right,
but I can't remember...
Yes, it is getting used as flexible array in code. hence, simply we can drop
this patch.
Also, looks to me, there is no more sparse warnings to fix in staging.
---
Jitendra
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: rtl8192e: fix array of flexible structures
On Tue, Apr 27, 2021 at 08:10:20PM +0200, Greg KH wrote:
On Tue, Apr 27, 2021 at 11:19:45PM +0530, Jitendra Khasdev wrote:
This patch fixes sparse warning "array of flexible structures"
for rtllib.h.
eg. drivers/staging/rtl8192e/rtllib.h:832:48: warning: array of
flexible structures
Signed-off-by: Jitendra Khasdev
---
drivers/staging/rtl8192e/rtllib.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtllib.h
b/drivers/staging/rtl8192e/rtllib.h
index 4cabaf2..c7cb318 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -802,7 +802,7 @@ struct rtllib_authentication {
__le16 transaction;
__le16 status;
/*challenge*/
- struct rtllib_info_element info_element[];
+ struct rtllib_info_element *info_element;
You just changed the definition of this structure, and the other
structures here. Are you sure this is working properly?
I have compiled the driver and install it on my vm, but I don't this specific
hardware, so couldn't test it.
I fixed in context of sparse.
---
Jitendra
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: rtl8192e: fix array of flexible structures
This patch fixes sparse warning "array of flexible structures"
for rtllib.h.
eg. drivers/staging/rtl8192e/rtllib.h:832:48: warning: array of
flexible structures
Signed-off-by: Jitendra Khasdev
---
drivers/staging/rtl8192e/rtllib.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtllib.h
b/drivers/staging/rtl8192e/rtllib.h
index 4cabaf2..c7cb318 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -802,7 +802,7 @@ struct rtllib_authentication {
__le16 transaction;
__le16 status;
/*challenge*/
- struct rtllib_info_element info_element[];
+ struct rtllib_info_element *info_element;
} __packed;
struct rtllib_disauth {
@@ -818,7 +818,7 @@ struct rtllib_disassoc {
struct rtllib_probe_request {
struct rtllib_hdr_3addr header;
/* SSID, supported rates */
- struct rtllib_info_element info_element[];
+ struct rtllib_info_element *info_element;
} __packed;
struct rtllib_probe_response {
@@ -829,7 +829,7 @@ struct rtllib_probe_response {
/* SSID, supported rates, FH params, DS params,
* CF params, IBSS params, TIM (if beacon), RSN
*/
- struct rtllib_info_element info_element[];
+ struct rtllib_info_element *info_element;
} __packed;
/* Alias beacon for probe_response */
@@ -840,7 +840,7 @@ struct rtllib_assoc_request_frame {
__le16 capability;
__le16 listen_interval;
/* SSID, supported rates, RSN */
- struct rtllib_info_element info_element[];
+ struct rtllib_info_element *info_element;
} __packed;
struct rtllib_assoc_response_frame {
@@ -848,7 +848,7 @@ struct rtllib_assoc_response_frame {
__le16 capability;
__le16 status;
__le16 aid;
- struct rtllib_info_element info_element[]; /* supported rates */
+ struct rtllib_info_element *info_element; /* supported rates */
} __packed;
struct rtllib_txb {
--
1.8.3.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: comedi: Removed not necessary braces for single block
"interesting" email name you used here :) Please fix up, it has to match the signed-off-by line. I fixed and resent the patch again. --- Jitendra ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: comedi: Removed not necessary braces for single block
This patch is used to remove not necessary braces for single if block.
Signed-off-by: Jitendra Khasdev
---
drivers/staging/comedi/comedi_fops.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/comedi_fops.c
b/drivers/staging/comedi/comedi_fops.c
index 5d2fcbfe02af..38980fad8be4 100644
--- a/drivers/staging/comedi/comedi_fops.c
+++ b/drivers/staging/comedi/comedi_fops.c
@@ -1605,9 +1605,9 @@ static int do_insn_ioctl(struct comedi_device *dev,
unsigned int n_data = MIN_SAMPLES;
int ret = 0;
- if (copy_from_user(, arg, sizeof(insn))) {
+ if (copy_from_user(, arg, sizeof(insn)))
return -EFAULT;
- }
+
n_data = max(n_data, insn.n);
--
2.13.6
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] Staging: vt6656: Fix spaces and char limit
This is a patch to usbpipe.c to fix space and char limit warning found by checkpatch tool. Signed-off-by: Jitendra Khasdev <jkhas...@gmail.com> --- drivers/staging/vt6656/usbpipe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/vt6656/usbpipe.c b/drivers/staging/vt6656/usbpipe.c index 1ae6a64..9ad8503 100644 --- a/drivers/staging/vt6656/usbpipe.c +++ b/drivers/staging/vt6656/usbpipe.c @@ -82,8 +82,8 @@ int vnt_control_in(struct vnt_private *priv, u8 request, u16 value, mutex_lock(>usb_lock); status = usb_control_msg(priv->usb, - usb_rcvctrlpipe(priv->usb, 0), request, 0xc0, value, - index, buffer, length, USB_CTL_WAIT); + usb_rcvctrlpipe(priv->usb, 0), request, 0xc0, + value, index, buffer, length, USB_CTL_WAIT); mutex_unlock(>usb_lock); -- 2.9.3 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: speakup: Replaced obsolete simple_strtoul
From: Jitendra Kumar Khasdev <jkhas...@gmail.com>
This patch is for replacing obsolete simple_strtoul to kstrtoul which remove
warning produce by checkpatch.
Signed-off-by: Jitendra Kumar Khasdev <jkhas...@gmail.com>
---
drivers/staging/speakup/varhandlers.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/speakup/varhandlers.c
b/drivers/staging/speakup/varhandlers.c
index 21186e3..1a3caf3 100644
--- a/drivers/staging/speakup/varhandlers.c
+++ b/drivers/staging/speakup/varhandlers.c
@@ -323,9 +323,11 @@ char *spk_strlwr(char *s)
char *spk_s2uchar(char *start, char *dest)
{
- int val;
+ unsigned long val;
+
+ if (kstrtoul(start, 10, ))
+ return NULL;
- val = simple_strtoul(skip_spaces(start), , 10);
if (*start == ',')
start++;
*dest = (u_char)val;
--
2.7.4
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: dgnc: dgnc_cls.c: Replaced udelay by usleep_range
This patch is to file dgnc_cls.c that fixes up udelay function by usleep_range. It is safe to use according to the following documentation Documentation/timers/timers-howto.txt. So that is why I have given an appropriate time range. Signed-off-by: Jitendra Kumar Khasdev <jkhas...@gmail.com> --- drivers/staging/dgnc/dgnc_cls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/dgnc/dgnc_cls.c b/drivers/staging/dgnc/dgnc_cls.c index 75040da..72f0aaa 100644 --- a/drivers/staging/dgnc/dgnc_cls.c +++ b/drivers/staging/dgnc/dgnc_cls.c @@ -934,7 +934,7 @@ static void cls_flush_uart_write(struct channel_t *ch) writeb((UART_FCR_ENABLE_FIFO | UART_FCR_CLEAR_XMIT), >ch_cls_uart->isr_fcr); - udelay(10); + usleep_range(10, 20); ch->ch_flags |= (CH_TX_FIFO_EMPTY | CH_TX_FIFO_LWM); } -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: comedi: comedilib.h: Coding style warning fix for block comments
This patch is to comedilib.h file that fixes up following warnings reported by checkpatch.pl : I) Block comments use * on subsequent lines. Apart from it I have remove header file path by base file name as suggested by community. Signed-off-by: Jitendra Kumar Khasdev <jkhas...@gmail.com> --- drivers/staging/comedi/comedilib.h | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/staging/comedi/comedilib.h b/drivers/staging/comedi/comedilib.h index 56baf85..f9b5639 100644 --- a/drivers/staging/comedi/comedilib.h +++ b/drivers/staging/comedi/comedilib.h @@ -1,20 +1,20 @@ /* -linux/include/comedilib.h -header file for kcomedilib - -COMEDI - Linux Control and Measurement Device Interface -Copyright (C) 1998-2001 David A. Schleef <d...@schleef.org> - -This program is free software; you can redistribute it and/or modify -it under the terms of the GNU General Public License as published by -the Free Software Foundation; either version 2 of the License, or -(at your option) any later version. - -This program is distributed in the hope that it will be useful, -but WITHOUT ANY WARRANTY; without even the implied warranty of -MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -GNU General Public License for more details. -*/ + * comedilib.h + * Header file for kcomedilib + * + * COMEDI - Linux Control and Measurement Device Interface + * Copyright (C) 1998-2001 David A. Schleef <d...@schleef.org> + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ #ifndef _LINUX_COMEDILIB_H #define _LINUX_COMEDILIB_H -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: comedi: comedilib.h: Coding style warning fix for block comments
This patch is to comedilib.h file that fixes up following warnings reported by checkpatch.pl : I) Block comments use * on subsequent lines Signed-off-by: Jitendra Kumar Khasdev <jkhas...@gmail.com> --- drivers/staging/comedi/comedilib.h | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/staging/comedi/comedilib.h b/drivers/staging/comedi/comedilib.h index 56baf85..e530028 100644 --- a/drivers/staging/comedi/comedilib.h +++ b/drivers/staging/comedi/comedilib.h @@ -1,20 +1,20 @@ /* -linux/include/comedilib.h -header file for kcomedilib - -COMEDI - Linux Control and Measurement Device Interface -Copyright (C) 1998-2001 David A. Schleef <d...@schleef.org> - -This program is free software; you can redistribute it and/or modify -it under the terms of the GNU General Public License as published by -the Free Software Foundation; either version 2 of the License, or -(at your option) any later version. - -This program is distributed in the hope that it will be useful, -but WITHOUT ANY WARRANTY; without even the implied warranty of -MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -GNU General Public License for more details. -*/ + * linux/include/comedilib.h + * + * COMEDI - Linux Control and Measurement Device Interface + * Copyright (C) 1998-2001 David A. Schleef <d...@schleef.org> + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + */ #ifndef _LINUX_COMEDILIB_H #define _LINUX_COMEDILIB_H -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: comedi: Coding style warning fix for block comments
This patch is to comedilib.h file that fixes up following warnings reported by checkpatch.pl : I) Block comments use * on subsequent lines Signed-off-by: Jitendra Kumar Khasdev <jkhas...@gmail.com> --- drivers/staging/comedi/comedilib.h | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/staging/comedi/comedilib.h b/drivers/staging/comedi/comedilib.h index 56baf85..ccbe17b 100644 --- a/drivers/staging/comedi/comedilib.h +++ b/drivers/staging/comedi/comedilib.h @@ -1,20 +1,20 @@ /* -linux/include/comedilib.h -header file for kcomedilib - -COMEDI - Linux Control and Measurement Device Interface -Copyright (C) 1998-2001 David A. Schleef <d...@schleef.org> - -This program is free software; you can redistribute it and/or modify -it under the terms of the GNU General Public License as published by -the Free Software Foundation; either version 2 of the License, or -(at your option) any later version. - -This program is distributed in the hope that it will be useful, -but WITHOUT ANY WARRANTY; without even the implied warranty of -MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -GNU General Public License for more details. -*/ + * linux/include/comedilib.h + * header file for kcomedilib + * + * COMEDI - Linux Control and Measurement Device Interface + * Copyright (C) 1998-2001 David A. Schleef <d...@schleef.org> + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ #ifndef _LINUX_COMEDILIB_H #define _LINUX_COMEDILIB_H -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: media: bcm2048: fix brace coding style issue in radio-bcm2048.c
This is a patch to the radio-bcm2048.c file that fixes up a brace warning found by the checkpatch.pl tool. Signed-off-by: Jitendra Kumar Khasdev <jkhas...@gmail.com> --- drivers/staging/media/bcm2048/radio-bcm2048.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c index b10d601..6226e02 100644 --- a/drivers/staging/media/bcm2048/radio-bcm2048.c +++ b/drivers/staging/media/bcm2048/radio-bcm2048.c @@ -2021,8 +2021,8 @@ static ssize_t bcm2048_##prop##_read(struct device *dev, \ } #define DEFINE_SYSFS_PROPERTY(prop, signal, size, mask, check) \ -property_write(prop, signal size, mask, check) \ -property_read(prop, size, mask) +(property_write(prop, signal size, mask, check) \ +property_read(prop, size, mask)) #define property_str_read(prop, size) \ static ssize_t bcm2048_##prop##_read(struct device *dev, \ -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: media: bcm2048: fix brace coding style issue in radio-bcm2048.c
On Wednesday 18 November 2015 10:42 PM, Greg KH wrote: > On Wed, Nov 18, 2015 at 09:25:22PM +0530, Jitendra Kumar Khasdev wrote: >> This is a patch to the radio-bcm2048.c file that fixes up a brace warning >> found by the checkpatch.pl tool. >> >> Signed-off-by: Jitendra Kumar Khasdev <jkhas...@gmail.com> >> --- >> drivers/staging/media/bcm2048/radio-bcm2048.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c >> b/drivers/staging/media/bcm2048/radio-bcm2048.c >> index b10d601..6226e02 100644 >> --- a/drivers/staging/media/bcm2048/radio-bcm2048.c >> +++ b/drivers/staging/media/bcm2048/radio-bcm2048.c >> @@ -2021,8 +2021,8 @@ static ssize_t bcm2048_##prop##_read(struct device >> *dev, \ >> } >> >> #define DEFINE_SYSFS_PROPERTY(prop, signal, size, mask, check) >> \ >> -property_write(prop, signal size, mask, check) >> \ >> -property_read(prop, size, mask) >> +(property_write(prop, signal size, mask, check) >> \ >> +property_read(prop, size, mask)) > You didn't even test-build this patch, why not? > Greg KH, I have compiled the kernel by following these step: 1. copied the .config files 2. make defconfig 3. make -j6 It doesn't show me any warning. so I have tested on my side. -- Thanks and Regards, Jitendra Kumar Khasdev ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 2/2] Staging: comedi: Fix warning line over 80 character
This is patch to file ni_labpc_cs.c that fix warning line over 80 character which is found by checkpatch tool. Signed-off-by: Jitendra Kumar Khasdev jkhas...@gmail.com --- drivers/staging/comedi/drivers/ni_labpc_cs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/ni_labpc_cs.c b/drivers/staging/comedi/drivers/ni_labpc_cs.c index 0a8b322..9858ab1 100644 --- a/drivers/staging/comedi/drivers/ni_labpc_cs.c +++ b/drivers/staging/comedi/drivers/ni_labpc_cs.c @@ -1,7 +1,8 @@ /* comedi/drivers/ni_labpc_cs.c Driver for National Instruments daqcard-1200 boards -Copyright (C) 2001, 2002, 2003 Frank Mori Hess fmh...@users.sourceforge.net +Copyright (C) 2001, 2002, 2003 Frank Mori Hess +fmh...@users.sourceforge.net PCMCIA crap is adapted from dummy_cs.c 1.31 2001/08/24 12:13:13 from the pcmcia package. -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v1 1/2] Staging: comedi: fix line over 80 characters warning
This is patch to file jr3_pci.h that fix up warning line
over 80 character which is found by checkpatch tool.
Signed-off-by: Jitendra Kumar Khasdev jkhas...@gmail.com
---
drivers/staging/comedi/drivers/jr3_pci.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/jr3_pci.h
b/drivers/staging/comedi/drivers/jr3_pci.h
index 20478ae..356811d 100644
--- a/drivers/staging/comedi/drivers/jr3_pci.h
+++ b/drivers/staging/comedi/drivers/jr3_pci.h
@@ -261,8 +261,9 @@ struct intern_transform {
} link[8];
};
-/* JR3 force/torque sensor data definition. For more information see sensor
and */
-/* hardware manuals. */
+/* JR3 force/torque sensor data definition. For more information see sensor
+ * and hardware manuals.
+ */
struct jr3_channel {
/* Raw_channels is the area used to store the raw data coming from */
--
1.9.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v1 2/2] Staging: comedi: fix line over 80 characters warning
This is patch to file jr3_pci.c that fix up warning line
over 80 character which is found by checkpatch tool. Made change into signature
of struct jr3_pci_poll_delay jr3_pci_poll_subdevice function by giving a newline
so that 80 character line over warning to be reduced.
Signed-off-by: Jitendra Kumar Khasdev jkhas...@gmail.com
---
drivers/staging/comedi/drivers/jr3_pci.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/jr3_pci.c
b/drivers/staging/comedi/drivers/jr3_pci.c
index 81fab2d..1de843d 100644
--- a/drivers/staging/comedi/drivers/jr3_pci.c
+++ b/drivers/staging/comedi/drivers/jr3_pci.c
@@ -449,7 +449,8 @@ static int jr3_download_firmware(struct comedi_device *dev,
return 0;
}
-static struct jr3_pci_poll_delay jr3_pci_poll_subdevice(struct
comedi_subdevice *s)
+static struct jr3_pci_poll_delay jr3_pci_poll_subdevice(struct comedi_subdevice
+ *s)
{
struct jr3_pci_subdev_private *spriv = s-private;
struct jr3_pci_poll_delay result = poll_delay_min_max(1000, 2000);
--
1.9.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v1 0/2] line over 80 character warnings.
In these two files jr3_pci.c, jr3_pci.h, 80 character warnings are reduced. jitendra kumar khasdev (2): Staging: comedi: fix line over 80 characters warning Staging: comedi: fix line over 80 characters warning drivers/staging/comedi/drivers/jr3_pci.c | 3 ++- drivers/staging/comedi/drivers/jr3_pci.h | 5 +++-- 2 files changed, 5 insertions(+), 3 deletions(-) -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v7] Staging: comedi: patch to fix line over 80 characters warning
Will you give reason for not apply my patch on your tree. I have tested by appling on linux main tree. On Sat, Jan 10, 2015 at 10:20:03AM +0530, jitendra kumar khasdev wrote: This is patch to pcl812.c that fix line over 80 characters warning which is found by checkpatch.pl tool. Reduce the extra space around equal sign that fix warning. Regards, JItendra kumar khasdev, jitendra-02.github.io | Mo. 8871242083 On 1/18/15, Greg KH gre...@linuxfoundation.org wrote: On Sat, Jan 10, 2015 at 10:20:03AM +0530, jitendra kumar khasdev wrote: This is patch to pcl812.c that fix line over 80 characters warning which is found by checkpatch.pl tool. Reduce the extra space around equal sign that fix warning. Signed-off-by: Jitendra kumar khasdev jkhas...@gmail.com --- drivers/staging/comedi/drivers/pcl812.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Does not apply to my tree :( ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v6] Staging: comedi: patch to fix 80 characters line over warnings
This is the patch to pcl812.c that fix 80 character line over warnings.
These warnings are identified by checkpatch.pl tool.
For this patch I have did following changes,
1. convert single line comment into multiline comment
2. provide tab sapce for indentation purpose
3. reduce extra space between ( = ) sign.
Signed-off-by: Jitendra kumar khasdev jkhas...@gmail.com
---
drivers/staging/comedi/drivers/pcl812.c | 20 +---
1 file changed, 13 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/comedi/drivers/pcl812.c
b/drivers/staging/comedi/drivers/pcl812.c
index ac243ca..3eac017 100644
--- a/drivers/staging/comedi/drivers/pcl812.c
+++ b/drivers/staging/comedi/drivers/pcl812.c
@@ -507,20 +507,26 @@ static const struct pcl812_board boardtypes[] = {
};
struct pcl812_private {
- unsigned char dma; /* 0 use dma ( usedDMA channel) */
+ unsigned char dma; /* 0 use dma ( usedDMA channel) */
unsigned char range_correction; /* =1 we must add 1 to range number */
unsigned int last_ai_chanspec;
- unsigned char mode_reg_int; /* there is stored INT number for some
card */
+ unsigned char mode_reg_int; /* there is stored INT number for
+* some card
+*/
unsigned int ai_poll_ptr; /* how many sampes transfer poll */
unsigned int dmapages;
unsigned int hwdmasize;
unsigned long dmabuf[2];/* PTR to DMA buf */
unsigned int hwdmaptr[2]; /* HW PTR to DMA buf */
unsigned int dmabytestomove[2]; /* how many bytes DMA transfer */
- int next_dma_buf; /* which buffer is next to use */
- unsigned int dma_runs_to_end; /* how many times we must switch DMA
buffers */
- unsigned int last_dma_run; /* how many bytes to transfer on last
DMA buffer */
- unsigned int max_812_ai_mode0_rangewait;/* setling time for
gain */
+ int next_dma_buf; /* which buffer is next to use */
+ unsigned int dma_runs_to_end; /* how many times we must switch
+* DMA buffers
+*/
+ unsigned int last_dma_run; /* how many bytes to transfer on
+* last DMA buffer
+*/
+ unsigned int max_812_ai_mode0_rangewait;/* setling time for gain */
unsigned int divisor1;
unsigned int divisor2;
unsigned int use_diff:1;
@@ -1235,7 +1241,7 @@ static int pcl812_attach(struct comedi_device *dev,
struct comedi_devconfig *it)
for (i = 0; i 2; i++) {
unsigned long dmabuf;
- dmabuf = __get_dma_pages(GFP_KERNEL,
devpriv-dmapages);
+ dmabuf = __get_dma_pages(GFP_KERNEL, devpriv-dmapages);
if (!dmabuf)
return -ENOMEM;
--
1.9.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v7] Staging: comedi: patch to fix line over 80 characters warning
This is patch to pcl812.c that fix line over 80 characters warning
which is found by checkpatch.pl tool. Reduce the extra space around
equal sign that fix warning.
Signed-off-by: Jitendra kumar khasdev jkhas...@gmail.com
---
drivers/staging/comedi/drivers/pcl812.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/pcl812.c
b/drivers/staging/comedi/drivers/pcl812.c
index ac243ca..9b576bc 100644
--- a/drivers/staging/comedi/drivers/pcl812.c
+++ b/drivers/staging/comedi/drivers/pcl812.c
@@ -1235,7 +1235,7 @@ static int pcl812_attach(struct comedi_device *dev,
struct comedi_devconfig *it)
for (i = 0; i 2; i++) {
unsigned long dmabuf;
- dmabuf = __get_dma_pages(GFP_KERNEL,
devpriv-dmapages);
+ dmabuf = __get_dma_pages(GFP_KERNEL, devpriv-dmapages);
if (!dmabuf)
return -ENOMEM;
--
1.9.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v5] Staging: comedi: fix line over 80 characters warning
This is patch to file pcl812.c that fix line over 80
characters warning which is found by checkpatch.pl tool.
Signed-off-by: Jitendra kumar khasdev jkhas...@gmail.com
---
drivers/staging/comedi/drivers/pcl812.c | 20 +---
1 file changed, 13 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/comedi/drivers/pcl812.c
b/drivers/staging/comedi/drivers/pcl812.c
index ac243ca..3eac017 100644
--- a/drivers/staging/comedi/drivers/pcl812.c
+++ b/drivers/staging/comedi/drivers/pcl812.c
@@ -507,20 +507,26 @@ static const struct pcl812_board boardtypes[] = {
};
struct pcl812_private {
- unsigned char dma; /* 0 use dma ( usedDMA channel) */
+ unsigned char dma; /* 0 use dma ( usedDMA channel) */
unsigned char range_correction; /* =1 we must add 1 to range number */
unsigned int last_ai_chanspec;
- unsigned char mode_reg_int; /* there is stored INT number for some
card */
+ unsigned char mode_reg_int; /* there is stored INT number for
+* some card
+*/
unsigned int ai_poll_ptr; /* how many sampes transfer poll */
unsigned int dmapages;
unsigned int hwdmasize;
unsigned long dmabuf[2];/* PTR to DMA buf */
unsigned int hwdmaptr[2]; /* HW PTR to DMA buf */
unsigned int dmabytestomove[2]; /* how many bytes DMA transfer */
- int next_dma_buf; /* which buffer is next to use */
- unsigned int dma_runs_to_end; /* how many times we must switch DMA
buffers */
- unsigned int last_dma_run; /* how many bytes to transfer on last
DMA buffer */
- unsigned int max_812_ai_mode0_rangewait;/* setling time for
gain */
+ int next_dma_buf; /* which buffer is next to use */
+ unsigned int dma_runs_to_end; /* how many times we must switch
+* DMA buffers
+*/
+ unsigned int last_dma_run; /* how many bytes to transfer on
+* last DMA buffer
+*/
+ unsigned int max_812_ai_mode0_rangewait;/* setling time for gain */
unsigned int divisor1;
unsigned int divisor2;
unsigned int use_diff:1;
@@ -1235,7 +1241,7 @@ static int pcl812_attach(struct comedi_device *dev,
struct comedi_devconfig *it)
for (i = 0; i 2; i++) {
unsigned long dmabuf;
- dmabuf = __get_dma_pages(GFP_KERNEL,
devpriv-dmapages);
+ dmabuf = __get_dma_pages(GFP_KERNEL, devpriv-dmapages);
if (!dmabuf)
return -ENOMEM;
--
1.9.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v4] Staging: comedi: Fix over 80 character line limit
This is patch to pcl812.c that fix 80 character line limit which is found
by checkpatch.pl tool.
I have already sent this patch earlier but it was in 5 different patches,
this time I have make it into one patch.
Signed-off-by: Jitendra Kumar Khasdev jkhas...@gmail.com
---
drivers/staging/comedi/drivers/pcl812.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/comedi/drivers/pcl812.c
b/drivers/staging/comedi/drivers/pcl812.c
index ac243ca..fe9496a 100644
--- a/drivers/staging/comedi/drivers/pcl812.c
+++ b/drivers/staging/comedi/drivers/pcl812.c
@@ -510,7 +510,8 @@ struct pcl812_private {
unsigned char dma; /* 0 use dma ( usedDMA channel) */
unsigned char range_correction; /* =1 we must add 1 to range number */
unsigned int last_ai_chanspec;
- unsigned char mode_reg_int; /* there is stored INT number for some
card */
+ unsigned char mode_reg_int; /* there is stored INT number for
+* some card */
unsigned int ai_poll_ptr; /* how many sampes transfer poll */
unsigned int dmapages;
unsigned int hwdmasize;
@@ -518,9 +519,11 @@ struct pcl812_private {
unsigned int hwdmaptr[2]; /* HW PTR to DMA buf */
unsigned int dmabytestomove[2]; /* how many bytes DMA transfer */
int next_dma_buf; /* which buffer is next to use */
- unsigned int dma_runs_to_end; /* how many times we must switch DMA
buffers */
- unsigned int last_dma_run; /* how many bytes to transfer on last
DMA buffer */
- unsigned int max_812_ai_mode0_rangewait;/* setling time for
gain */
+ unsigned int dma_runs_to_end; /* how many times we must switch
+* DMA buffers */
+ unsigned int last_dma_run; /* how many bytes to transfer on
+* last DMA buffer */
+ unsigned int max_812_ai_mode0_rangewait;/* setling time for gain */
unsigned int divisor1;
unsigned int divisor2;
unsigned int use_diff:1;
@@ -1235,7 +1238,7 @@ static int pcl812_attach(struct comedi_device *dev,
struct comedi_devconfig *it)
for (i = 0; i 2; i++) {
unsigned long dmabuf;
- dmabuf = __get_dma_pages(GFP_KERNEL,
devpriv-dmapages);
+ dmabuf = __get_dma_pages(GFP_KERNEL, devpriv-dmapages);
if (!dmabuf)
return -ENOMEM;
--
1.9.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 1/5] Staging: comedi: fix line over 80 characters warning
Hello, Will I have to resubmit by combining all 5 into 1 patch? Please give me suggestion so that I can do it in correct way. Regards, Jitendra Regards, Jitendra Kumar Khasdev, CSE-Student | GGITM jkhas...@gmail.com| Mo.8435260882 On Sun, 4 Jan 2015, Greg KH wrote: On Sat, Jan 03, 2015 at 06:16:31PM +0530, jitendra kumar khasdev wrote: This is patch to file pcl812.c that fix up warning line over 80 character which is found by checkpatch tool. Signed-off-by: Jitendra Kumar Khasdev jkhas...@gmail.com --- drivers/staging/comedi/drivers/pcl812.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) There are 5 patches here all with the identical subject line, which I can't accept for the obvious reason that they must be all doing the same exact thing, which would be pointless, right? :) thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 3/5] Staging: comedi: fix line over 80 characters warning
This is patch to file pcl812.c that fix up warning line
over 80 character which is found by checkpatch tool.
Singed-off-by: Jitendra Kumar Khasdev jkhas...@gmail.com
---
drivers/staging/comedi/drivers/pcl812.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/pcl812.c
b/drivers/staging/comedi/drivers/pcl812.c
index 069af70..aae934e7 100644
--- a/drivers/staging/comedi/drivers/pcl812.c
+++ b/drivers/staging/comedi/drivers/pcl812.c
@@ -522,7 +522,9 @@ struct pcl812_private {
unsigned int dma_runs_to_end; /* how many times we must switch
* DMA buffers
*/
- unsigned int last_dma_run; /* how many bytes to transfer on last
DMA buffer */
+ unsigned int last_dma_run; /* how many bytes to transfer on last
+* DMA buffer
+*/
unsigned int max_812_ai_mode0_rangewait;/* setling time for
gain */
unsigned int divisor1;
unsigned int divisor2;
--
1.9.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 4/5] Staging: comedi: fix line over 80 characters warning
This is patch to file pcl812.c that fix up warning line
over 80 character which is found by checkpatch tool.
Singed-off-by: Jitendra Kumar Khasdev jkhas...@gmail.com
---
drivers/staging/comedi/drivers/pcl812.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/pcl812.c
b/drivers/staging/comedi/drivers/pcl812.c
index aae934e7..5aeb695 100644
--- a/drivers/staging/comedi/drivers/pcl812.c
+++ b/drivers/staging/comedi/drivers/pcl812.c
@@ -525,7 +525,7 @@ struct pcl812_private {
unsigned int last_dma_run; /* how many bytes to transfer on last
* DMA buffer
*/
- unsigned int max_812_ai_mode0_rangewait;/* setling time for
gain */
+ unsigned int max_812_ai_mode0_rangewait; /* setling time for gain */
unsigned int divisor1;
unsigned int divisor2;
unsigned int use_diff:1;
--
1.9.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 5/5] Staging: comedi: fix line over 80 characters warning
This is patch to file pcl812.c that fix up warning line
over 80 character which is found by checkpatch tool.
Singed-off-by: Jitendra Kumar Khasdev jkhas...@gmail.com
---
drivers/staging/comedi/drivers/pcl812.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/pcl812.c
b/drivers/staging/comedi/drivers/pcl812.c
index 5aeb695..f06347f 100644
--- a/drivers/staging/comedi/drivers/pcl812.c
+++ b/drivers/staging/comedi/drivers/pcl812.c
@@ -1240,7 +1240,7 @@ static int pcl812_attach(struct comedi_device *dev,
struct comedi_devconfig *it)
for (i = 0; i 2; i++) {
unsigned long dmabuf;
- dmabuf = __get_dma_pages(GFP_KERNEL,
devpriv-dmapages);
+ dmabuf = __get_dma_pages(GFP_KERNEL, devpriv-dmapages);
if (!dmabuf)
return -ENOMEM;
--
1.9.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 2/5] Staging: comedi: fix line over 80 characters warning
This is patch to file pcl812.c that fix up warning line
over 80 character which is found by checkpatch tool.
Singed-off-by: Jitendra Kumar Khasdev jkhas...@gmail.com
---
drivers/staging/comedi/drivers/pcl812.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/pcl812.c
b/drivers/staging/comedi/drivers/pcl812.c
index 24eb601..069af70 100644
--- a/drivers/staging/comedi/drivers/pcl812.c
+++ b/drivers/staging/comedi/drivers/pcl812.c
@@ -519,7 +519,9 @@ struct pcl812_private {
unsigned int hwdmaptr[2]; /* HW PTR to DMA buf */
unsigned int dmabytestomove[2]; /* how many bytes DMA transfer */
int next_dma_buf; /* which buffer is next to use */
- unsigned int dma_runs_to_end; /* how many times we must switch DMA
buffers */
+ unsigned int dma_runs_to_end; /* how many times we must switch
+* DMA buffers
+*/
unsigned int last_dma_run; /* how many bytes to transfer on last
DMA buffer */
unsigned int max_812_ai_mode0_rangewait;/* setling time for
gain */
unsigned int divisor1;
--
1.9.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 1/5] Staging: comedi: fix line over 80 characters warning
This is patch to file pcl812.c that fix up warning line
over 80 character which is found by checkpatch tool.
Singed-off-by: Jitendra Kumar Khasdev jkhas...@gmail.com
---
drivers/staging/comedi/drivers/pcl812.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/pcl812.c
b/drivers/staging/comedi/drivers/pcl812.c
index ac243ca..24eb601 100644
--- a/drivers/staging/comedi/drivers/pcl812.c
+++ b/drivers/staging/comedi/drivers/pcl812.c
@@ -510,7 +510,8 @@ struct pcl812_private {
unsigned char dma; /* 0 use dma ( usedDMA channel) */
unsigned char range_correction; /* =1 we must add 1 to range number */
unsigned int last_ai_chanspec;
- unsigned char mode_reg_int; /* there is stored INT number for some
card */
+ unsigned char mode_reg_int; /* there is stored INT number
+ for some card */
unsigned int ai_poll_ptr; /* how many sampes transfer poll */
unsigned int dmapages;
unsigned int hwdmasize;
--
1.9.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2 5/5] Staging: comedi: fix line over 80 characters warning
This is patch to file pcl812.c that fix up warning line
over 80 character which is found by checkpatch tool.
Singed-off-by: Jitendra Kumar Khasdev jkhas...@gmail.com
---
drivers/staging/comedi/drivers/pcl812.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/pcl812.c
b/drivers/staging/comedi/drivers/pcl812.c
index 5aeb695..f06347f 100644
--- a/drivers/staging/comedi/drivers/pcl812.c
+++ b/drivers/staging/comedi/drivers/pcl812.c
@@ -1240,7 +1240,7 @@ static int pcl812_attach(struct comedi_device *dev,
struct comedi_devconfig *it)
for (i = 0; i 2; i++) {
unsigned long dmabuf;
- dmabuf = __get_dma_pages(GFP_KERNEL,
devpriv-dmapages);
+ dmabuf = __get_dma_pages(GFP_KERNEL, devpriv-dmapages);
if (!dmabuf)
return -ENOMEM;
--
1.9.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 0/5] *** SUBJECT HERE ***
*** BLURB HERE *** jitendra kumar khasdev (5): Staging: comedi: fix line over 80 characters warning Staging: comedi: fix line over 80 characters warning Staging: comedi: fix line over 80 characters warning Staging: comedi: fix line over 80 characters warning Staging: comedi: fix line over 80 characters warning drivers/staging/comedi/drivers/pcl812.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2 3/5] Staging: comedi: fix line over 80 characters warning
This is patch to file pcl812.c that fix up warning line
over 80 character which is found by checkpatch tool.
Singed-off-by: Jitendra Kumar Khasdev jkhas...@gmail.com
---
drivers/staging/comedi/drivers/pcl812.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/pcl812.c
b/drivers/staging/comedi/drivers/pcl812.c
index 069af70..aae934e7 100644
--- a/drivers/staging/comedi/drivers/pcl812.c
+++ b/drivers/staging/comedi/drivers/pcl812.c
@@ -522,7 +522,9 @@ struct pcl812_private {
unsigned int dma_runs_to_end; /* how many times we must switch
* DMA buffers
*/
- unsigned int last_dma_run; /* how many bytes to transfer on last
DMA buffer */
+ unsigned int last_dma_run; /* how many bytes to transfer on last
+* DMA buffer
+*/
unsigned int max_812_ai_mode0_rangewait;/* setling time for
gain */
unsigned int divisor1;
unsigned int divisor2;
--
1.9.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2 2/5] Staging: comedi: fix line over 80 characters warning
This is patch to file pcl812.c that fix up warning line
over 80 character which is found by checkpatch tool.
Singed-off-by: Jitendra Kumar Khasdev jkhas...@gmail.com
---
drivers/staging/comedi/drivers/pcl812.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/pcl812.c
b/drivers/staging/comedi/drivers/pcl812.c
index 24eb601..069af70 100644
--- a/drivers/staging/comedi/drivers/pcl812.c
+++ b/drivers/staging/comedi/drivers/pcl812.c
@@ -519,7 +519,9 @@ struct pcl812_private {
unsigned int hwdmaptr[2]; /* HW PTR to DMA buf */
unsigned int dmabytestomove[2]; /* how many bytes DMA transfer */
int next_dma_buf; /* which buffer is next to use */
- unsigned int dma_runs_to_end; /* how many times we must switch DMA
buffers */
+ unsigned int dma_runs_to_end; /* how many times we must switch
+* DMA buffers
+*/
unsigned int last_dma_run; /* how many bytes to transfer on last
DMA buffer */
unsigned int max_812_ai_mode0_rangewait;/* setling time for
gain */
unsigned int divisor1;
--
1.9.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2 4/5] Staging: comedi: fix line over 80 characters warning
This is patch to file pcl812.c that fix up warning line
over 80 character which is found by checkpatch tool.
Singed-off-by: Jitendra Kumar Khasdev jkhas...@gmail.com
---
drivers/staging/comedi/drivers/pcl812.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/pcl812.c
b/drivers/staging/comedi/drivers/pcl812.c
index aae934e7..5aeb695 100644
--- a/drivers/staging/comedi/drivers/pcl812.c
+++ b/drivers/staging/comedi/drivers/pcl812.c
@@ -525,7 +525,7 @@ struct pcl812_private {
unsigned int last_dma_run; /* how many bytes to transfer on last
* DMA buffer
*/
- unsigned int max_812_ai_mode0_rangewait;/* setling time for
gain */
+ unsigned int max_812_ai_mode0_rangewait; /* setling time for gain */
unsigned int divisor1;
unsigned int divisor2;
unsigned int use_diff:1;
--
1.9.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2 0/5] *** SUBJECT HERE ***
*** BLURB HERE *** jitendra kumar khasdev (5): Staging: comedi: fix line over 80 characters warning Staging: comedi: fix line over 80 characters warning Staging: comedi: fix line over 80 characters warning Staging: comedi: fix line over 80 characters warning Staging: comedi: fix line over 80 characters warning drivers/staging/comedi/drivers/pcl812.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2 1/5] Staging: comedi: fix line over 80 characters warning
This is patch to file pcl812.c that fix up warning line
over 80 character which is found by checkpatch tool.
Singed-off-by: Jitendra Kumar Khasdev jkhas...@gmail.com
---
drivers/staging/comedi/drivers/pcl812.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/pcl812.c
b/drivers/staging/comedi/drivers/pcl812.c
index ac243ca..24eb601 100644
--- a/drivers/staging/comedi/drivers/pcl812.c
+++ b/drivers/staging/comedi/drivers/pcl812.c
@@ -510,7 +510,8 @@ struct pcl812_private {
unsigned char dma; /* 0 use dma ( usedDMA channel) */
unsigned char range_correction; /* =1 we must add 1 to range number */
unsigned int last_ai_chanspec;
- unsigned char mode_reg_int; /* there is stored INT number for some
card */
+ unsigned char mode_reg_int; /* there is stored INT number
+ for some card */
unsigned int ai_poll_ptr; /* how many sampes transfer poll */
unsigned int dmapages;
unsigned int hwdmasize;
--
1.9.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 2/5] Staging: comedi: fix line over 80 characters warning
This is patch to file pcl812.c that fix up warning line
over 80 character which is found by checkpatch tool.
Signed-off-by: Jitendra Kumar Khasdev jkhas...@gmail.com
---
drivers/staging/comedi/drivers/pcl812.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/pcl812.c
b/drivers/staging/comedi/drivers/pcl812.c
index 24eb601..069af70 100644
--- a/drivers/staging/comedi/drivers/pcl812.c
+++ b/drivers/staging/comedi/drivers/pcl812.c
@@ -519,7 +519,9 @@ struct pcl812_private {
unsigned int hwdmaptr[2]; /* HW PTR to DMA buf */
unsigned int dmabytestomove[2]; /* how many bytes DMA transfer */
int next_dma_buf; /* which buffer is next to use */
- unsigned int dma_runs_to_end; /* how many times we must switch DMA
buffers */
+ unsigned int dma_runs_to_end; /* how many times we must switch
+* DMA buffers
+*/
unsigned int last_dma_run; /* how many bytes to transfer on last
DMA buffer */
unsigned int max_812_ai_mode0_rangewait;/* setling time for
gain */
unsigned int divisor1;
--
1.9.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 1/5] Staging: comedi: fix line over 80 characters warning
This is patch to file pcl812.c that fix up warning line
over 80 character which is found by checkpatch tool.
Signed-off-by: Jitendra Kumar Khasdev jkhas...@gmail.com
---
drivers/staging/comedi/drivers/pcl812.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/pcl812.c
b/drivers/staging/comedi/drivers/pcl812.c
index ac243ca..24eb601 100644
--- a/drivers/staging/comedi/drivers/pcl812.c
+++ b/drivers/staging/comedi/drivers/pcl812.c
@@ -510,7 +510,8 @@ struct pcl812_private {
unsigned char dma; /* 0 use dma ( usedDMA channel) */
unsigned char range_correction; /* =1 we must add 1 to range number */
unsigned int last_ai_chanspec;
- unsigned char mode_reg_int; /* there is stored INT number for some
card */
+ unsigned char mode_reg_int; /* there is stored INT number
+ for some card */
unsigned int ai_poll_ptr; /* how many sampes transfer poll */
unsigned int dmapages;
unsigned int hwdmasize;
--
1.9.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 4/5] Staging: comedi: fix line over 80 characters warning
This is patch to file pcl812.c that fix up warning line
over 80 character which is found by checkpatch tool.
Signed-off-by: Jitendra Kumar Khasdev jkhas...@gmail.com
---
drivers/staging/comedi/drivers/pcl812.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/pcl812.c
b/drivers/staging/comedi/drivers/pcl812.c
index aae934e7..5aeb695 100644
--- a/drivers/staging/comedi/drivers/pcl812.c
+++ b/drivers/staging/comedi/drivers/pcl812.c
@@ -525,7 +525,7 @@ struct pcl812_private {
unsigned int last_dma_run; /* how many bytes to transfer on last
* DMA buffer
*/
- unsigned int max_812_ai_mode0_rangewait;/* setling time for
gain */
+ unsigned int max_812_ai_mode0_rangewait; /* setling time for gain */
unsigned int divisor1;
unsigned int divisor2;
unsigned int use_diff:1;
--
1.9.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 3/5] Staging: comedi: fix line over 80 characters warning
This is patch to file pcl812.c that fix up warning line
over 80 character which is found by checkpatch tool.
Signed-off-by: Jitendra Kumar Khasdev jkhas...@gmail.com
---
drivers/staging/comedi/drivers/pcl812.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/pcl812.c
b/drivers/staging/comedi/drivers/pcl812.c
index 069af70..aae934e7 100644
--- a/drivers/staging/comedi/drivers/pcl812.c
+++ b/drivers/staging/comedi/drivers/pcl812.c
@@ -522,7 +522,9 @@ struct pcl812_private {
unsigned int dma_runs_to_end; /* how many times we must switch
* DMA buffers
*/
- unsigned int last_dma_run; /* how many bytes to transfer on last
DMA buffer */
+ unsigned int last_dma_run; /* how many bytes to transfer on last
+* DMA buffer
+*/
unsigned int max_812_ai_mode0_rangewait;/* setling time for
gain */
unsigned int divisor1;
unsigned int divisor2;
--
1.9.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 5/5] Staging: comedi: fix line over 80 characters warning
This is patch to file pcl812.c that fix up warning line
over 80 character which is found by checkpatch tool.
Signed-off-by: Jitendra Kumar Khasdev jkhas...@gmail.com
---
drivers/staging/comedi/drivers/pcl812.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/pcl812.c
b/drivers/staging/comedi/drivers/pcl812.c
index 5aeb695..f06347f 100644
--- a/drivers/staging/comedi/drivers/pcl812.c
+++ b/drivers/staging/comedi/drivers/pcl812.c
@@ -1240,7 +1240,7 @@ static int pcl812_attach(struct comedi_device *dev,
struct comedi_devconfig *it)
for (i = 0; i 2; i++) {
unsigned long dmabuf;
- dmabuf = __get_dma_pages(GFP_KERNEL,
devpriv-dmapages);
+ dmabuf = __get_dma_pages(GFP_KERNEL, devpriv-dmapages);
if (!dmabuf)
return -ENOMEM;
--
1.9.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 1/2] Staging: comedi: tab space coding style issue in pcl818.c
This is patch to the pcl818.c that fix up a use tab error found by the checkpatch.pl tool Signed-off-by: Jitendra kumar khasdev jkhas...@gmail.com --- drivers/staging/comedi/drivers/pcl818.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/pcl818.c b/drivers/staging/comedi/drivers/pcl818.c index 8edea35..c29223b 100644 --- a/drivers/staging/comedi/drivers/pcl818.c +++ b/drivers/staging/comedi/drivers/pcl818.c @@ -45,7 +45,7 @@ A word or two about DMA. Driver support DMA operations at two ways: [1] - IRQ (0=disable, 2, 3, 4, 5, 6, 7) [2] - DMA (0=disable, 1, 3) [3] - 0, 10=10MHz clock for 8254 - 1= 1MHz clock for 8254 + 1= 1MHz clock for 8254 [4] - 0, 5=A/D input -5V.. +5V 1, 10=A/D input -10V..+10V [5] - 0, 5=D/A output 0-5V (internal reference -5V) -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 2/2] Staging: comedi: fix tab style issue
This is a patch to pcl818 that fix tab style error which is found by the checkpatch tool Signed-off-by: Jitendra Kumar Khasdev jkhas...@gmail.com --- drivers/staging/comedi/drivers/pcl818.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/pcl818.c b/drivers/staging/comedi/drivers/pcl818.c index c29223b..aa93d55 100644 --- a/drivers/staging/comedi/drivers/pcl818.c +++ b/drivers/staging/comedi/drivers/pcl818.c @@ -47,7 +47,7 @@ A word or two about DMA. Driver support DMA operations at two ways: [3] - 0, 10=10MHz clock for 8254 1= 1MHz clock for 8254 [4] - 0, 5=A/D input -5V.. +5V - 1, 10=A/D input -10V..+10V + 1, 10=A/D input -10V..+10V [5] - 0, 5=D/A output 0-5V (internal reference -5V) 1, 10=D/A output 0-10V (internal reference -10V) 2=D/A output unknown (external reference) -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] Staging: comedi: tab space coding style issue in pcl818.c
This is patch to the pcl818.c that fix up a use tab error found by the checkpatch.pl tool --- drivers/staging/comedi/drivers/pcl818.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/pcl818.c b/drivers/staging/comedi/drivers/pcl818.c index 8edea35..c29223b 100644 --- a/drivers/staging/comedi/drivers/pcl818.c +++ b/drivers/staging/comedi/drivers/pcl818.c @@ -45,7 +45,7 @@ A word or two about DMA. Driver support DMA operations at two ways: [1] - IRQ (0=disable, 2, 3, 4, 5, 6, 7) [2] - DMA (0=disable, 1, 3) [3] - 0, 10=10MHz clock for 8254 - 1= 1MHz clock for 8254 + 1= 1MHz clock for 8254 [4] - 0, 5=A/D input -5V.. +5V 1, 10=A/D input -10V..+10V [5] - 0, 5=D/A output 0-5V (internal reference -5V) -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] Staging: comedi: drivers: fix space coding style issue in s626.c
This is a patch to the s626.c file that fixes up a space error
found by the checkpatch.pl tool
Signed-off-by: Jitendra Kumar Khasdev jkhas...@gmail.com
---
drivers/staging/comedi/drivers/s626.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/s626.c
b/drivers/staging/comedi/drivers/s626.c
index 14932c5..fc497dd 100644
--- a/drivers/staging/comedi/drivers/s626.c
+++ b/drivers/staging/comedi/drivers/s626.c
@@ -118,7 +118,7 @@ static void s626_mc_enable(struct comedi_device *dev,
static void s626_mc_disable(struct comedi_device *dev,
unsigned int cmd, unsigned int reg)
{
- writel(cmd 16 , dev-mmio + reg);
+ writel(cmd 16, dev-mmio + reg);
mmiowb();
}
--
1.9.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 2/2] Staging: comedi: driver : fix max 80 character coding style issue in s626.c
This is a patch to the s626.c file that fixes up a maximum 80 character limit
warning found by the checkpatch.pl tool
Signed-off-by: Jitendra Kumar Khasdev jkhas...@gmail.com
---
drivers/staging/comedi/drivers/s626.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/s626.c
b/drivers/staging/comedi/drivers/s626.c
index fc497dd..77f715b 100644
--- a/drivers/staging/comedi/drivers/s626.c
+++ b/drivers/staging/comedi/drivers/s626.c
@@ -2534,7 +2534,8 @@ static int s626_initialize(struct comedi_device *dev)
for (i = 0; i 2; i++) {
writel(S626_I2C_CLKSEL, dev-mmio + S626_P_I2CSTAT);
s626_mc_enable(dev, S626_MC2_UPLD_IIC, S626_P_MC2);
- ret = comedi_timeout(dev, NULL, NULL, s626_i2c_handshake_eoc,
0);
+ ret = comedi_timeout(dev, NULL, NULL, s626_i2c_handshake_eoc,
+ 0);
if (ret)
return ret;
}
--
1.9.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 3/3] Staging: comedi: fix space and 80 char coding style issue
This is a patch to the s626.c file that fixes up spcae and maximum
character limit warning found by the checkpatch.pl tool
Signed-off-by: Jitendra Kumar Khasdev jkhas...@gmail.com
---
drivers/staging/comedi/drivers/s626.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/s626.c
b/drivers/staging/comedi/drivers/s626.c
index 14932c5..77f715b 100644
--- a/drivers/staging/comedi/drivers/s626.c
+++ b/drivers/staging/comedi/drivers/s626.c
@@ -118,7 +118,7 @@ static void s626_mc_enable(struct comedi_device *dev,
static void s626_mc_disable(struct comedi_device *dev,
unsigned int cmd, unsigned int reg)
{
- writel(cmd 16 , dev-mmio + reg);
+ writel(cmd 16, dev-mmio + reg);
mmiowb();
}
@@ -2534,7 +2534,8 @@ static int s626_initialize(struct comedi_device *dev)
for (i = 0; i 2; i++) {
writel(S626_I2C_CLKSEL, dev-mmio + S626_P_I2CSTAT);
s626_mc_enable(dev, S626_MC2_UPLD_IIC, S626_P_MC2);
- ret = comedi_timeout(dev, NULL, NULL, s626_i2c_handshake_eoc,
0);
+ ret = comedi_timeout(dev, NULL, NULL, s626_i2c_handshake_eoc,
+ 0);
if (ret)
return ret;
}
--
1.9.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
