Re: [PATCH v18 0/12] dw-hdmi: convert imx hdmi to bridge/dw_hdmi

2015-01-06 Thread Liu Ying 
 with the
allmodconfig configuration for the ARM architecture.
Please fix this.

drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c:243:1: error: 
‘__mod_of__dw_hdmi_rockchip_dt_ids_device_table’ aliased to undefined 
symbol ‘dw_hdmi_rockchip_dt_ids’
scripts/Makefile.build:257: recipe for target 
'drivers/gpu/drm/rockchip/dw_hdmi-rockchip.o' failed

make[4]: *** [drivers/gpu/drm/rockchip/dw_hdmi-rockchip.o] Error 1
scripts/Makefile.build:402: recipe for target 'drivers/gpu/drm/rockchip' 
failed

make[3]: *** [drivers/gpu/drm/rockchip] Error 2
scripts/Makefile.build:402: recipe for target 'drivers/gpu/drm' failed
make[2]: *** [drivers/gpu/drm] Error 2
scripts/Makefile.build:402: recipe for target 'drivers/gpu' failed
make[1]: *** [drivers/gpu] Error 2
Makefile:937: recipe for target 'drivers' failed
make: *** [drivers] Error 2

Regards,
Liu Ying
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: drm/imx: remove an unnecessary local variable

2014-02-10 Thread Liu Ying 
This patch removes an unnecessary local variable defined
in the function imx_drm_driver_unload() so as to fix the
following build warning.

drivers/staging/imx-drm/imx-drm-core.c: \
In function ‘imx_drm_driver_unload’:
drivers/staging/imx-drm/imx-drm-core.c:87:25: \
warning: unused variable ‘imxdrm’ [-Wunused-variable]

Signed-off-by: Liu Ying ying@freescale.com
---
 drivers/staging/imx-drm/imx-drm-core.c |2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/staging/imx-drm/imx-drm-core.c 
b/drivers/staging/imx-drm/imx-drm-core.c
index 236ed66..573fe88 100644
--- a/drivers/staging/imx-drm/imx-drm-core.c
+++ b/drivers/staging/imx-drm/imx-drm-core.c
@@ -84,8 +84,6 @@ static void imx_drm_driver_lastclose(struct drm_device *drm)
 
 static int imx_drm_driver_unload(struct drm_device *drm)
 {
-   struct imx_drm_device *imxdrm = drm-dev_private;
-
imx_drm_device_put();
 
drm_vblank_cleanup(drm);
-- 
1.7.9.5


___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: drm/imx: remove an unnecessary local variable

2014-02-10 Thread Liu Ying 
On 02/10/2014 06:29 PM, Russell King - ARM Linux wrote:
 On Mon, Feb 10, 2014 at 06:29:45PM +0800, Liu Ying wrote:
 This patch removes an unnecessary local variable defined
 in the function imx_drm_driver_unload() so as to fix the
 following build warning.

 drivers/staging/imx-drm/imx-drm-core.c: \
 In function ‘imx_drm_driver_unload’:
 drivers/staging/imx-drm/imx-drm-core.c:87:25: \
 warning: unused variable ‘imxdrm’ [-Wunused-variable]
 
 Already-Naked-by: me.  This is required by later patches in the series
 posted earlier.
 

Sorry. Did you mean that you have already got a fix for this?


___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v2] staging: imx-drm: imx-tve: Fix a sparse warning

2013-12-23 Thread Liu Ying 
This patch declares the function of_get_tve_mode
as a static one to fix this sparse warning:
drivers/staging/imx-drm/imx-tve.c:563:11: warning: \
symbol 'of_get_tve_mode' was not declared. \
Should it be static?

Acked-by: Shawn Guo shawn@linaro.org
Signed-off-by: Liu Ying ying@freescale.com
---
Changes from v2:
-Just added Shawn Guo's ack.

 drivers/staging/imx-drm/imx-tve.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/imx-drm/imx-tve.c 
b/drivers/staging/imx-drm/imx-tve.c
index 2c44fef..9abc7ca 100644
--- a/drivers/staging/imx-drm/imx-tve.c
+++ b/drivers/staging/imx-drm/imx-tve.c
@@ -560,7 +560,7 @@ static const char *imx_tve_modes[] = {
[TVE_MODE_VGA] = vga,
 };
 
-const int of_get_tve_mode(struct device_node *np)
+static const int of_get_tve_mode(struct device_node *np)
 {
const char *bm;
int ret, i;
-- 
1.7.9.5


___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: imx-drm: imx-tve: Fix a sparse warning

2013-12-21 Thread Liu Ying 
This patch declares the function of_get_tve_mode
as a static one to fix this sparse warning:
drivers/staging/imx-drm/imx-tve.c:563:11: warning: \
symbol 'of_get_tve_mode' was not declared. \
Should it be static?

Signed-off-by: Liu Ying ying@freescale.com
---
 drivers/staging/imx-drm/imx-tve.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/imx-drm/imx-tve.c 
b/drivers/staging/imx-drm/imx-tve.c
index 2c44fef..9abc7ca 100644
--- a/drivers/staging/imx-drm/imx-tve.c
+++ b/drivers/staging/imx-drm/imx-tve.c
@@ -560,7 +560,7 @@ static const char *imx_tve_modes[] = {
[TVE_MODE_VGA] = vga,
 };
 
-const int of_get_tve_mode(struct device_node *np)
+static const int of_get_tve_mode(struct device_node *np)
 {
const char *bm;
int ret, i;
-- 
1.7.9.5


___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 01/11] staging: drm/imx: also allow to allocate only 2 DMFC slots for DP full plane

2013-10-11 Thread Liu Ying 
Hi Philipp,

On 10/10/2013 10:18 PM, Philipp Zabel wrote:
 Connecting a 320x240 parallel display on i.MX6 resulted in an invalid DRDY
 signal because the DC would not receive NL/EOL events on every line.
 Reducing the allocated DMFC space from 4 slots (256 * 128-bit) to 2 slots
 (128 * 128-bit) solved the problem.
 
 Signed-off-by: Philipp Zabel p.za...@pengutronix.de
 ---
  drivers/staging/imx-drm/ipu-v3/ipu-dmfc.c | 8 
  1 file changed, 4 insertions(+), 4 deletions(-)
 
 diff --git a/drivers/staging/imx-drm/ipu-v3/ipu-dmfc.c 
 b/drivers/staging/imx-drm/ipu-v3/ipu-dmfc.c
 index 2e97c33..98070dd 100644
 --- a/drivers/staging/imx-drm/ipu-v3/ipu-dmfc.c
 +++ b/drivers/staging/imx-drm/ipu-v3/ipu-dmfc.c
 @@ -307,13 +307,13 @@ int ipu_dmfc_alloc_bandwidth(struct dmfc_channel *dmfc,
   goto out;
   }
  
 - /* Always allocate at least 128*4 bytes (2 slots) */
 - if (slots  2)
 - slots = 2;
 -
   /* For the MEM_BG channel, first try to allocate twice the slots */
   if (dmfc-data-ipu_channel == IPUV3_CHANNEL_MEM_BG_SYNC)
   segment = dmfc_find_slots(priv, slots * 2);
 + else if (slots  2)
 + /* Always allocate at least 128*4 bytes (2 slots) */

The commit message mentions that the size of 2 slots is 128*128-bit, that is, 
128*16-byte.
This contradicts the above annotation(128*4 bytes (2 slots)).

 + slots = 2;
 +
   if (segment = 0)
   slots *= 2;
   else
 

Regards,
Liu Ying

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel