Re: [PATCH] Staging:bcm: Fixes coding style issues in drivers/staging/bcm/Qos.c

2014-04-16 Thread Marcos Di Pietro 
On Wed, Apr 16, 2014 at 11:39 AM, Greg KH g...@kroah.com wrote:
 On Tue, Apr 15, 2014 at 09:37:18PM -0400, Marcos A. Di Pietro wrote:
 On 04/10/2014 07:56 PM, Greg KH wrote:
  On Thu, Apr 10, 2014 at 07:27:27PM -0400, Marcos A. Di Pietro wrote:
  That's pretty obviously not going to apply properly, you have line-wrapp
  on.  You can't cut-and-paste patches into gmail, see
  Documentation/email_clients.txt for details.
 
  thanks,
 
  greg k-h
 
  I'm so sorry about that. I already read it and configured Thunderbird as 
  recommended. I just forgot to turn line wrap off.
 
  That worked, as this line shows :)
 
  But you put the patch at the end of the email, I can't do anything with
  it, I need it as a clean email, something I don't have to edit by hand
  when applying.
 
  Also...
 
  -static void EThCSGetPktInfo(struct bcm_mini_adapter *Adapter, PVOID 
  pvEthPayload, struct bcm_eth_packet_info *pstEthCsPktInfo);
  -static bool EThCSClassifyPkt(struct bcm_mini_adapter *Adapter, struct 
  sk_buff* skb, struct bcm_eth_packet_info *pstEthCsPktInfo, struct 
  bcm_classifier_rule *pstClassifierRule, B_UINT8 EthCSCupport);
  +static void EThCSGetPktInfo(struct bcm_mini_adapter *Adapter,
  +   PVOID pvEthPayload, struct bcm_eth_packet_info *pstEthCsPktInfo);
  +
  +static bool EThCSClassifyPkt(struct bcm_mini_adapter *Adapter,
  +   struct sk_buff *skb, struct bcm_eth_packet_info *pstEthCsPktInfo,
  +   struct bcm_classifier_rule *pstClassifierRule, B_UINT8 
  EthCSCupport);
 
   static USHORT  IpVersion4(struct bcm_mini_adapter *Adapter, struct iphdr 
  *iphd,
  -  struct bcm_classifier_rule *pstClassifierRule);
  +   struct bcm_classifier_rule *pstClassifierRule);
 
  What happened to the tabs?
 
  And why modify this last line, what was wrong with it?
 
  thanks,
 
  greg k-h
 

 Greg,

 Where you able to apply the patch successfully?

 I asked above what happened to the tabs, and why modify that line, so
 no, I did not apply it, as it doesn't look correct to me.

 thanks,

 greg k-h

In the last patch I sent, I believe I addressed the why modify that line issue.
However, I just realized that for whatever reason my tabs are being converted
to spaces when sending the email.  I'll try to work around this.  What email
client do you recommend for submitting patches?

Also, I sent a v2 patch and received and auto response from you. Should I
submitted the fixed patch as a v3 or continue in this thread?

thanks,
marcos
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] Staging:bcm: Fixes coding style issues in drivers/staging/bcm/Qos.c

2014-03-25 Thread Marcos Di Pietro 
Thank you for the advise and the heads up.

On Tue, Mar 25, 2014 at 2:14 PM, Greg KH gre...@linuxfoundation.org wrote:
 On Tue, Mar 25, 2014 at 01:55:47PM -0400, Marcos A. Di Pietro wrote:
 Fixes code style errors in drivers/staging/bcm/Qos.c

 Patch submitted as part of the Eudyptula Challenge.

 Signed-off-by: Marcos A. Di Pietro marcos...@gmail.com
 ---
  drivers/staging/bcm/Qos.c | 13 -
  1 file changed, 8 insertions(+), 5 deletions(-)

 Always properly cc: the relevant maintainers involved in a driver/file.
 scripts/get_maintainer.pl can help you here.

 I'll queue this up after the merge window is over (i.e. after 3.15-rc1
 is out).  Don't worry, it's not lost.

 thanks,

 greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel