Re: [PATCH] staging: ks7010: remove unnecessary parentheses

[Matt McCoy]

On Tue, Jan 22, 2019 at 06:45:37PM -0800, Joe Perches wrote:
> On Tue, 2019-01-22 at 21:18 -0500, Matt McCoy wrote:
> > Remove unnecessary parentheses reported by checkpatch.
> []
> > diff --git a/drivers/staging/ks7010/ks_hostif.c 
> > b/drivers/staging/ks7010/ks_hostif.c
> []
> > @@ -171,7 +171,7 @@ int get_current_ap(struct ks_wlan_private *priv, struct 
> > link_ap_info *ap_info)
> >"- rate_set_size=%d\n",
> >ap->bssid[0], ap->bssid[1], ap->bssid[2],
> >ap->bssid[3], ap->bssid[4], ap->bssid[5],
> > -  &(ap->ssid.body[0]),
> > +  >ssid.body[0],
> >ap->rate_set.body[0], ap->rate_set.body[1],
> >ap->rate_set.body[2], ap->rate_set.body[3],
> >ap->rate_set.body[4], ap->rate_set.body[5],
> 
> This bit:
> 
> []
>   netdev_dbg(priv->net_dev, "Link AP\n"
>  "- bssid=%02X:%02X:%02X:%02X:%02X:%02X\n"
> []
>  ap->bssid[0], ap->bssid[1], ap->bssid[2],
> 
> should instead use the vsprintf %pM extension
> 
>   "- bssid: %pM\n"
> []
>   ap->bssid,
> 
>

Should I just make a v2 of this patch with 2 parts ?
One being this change and the other using the %pM extension.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: ks7010: remove unnecessary parentheses

[Matt McCoy]

Remove unnecessary parentheses reported by checkpatch.

Signed-off-by: Matt McCoy 
---
 drivers/staging/ks7010/ks_hostif.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/ks7010/ks_hostif.c 
b/drivers/staging/ks7010/ks_hostif.c
index 065bce1..d938b09 100644
--- a/drivers/staging/ks7010/ks_hostif.c
+++ b/drivers/staging/ks7010/ks_hostif.c
@@ -35,7 +35,7 @@ static inline u8 get_byte(struct ks_wlan_private *priv)
 {
u8 data;
 
-   data = *(priv->rxp)++;
+   data = *priv->rxp++;
/* length check in advance ! */
--(priv->rx_size);
return data;
@@ -171,7 +171,7 @@ int get_current_ap(struct ks_wlan_private *priv, struct 
link_ap_info *ap_info)
   "- rate_set_size=%d\n",
   ap->bssid[0], ap->bssid[1], ap->bssid[2],
   ap->bssid[3], ap->bssid[4], ap->bssid[5],
-  &(ap->ssid.body[0]),
+  >ssid.body[0],
   ap->rate_set.body[0], ap->rate_set.body[1],
   ap->rate_set.body[2], ap->rate_set.body[3],
   ap->rate_set.body[4], ap->rate_set.body[5],
@@ -732,7 +732,7 @@ void hostif_scan_indication(struct ks_wlan_private *priv)
netdev_dbg(priv->net_dev, " scan_ind_count=%d :: 
aplist.size=%d\n",
priv->scan_ind_count, priv->aplist.size);
get_ap_information(priv, (struct ap_info *)(priv->rxp),
-  &(priv->aplist.ap[priv->scan_ind_count - 
1]));
+  >aplist.ap[priv->scan_ind_count - 1]);
priv->aplist.size = priv->scan_ind_count;
} else {
netdev_dbg(priv->net_dev, " count over :: scan_ind_count=%d\n",
-- 
2.7.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel