Re: [PATCH] staging: rtl8712: Fixed multiple parenthesis alignment warnings in ieee80211.c
No mate, that aint just cutting it. I tried putting it, maybe i’m doing something wrong? Regards, Parth > On 08-Jun-2016, at 5:46 PM, Luis de Bethencourt <lui...@osg.samsung.com> > wrote: > > On 08/06/16 12:58, Parth Sane wrote: >> I’m trying to fix line 224 but its simply not happening. Can you help me >> with this? >> Regards, >> Parth >>> On 08-Jun-2016, at 5:19 PM, Luis de Bethencourt <lui...@osg.samsung.com> >>> wrote: >>> >>> On 08/06/16 12:37, Parth Sane wrote: >>>> >>>>> On 08-Jun-2016, at 5:01 PM, Luis de Bethencourt <lui...@osg.samsung.com> >>>>> wrote: >>>>> >>>>> On 08/06/16 12:27, Parth Sane wrote: >>>>>> Multiple parenthesis alignment warnings were thrown by checkpatch in >>>>>> ieee80211.c >>>>>> This patch effectively fixes that. >>>>>> >>>>>> Signed-off-by: Parth Sane <laerdevstud...@gmail.com> >>>>>> >>>>>> --- >>>>>> drivers/staging/rtl8712/ieee80211.c | 25 - >>>>>> 1 file changed, 12 insertions(+), 13 deletions(-) >>>>> >>>>> Some of the lines you change are over 80 characters. You could fix those >>>>> as well in >>>>> a second patch :) >>>>> >>>>> Thanks, >>>>> Luis >>>>> >>>> >>>> You’re right on that regard. Maybe once this is accepted I can come back >>>> to other warnings. I will submit other patches meanwhile. >>>> I seriously want to see this driver in the next release! >>>> Regards, >>>> Parth >>>> >>> >>> You can resend this patch and the one fixing the 80 char limit with the >>> subject >>> prefix [RESEND PATCH v2 x/2]. >>> >>> AFAIK this driver is already in the release, check menuconfig under >>> "Device Drivers > Staging drivers > Realtek RTL8172" >>> >>> Thanks, >>> Luis >> > > Sure. > > You want something like this: > - if (memcmp((pbuf + 2), wpa_oui_type, > sizeof(wpa_oui_type))) > + if (memcmp((pbuf + 2), wpa_oui_type, > + sizeof(wpa_oui_type))) > > You could check for references of how other parts of the code have solved it > by doing: > git grep memcpy * | grep -v ";" > > I hope that helps. > Luis > > > > Reviewed-by: Luis de Bethencourt <lui...@osg.samsung.com> signature.asc Description: Message signed with OpenPGP using GPGMail ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: rtl8712: Fixed multiple parenthesis alignment warnings in ieee80211.c
I’m trying to fix line 224 but its simply not happening. Can you help me with this? Regards, Parth > On 08-Jun-2016, at 5:19 PM, Luis de Bethencourt <lui...@osg.samsung.com> > wrote: > > On 08/06/16 12:37, Parth Sane wrote: >> >>> On 08-Jun-2016, at 5:01 PM, Luis de Bethencourt <lui...@osg.samsung.com> >>> wrote: >>> >>> On 08/06/16 12:27, Parth Sane wrote: >>>> Multiple parenthesis alignment warnings were thrown by checkpatch in >>>> ieee80211.c >>>> This patch effectively fixes that. >>>> >>>> Signed-off-by: Parth Sane <laerdevstud...@gmail.com> >>>> >>>> --- >>>> drivers/staging/rtl8712/ieee80211.c | 25 - >>>> 1 file changed, 12 insertions(+), 13 deletions(-) >>> >>> Some of the lines you change are over 80 characters. You could fix those as >>> well in >>> a second patch :) >>> >>> Thanks, >>> Luis >>> >> >> You’re right on that regard. Maybe once this is accepted I can come back to >> other warnings. I will submit other patches meanwhile. >> I seriously want to see this driver in the next release! >> Regards, >> Parth >> > > You can resend this patch and the one fixing the 80 char limit with the > subject > prefix [RESEND PATCH v2 x/2]. > > AFAIK this driver is already in the release, check menuconfig under > "Device Drivers > Staging drivers > Realtek RTL8172" > > Thanks, > Luis signature.asc Description: Message signed with OpenPGP using GPGMail ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: rtl8712: Fixed multiple parenthesis alignment warnings in ieee80211.c
> On 08-Jun-2016, at 5:01 PM, Luis de Bethencourt <lui...@osg.samsung.com> > wrote: > > On 08/06/16 12:27, Parth Sane wrote: >> Multiple parenthesis alignment warnings were thrown by checkpatch in >> ieee80211.c >> This patch effectively fixes that. >> >> Signed-off-by: Parth Sane <laerdevstud...@gmail.com> >> >> --- >> drivers/staging/rtl8712/ieee80211.c | 25 - >> 1 file changed, 12 insertions(+), 13 deletions(-) > > Some of the lines you change are over 80 characters. You could fix those as > well in > a second patch :) > > Thanks, > Luis > You’re right on that regard. Maybe once this is accepted I can come back to other warnings. I will submit other patches meanwhile. I seriously want to see this driver in the next release! Regards, Parth signature.asc Description: Message signed with OpenPGP using GPGMail ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: rtl8712: Fixed multiple parenthesis alignment warnings in ieee80211.c
Multiple parenthesis alignment warnings were thrown by checkpatch in ieee80211.c
This patch effectively fixes that.
Signed-off-by: Parth Sane <laerdevstud...@gmail.com>
---
drivers/staging/rtl8712/ieee80211.c | 25 -
1 file changed, 12 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/rtl8712/ieee80211.c
b/drivers/staging/rtl8712/ieee80211.c
index 8918654..5dc3b5b 100644
--- a/drivers/staging/rtl8712/ieee80211.c
+++ b/drivers/staging/rtl8712/ieee80211.c
@@ -145,7 +145,7 @@ static void set_supported_rate(u8 *rates, uint mode)
case WIRELESS_11BG:
memcpy(rates, WIFI_CCKRATES, IEEE80211_CCK_RATE_LEN);
memcpy(rates + IEEE80211_CCK_RATE_LEN, WIFI_OFDMRATES,
- IEEE80211_NUM_OFDM_RATESLEN);
+ IEEE80211_NUM_OFDM_RATESLEN);
break;
}
}
@@ -188,24 +188,24 @@ int r8712_generate_ie(struct registry_priv *pregistrypriv)
ie += 2;
/*SSID*/
ie = r8712_set_ie(ie, _SSID_IE_, pdev_network->Ssid.SsidLength,
- pdev_network->Ssid.Ssid, );
+ pdev_network->Ssid.Ssid, );
/*supported rates*/
set_supported_rate(pdev_network->rates, pregistrypriv->wireless_mode);
rateLen = r8712_get_rateset_len(pdev_network->rates);
if (rateLen > 8) {
ie = r8712_set_ie(ie, _SUPPORTEDRATES_IE_, 8,
- pdev_network->rates, );
+ pdev_network->rates, );
ie = r8712_set_ie(ie, _EXT_SUPPORTEDRATES_IE_, (rateLen - 8),
- (pdev_network->rates + 8), );
+ (pdev_network->rates + 8), );
} else
ie = r8712_set_ie(ie, _SUPPORTEDRATES_IE_,
- rateLen, pdev_network->rates, );
+ rateLen, pdev_network->rates, );
/*DS parameter set*/
ie = r8712_set_ie(ie, _DSSET_IE_, 1,
- (u8 *)&(pdev_network->Configuration.DSConfig), );
+ (u8 *)&(pdev_network->Configuration.DSConfig), );
/*IBSS Parameter Set*/
ie = r8712_set_ie(ie, _IBSS_PARA_IE_, 2,
- (u8 *)&(pdev_network->Configuration.ATIMWindow), );
+ (u8 *)&(pdev_network->Configuration.ATIMWindow), );
return sz;
}
@@ -220,8 +220,7 @@ unsigned char *r8712_get_wpa_ie(unsigned char *pie, int
*wpa_ie_len, int limit)
pbuf = r8712_get_ie(pbuf, _WPA_IE_ID_, , limit);
if (pbuf) {
/*check if oui matches...*/
- if (memcmp((pbuf + 2), wpa_oui_type,
- sizeof(wpa_oui_type)))
+ if (memcmp((pbuf + 2), wpa_oui_type,
sizeof(wpa_oui_type)))
goto check_next_ie;
/*check version...*/
memcpy((u8 *), (pbuf + 6), sizeof(val16));
@@ -279,7 +278,7 @@ static int r8712_get_wpa2_cipher_suite(u8 *s)
}
int r8712_parse_wpa_ie(u8 *wpa_ie, int wpa_ie_len, int *group_cipher,
-int *pairwise_cipher)
+ int *pairwise_cipher)
{
int i;
int left, count;
@@ -322,7 +321,7 @@ int r8712_parse_wpa_ie(u8 *wpa_ie, int wpa_ie_len, int
*group_cipher,
}
int r8712_parse_wpa2_ie(u8 *rsn_ie, int rsn_ie_len, int *group_cipher,
- int *pairwise_cipher)
+ int *pairwise_cipher)
{
int i;
int left, count;
@@ -365,7 +364,7 @@ int r8712_parse_wpa2_ie(u8 *rsn_ie, int rsn_ie_len, int
*group_cipher,
}
int r8712_get_sec_ie(u8 *in_ie, uint in_len, u8 *rsn_ie, u16 *rsn_len,
- u8 *wpa_ie, u16 *wpa_len)
+u8 *wpa_ie, u16 *wpa_len)
{
u8 authmode;
u8 wpa_oui[4] = {0x0, 0x50, 0xf2, 0x01};
@@ -383,7 +382,7 @@ int r8712_get_sec_ie(u8 *in_ie, uint in_len, u8 *rsn_ie,
u16 *rsn_len,
} else {
if (authmode == _WPA2_IE_ID_) {
memcpy(rsn_ie, _ie[cnt],
- in_ie[cnt + 1] + 2);
+ in_ie[cnt + 1] + 2);
*rsn_len = in_ie[cnt + 1] + 2;
cnt += in_ie[cnt + 1] + 2; /*get next*/
} else {
--
1.9.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v6] rtl8712: Fixed alignment to match open parenthesis
Hi, Yes you are right on that regard. I did do that in my previous patches. It’s just something that I will have to remember now onwards. Thanks. Regards, Parth Sane > On 26-Apr-2016, at 8:14 PM, Luis de Bethencourt <lui...@osg.samsung.com> > wrote: > > On 26/04/16 15:33, Parth Sane wrote: >> Hi, >> Thanks for the feedback. I did find this issue with the assistance >> checkpatch.pl script. >> Regards, >> Parth Sane > > Normally people mention the checkpatch warning they are fixing. > > For example: > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=5f10ef7dce02d8e36665974aca0977cda58c1122 > > Verbosity in the commit message is a good thing :) > > I have tested that your patch still applies cleanly to Greg's staging-testing > branch. > > Thanks, > Luis > >>> On 26-Apr-2016, at 8:00 PM, Luis de Bethencourt <lui...@osg.samsung.com> >>> wrote: >>> >>> On 25/04/16 16:43, Parth Sane wrote: >>>> Fixed alignment to match open parenthesis. >>>> >>>> Signed-off-by: Parth Sane <laerdevstud...@gmail.com> >>>> >>>> --- >>>> Changes in v6: >>>>-Added line before Signed-off message >>>> >>> >>> This last version looks good to me. Did you find this issue with >>> checkpatch.pl? >>> >>> Thanks, >>> Luis >>> >> signature.asc Description: Message signed with OpenPGP using GPGMail ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v6] rtl8712: Fixed alignment to match open parenthesis
Hi, Thanks for the feedback. I did find this issue with the assistance checkpatch.pl script. Regards, Parth Sane > On 26-Apr-2016, at 8:00 PM, Luis de Bethencourt <lui...@osg.samsung.com> > wrote: > > On 25/04/16 16:43, Parth Sane wrote: >> Fixed alignment to match open parenthesis. >> >> Signed-off-by: Parth Sane <laerdevstud...@gmail.com> >> >> --- >> Changes in v6: >> -Added line before Signed-off message >> > > This last version looks good to me. Did you find this issue with > checkpatch.pl? > > Thanks, > Luis > signature.asc Description: Message signed with OpenPGP using GPGMail ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v6] rtl8712: Fixed alignment to match open parenthesis
Fixed alignment to match open parenthesis. Signed-off-by: Parth Sane <laerdevstud...@gmail.com> --- Changes in v6: -Added line before Signed-off message drivers/staging/rtl8712/hal_init.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8712/hal_init.c b/drivers/staging/rtl8712/hal_init.c index 0c76fbc..0dd458d 100644 --- a/drivers/staging/rtl8712/hal_init.c +++ b/drivers/staging/rtl8712/hal_init.c @@ -197,8 +197,8 @@ static u8 rtl8712_dl_fw(struct _adapter *padapter) 0x); memcpy(ppayload, ptr, dump_imem_sz); r8712_write_mem(padapter, RTL8712_DMA_VOQ, - dump_imem_sz + TXDESC_SIZE, - (u8 *)ptx_desc); + dump_imem_sz + TXDESC_SIZE, + (u8 *)ptx_desc); ptr += dump_imem_sz; imem_sz -= dump_imem_sz; } while (imem_sz > 0); @@ -226,7 +226,8 @@ static u8 rtl8712_dl_fw(struct _adapter *padapter) 0x); memcpy(ppayload, ptr, dump_emem_sz); r8712_write_mem(padapter, RTL8712_DMA_VOQ, - dump_emem_sz + TXDESC_SIZE, (u8 *)ptx_desc); + dump_emem_sz + TXDESC_SIZE, + (u8 *)ptx_desc); ptr += dump_emem_sz; emem_sz -= dump_emem_sz; } while (emem_sz > 0); @@ -278,7 +279,7 @@ static u8 rtl8712_dl_fw(struct _adapter *padapter) ptx_desc->txdw0 |= cpu_to_le32(BIT(28)); memcpy(ppayload, , fwhdr.fw_priv_sz); r8712_write_mem(padapter, RTL8712_DMA_VOQ, - fwhdr.fw_priv_sz + TXDESC_SIZE, (u8 *)ptx_desc); + fwhdr.fw_priv_sz + TXDESC_SIZE, (u8 *)ptx_desc); /* polling dmem code done */ i = 100; -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v5] rtl8712: Fixed alignment to match open parenthesis
Fixed alignment to match open parenthesis. Signed-off-by: Parth Sane <laerdevstud...@gmail.com> --- Changes in v5: -Fixed missing commit messages. drivers/staging/rtl8712/hal_init.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8712/hal_init.c b/drivers/staging/rtl8712/hal_init.c index 0c76fbc..0dd458d 100644 --- a/drivers/staging/rtl8712/hal_init.c +++ b/drivers/staging/rtl8712/hal_init.c @@ -197,8 +197,8 @@ static u8 rtl8712_dl_fw(struct _adapter *padapter) 0x); memcpy(ppayload, ptr, dump_imem_sz); r8712_write_mem(padapter, RTL8712_DMA_VOQ, - dump_imem_sz + TXDESC_SIZE, - (u8 *)ptx_desc); + dump_imem_sz + TXDESC_SIZE, + (u8 *)ptx_desc); ptr += dump_imem_sz; imem_sz -= dump_imem_sz; } while (imem_sz > 0); @@ -226,7 +226,8 @@ static u8 rtl8712_dl_fw(struct _adapter *padapter) 0x); memcpy(ppayload, ptr, dump_emem_sz); r8712_write_mem(padapter, RTL8712_DMA_VOQ, - dump_emem_sz + TXDESC_SIZE, (u8 *)ptx_desc); + dump_emem_sz + TXDESC_SIZE, + (u8 *)ptx_desc); ptr += dump_emem_sz; emem_sz -= dump_emem_sz; } while (emem_sz > 0); @@ -278,7 +279,7 @@ static u8 rtl8712_dl_fw(struct _adapter *padapter) ptx_desc->txdw0 |= cpu_to_le32(BIT(28)); memcpy(ppayload, , fwhdr.fw_priv_sz); r8712_write_mem(padapter, RTL8712_DMA_VOQ, - fwhdr.fw_priv_sz + TXDESC_SIZE, (u8 *)ptx_desc); + fwhdr.fw_priv_sz + TXDESC_SIZE, (u8 *)ptx_desc); /* polling dmem code done */ i = 100; -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v4] rtl8712: Fixed alignment to match open parenthesis
diff --git a/drivers/staging/rtl8712/hal_init.c b/drivers/staging/rtl8712/hal_init.c index 0c76fbc..0dd458d 100644 --- a/drivers/staging/rtl8712/hal_init.c +++ b/drivers/staging/rtl8712/hal_init.c @@ -197,8 +197,8 @@ static u8 rtl8712_dl_fw(struct _adapter *padapter) 0x); memcpy(ppayload, ptr, dump_imem_sz); r8712_write_mem(padapter, RTL8712_DMA_VOQ, - dump_imem_sz + TXDESC_SIZE, - (u8 *)ptx_desc); + dump_imem_sz + TXDESC_SIZE, + (u8 *)ptx_desc); ptr += dump_imem_sz; imem_sz -= dump_imem_sz; } while (imem_sz > 0); @@ -226,7 +226,8 @@ static u8 rtl8712_dl_fw(struct _adapter *padapter) 0x); memcpy(ppayload, ptr, dump_emem_sz); r8712_write_mem(padapter, RTL8712_DMA_VOQ, - dump_emem_sz + TXDESC_SIZE, (u8 *)ptx_desc); + dump_emem_sz + TXDESC_SIZE, + (u8 *)ptx_desc); ptr += dump_emem_sz; emem_sz -= dump_emem_sz; } while (emem_sz > 0); @@ -278,7 +279,7 @@ static u8 rtl8712_dl_fw(struct _adapter *padapter) ptx_desc->txdw0 |= cpu_to_le32(BIT(28)); memcpy(ppayload, , fwhdr.fw_priv_sz); r8712_write_mem(padapter, RTL8712_DMA_VOQ, - fwhdr.fw_priv_sz + TXDESC_SIZE, (u8 *)ptx_desc); + fwhdr.fw_priv_sz + TXDESC_SIZE, (u8 *)ptx_desc); /* polling dmem code done */ i = 100; -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2] rtl8712: Fixed alignment to match open parenthesis
Added missing signed off by line and fixed alignment to match open parenthesis. Signed-off-by: Parth Sane <laerdevstud...@gmail.com> --- drivers/staging/rtl8712/hal_init.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8712/hal_init.c b/drivers/staging/rtl8712/hal_init.c index 0c76fbc..0dd458d 100644 --- a/drivers/staging/rtl8712/hal_init.c +++ b/drivers/staging/rtl8712/hal_init.c @@ -197,8 +197,8 @@ static u8 rtl8712_dl_fw(struct _adapter *padapter) 0x); memcpy(ppayload, ptr, dump_imem_sz); r8712_write_mem(padapter, RTL8712_DMA_VOQ, - dump_imem_sz + TXDESC_SIZE, - (u8 *)ptx_desc); + dump_imem_sz + TXDESC_SIZE, + (u8 *)ptx_desc); ptr += dump_imem_sz; imem_sz -= dump_imem_sz; } while (imem_sz > 0); @@ -226,7 +226,8 @@ static u8 rtl8712_dl_fw(struct _adapter *padapter) 0x); memcpy(ppayload, ptr, dump_emem_sz); r8712_write_mem(padapter, RTL8712_DMA_VOQ, - dump_emem_sz + TXDESC_SIZE, (u8 *)ptx_desc); + dump_emem_sz + TXDESC_SIZE, + (u8 *)ptx_desc); ptr += dump_emem_sz; emem_sz -= dump_emem_sz; } while (emem_sz > 0); @@ -278,7 +279,7 @@ static u8 rtl8712_dl_fw(struct _adapter *padapter) ptx_desc->txdw0 |= cpu_to_le32(BIT(28)); memcpy(ppayload, , fwhdr.fw_priv_sz); r8712_write_mem(padapter, RTL8712_DMA_VOQ, - fwhdr.fw_priv_sz + TXDESC_SIZE, (u8 *)ptx_desc); + fwhdr.fw_priv_sz + TXDESC_SIZE, (u8 *)ptx_desc); /* polling dmem code done */ i = 100; -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] rtl8712: Fixed alignment to match open parenthesis
Fixed parenthesis alignment checkpatch checks as per kernel coding style guidelines in hal_init.c --- drivers/staging/rtl8712/hal_init.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8712/hal_init.c b/drivers/staging/rtl8712/hal_init.c index 0c76fbc..0dd458d 100644 --- a/drivers/staging/rtl8712/hal_init.c +++ b/drivers/staging/rtl8712/hal_init.c @@ -197,8 +197,8 @@ static u8 rtl8712_dl_fw(struct _adapter *padapter) 0x); memcpy(ppayload, ptr, dump_imem_sz); r8712_write_mem(padapter, RTL8712_DMA_VOQ, - dump_imem_sz + TXDESC_SIZE, - (u8 *)ptx_desc); + dump_imem_sz + TXDESC_SIZE, + (u8 *)ptx_desc); ptr += dump_imem_sz; imem_sz -= dump_imem_sz; } while (imem_sz > 0); @@ -226,7 +226,8 @@ static u8 rtl8712_dl_fw(struct _adapter *padapter) 0x); memcpy(ppayload, ptr, dump_emem_sz); r8712_write_mem(padapter, RTL8712_DMA_VOQ, - dump_emem_sz + TXDESC_SIZE, (u8 *)ptx_desc); + dump_emem_sz + TXDESC_SIZE, + (u8 *)ptx_desc); ptr += dump_emem_sz; emem_sz -= dump_emem_sz; } while (emem_sz > 0); @@ -278,7 +279,7 @@ static u8 rtl8712_dl_fw(struct _adapter *padapter) ptx_desc->txdw0 |= cpu_to_le32(BIT(28)); memcpy(ppayload, , fwhdr.fw_priv_sz); r8712_write_mem(padapter, RTL8712_DMA_VOQ, - fwhdr.fw_priv_sz + TXDESC_SIZE, (u8 *)ptx_desc); + fwhdr.fw_priv_sz + TXDESC_SIZE, (u8 *)ptx_desc); /* polling dmem code done */ i = 100; -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: vt6656: Fixed multiple logical comparisions warnings in main_usb.c
Using comparison to false and true is error prone. Fixed multiple warnings as
per checkpatch guidelines.
Signed-off-by: Parth Sane <laerdevstud...@gmail.com>
---
drivers/staging/vt6656/main_usb.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/vt6656/main_usb.c
b/drivers/staging/vt6656/main_usb.c
index f9afab7..5e77496 100644
--- a/drivers/staging/vt6656/main_usb.c
+++ b/drivers/staging/vt6656/main_usb.c
@@ -238,7 +238,7 @@ static int vnt_init_registers(struct vnt_private *priv)
priv->tx_antenna_mode = ANT_B;
priv->rx_antenna_sel = 1;
- if (priv->tx_rx_ant_inv == true)
+ if (priv->tx_rx_ant_inv)
priv->rx_antenna_mode = ANT_A;
else
priv->rx_antenna_mode = ANT_B;
@@ -248,14 +248,14 @@ static int vnt_init_registers(struct vnt_private *priv)
if (antenna & EEP_ANTENNA_AUX) {
priv->tx_antenna_mode = ANT_A;
- if (priv->tx_rx_ant_inv == true)
+ if (priv->tx_rx_ant_inv)
priv->rx_antenna_mode = ANT_B;
else
priv->rx_antenna_mode = ANT_A;
} else {
priv->tx_antenna_mode = ANT_B;
- if (priv->tx_rx_ant_inv == true)
+ if (priv->tx_rx_ant_inv)
priv->rx_antenna_mode = ANT_A;
else
priv->rx_antenna_mode = ANT_B;
--
1.9.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging:vt6656:Fixed multiple logical comparisions warnings
Using comparison to false and true is error prone. Fixed multiple warnings as
per checkpatch guidelines.
Signed-off-by: Parth Sane <laerdevstud...@gmail.com>
---
drivers/staging/vt6656/wcmd.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/vt6656/wcmd.c b/drivers/staging/vt6656/wcmd.c
index 4846a89..95faaeb 100644
--- a/drivers/staging/vt6656/wcmd.c
+++ b/drivers/staging/vt6656/wcmd.c
@@ -97,7 +97,7 @@ void vnt_run_command(struct work_struct *work)
if (test_bit(DEVICE_FLAGS_DISCONNECTED, >flags))
return;
- if (priv->cmd_running != true)
+ if (!priv->cmd_running)
return;
switch (priv->command_state) {
@@ -143,13 +143,13 @@ void vnt_run_command(struct work_struct *work)
if (priv->rx_antenna_sel == 0) {
priv->rx_antenna_sel = 1;
- if (priv->tx_rx_ant_inv == true)
+ if (priv->tx_rx_ant_inv)
vnt_set_antenna_mode(priv, ANT_RXA);
else
vnt_set_antenna_mode(priv, ANT_RXB);
} else {
priv->rx_antenna_sel = 0;
- if (priv->tx_rx_ant_inv == true)
+ if (priv->tx_rx_ant_inv)
vnt_set_antenna_mode(priv, ANT_RXB);
else
vnt_set_antenna_mode(priv, ANT_RXA);
@@ -174,7 +174,7 @@ int vnt_schedule_command(struct vnt_private *priv, enum
vnt_cmd command)
ADD_ONE_WITH_WRAP_AROUND(priv->cmd_enqueue_idx, CMD_Q_SIZE);
priv->free_cmd_queue--;
- if (priv->cmd_running == false)
+ if (!priv->cmd_running)
vnt_cmd_complete(priv);
return true;
--
1.9.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v3 1/5] staging: rtl8712: Fixed FSF address warning in basic_types.h
Fixed checkpatch warning after removing FSF address paragraph as per guidelines. Signed-off-by: Parth Sane <laerdevstud...@gmail.com> --- Changes in v3: - Fixed subject - Fixed commit message drivers/staging/rtl8712/basic_types.h | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8712/basic_types.h b/drivers/staging/rtl8712/basic_types.h index 7561bed..f5c0231 100644 --- a/drivers/staging/rtl8712/basic_types.h +++ b/drivers/staging/rtl8712/basic_types.h @@ -11,10 +11,6 @@ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for * more details. * - * You should have received a copy of the GNU General Public License along with - * this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA - * * Modifications for inclusion into the Linux staging tree are * Copyright(c) 2010 Larry Finger. All rights reserved. * -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v3 5/5] staging: rtl8712: Fixed FSF address warning in ieee80211.c
Fixed checkpatch warning after removing FSF address block as per guidelines. Signed-off-by: Parth Sane <laerdevstud...@gmail.com> --- Changes in v3: - Fixed subject - Fixed commit message drivers/staging/rtl8712/ieee80211.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8712/ieee80211.c b/drivers/staging/rtl8712/ieee80211.c index d13b4d5..8918654 100644 --- a/drivers/staging/rtl8712/ieee80211.c +++ b/drivers/staging/rtl8712/ieee80211.c @@ -13,10 +13,6 @@ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for * more details. * - * You should have received a copy of the GNU General Public License along with - * this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA - * * Modifications for inclusion into the Linux staging tree are * Copyright(c) 2010 Larry Finger. All rights reserved. * -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v3 0/5] staging: rtl8712: Fixed multiple checkpatch FSF address warnings
Fixed Multiple FSF address checkpatch warnings to conform to kernel coding style. Parth Sane (5): staging: rtl8712: Fixed FSF address warning in basic_types.h staging: rtl8712: Fixed FSF address warning in drv_types.h staging: rtl8712: Fixed FSF address warning in ethernet.h staging: rtl8712: Fixed FSF address warning in hal_init.c staging: rtl8712: Fixed FSF address warning in ieee80211.c drivers/staging/rtl8712/basic_types.h | 4 drivers/staging/rtl8712/drv_types.h | 4 drivers/staging/rtl8712/ethernet.h| 4 drivers/staging/rtl8712/hal_init.c| 4 drivers/staging/rtl8712/ieee80211.c | 4 5 files changed, 20 deletions(-) -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v3 4/5] staging: rtl8712: Fixed FSF address warning in hal_init.c
Fixed checkpatch warning after removing FSF address block as per guidelines. Signed-off-by: Parth Sane <laerdevstud...@gmail.com> --- Changes in v3: - Fixed subject - Fixed commit message drivers/staging/rtl8712/hal_init.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8712/hal_init.c b/drivers/staging/rtl8712/hal_init.c index 17d2b5f..afa7fe78 100644 --- a/drivers/staging/rtl8712/hal_init.c +++ b/drivers/staging/rtl8712/hal_init.c @@ -13,10 +13,6 @@ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for * more details. * - * You should have received a copy of the GNU General Public License along with - * this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA - * * Modifications for inclusion into the Linux staging tree are * Copyright(c) 2010 Larry Finger. All rights reserved. * -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v3 2/5] staging: rtl8712: Fixed FSF address warning in drv_types.h
Fixed checkpatch warning after removing FSF address block as per guidelines. Signed-off-by: Parth Sane <laerdevstud...@gmail.com> --- Changes in v3: - Fixed subject - Fixed commit message drivers/staging/rtl8712/drv_types.h | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8712/drv_types.h b/drivers/staging/rtl8712/drv_types.h index 29e47e1..ae79047 100644 --- a/drivers/staging/rtl8712/drv_types.h +++ b/drivers/staging/rtl8712/drv_types.h @@ -11,10 +11,6 @@ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for * more details. * - * You should have received a copy of the GNU General Public License along with - * this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA - * * Modifications for inclusion into the Linux staging tree are * Copyright(c) 2010 Larry Finger. All rights reserved. * -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v3 3/5] staging: rtl8712: Fixed FSF address warning in ethernet.h
Fixed checkpatch warning after removing FSF address block as per guidelines. Signed-off-by: Parth Sane <laerdevstud...@gmail.com> --- Changes in v3: - Fixed subject - Fixed commit message drivers/staging/rtl8712/ethernet.h | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8712/ethernet.h b/drivers/staging/rtl8712/ethernet.h index fad173f..039da36 100644 --- a/drivers/staging/rtl8712/ethernet.h +++ b/drivers/staging/rtl8712/ethernet.h @@ -11,10 +11,6 @@ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for * more details. * - * You should have received a copy of the GNU General Public License along with - * this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA - * * Modifications for inclusion into the Linux staging tree are * Copyright(c) 2010 Larry Finger. All rights reserved. * -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2 5/5] staging: rtl9712: Fixed FSF address warning in ieee80211.c
Fixed checkpatch warning caused to FSF address block as per guidelines. Signed-off-by: Parth Sane <laerdevstud...@gmail.com> --- Changes in v2: - Added commit message drivers/staging/rtl8712/ieee80211.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8712/ieee80211.c b/drivers/staging/rtl8712/ieee80211.c index d13b4d5..8918654 100644 --- a/drivers/staging/rtl8712/ieee80211.c +++ b/drivers/staging/rtl8712/ieee80211.c @@ -13,10 +13,6 @@ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for * more details. * - * You should have received a copy of the GNU General Public License along with - * this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA - * * Modifications for inclusion into the Linux staging tree are * Copyright(c) 2010 Larry Finger. All rights reserved. * -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2 4/5] staging: rtl9712: Fixed FSF address warning in hal_init.c
Fixed checkpatch warning caused due to FSF address block as per guidelines. Signed-off-by: Parth Sane <laerdevstud...@gmail.com> --- Changes in v2: - Added commit message. drivers/staging/rtl8712/hal_init.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8712/hal_init.c b/drivers/staging/rtl8712/hal_init.c index 17d2b5f..afa7fe78 100644 --- a/drivers/staging/rtl8712/hal_init.c +++ b/drivers/staging/rtl8712/hal_init.c @@ -13,10 +13,6 @@ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for * more details. * - * You should have received a copy of the GNU General Public License along with - * this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA - * * Modifications for inclusion into the Linux staging tree are * Copyright(c) 2010 Larry Finger. All rights reserved. * -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2 1/5] staging: rtl8712: Fixed FSF address warning in basic_types.h
Fixed checkpatch check caused by FSF address paragraph as per guidelines. Signed-off-by: Parth Sane <laerdevstud...@gmail.com> --- Changes in v2: - Added commit message drivers/staging/rtl8712/basic_types.h | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8712/basic_types.h b/drivers/staging/rtl8712/basic_types.h index 7561bed..f5c0231 100644 --- a/drivers/staging/rtl8712/basic_types.h +++ b/drivers/staging/rtl8712/basic_types.h @@ -11,10 +11,6 @@ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for * more details. * - * You should have received a copy of the GNU General Public License along with - * this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA - * * Modifications for inclusion into the Linux staging tree are * Copyright(c) 2010 Larry Finger. All rights reserved. * -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2 3/5] staging: rtl9712: Fixed FSF address warning in ethernet.h
Fixed checkpatch check caused by FSF address paragraph as per guidelines. Signed-off-by: Parth Sane <laerdevstud...@gmail.com> --- Changes in v2: - Added commit message drivers/staging/rtl8712/ethernet.h | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8712/ethernet.h b/drivers/staging/rtl8712/ethernet.h index fad173f..039da36 100644 --- a/drivers/staging/rtl8712/ethernet.h +++ b/drivers/staging/rtl8712/ethernet.h @@ -11,10 +11,6 @@ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for * more details. * - * You should have received a copy of the GNU General Public License along with - * this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA - * * Modifications for inclusion into the Linux staging tree are * Copyright(c) 2010 Larry Finger. All rights reserved. * -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2 0/5] staging: rtl8712: Fixed checkpatch warning due to FSF address block
Fixed checkpatch warning caused due to FSF address block. Linux already has a copy of the GPL, so as per checkpatch this address block is unnecessary. Parth Sane (5): staging: rtl8712: Fixed FSF address warning in basic_types.h staging: rtl8712: Fixed FSF address warning in drv_types.h staging: rtl9712: Fixed FSF address warning in ethernet.h staging: rtl9712: Fixed FSF address warning in hal_init.c staging: rtl9712: Fixed FSF address warning in ieee80211.c drivers/staging/rtl8712/basic_types.h | 4 drivers/staging/rtl8712/drv_types.h | 4 drivers/staging/rtl8712/ethernet.h| 4 drivers/staging/rtl8712/hal_init.c| 4 drivers/staging/rtl8712/ieee80211.c | 4 5 files changed, 20 deletions(-) -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2 2/5] staging: rtl8712: Fixed FSF address warning in drv_types.h
Fixed checkpatch check caused by FSF address paragraph as per guidelines. Signed-off-by: Parth Sane <laerdevstud...@gmail.com> --- Changes in v2: - Added commit message drivers/staging/rtl8712/drv_types.h | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8712/drv_types.h b/drivers/staging/rtl8712/drv_types.h index 29e47e1..ae79047 100644 --- a/drivers/staging/rtl8712/drv_types.h +++ b/drivers/staging/rtl8712/drv_types.h @@ -11,10 +11,6 @@ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for * more details. * - * You should have received a copy of the GNU General Public License along with - * this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA - * * Modifications for inclusion into the Linux staging tree are * Copyright(c) 2010 Larry Finger. All rights reserved. * -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 0/5] staging: rtl8712: Fixed Multiple FSF address checkpatch warnings
> Fixed Multiple FSF address checkpatch warnings to conform to kernel coding > style. > > Parth Sane (5): > staging: rtl8712: Fixed FSF address warning in basic_types.h > staging: rtl8712: Fixed FSF address warning in drv_types.h > staging: rtl9712: Fixed FSF address warning in ethernet.h > staging: rtl9712: Fixed FSF address warning in hal_init.c > staging: rtl9712: Fixed FSF address warning in ieee80211.c > > drivers/staging/rtl8712/basic_types.h | 4 > drivers/staging/rtl8712/drv_types.h | 4 > drivers/staging/rtl8712/ethernet.h| 4 > drivers/staging/rtl8712/hal_init.c| 4 > drivers/staging/rtl8712/ieee80211.c | 4 > 5 files changed, 20 deletions(-) > > -- > 1.9.1 Hi, The thing is all these patches are related and have a cover letter explaining changes. But this seems to be a trivial change which is self explanatory. This should possibly suffice. What do you think? Regards, Parth Sane signature.asc Description: Message signed with OpenPGP using GPGMail ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: rtl8712: Fixed Multiple Parenthesis Alignment
> On 20-Mar-2016, at 10:03 PM, Roger H Newell <newell.ro...@gmail.com> wrote: > > > On Mar 20, 2016 1:21 PM, "Parth Sane" <laerdevstud...@gmail.com> wrote: > > > > > > > On 20-Mar-2016, at 9:18 PM, Joe Perches <j...@perches.com> wrote: > > > > > > On Sun, 2016-03-20 at 14:33 +, Parth Sane wrote: > > >> Fixed multiple parenthesis alignment warnings. > > >> Signed-off-by: Parth Sane <laerdevstud...@gmail.com> > > > > > > Please always add a blank line after your changelog and > > > before your "Signed-off-by:" line > > > > > >> diff --git a/drivers/staging/rtl8712/hal_init.c > > >> b/drivers/staging/rtl8712/hal_init.c > > > [] > > >> @@ -197,7 +197,7 @@ static u8 rtl8712_dl_fw(struct _adapter *padapter) > > >> 0x); > > >> memcpy(ppayload, ptr, dump_imem_sz); > > >> r8712_write_mem(padapter, RTL8712_DMA_VOQ, > > >> - dump_imem_sz + TXDESC_SIZE, > > >> +dump_imem_sz + TXDESC_SIZE, > > >>(u8 *)ptx_desc); > > > > > > Please align all lines of multi-line statements. > > > > > > checkpatch is a stupid little script. > > > You have to make sure your own patches are sensible. > > > > > > There are several things you should read and > > > understand in the Documentation directory. > > > > > > Documentation/CodingStyle > > > Documentation/SubmittingPatches > > > Documentation/SubmitChecklist > > > > > > Fixing checkpatch messages is sometimes a decent > > > way to understand this process, but the patches > > > that can be generated fixing these messages tend > > > to have low overall value. > > > > > > After doing a few of these, please move on to > > > some part of the kernel that interests you and > > > submit new code or start to fix actual defects. > > > > > > Maybe if you are interested in wireless drivers, > > > buy a NIC that isn't supported by the mac80211 > > > drivers and adapt the existing staging driver for > > > that variant. > > > > > > Code, test, validate, submit, repeat... > > > > > Hi, > > I’m first trying my hands at easy stuff before I actually move on to more > > difficult stuff. I will surely look in that direction. Thanks for your > > valuable inputs. > > Regards, > > Parth Sane > > > > ___ > > devel mailing list > > de...@linuxdriverproject.org > > http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel > > > > www.kernelnewbies.org is an excellent resource for getting started. Check out > the first patch tutorial, it walks you through all the basics of creating and > sending a properly formated patch. You're better off learning to do it right > the first time, if its not right the patch simply won't be accepted and > you'll have to redo it anyway. Take some time to go through the tutorial I > mentioned. Good luck > > Roger H. Newell > Hi Roger, Thanks for your comments. I’ve correctly submitted a patchset for the multiple FSF notices, maybe you can comment if its any good?. I’m through the rough patch and now understand the process now quite fairly. I did checkout kernelnewbies.org before I submitted the patch, but alas I needed some practical XP. Regards, Parth Sane signature.asc Description: Message signed with OpenPGP using GPGMail ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 5/5] staging: rtl9712: Fixed FSF address warning in ieee80211.c
Signed-off-by: Parth Sane <laerdevstud...@gmail.com> --- drivers/staging/rtl8712/ieee80211.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8712/ieee80211.c b/drivers/staging/rtl8712/ieee80211.c index d13b4d5..8918654 100644 --- a/drivers/staging/rtl8712/ieee80211.c +++ b/drivers/staging/rtl8712/ieee80211.c @@ -13,10 +13,6 @@ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for * more details. * - * You should have received a copy of the GNU General Public License along with - * this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA - * * Modifications for inclusion into the Linux staging tree are * Copyright(c) 2010 Larry Finger. All rights reserved. * -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 4/5] staging: rtl9712: Fixed FSF address warning in hal_init.c
Signed-off-by: Parth Sane <laerdevstud...@gmail.com> --- drivers/staging/rtl8712/hal_init.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8712/hal_init.c b/drivers/staging/rtl8712/hal_init.c index 17d2b5f..afa7fe78 100644 --- a/drivers/staging/rtl8712/hal_init.c +++ b/drivers/staging/rtl8712/hal_init.c @@ -13,10 +13,6 @@ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for * more details. * - * You should have received a copy of the GNU General Public License along with - * this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA - * * Modifications for inclusion into the Linux staging tree are * Copyright(c) 2010 Larry Finger. All rights reserved. * -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 3/5] staging: rtl9712: Fixed FSF address warning in ethernet.h
Signed-off-by: Parth Sane <laerdevstud...@gmail.com> --- drivers/staging/rtl8712/ethernet.h | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8712/ethernet.h b/drivers/staging/rtl8712/ethernet.h index fad173f..039da36 100644 --- a/drivers/staging/rtl8712/ethernet.h +++ b/drivers/staging/rtl8712/ethernet.h @@ -11,10 +11,6 @@ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for * more details. * - * You should have received a copy of the GNU General Public License along with - * this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA - * * Modifications for inclusion into the Linux staging tree are * Copyright(c) 2010 Larry Finger. All rights reserved. * -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 2/5] staging: rtl8712: Fixed FSF address warning in drv_types.h
Signed-off-by: Parth Sane <laerdevstud...@gmail.com> --- drivers/staging/rtl8712/drv_types.h | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8712/drv_types.h b/drivers/staging/rtl8712/drv_types.h index 29e47e1..ae79047 100644 --- a/drivers/staging/rtl8712/drv_types.h +++ b/drivers/staging/rtl8712/drv_types.h @@ -11,10 +11,6 @@ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for * more details. * - * You should have received a copy of the GNU General Public License along with - * this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA - * * Modifications for inclusion into the Linux staging tree are * Copyright(c) 2010 Larry Finger. All rights reserved. * -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 0/5] staging: rtl8712: Fixed Multiple FSF address checkpatch warnings
*** BLURB HERE *** Parth Sane (5): staging: rtl8712: Fixed FSF address warning in basic_types.h staging: rtl8712: Fixed FSF address warning in drv_types.h staging: rtl9712: Fixed FSF address warning in ethernet.h staging: rtl9712: Fixed FSF address warning in hal_init.c staging: rtl9712: Fixed FSF address warning in ieee80211.c drivers/staging/rtl8712/basic_types.h | 4 drivers/staging/rtl8712/drv_types.h | 4 drivers/staging/rtl8712/ethernet.h| 4 drivers/staging/rtl8712/hal_init.c| 4 drivers/staging/rtl8712/ieee80211.c | 4 5 files changed, 20 deletions(-) -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 1/5] staging: rtl8712: Fixed FSF address warning in basic_types.h
Signed-off-by: Parth Sane <laerdevstud...@gmail.com> --- drivers/staging/rtl8712/basic_types.h | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8712/basic_types.h b/drivers/staging/rtl8712/basic_types.h index 7561bed..f5c0231 100644 --- a/drivers/staging/rtl8712/basic_types.h +++ b/drivers/staging/rtl8712/basic_types.h @@ -11,10 +11,6 @@ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for * more details. * - * You should have received a copy of the GNU General Public License along with - * this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA - * * Modifications for inclusion into the Linux staging tree are * Copyright(c) 2010 Larry Finger. All rights reserved. * -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: rtl8712: Fixed Multiple Parenthesis Alignment
> On 20-Mar-2016, at 9:18 PM, Joe Perches <j...@perches.com> wrote: > > On Sun, 2016-03-20 at 14:33 +0000, Parth Sane wrote: >> Fixed multiple parenthesis alignment warnings. >> Signed-off-by: Parth Sane <laerdevstud...@gmail.com> > > Please always add a blank line after your changelog and > before your "Signed-off-by:" line > >> diff --git a/drivers/staging/rtl8712/hal_init.c >> b/drivers/staging/rtl8712/hal_init.c > [] >> @@ -197,7 +197,7 @@ static u8 rtl8712_dl_fw(struct _adapter *padapter) >> 0x); >> memcpy(ppayload, ptr, dump_imem_sz); >> r8712_write_mem(padapter, RTL8712_DMA_VOQ, >> - dump_imem_sz + TXDESC_SIZE, >> +dump_imem_sz + TXDESC_SIZE, >>(u8 *)ptx_desc); > > Please align all lines of multi-line statements. > > checkpatch is a stupid little script. > You have to make sure your own patches are sensible. > > There are several things you should read and > understand in the Documentation directory. > > Documentation/CodingStyle > Documentation/SubmittingPatches > Documentation/SubmitChecklist > > Fixing checkpatch messages is sometimes a decent > way to understand this process, but the patches > that can be generated fixing these messages tend > to have low overall value. > > After doing a few of these, please move on to > some part of the kernel that interests you and > submit new code or start to fix actual defects. > > Maybe if you are interested in wireless drivers, > buy a NIC that isn't supported by the mac80211 > drivers and adapt the existing staging driver for > that variant. > > Code, test, validate, submit, repeat... > Hi, I’m first trying my hands at easy stuff before I actually move on to more difficult stuff. I will surely look in that direction. Thanks for your valuable inputs. Regards, Parth Sane signature.asc Description: Message signed with OpenPGP using GPGMail ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: rtl8712: Removed FSF address warning
> On 20-Mar-2016, at 7:56 PM, Larry Finger <larry.fin...@lwfinger.net> wrote: > > On 03/20/2016 08:59 AM, Parth Sane wrote: >> Removed checkpatch warning caused by FSF address block >> Signed-off-by: Parth Sane <laerdevstud...@gmail.com> >> --- >> drivers/staging/rtl8712/hal_init.c | 4 >> 1 file changed, 4 deletions(-) > > Now you have at least 3 different patches all with the same subject! How is > the maintainer supposed to keep them separate? Patchworks will replace each > of them with the next one having the same title. > > A better way would be to create a multiple-part set of patches with the > subject containing the name of the file being "fixed". > > Note that this warning was added to checkpatch.pl well after the driver was > added to the staging tree. In fact, if this warning had been present then, > the FSF address would have been removed. > > I consider this type of patch to be of minimal value; however, if you do not > remove this warning, then someone else will. Thus, you should repackage these > changes. By my count, there are 94 files containing this information. > Dropping them as one set of patches might be too many at once. I would split > them into groups of 13 files in one batch, 14 in the next, then 15, 16, 17, > and finally 19, then each group will also be distinguishable. > > If GregKH wants it done differently, he will let us know. > > Larry > Hi, It has been pointed out to me that I should send patch sets. I will be doing so. So please ignore the earlier sent patches except the parenthesis patch. Its been a pleasure to work with such a helpful community and hope to do do more in the future. Regards, Parth Sane signature.asc Description: Message signed with OpenPGP using GPGMail ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: rtl8712: Fixed Multiple Parenthesis Alignment
Fixed multiple parenthesis alignment warnings. Signed-off-by: Parth Sane <laerdevstud...@gmail.com> --- drivers/staging/rtl8712/hal_init.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8712/hal_init.c b/drivers/staging/rtl8712/hal_init.c index 225ef37..afa7fe78 100644 --- a/drivers/staging/rtl8712/hal_init.c +++ b/drivers/staging/rtl8712/hal_init.c @@ -197,7 +197,7 @@ static u8 rtl8712_dl_fw(struct _adapter *padapter) 0x); memcpy(ppayload, ptr, dump_imem_sz); r8712_write_mem(padapter, RTL8712_DMA_VOQ, - dump_imem_sz + TXDESC_SIZE, + dump_imem_sz + TXDESC_SIZE, (u8 *)ptx_desc); ptr += dump_imem_sz; imem_sz -= dump_imem_sz; @@ -226,7 +226,8 @@ static u8 rtl8712_dl_fw(struct _adapter *padapter) 0x); memcpy(ppayload, ptr, dump_emem_sz); r8712_write_mem(padapter, RTL8712_DMA_VOQ, - dump_emem_sz + TXDESC_SIZE, (u8 *)ptx_desc); + dump_emem_sz + TXDESC_SIZE, + (u8 *)ptx_desc); ptr += dump_emem_sz; emem_sz -= dump_emem_sz; } while (emem_sz > 0); @@ -278,7 +279,7 @@ static u8 rtl8712_dl_fw(struct _adapter *padapter) ptx_desc->txdw0 |= cpu_to_le32(BIT(28)); memcpy(ppayload, , fwhdr.fw_priv_sz); r8712_write_mem(padapter, RTL8712_DMA_VOQ, - fwhdr.fw_priv_sz + TXDESC_SIZE, (u8 *)ptx_desc); + fwhdr.fw_priv_sz + TXDESC_SIZE, (u8 *)ptx_desc); /* polling dmem code done */ i = 100; -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: rtl8712: Removed FSF address warning
Removed checkpatch warning caused due to FSF address paragraph Signed-off-by: Parth Sane <laerdevstud...@gmail.com> --- drivers/staging/rtl8712/mlme_linux.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8712/mlme_linux.c b/drivers/staging/rtl8712/mlme_linux.c index e4e4bde..f124d72 100644 --- a/drivers/staging/rtl8712/mlme_linux.c +++ b/drivers/staging/rtl8712/mlme_linux.c @@ -13,10 +13,6 @@ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for * more details. * - * You should have received a copy of the GNU General Public License along with - * this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA - * * Modifications for inclusion into the Linux staging tree are * Copyright(c) 2010 Larry Finger. All rights reserved. * -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: rtl8712: Removed FSF address warning
Removed checkpatch warning caused due to FSF address paragraph Signed-off-by: Parth Sane <laerdevstud...@gmail.com> --- drivers/staging/rtl8712/ieee80211.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8712/ieee80211.c b/drivers/staging/rtl8712/ieee80211.c index d13b4d5..8918654 100644 --- a/drivers/staging/rtl8712/ieee80211.c +++ b/drivers/staging/rtl8712/ieee80211.c @@ -13,10 +13,6 @@ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for * more details. * - * You should have received a copy of the GNU General Public License along with - * this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA - * * Modifications for inclusion into the Linux staging tree are * Copyright(c) 2010 Larry Finger. All rights reserved. * -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: rtl8712: Removed FSF address warning
Removed checkpatch warning caused by FSF address block Signed-off-by: Parth Sane <laerdevstud...@gmail.com> --- drivers/staging/rtl8712/hal_init.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8712/hal_init.c b/drivers/staging/rtl8712/hal_init.c index 8008efe..225ef37 100644 --- a/drivers/staging/rtl8712/hal_init.c +++ b/drivers/staging/rtl8712/hal_init.c @@ -13,10 +13,6 @@ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for * more details. * - * You should have received a copy of the GNU General Public License along with - * this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA - * * Modifications for inclusion into the Linux staging tree are * Copyright(c) 2010 Larry Finger. All rights reserved. * -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: rtl8712: Removed FSF address warning
Removed checkpatch warning caused by FSF address paragraph. Signed-off-by: Parth Sane <laerdevstud...@gmail.com> --- drivers/staging/rtl8712/ethernet.h | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8712/ethernet.h b/drivers/staging/rtl8712/ethernet.h index fad173f..039da36 100644 --- a/drivers/staging/rtl8712/ethernet.h +++ b/drivers/staging/rtl8712/ethernet.h @@ -11,10 +11,6 @@ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for * more details. * - * You should have received a copy of the GNU General Public License along with - * this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA - * * Modifications for inclusion into the Linux staging tree are * Copyright(c) 2010 Larry Finger. All rights reserved. * -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2] staging: rtl8712: Removed warning about FSFs mailing address
Removed FSF address notice which causes checkpatch warning. Signed-off-by: Parth Sane <laerdevstud...@gmail.com> --- drivers/staging/rtl8712/drv_types.h | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8712/drv_types.h b/drivers/staging/rtl8712/drv_types.h index 29e47e1..ae79047 100644 --- a/drivers/staging/rtl8712/drv_types.h +++ b/drivers/staging/rtl8712/drv_types.h @@ -11,10 +11,6 @@ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for * more details. * - * You should have received a copy of the GNU General Public License along with - * this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA - * * Modifications for inclusion into the Linux staging tree are * Copyright(c) 2010 Larry Finger. All rights reserved. * -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v3] staging: netlogic: Fixed alignment of parentheseis checkpatch warning
Hi, Thanks for pointing out that the changes have been done. Nevertheless this was a good learning exercise. How do I check which changes have already been done? I’m planning to send in another patch on a blank line warning on the same file. I don’t want to overburden the mailing list by repeating work. I apologise for any inconvenience. Regards, Parth Sane signature.asc Description: Message signed with OpenPGP using GPGMail ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: netlogic: Fixed alignment of parentheseis checkpatch warning line#186
Fixed checkpatch warnings about parenthesis alignment at line #186. Signed-off-by: Parth Sane <laerdevstud...@gmail.com> --- drivers/staging/netlogic/platform_net.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/netlogic/platform_net.c b/drivers/staging/netlogic/platform_net.c index c967543..a2941a0 100644 --- a/drivers/staging/netlogic/platform_net.c +++ b/drivers/staging/netlogic/platform_net.c @@ -183,8 +183,8 @@ static void xls_gmac_init(void) ndata0.phy_addr[mac] = mac + 0x10; xlr_resource_init(_net0_res[mac * 2], - xlr_gmac_offsets[mac], - xlr_gmac_irqs[mac]); + xlr_gmac_offsets[mac], + xlr_gmac_irqs[mac]); } xlr_net_dev0.num_resources = 8; platform_device_register(_net_dev0); -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: netlogic: Fixed alignment of parantheseis checkpatch warning
Fixed alignment of paranthesis as per checkpatch. Please ignore earlier sent
patch for paranthesis check and use this one.
Signed-off-by: Parth Sane <laerdevstud...@gmail.com>
---
drivers/staging/netlogic/platform_net.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/netlogic/platform_net.c
b/drivers/staging/netlogic/platform_net.c
index daee1b2..dde20d5 100644
--- a/drivers/staging/netlogic/platform_net.c
+++ b/drivers/staging/netlogic/platform_net.c
@@ -120,10 +120,9 @@ static struct platform_device *gmac_controller2_init(void
*gmac0_addr)
for (mac = 0; mac < 4; mac++) {
ndata1.tx_stnid[mac] = FMN_STNID_GMAC1_TX0 + mac;
ndata1.phy_addr[mac] = mac + 4 + 0x10;
-
xlr_resource_init(_net1_res[mac * 2],
- xlr_gmac_offsets[mac + 4],
- xlr_gmac_irqs[mac + 4]);
+ xlr_gmac_offsets[mac + 4],
+ xlr_gmac_irqs[mac + 4]);
}
xlr_net_dev1.num_resources = 8;
--
1.9.1
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: netlogic: Fixed alignment of parantheseis checkpatch warning
Fixed alignment of paranthesis as per checkpatch. Signed-off-by: Parth Sane <laerdevstud...@gmail.com> --- drivers/staging/netlogic/platform_net.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/netlogic/platform_net.c b/drivers/staging/netlogic/platform_net.c index daee1b2..82af021 100644 --- a/drivers/staging/netlogic/platform_net.c +++ b/drivers/staging/netlogic/platform_net.c @@ -121,9 +121,7 @@ static struct platform_device *gmac_controller2_init(void *gmac0_addr) ndata1.tx_stnid[mac] = FMN_STNID_GMAC1_TX0 + mac; ndata1.phy_addr[mac] = mac + 4 + 0x10; - xlr_resource_init(_net1_res[mac * 2], - xlr_gmac_offsets[mac + 4], - xlr_gmac_irqs[mac + 4]); + xlr_resource_init(_net1_res[mac * 2], xlr_gmac_offsets[mac + 4], xlr_gmac_irqs[mac + 4]); } xlr_net_dev1.num_resources = 8; -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: netlogic: Fixed alignment of parantheseis checkpatch warning
From: Ubuntu <ubu...@ip-172-31-28-98.ap-southeast-1.compute.internal> Fixed alignment of paranthesis as per checkpatch. Signed-off-by: Parth Sane <laerdevstud...@gmail.com> --- drivers/staging/netlogic/platform_net.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/netlogic/platform_net.c b/drivers/staging/netlogic/platform_net.c index daee1b2..82af021 100644 --- a/drivers/staging/netlogic/platform_net.c +++ b/drivers/staging/netlogic/platform_net.c @@ -121,9 +121,7 @@ static struct platform_device *gmac_controller2_init(void *gmac0_addr) ndata1.tx_stnid[mac] = FMN_STNID_GMAC1_TX0 + mac; ndata1.phy_addr[mac] = mac + 4 + 0x10; - xlr_resource_init(_net1_res[mac * 2], - xlr_gmac_offsets[mac + 4], - xlr_gmac_irqs[mac + 4]); + xlr_resource_init(_net1_res[mac * 2], xlr_gmac_offsets[mac + 4], xlr_gmac_irqs[mac + 4]); } xlr_net_dev1.num_resources = 8; -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: netlogic: removed 1 multiple assignment checkpatch warning
Hi, Thanks for getting back to me Greg! I’m still learning, so thanks again for bearing with me! Regards, Parth Sane > On 19-Mar-2016, at 10:43 PM, Greg KH <gre...@linuxfoundation.org> wrote: > > On Sat, Mar 19, 2016 at 10:04:23PM +0530, Parth Sane wrote: >> Hi, >> I haven’t received any feedback as to whether my patch has been accepted. >> Would request someone to kindly help me out. Maybe you could weigh in here >> Greg? >> Regards, >> Parth Sane >>> On 15-Mar-2016, at 10:16 PM, laerdevstud...@gmail.com wrote: > > 4 days later in the middle of a merge window when I can't add any new > patches to my queue? Please be patient, I will get to this after > 4.6-rc1 is out. > > thanks, > > greg k-h signature.asc Description: Message signed with OpenPGP using GPGMail ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: netlogic: removed 1 multiple assignment checkpatch warning
Hi Roger, Can I submit more patches similarly until this has been accepted? I’ll be sure to remove the from part in my next patch(I hope I don’t have to submit the earlier patch again).Thanks for your wise comments! Regards, Parth Sane > On 19-Mar-2016, at 10:33 PM, Roger H Newell <newell.ro...@gmail.com> wrote: > > On Sat, Mar 19, 2016 at 2:04 PM, Parth Sane <laerdevstud...@gmail.com> wrote: >> Hi, >> I haven’t received any feedback as to whether my patch has been accepted. >> Would request someone to kindly help me out. Maybe you could weigh in here >> Greg? >> Regards, >> Parth Sane >>> On 15-Mar-2016, at 10:16 PM, laerdevstud...@gmail.com wrote: >>> >>> From: Parth Sane <laerdevstud...@gmail.com> >>> >>> Fixed multiple assignment checkpatch warning by rearranging code. >>> >>> Signed-off-by: Parth Sane <laerdevstud...@gmail.com> >>> >>> --- >>> drivers/staging/netlogic/platform_net.c | 3 ++- >>> 1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/drivers/staging/netlogic/platform_net.c >>> b/drivers/staging/netlogic/platform_net.c >>> index 7806c2b..daee1b2 100644 >>> --- a/drivers/staging/netlogic/platform_net.c >>> +++ b/drivers/staging/netlogic/platform_net.c >>> @@ -86,7 +86,8 @@ static void xlr_resource_init(struct resource *res, int >>> offset, int irq) >>> >>> res++; >>> res->name = "gmac"; >>> - res->start = res->end = irq; >>> + res->end = irq; >>> + res->start = res->end; >>> res->flags = IORESOURCE_IRQ; >>> } >>> >>> -- >>> 2.1.4 >>> >> >> >> ___ >> devel mailing list >> de...@linuxdriverproject.org >> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel >> > > This patch is only 4 days old. It's likely in Gregs queue and you just > have to wait a bit longer. I don't think you need the From: line in > the body of the patch. The Signed-off-by: should suffice. signature.asc Description: Message signed with OpenPGP using GPGMail ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: netlogic: removed 1 multiple assignment checkpatch warning
Hi, I haven’t received any feedback as to whether my patch has been accepted. Would request someone to kindly help me out. Maybe you could weigh in here Greg? Regards, Parth Sane > On 15-Mar-2016, at 10:16 PM, laerdevstud...@gmail.com wrote: > > From: Parth Sane <laerdevstud...@gmail.com> > > Fixed multiple assignment checkpatch warning by rearranging code. > > Signed-off-by: Parth Sane <laerdevstud...@gmail.com> > > --- > drivers/staging/netlogic/platform_net.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/netlogic/platform_net.c > b/drivers/staging/netlogic/platform_net.c > index 7806c2b..daee1b2 100644 > --- a/drivers/staging/netlogic/platform_net.c > +++ b/drivers/staging/netlogic/platform_net.c > @@ -86,7 +86,8 @@ static void xlr_resource_init(struct resource *res, int > offset, int irq) > > res++; > res->name = "gmac"; > - res->start = res->end = irq; > + res->end = irq; > + res->start = res->end; > res->flags = IORESOURCE_IRQ; > } > > -- > 2.1.4 > signature.asc Description: Message signed with OpenPGP using GPGMail ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: nvec: Fixed 12 code style checks and changed udelay() to usleep_range() on 2 lines
Hi,
Sure thanks for pointing that out. I’ll send in a small patch for the problems
in the following order.
1) Null Comparison
2) License declaration
Hopefully maybe you guys can tell me what else is needed. Thanks for being so
supportive!
Regards,
Parth Sane
> On 29-Feb-2016, at 5:00 PM, Marc Dietrich <marvi...@gmx.de> wrote:
>
> Hi Parth,
>
> please also cc de...@linuxdriverproject.org next time.
>
> Some comments below.
>
> Am Freitag, 26. Februar 2016, 15:24:21 CET schrieb Parth Sane:
>> 1)Null comparison
>> 2)Extra Line after curly braces
>> 3)Changed udelay to udelay_range
>> 4)BUG_ON to WARN_ON to avoid crashing kernel
>> 5)Removed copyright notice as recommended by checkpatch script
>>
>> Signed-off-by: Parth Sane <laerdevstud...@gmail.com>
>> ---
>> drivers/staging/nvec/nvec-keytable.h | 13 -
>> drivers/staging/nvec/nvec.c | 18 +-
>> drivers/staging/nvec/nvec_paz00.c| 1 -
>> 3 files changed, 9 insertions(+), 23 deletions(-)
>>
>> diff --git a/drivers/staging/nvec/nvec-keytable.h
>> b/drivers/staging/nvec/nvec-keytable.h index 1dc22cb..9f369d5 100644
>> --- a/drivers/staging/nvec/nvec-keytable.h
>> +++ b/drivers/staging/nvec/nvec-keytable.h
>> @@ -6,19 +6,6 @@
>> *
>> * Copyright (c) 2009, NVIDIA Corporation.
>> *
>> - * This program is free software; you can redistribute it and/or modify
>> - * it under the terms of the GNU General Public License as published by
>> - * the Free Software Foundation; either version 2 of the License, or
>> - * (at your option) any later version.
>> - *
>> - * This program is distributed in the hope that it will be useful, but
>> WITHOUT - * ANY WARRANTY; without even the implied warranty of
>> MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU
>> General Public License for - * more details.
>> - *
>> - * You should have received a copy of the GNU General Public License along
>> - * with this program; if not, write to the Free Software Foundation, Inc.,
>> - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
>> */
>>
>> static unsigned short code_tab_102us[] = {
>> diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
>> index c335ae2..03dbc09 100644
>> --- a/drivers/staging/nvec/nvec.c
>> +++ b/drivers/staging/nvec/nvec.c
>> @@ -1,4 +1,4 @@
>> -/*
>> +2/*
>
> stray "2"
>
>> * NVEC: NVIDIA compliant embedded controller interface
>> *
>> * Copyright (C) 2011 The AC100 Kernel Team <ac...@lists.lauchpad.net>
>> @@ -264,7 +264,7 @@ int nvec_write_async(struct nvec_chip *nvec, const
>> unsigned char *data,
>>
>> msg = nvec_msg_alloc(nvec, NVEC_MSG_TX);
>>
>> -if (msg == NULL)
>> +if (!msg)
>> return -ENOMEM;
>>
>> msg->data[0] = size;
>> @@ -620,7 +620,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
>> } else {I had sent a patch for the staging nvec driver. It had
>> some
> checkpatch
>
>> nvec->rx = nvec_msg_alloc(nvec, NVEC_MSG_RX);
>> /* Should not happen in a normal world */
>> -if (unlikely(nvec->rx == NULL)) {
>> +if (unlikely(!nvec->rx)) {
>> nvec->state = 0;
>> break;
>> }
>> @@ -631,7 +631,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
>> break;
>> case 2: /* first byte after command */
>> if (status == (I2C_SL_IRQ | RNW | RCVD)) {
>> -udelay(33);
>> +usleep_range(32, 33);
>> if (nvec->rx->data[0] != 0x01) {
>> dev_err(nvec->dev,
>> "Read without prior read command\n");
>> @@ -641,11 +641,11 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
>> nvec_msg_free(nvec, nvec->rx);
>> nvec->state = 3;
>> nvec_tx_set(nvec);
>> -BUG_ON(nvec->tx->size < 1);
>> +WARN_ON(nvec->tx->size < 1);
>> to_send = nvec->tx->data[0];
>> nvec->tx->pos = 1;
>> } else if (status == (I2C_SL_IRQ)) {
>> -BUG_ON(nvec->rx == NULL);
>> +
Re: [PATCH] staging: nvec: Fixed 12 code style checks and changed udelay() to usleep_range() on 2 lines
Hi,
As per the previous email, I understand that some patches were unnecessary(For
example the fix for the spaces ). But it was a bit confusing. Can someone
please let me know which patches are needed and which are not?
Regards,
Parth Sane
> On 29-Feb-2016, at 5:00 PM, Marc Dietrich <marvi...@gmx.de> wrote:
>
> Hi Parth,
>
> please also cc de...@linuxdriverproject.org next time.
>
> Some comments below.
>
> Am Freitag, 26. Februar 2016, 15:24:21 CET schrieb Parth Sane:
>> 1)Null comparison
>> 2)Extra Line after curly braces
>> 3)Changed udelay to udelay_range
>> 4)BUG_ON to WARN_ON to avoid crashing kernel
>> 5)Removed copyright notice as recommended by checkpatch script
>>
>> Signed-off-by: Parth Sane <laerdevstud...@gmail.com>
>> ---
>> drivers/staging/nvec/nvec-keytable.h | 13 -
>> drivers/staging/nvec/nvec.c | 18 +-
>> drivers/staging/nvec/nvec_paz00.c| 1 -
>> 3 files changed, 9 insertions(+), 23 deletions(-)
>>
>> diff --git a/drivers/staging/nvec/nvec-keytable.h
>> b/drivers/staging/nvec/nvec-keytable.h index 1dc22cb..9f369d5 100644
>> --- a/drivers/staging/nvec/nvec-keytable.h
>> +++ b/drivers/staging/nvec/nvec-keytable.h
>> @@ -6,19 +6,6 @@
>> *
>> * Copyright (c) 2009, NVIDIA Corporation.
>> *
>> - * This program is free software; you can redistribute it and/or modify
>> - * it under the terms of the GNU General Public License as published by
>> - * the Free Software Foundation; either version 2 of the License, or
>> - * (at your option) any later version.
>> - *
>> - * This program is distributed in the hope that it will be useful, but
>> WITHOUT - * ANY WARRANTY; without even the implied warranty of
>> MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU
>> General Public License for - * more details.
>> - *
>> - * You should have received a copy of the GNU General Public License along
>> - * with this program; if not, write to the Free Software Foundation, Inc.,
>> - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
>> */
>>
>> static unsigned short code_tab_102us[] = {
>> diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
>> index c335ae2..03dbc09 100644
>> --- a/drivers/staging/nvec/nvec.c
>> +++ b/drivers/staging/nvec/nvec.c
>> @@ -1,4 +1,4 @@
>> -/*
>> +2/*
>
> stray "2"
>
>> * NVEC: NVIDIA compliant embedded controller interface
>> *
>> * Copyright (C) 2011 The AC100 Kernel Team <ac...@lists.lauchpad.net>
>> @@ -264,7 +264,7 @@ int nvec_write_async(struct nvec_chip *nvec, const
>> unsigned char *data,
>>
>> msg = nvec_msg_alloc(nvec, NVEC_MSG_TX);
>>
>> -if (msg == NULL)
>> +if (!msg)
>> return -ENOMEM;
>>
>> msg->data[0] = size;
>> @@ -620,7 +620,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
>> } else {I had sent a patch for the staging nvec driver. It had
>> some
> checkpatch
>
>> nvec->rx = nvec_msg_alloc(nvec, NVEC_MSG_RX);
>> /* Should not happen in a normal world */
>> -if (unlikely(nvec->rx == NULL)) {
>> +if (unlikely(!nvec->rx)) {
>> nvec->state = 0;
>> break;
>> }
>> @@ -631,7 +631,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
>> break;
>> case 2: /* first byte after command */
>> if (status == (I2C_SL_IRQ | RNW | RCVD)) {
>> -udelay(33);
>> +usleep_range(32, 33);
>> if (nvec->rx->data[0] != 0x01) {
>> dev_err(nvec->dev,
>> "Read without prior read command\n");
>> @@ -641,11 +641,11 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
>> nvec_msg_free(nvec, nvec->rx);
>> nvec->state = 3;
>> nvec_tx_set(nvec);
>> -BUG_ON(nvec->tx->size < 1);
>> +WARN_ON(nvec->tx->size < 1);
>> to_send = nvec->tx->data[0];
>> nvec->tx->pos = 1;
>> } else if (status == (I2C_SL_IRQ)) {
>> -BUG_ON(nvec->rx == NULL);
>> +WARN_ON(!nvec->rx);
&g
Re: Ralink 6570 / Mediatek MT7601STA (was Re: Addition of a wifi kernel module to the linux source tree)
Hello everone! A few months earlier I had requested addition of the MT7601 WiFi dongle module into the kernel. I was told that the needful would be done in the rt2x00 driver. Could you guys update me with the status? Thanks a lot! -Parth Sane On 4 December 2014 at 20:06, Stanislaw Gruszka sgrus...@redhat.com wrote: On Thu, Dec 04, 2014 at 09:49:53AM +0100, Oleksij Rempel wrote: So far i know, Felix is working on abgn+ac (MT7662 and MT7612) devices. MT7601STA is (a)bgn. Are there similar regs? All Mediatek/Ralink devices I know have the same MAC registers, but different BBP and RF registers. In mt7601 code i see parts like if (IS_RT3290(pAd) || IS_RT65XX(pAd) || IS_MT7601(pAd)). RT3290 is supported by rt2x00. Hence looks that support for this devices should be added to rt2x00. Stanislaw ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: Ralink 6570 / Mediatek MT7601STA (was Re: Addition of a wifi kernel module to the linux source tree)
Hi, Guys I'll be using my other account on my private domain laer.in now onwards. Be sure to add me in your contacts. My new email is parths...@laer.in -Parth On 4 December 2014 at 14:19, Oleksij Rempel li...@rempel-privat.de wrote: Am 04.12.2014 um 09:23 schrieb Stanislaw Gruszka: On Thu, Dec 04, 2014 at 03:52:52PM +1100, Julian Calaby wrote: On Thu, Dec 4, 2014 at 3:39 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Thu, Dec 04, 2014 at 07:07:58AM +0530, Parth Sane wrote: Hi, I'd say I'm midway through with c programming(part of my computer engineering degree course) and know a decent amount of git. So yes I'm comfortable writing code. Ok great, let's see if it's just a matter of some changes to the existing kernel driver before we decide to add the whole huge tarball to the staging tree as fixing it up will be a lot of work. I believe some people (CC'd) may have been working on / had an interest in writing such a driver. I'm not sure what the status of that effort is though. Right. Felix is working on new linux friendly driver for new Mediatek chips. So far i know, Felix is working on abgn+ac (MT7662 and MT7612) devices. MT7601STA is (a)bgn. Are there similar regs? In mt7601 code i see parts like if (IS_RT3290(pAd) || IS_RT65XX(pAd) || IS_MT7601(pAd)). RT3290 is supported by rt2x00. -- Regards, Oleksij ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: Ralink 6570 / Mediatek MT7601STA (was Re: Addition of a wifi kernel module to the linux source tree)
Hi,
I'd say I'm midway through with c programming(part of my computer
engineering degree course) and know a decent amount of git. So yes I'm
comfortable writing code.
Also here's the link to an eBay listing for the same hardware.
http://www.ebay.com/itm/like/231051816145?lpid=82item=231051816145lgeo=1vectorid=229466
I think that should do the trick.
Cheers,
-Parth
On 04/12/2014, Greg Kroah-Hartman gre...@linuxfoundation.org wrote:
On Sun, Nov 30, 2014 at 06:55:12PM +, Parth Sane wrote:
Hi Greg,
You can find the source code attached as a tarball. It works and I have
tested
it myself. You only need to use make and make install for this.
This really looks like a variant of some existing devices, the rt2x00,
Ralink driver.
I've copied the maintainers of that driver here.
Is anyone working on support for the following devices in the existing
rt2x00 USB driver:
{USB_DEVICE(0x148f, 0x6570)}, /* Ralink 6570 */
{USB_DEVICE(0x148f, 0x7650)}, /* MT7650 */
{USB_DEVICE(0x148f, 0x6370)}, /* Ralink 6370 */
{USB_DEVICE(0x148f, 0x7601)}, /* MT 6370 */
thanks,
greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: PATCH
Hi Greg, I have looked at the patches and documentation on how to proceed forward. But I have a doubt. Was hoping you could make it clear for me. You have said that you don't want unnecessary binary firmware files in the source which is really good. But if I how do I know which binary files are required or not? This is nearly impossible for me to guess this, since I haven't written the driver. Please help me out with this. -Parth On 1 December 2014 at 08:19, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Sun, Nov 30, 2014 at 08:54:08PM +, Parth Sane wrote: Hi, Please find the attached patch file. I hope it's OK. -Parth From 3a429077981db3a7cf96d1e503c0bbbc932cab32 Mon Sep 17 00:00:00 2001 From: Parth Sane laerdevstud...@gmail.com Date: Mon, 1 Dec 2014 01:55:47 +0530 Subject: [PATCH] added_missing_driver_code --- drivers/staging/mt7601u/TODO~ | 10 + drivers/staging/mt7601u/common/image.bin | Bin 0 - 67936 bytes drivers/staging/mt7601u/common/rt2870_wow.bin | Bin 0 - 12288 bytes drivers/staging/mt7601u/mcu/bin/MT7601.bin | Bin 0 - 45412 bytes .../staging/mt7601u/mcu/bin/MT7601_formal_1.7.bin | Bin 0 - 47032 bytes .../mt7601u/mcu/bin/MT7601_formal_1.7_Debug.bin| Bin 0 - 51944 bytes drivers/staging/mt7601u/mcu/bin/MT7650.bin | Bin 0 - 59580 bytes drivers/staging/mt7601u/mcu/bin/RT85592.bin| Bin 0 - 35060 bytes drivers/staging/mt7601u/mcu/bin/rt2860.bin | Bin 0 - 512 bytes drivers/staging/mt7601u/mcu/bin/rt2870.bin | Bin 0 - 8192 bytes drivers/staging/mt7601u/mcu/bin/rt2870_wow.bin | Bin 0 - 12288 bytes drivers/staging/mt7601u/os/linux/rt_linux.c~ | 6215 Take a look at the file Documentation/SubmittingPatches for the proper format for how to submit patches in a way that we can accept them. We also don't want binary firmware files in the kernel source tree, those will have to go to the linux-firmware project, but only the ones that the driver really needs, not all of the ones you have listed here. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
