Re: [PATCH 08/44] kernel: Move pm_power_off to common code

[Vineet Gupta]

On Tuesday 07 October 2014 11:01 AM, Guenter Roeck wrote:

diff --git a/arch/arc/kernel/reset.c b/arch/arc/kernel/reset.c
index 2768fa1..8a4fc47 100644
--- a/arch/arc/kernel/reset.c
+++ b/arch/arc/kernel/reset.c
@@ -26,9 +26,6 @@ void machine_restart(char *__unused)

 void machine_power_off(void)
 {
-   /* FIXME ::  power off ??? */
+   do_kernel_poweroff();
machine_halt();
 }
-
-void (*pm_power_off) (void) = NULL;
-EXPORT_SYMBOL(pm_power_off);

Acked-by: Vineet Gupta <mailto:vgu...@synopsys.com>

Thx,
-Vineet
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] arc: include: asm: define empty SERIAL_PORT_DFNS in serial.h

[Vineet Gupta]

On 10/31/2013 07:15 AM, Chen Gang wrote:
> For some architectures (e.g. arc, openrisc), BASE_BAUD isn't constant
> And SERIAL_PORT_DFNS always use BASE_BAUND, and also all drivers use
> SERIAL_PORT_DFNS to initialize static variables, statically.
>
> So need define SERIAL_PORT_DFNS as empty to tell drivers they don't
> support SERIAL_PORT_DFNS (mostly like frv and parisc did), or can not
> pass compiling
>
> The related error (allmodconfig for arc with gcc-4.8.0):
>
> CC [M]  drivers/staging/speakup/serialio.o
>   drivers/staging/speakup/serialio.c:12:2: error: initializer element is not 
> constant
> SERIAL_PORT_DFNS
> ^
>   drivers/staging/speakup/serialio.c:12:2: error: (near initialization for 
> 'rs_table[0].baud_base')
>   drivers/staging/speakup/serialio.c:12:2: error: initializer element is not 
> constant
>   drivers/staging/speakup/serialio.c:12:2: error: (near initialization for 
> 'rs_table[1].baud_base')
>   drivers/staging/speakup/serialio.c:12:2: error: initializer element is not 
> constant
>   drivers/staging/speakup/serialio.c:12:2: error: (near initialization for 
> 'rs_table[2].baud_base')
>   drivers/staging/speakup/serialio.c:12:2: error: initializer element is not 
> constant
>   drivers/staging/speakup/serialio.c:12:2: error: (near initialization for 
> 'rs_table[3].baud_base')
>
>
> Signed-off-by: Chen Gang 

NAK - as mentioned in prev email please fix the driver.

-Vineet
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] drivers: staging: speakup: serialio: delay initializing 'old_serial_port.baud_base'

[Vineet Gupta]

On 10/31/2013 06:57 AM, Chen Gang wrote:
> On 10/26/2013 09:18 PM, Chen Gang wrote:
>> On 10/25/2013 01:29 PM, Greg KH wrote:
>>> No, just use the platform-specific SERIAL_PORT_DNFS, instead of having a
>>> copy of it here in this driver, which is just wrong.  So please remove
>>> this, and just rely on the system version of this, defining it to
>>> "nothing" if it isn't present, like the 8250 serial driver does it.
>>>
>> Hmm... excuse me, I am not quite familiar with it, I will consult
>> related member.
>>
>> Hello Vineet, I have 2 questions to consult you, please help check:
>>
>>  - can arc support this driver? ("drivers/staging/speakup/serialio.c")

No I don' think it is relevant for ARC - but nevertheless as a general rule, it
should still build for ARC.

>>  - if arc supports the driver, can arc let it be initialized statically?
>>  (not dynamically, e.g. BASE_BAUD).

Like Greg said it needs to be fixed in the driver, just like 8250 does.

If this driver needs a specific definition of SERIAL_PORT_DFNS, that needs to 
come
from platform's asm/serial.h w/o littering all other arches with an irrelevant 
ifdef.

> After scan "arch" and "drivers" sub-directory:
>
>  - arc and openrisc define BASE_BAUD as non-constant number, and like most of 
> architectures, neither of them provide SERIAL_PORT_DFNS.
>
>  - frv and parisc define SERIAL_PORT_DFNS as empty, for all other 
> architectures who already define SERIAL_PORT_DFNS, they also use BASE_BAUD on 
> it.
>
>  - for all drivers, they treat SERIAL_PORT_DFNS as 'constant' to initialize 
> static variables statically.
>
> So for me, we need defind SERIAL_PORT_DFNS as empty for arc and
> openrisc, since they can not treate BASE_BAUD as constant number.

No, please fix the driver instead.

-Vineet

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel