from:"Yousof El\-Sayed"

[PATCH] staging: rtl8192e: fixed coding style issues

2016-03-19 Thread Yousof El-Sayed

staging: rtl8192e - dot11d.c

[patch 1/2] Fixed throughout:
spaces preferred around that '+' (ctx:VxV)

[patch 2/2] Fixed throughout:
Please don't use multiple blank lines

Signed-off-by: Yousof El-Sayed <yousof.el-sa...@elastichosts.com>
---
 drivers/staging/rtl8192e/dot11d.c | 14 ++
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/drivers/staging/rtl8192e/dot11d.c 
b/drivers/staging/rtl8192e/dot11d.c
index 4d8fb41..a08bfef 100644
--- a/drivers/staging/rtl8192e/dot11d.c
+++ b/drivers/staging/rtl8192e/dot11d.c
@@ -50,10 +50,9 @@ void dot11d_init(struct rtllib_device *ieee)
 
pDot11dInfo->State = DOT11D_STATE_NONE;
pDot11dInfo->CountryIeLen = 0;
-   memset(pDot11dInfo->channel_map, 0, MAX_CHANNEL_NUMBER+1);
-   memset(pDot11dInfo->MaxTxPwrDbmList, 0xFF, MAX_CHANNEL_NUMBER+1);
+   memset(pDot11dInfo->channel_map, 0, MAX_CHANNEL_NUMBER + 1);
+   memset(pDot11dInfo->MaxTxPwrDbmList, 0xFF, MAX_CHANNEL_NUMBER + 1);
RESET_CIE_WATCHDOG(ieee);
-
 }
 EXPORT_SYMBOL(dot11d_init);
 
@@ -99,14 +98,13 @@ void Dot11d_Channelmap(u8 channel_plan, struct 
rtllib_device *ieee)
 }
 EXPORT_SYMBOL(Dot11d_Channelmap);
 
-
 void Dot11d_Reset(struct rtllib_device *ieee)
 {
struct rt_dot11d_info *pDot11dInfo = GET_DOT11D_INFO(ieee);
u32 i;
 
-   memset(pDot11dInfo->channel_map, 0, MAX_CHANNEL_NUMBER+1);
-   memset(pDot11dInfo->MaxTxPwrDbmList, 0xFF, MAX_CHANNEL_NUMBER+1);
+   memset(pDot11dInfo->channel_map, 0, MAX_CHANNEL_NUMBER + 1);
+   memset(pDot11dInfo->MaxTxPwrDbmList, 0xFF, MAX_CHANNEL_NUMBER + 1);
for (i = 1; i <= 11; i++)
(pDot11dInfo->channel_map)[i] = 1;
for (i = 12; i <= 14; i++)
@@ -123,8 +121,8 @@ void Dot11d_UpdateCountryIe(struct rtllib_device *dev, u8 
*pTaddr,
u8 i, j, NumTriples, MaxChnlNum;
struct chnl_txpow_triple *pTriple;
 
-   memset(pDot11dInfo->channel_map, 0, MAX_CHANNEL_NUMBER+1);
-   memset(pDot11dInfo->MaxTxPwrDbmList, 0xFF, MAX_CHANNEL_NUMBER+1);
+   memset(pDot11dInfo->channel_map, 0, MAX_CHANNEL_NUMBER + 1);
+   memset(pDot11dInfo->MaxTxPwrDbmList, 0xFF, MAX_CHANNEL_NUMBER + 1);
MaxChnlNum = 0;
NumTriples = (CoutryIeLen - 3) / 3;
pTriple = (struct chnl_txpow_triple *)(pCoutryIe + 3);
-- 
1.8.3.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] Staging: rtl8192e: fix line length coding style issue in rtllib_softmac.c

2016-03-19 Thread Yousof El-Sayed

This is a patch to the rtllib_softmac.c file that fixes up all instances of
 the 'line over 80 characters' warnings found by the checkpatch.pl tool.

Signed-off-by: Yousof El-Sayed <yousof.el-sa...@elastichosts.com>
---
 drivers/staging/rtl8192e/rtllib_softmac.c | 35 +++
 1 file changed, 22 insertions(+), 13 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c 
b/drivers/staging/rtl8192e/rtllib_softmac.c
index cfab715..9ba2230 100644
--- a/drivers/staging/rtl8192e/rtllib_softmac.c
+++ b/drivers/staging/rtl8192e/rtllib_softmac.c
@@ -389,7 +389,8 @@ static void rtllib_send_beacon(struct rtllib_device *ieee)
 
if (ieee->beacon_txing && ieee->ieee_up)
mod_timer(>beacon_timer, jiffies +
- 
(msecs_to_jiffies(ieee->current_network.beacon_interval - 5)));
+ (msecs_to_jiffies
+  (ieee->current_network.beacon_interval - 5)));
 }
 
 
@@ -601,7 +602,8 @@ static void rtllib_softmac_scan_wq(void *data)
(ieee->current_network.channel + 1) %
MAX_CHANNEL_NUMBER;
if (ieee->scan_watch_dog++ > MAX_CHANNEL_NUMBER) {
-   if 
(!ieee->active_channel_map[ieee->current_network.channel])
+   if (!ieee->active_channel_map[ieee->
+   current_network.channel])
ieee->current_network.channel = 6;
goto out; /* no good chans */
}
@@ -1716,8 +1718,9 @@ inline void rtllib_softmac_new_net(struct rtllib_device 
*ieee,
if (ieee->iw_mode == IW_MODE_INFRA) {
/* Join the network for the first time */
ieee->AsocRetryCount = 0;
-   if ((ieee->current_network.qos_data.supported 
== 1) &&
-   ieee->current_network.bssht.bdSupportHT)
+   if ((ieee->current_network.qos_data.supported 
+ == 1) && 
+  ieee->current_network.bssht.bdSupportHT)
HTResetSelfAndSavePeerSetting(ieee,
 &(ieee->current_network));
else
@@ -2044,8 +2047,8 @@ static short rtllib_sta_ps_sleep(struct rtllib_device 
*ieee, u64 *time)
}
 
*time = ieee->current_network.last_dtim_sta_time
-   + 
msecs_to_jiffies(ieee->current_network.beacon_interval *
-   LPSAwakeIntvl_tmp);
+   + msecs_to_jiffies(ieee->
+   current_network.beacon_interval * LPSAwakeIntvl_tmp);
}
}
 
@@ -2237,11 +2240,15 @@ inline int rtllib_rx_assoc_resp(struct rtllib_device 
*ieee, struct sk_buff *skb,
ieee->assoc_id = aid;
ieee->softmac_stats.rx_ass_ok++;
/* station support qos */
-   /* Let the register setting default with Legacy station 
*/
-   assoc_resp = (struct rtllib_assoc_response_frame 
*)skb->data;
+   /* Let the register setting default */
+   /*  with Legacy station */
+   assoc_resp = (struct 
+   rtllib_assoc_response_frame *)skb->data;
if (ieee->current_network.qos_data.supported == 1) {
-   if (rtllib_parse_info_param(ieee, 
assoc_resp->info_element,
-   rx_stats->len - 
sizeof(*assoc_resp),
+   if (rtllib_parse_info_param
+   (ieee, assoc_resp->info_element,
+   rx_stats->len - sizeof
+   (*assoc_resp),
network, rx_stats)) {
kfree(network);
return 1;
@@ -2254,8 +2261,9 @@ inline int rtllib_rx_assoc_resp(struct rtllib_device 
*ieee, struct sk_buff *skb,
   network->bssht.bdHTInfoLen);
if (ieee->handle_assoc_response != NULL)
ieee->handle_assoc_response(ieee->dev,
-(struct 
rtllib_assoc_response_frame *)header,
-network);
+(struct 
+

[PATCH] staging: rtl8192e: fixed coding style issues

2016-03-19 Thread Yousof El-Sayed

Signed-off-by: Yousof El-Sayed <yousof.el-sa...@elastichosts.com>
---
 drivers/staging/rtl8192e/dot11d.c | 14 ++
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/drivers/staging/rtl8192e/dot11d.c 
b/drivers/staging/rtl8192e/dot11d.c
index 4d8fb41..a08bfef 100644
--- a/drivers/staging/rtl8192e/dot11d.c
+++ b/drivers/staging/rtl8192e/dot11d.c
@@ -50,10 +50,9 @@ void dot11d_init(struct rtllib_device *ieee)
 
pDot11dInfo->State = DOT11D_STATE_NONE;
pDot11dInfo->CountryIeLen = 0;
-   memset(pDot11dInfo->channel_map, 0, MAX_CHANNEL_NUMBER+1);
-   memset(pDot11dInfo->MaxTxPwrDbmList, 0xFF, MAX_CHANNEL_NUMBER+1);
+   memset(pDot11dInfo->channel_map, 0, MAX_CHANNEL_NUMBER + 1);
+   memset(pDot11dInfo->MaxTxPwrDbmList, 0xFF, MAX_CHANNEL_NUMBER + 1);
RESET_CIE_WATCHDOG(ieee);
-
 }
 EXPORT_SYMBOL(dot11d_init);
 
@@ -99,14 +98,13 @@ void Dot11d_Channelmap(u8 channel_plan, struct 
rtllib_device *ieee)
 }
 EXPORT_SYMBOL(Dot11d_Channelmap);
 
-
 void Dot11d_Reset(struct rtllib_device *ieee)
 {
struct rt_dot11d_info *pDot11dInfo = GET_DOT11D_INFO(ieee);
u32 i;
 
-   memset(pDot11dInfo->channel_map, 0, MAX_CHANNEL_NUMBER+1);
-   memset(pDot11dInfo->MaxTxPwrDbmList, 0xFF, MAX_CHANNEL_NUMBER+1);
+   memset(pDot11dInfo->channel_map, 0, MAX_CHANNEL_NUMBER + 1);
+   memset(pDot11dInfo->MaxTxPwrDbmList, 0xFF, MAX_CHANNEL_NUMBER + 1);
for (i = 1; i <= 11; i++)
(pDot11dInfo->channel_map)[i] = 1;
for (i = 12; i <= 14; i++)
@@ -123,8 +121,8 @@ void Dot11d_UpdateCountryIe(struct rtllib_device *dev, u8 
*pTaddr,
u8 i, j, NumTriples, MaxChnlNum;
struct chnl_txpow_triple *pTriple;
 
-   memset(pDot11dInfo->channel_map, 0, MAX_CHANNEL_NUMBER+1);
-   memset(pDot11dInfo->MaxTxPwrDbmList, 0xFF, MAX_CHANNEL_NUMBER+1);
+   memset(pDot11dInfo->channel_map, 0, MAX_CHANNEL_NUMBER + 1);
+   memset(pDot11dInfo->MaxTxPwrDbmList, 0xFF, MAX_CHANNEL_NUMBER + 1);
MaxChnlNum = 0;
NumTriples = (CoutryIeLen - 3) / 3;
pTriple = (struct chnl_txpow_triple *)(pCoutryIe + 3);
-- 
1.8.3.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] Staging: rtl8192e: fix line length coding style issue in rtllib_softmac.c

2016-03-19 Thread Yousof El-Sayed

This is a patch to the rtllib_softmac.c file that fixes up all instances of the 
'line over 80 characters' warnings found by the checkpatch.pl tool

Signed-off-by: Yousof El-Sayed <yousof.el-sa...@elastichosts.com>
---
 drivers/staging/rtl8192e/rtllib_softmac.c | 35 +++
 1 file changed, 22 insertions(+), 13 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c 
b/drivers/staging/rtl8192e/rtllib_softmac.c
index cfab715..9ba2230 100644
--- a/drivers/staging/rtl8192e/rtllib_softmac.c
+++ b/drivers/staging/rtl8192e/rtllib_softmac.c
@@ -389,7 +389,8 @@ static void rtllib_send_beacon(struct rtllib_device *ieee)
 
if (ieee->beacon_txing && ieee->ieee_up)
mod_timer(>beacon_timer, jiffies +
- 
(msecs_to_jiffies(ieee->current_network.beacon_interval - 5)));
+ (msecs_to_jiffies
+  (ieee->current_network.beacon_interval - 5)));
 }
 
 
@@ -601,7 +602,8 @@ static void rtllib_softmac_scan_wq(void *data)
(ieee->current_network.channel + 1) %
MAX_CHANNEL_NUMBER;
if (ieee->scan_watch_dog++ > MAX_CHANNEL_NUMBER) {
-   if 
(!ieee->active_channel_map[ieee->current_network.channel])
+   if (!ieee->active_channel_map[ieee->
+   current_network.channel])
ieee->current_network.channel = 6;
goto out; /* no good chans */
}
@@ -1716,8 +1718,9 @@ inline void rtllib_softmac_new_net(struct rtllib_device 
*ieee,
if (ieee->iw_mode == IW_MODE_INFRA) {
/* Join the network for the first time */
ieee->AsocRetryCount = 0;
-   if ((ieee->current_network.qos_data.supported 
== 1) &&
-   ieee->current_network.bssht.bdSupportHT)
+   if ((ieee->current_network.qos_data.supported 
+ == 1) && 
+  ieee->current_network.bssht.bdSupportHT)
HTResetSelfAndSavePeerSetting(ieee,
 &(ieee->current_network));
else
@@ -2044,8 +2047,8 @@ static short rtllib_sta_ps_sleep(struct rtllib_device 
*ieee, u64 *time)
}
 
*time = ieee->current_network.last_dtim_sta_time
-   + 
msecs_to_jiffies(ieee->current_network.beacon_interval *
-   LPSAwakeIntvl_tmp);
+   + msecs_to_jiffies(ieee->
+   current_network.beacon_interval * LPSAwakeIntvl_tmp);
}
}
 
@@ -2237,11 +2240,15 @@ inline int rtllib_rx_assoc_resp(struct rtllib_device 
*ieee, struct sk_buff *skb,
ieee->assoc_id = aid;
ieee->softmac_stats.rx_ass_ok++;
/* station support qos */
-   /* Let the register setting default with Legacy station 
*/
-   assoc_resp = (struct rtllib_assoc_response_frame 
*)skb->data;
+   /* Let the register setting default */
+   /*  with Legacy station */
+   assoc_resp = (struct 
+   rtllib_assoc_response_frame *)skb->data;
if (ieee->current_network.qos_data.supported == 1) {
-   if (rtllib_parse_info_param(ieee, 
assoc_resp->info_element,
-   rx_stats->len - 
sizeof(*assoc_resp),
+   if (rtllib_parse_info_param
+   (ieee, assoc_resp->info_element,
+   rx_stats->len - sizeof
+   (*assoc_resp),
network, rx_stats)) {
kfree(network);
return 1;
@@ -2254,8 +2261,9 @@ inline int rtllib_rx_assoc_resp(struct rtllib_device 
*ieee, struct sk_buff *skb,
   network->bssht.bdHTInfoLen);
if (ieee->handle_assoc_response != NULL)
ieee->handle_assoc_response(ieee->dev,
-(struct 
rtllib_assoc_response_frame *)header,
-network);
+(struct 
+

Re: [PATCH] staging: rtl8192e: fixed coding style issues

2016-03-18 Thread Yousof El-Sayed

Hi,

Thank you for the email, apologies for that I'll get that sorted out now.

Thanks again

On Thu, Mar 17, 2016 at 10:11:18AM -0700, Greg KH wrote:
> On Thu, Mar 17, 2016 at 04:55:37PM +0000, Yousof El-Sayed wrote:
> > Signed-off-by: Yousof El-Sayed <yousof.el-sa...@elastichosts.com>
> 
> I can't take patches without any changelog entry, sorry.
> 
> And be specific about what and why you are changing anything, "coding
> style issues" is very vague.
> 
> thanks,
> 
> greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: rtl8192e: fixed coding style issues

[PATCH] Staging: rtl8192e: fix line length coding style issue in rtllib_softmac.c

[PATCH] staging: rtl8192e: fixed coding style issues

[PATCH] Staging: rtl8192e: fix line length coding style issue in rtllib_softmac.c

Re: [PATCH] staging: rtl8192e: fixed coding style issues

5 matches

Site Navigation

Mail list logo

Footer information