[PATCH] Staging: goldfish: use __func__ instead of embedded function names
Embedded function names are less appropriate to use when refactoring, can cause function renaming. Prefer the use of "%s", __func__ to embedded function names Signed-off-by: Mohsin Shan --- drivers/staging/goldfish/goldfish_nand.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/goldfish/goldfish_nand.c b/drivers/staging/goldfish/goldfish_nand.c index 76d60ee..8f92ff4 100644 --- a/drivers/staging/goldfish/goldfish_nand.c +++ b/drivers/staging/goldfish/goldfish_nand.c @@ -114,8 +114,8 @@ static int goldfish_nand_erase(struct mtd_info *mtd, struct erase_info *instr) len = len / mtd->writesize * (mtd->writesize + mtd->oobsize); if (goldfish_nand_cmd(mtd, NAND_CMD_ERASE, ofs, len, NULL) != len) { - pr_err("goldfish_nand_erase: erase failed, start %llx, len %x, dev_size %llx, erase_size %x\n", - ofs, len, mtd->size, mtd->erasesize); + pr_err("%s: erase failed, start %llx, len %x, dev_size %llx, erase_size %x\n", + __func__, ofs, len, mtd->size, mtd->erasesize); return -EIO; } @@ -125,8 +125,8 @@ static int goldfish_nand_erase(struct mtd_info *mtd, struct erase_info *instr) return 0; invalid_arg: - pr_err("goldfish_nand_erase: invalid erase, start %llx, len %x, dev_size %llx, erase_size %x\n", - ofs, len, mtd->size, mtd->erasesize); + pr_err("%s: invalid erase, start %llx, len %x, dev_size %llx, erase_size %x\n", + __func__, ofs, len, mtd->size, mtd->erasesize); return -EINVAL; } @@ -254,8 +254,8 @@ static int goldfish_nand_block_isbad(struct mtd_info *mtd, loff_t ofs) return goldfish_nand_cmd(mtd, NAND_CMD_BLOCK_BAD_GET, ofs, 0, NULL); invalid_arg: - pr_err("goldfish_nand_block_isbad: invalid arg, ofs %llx, dev_size %llx, write_size %x\n", - ofs, mtd->size, mtd->writesize); + pr_err("%s: invalid arg, ofs %llx, dev_size %llx, write_size %x\n", + __func__, ofs, mtd->size, mtd->writesize); return -EINVAL; } @@ -277,8 +277,8 @@ static int goldfish_nand_block_markbad(struct mtd_info *mtd, loff_t ofs) return 0; invalid_arg: - pr_err("goldfish_nand_block_markbad: invalid arg, ofs %llx, dev_size %llx, write_size %x\n", - ofs, mtd->size, mtd->writesize); + pr_err("%s: invalid arg, ofs %llx, dev_size %llx, write_size %x\n", + __func__, ofs, mtd->size, mtd->writesize); return -EINVAL; } -- 2.7.4 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] drivers/staging/goldfish/goldfish_nand.c: Fixed Coding style Warnings.
Embedded function names are less appropriate to use when refactoring, can cause function renaming. Prefer the use of "%s", __func__ to embedded function names Signed-off-by: mshan --- drivers/staging/goldfish/goldfish_nand.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/goldfish/goldfish_nand.c b/drivers/staging/goldfish/goldfish_nand.c index 76d60ee..8f92ff4 100644 --- a/drivers/staging/goldfish/goldfish_nand.c +++ b/drivers/staging/goldfish/goldfish_nand.c @@ -114,8 +114,8 @@ static int goldfish_nand_erase(struct mtd_info *mtd, struct erase_info *instr) len = len / mtd->writesize * (mtd->writesize + mtd->oobsize); if (goldfish_nand_cmd(mtd, NAND_CMD_ERASE, ofs, len, NULL) != len) { - pr_err("goldfish_nand_erase: erase failed, start %llx, len %x, dev_size %llx, erase_size %x\n", - ofs, len, mtd->size, mtd->erasesize); + pr_err("%s: erase failed, start %llx, len %x, dev_size %llx, erase_size %x\n", + __func__, ofs, len, mtd->size, mtd->erasesize); return -EIO; } @@ -125,8 +125,8 @@ static int goldfish_nand_erase(struct mtd_info *mtd, struct erase_info *instr) return 0; invalid_arg: - pr_err("goldfish_nand_erase: invalid erase, start %llx, len %x, dev_size %llx, erase_size %x\n", - ofs, len, mtd->size, mtd->erasesize); + pr_err("%s: invalid erase, start %llx, len %x, dev_size %llx, erase_size %x\n", + __func__, ofs, len, mtd->size, mtd->erasesize); return -EINVAL; } @@ -254,8 +254,8 @@ static int goldfish_nand_block_isbad(struct mtd_info *mtd, loff_t ofs) return goldfish_nand_cmd(mtd, NAND_CMD_BLOCK_BAD_GET, ofs, 0, NULL); invalid_arg: - pr_err("goldfish_nand_block_isbad: invalid arg, ofs %llx, dev_size %llx, write_size %x\n", - ofs, mtd->size, mtd->writesize); + pr_err("%s: invalid arg, ofs %llx, dev_size %llx, write_size %x\n", + __func__, ofs, mtd->size, mtd->writesize); return -EINVAL; } @@ -277,8 +277,8 @@ static int goldfish_nand_block_markbad(struct mtd_info *mtd, loff_t ofs) return 0; invalid_arg: - pr_err("goldfish_nand_block_markbad: invalid arg, ofs %llx, dev_size %llx, write_size %x\n", - ofs, mtd->size, mtd->writesize); + pr_err("%s: invalid arg, ofs %llx, dev_size %llx, write_size %x\n", + __func__, ofs, mtd->size, mtd->writesize); return -EINVAL; } -- 2.7.4 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Coding Style fix in drivers/staging/fwserial
Arguments in the macros should be coverd in brackets to aviod any precedence issues. Fixed it. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] Fixed a minor coding style warning. Arguments in the macros should be coverd in brackets to aviod any precedence issues.
Signed-off-by: mshan --- drivers/staging/fwserial/fwserial.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fwserial/fwserial.c b/drivers/staging/fwserial/fwserial.c index 41a49c8..d693c03 100644 --- a/drivers/staging/fwserial/fwserial.c +++ b/drivers/staging/fwserial/fwserial.c @@ -98,7 +98,7 @@ struct fwtty_transaction { }; }; -#define to_device(a, b)(a->b) +#define to_device(a, b)((a)->(b)) #define fwtty_err(p, fmt, ...) \ dev_err(to_device(p, device), fmt, ##__VA_ARGS__) #define fwtty_info(p, fmt, ...) \ -- 2.7.4 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] Fixed a minor coding style warning. Arguments in the macros should be coverd in brackets to aviod any precedence issues.
Signed-off-by: mshan --- drivers/staging/fwserial/fwserial.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fwserial/fwserial.c b/drivers/staging/fwserial/fwserial.c index 41a49c8..d693c03 100644 --- a/drivers/staging/fwserial/fwserial.c +++ b/drivers/staging/fwserial/fwserial.c @@ -98,7 +98,7 @@ struct fwtty_transaction { }; }; -#define to_device(a, b)(a->b) +#define to_device(a, b)((a)->(b)) #define fwtty_err(p, fmt, ...) \ dev_err(to_device(p, device), fmt, ##__VA_ARGS__) #define fwtty_info(p, fmt, ...) \ -- 2.7.4 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel