Re: [Outreachy kernel] [PATCH 0/2] IIO coding tasks
On 21 March 2017 17:27:02 GMT+00:00, Julia Lawall wrote: > > >On Tue, 21 Mar 2017, Arushi Singhal wrote: > >> >> >> On Tue, Mar 21, 2017 at 10:32 PM, Alison Schofield > >> wrote: >> On Tue, Mar 21, 2017 at 05:39:38PM +0100, Julia Lawall wrote: >> > >> > >> > On Tue, 21 Mar 2017, Arushi Singhal wrote: >> > >> > > On Tue, Mar 21, 2017 at 9:33 PM, Alison Schofield >> >> > > wrote: >> > > On Tue, Mar 21, 2017 at 07:00:17PM +0530, Arushi >> Singhal wrote: >> > > > Patchseries of IIO coding tasks >> > > >> > > This wouldn't be a patchset. Although they touch the >> same >> > > driver, the changes are unrelated. See more below... >> > > >> > > This I have send as a Patchset because as you have >mentioned >> below that the >> > > [PATCH 2/2] was already done before by someone but I think >> so it is not yet >> > > applied in the Greg's tree yet.So I have done both the >> changes and as they >> > > should be applied one after other so that's why I have send >> them as >> > > Patchset. >> > >> > For the IIO patches, it is better to work on the IIO tree, >not >> Greg's. >> > Greg manages staging, not IIO. The IIO patches should appear >> in Greg's >> > tree eventually. >> > >> > julia >> >> We didn't direct applicants to create an iio tree. At this >> point, >> it seems more than is necessary. They can follow the >directions >> in the >> task descriptions and avoid the collisions. >> >> Of course, they are welcome to create a tree to iio/testing. >> >> (IMHO it's more overhead/busy work and maybe not the best use >> of time in the home stretch of the application period.) >> >> alisons >> >> >> Hi Alison >> As you have mentioned that my [PATCH 2/2] is already being done >someone. So >> how can I make the changes of [PATCH 1/2] on top of it as [PATCH 2/2] >is not >> yet applied on the staging tree. > >Make a patch that applies to the current state of the IIO tree. Just >clone that one like you cloned the staging one. > >julia > Slight amendment,. Normally would be the togreg branch which doesn't rebase. With all the current churn might be best to use the testing branch and i will fix up any issues if i have to rebase as result of build tests. Will.send Greg a pull later anyway, so should be less difference after he pulls that. J >> Please suggest me. >> Thanks >> Arushi >> > >> > > > >> > > > Arushi Singhal (2): >> > > > staging: ad7759: Replace mlock with driver >private >> lock >> > > >> > > This one is already been submitted. If you have a v2 >> for it, >> > > then v2 >> > > the original patch. >> > > >> > > Is it submitted by me only before? And this is not the v2. >> > > I have just resed it. >> > > > staging: iio: ade7759: Move header content to >> implementation >> > > file >> > > >> > > This patch is done and applied already. See the >> Coding Task #1 >> > > notes >> > > in the IIO Tasks page. >> > > >> > > Not at applied I think so. >> > > Thanks >> > > Arushi >> > > >> > > alisons >> > > >> > > > >> > > > drivers/staging/iio/meter/ade7759.c | 56 >> > > +-- >> > > > drivers/staging/iio/meter/ade7759.h | 53 >> > > - >> > > > 2 files changed, 54 insertions(+), 57 deletions(-) >> > > > >> > > > -- >> > > > 2.11.0 >> > > > >> > > > -- >> > > > You received this message because you are subscribed to >> the Google >> > > Groups "outreachy-kernel" group. >> > > > To unsubscribe from this group and stop receiving emails >> from it, >> > > send an email to >> outreachy-kernel+unsubscr...@googlegroups.com. >> > > > To post to this group, send email to >> > > outreachy-ker...@googlegroups.com. >> > > > To view this discussion on the >webvisithttps://groups.google.com/d/msgid/outreachy-kernel/20170321133021.6737 >> -1-ar >> > > ushisinghal19971997%40gmail.com. >> > > > For more options, visit >> https://groups.google.com/d/optout. >> > > >> > > >> > > -- >> > > You received this message because you are subscribed to the >> Google Groups >> > > "outreachy-kernel" group. >> > > To unsubscribe from this group and stop receiving emails >> from it, send an >> > > email to outreachy-kernel+unsubscr...@googlegroups.com. >> > > To post to this group, send email to >>
Re: [Outreachy kernel] [PATCH 0/2] IIO coding tasks
On Tue, Mar 21, 2017 at 10:52:46PM +0530, Arushi Singhal wrote: > On Tue, Mar 21, 2017 at 10:32 PM, Alison Schofield > wrote: > > > On Tue, Mar 21, 2017 at 05:39:38PM +0100, Julia Lawall wrote: > > > > > > > > > On Tue, 21 Mar 2017, Arushi Singhal wrote: > > > > > > > On Tue, Mar 21, 2017 at 9:33 PM, Alison Schofield < > > amsfiel...@gmail.com> > > > > wrote: > > > > On Tue, Mar 21, 2017 at 07:00:17PM +0530, Arushi Singhal wrote: > > > > > Patchseries of IIO coding tasks > > > > > > > > This wouldn't be a patchset. Although they touch the same > > > > driver, the changes are unrelated. See more below... > > > > > > > > This I have send as a Patchset because as you have mentioned below > > that the > > > > [PATCH 2/2] was already done before by someone but I think so it is > > not yet > > > > applied in the Greg's tree yet.So I have done both the changes and as > > they > > > > should be applied one after other so that's why I have send them as > > > > Patchset. > > > > > > For the IIO patches, it is better to work on the IIO tree, not Greg's. > > > Greg manages staging, not IIO. The IIO patches should appear in Greg's > > > tree eventually. > > > > > > julia > > > > We didn't direct applicants to create an iio tree. At this point, > > it seems more than is necessary. They can follow the directions in the > > task descriptions and avoid the collisions. > > > > Of course, they are welcome to create a tree to iio/testing. > > > > (IMHO it's more overhead/busy work and maybe not the best use > > of time in the home stretch of the application period.) > > > > alisons > > > > Hi Alison > As you have mentioned that my [PATCH 2/2] is already being done someone. So > how can I make the changes of [PATCH 1/2] on top of it as [PATCH 2/2] is > not yet applied on the staging tree. > Please suggest me. > Thanks > Arushi Arushi - I don't see anything needing to be done by you! Your ad7759 mlock patch is awaiting review. It's not your issue to keep up with all changes going into the file. When it gets applied will most likely merge with no merge issue at all. alisons > > > > > > > > > > > > > > Arushi Singhal (2): > > > > > staging: ad7759: Replace mlock with driver private lock > > > > > > > > This one is already been submitted. If you have a v2 for it, > > > > then v2 > > > > the original patch. > > > > > > > > Is it submitted by me only before? And this is not the v2. > > > > I have just resed it. > > > > > staging: iio: ade7759: Move header content to implementation > > > > file > > > > > > > > This patch is done and applied already. See the Coding Task #1 > > > > notes > > > > in the IIO Tasks page. > > > > > > > > Not at applied I think so. > > > > Thanks > > > > Arushi > > > > > > > > alisons > > > > > > > > > > > > > > drivers/staging/iio/meter/ade7759.c | 56 > > > > +-- > > > > > drivers/staging/iio/meter/ade7759.h | 53 > > > > - > > > > > 2 files changed, 54 insertions(+), 57 deletions(-) > > > > > > > > > > -- > > > > > 2.11.0 > > > > > > > > > > -- > > > > > You received this message because you are subscribed to the Google > > > > Groups "outreachy-kernel" group. > > > > > To unsubscribe from this group and stop receiving emails from it, > > > > send an email to outreachy-kernel+unsubscr...@googlegroups.com. > > > > > To post to this group, send email to > > > > outreachy-ker...@googlegroups.com. > > > > > To view this discussion on the web visithttps://groups.google. > > com/d/msgid/outreachy-kernel/20170321133021.6737-1-ar > > > > ushisinghal19971997%40gmail.com. > > > > > For more options, visit https://groups.google.com/d/optout. > > > > > > > > > > > > -- > > > > You received this message because you are subscribed to the Google > > Groups > > > > "outreachy-kernel" group. > > > > To unsubscribe from this group and stop receiving emails from it, send > > an > > > > email to outreachy-kernel+unsubscr...@googlegroups.com. > > > > To post to this group, send email to outreachy-ker...@googlegroups.com > > . > > > > To view this discussion on the web visithttps://groups.google. > > com/d/msgid/outreachy-kernel/CA%2BXqjF9dVy33Dsv0H2z8x > > > > taNeMOW7SQgr4qa4wLwz6xFNVTsUA%40mail.gmail.com. > > > > For more options, visit https://groups.google.com/d/optout. > > > > > > > > > > > > ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [Outreachy kernel] [PATCH 0/2] IIO coding tasks
On Tue, 21 Mar 2017, Arushi Singhal wrote: > > > On Tue, Mar 21, 2017 at 10:32 PM, Alison Schofield > wrote: > On Tue, Mar 21, 2017 at 05:39:38PM +0100, Julia Lawall wrote: > > > > > > On Tue, 21 Mar 2017, Arushi Singhal wrote: > > > > > On Tue, Mar 21, 2017 at 9:33 PM, Alison Schofield > > > > wrote: > > > On Tue, Mar 21, 2017 at 07:00:17PM +0530, Arushi > Singhal wrote: > > > > Patchseries of IIO coding tasks > > > > > > This wouldn't be a patchset. Although they touch the > same > > > driver, the changes are unrelated. See more below... > > > > > > This I have send as a Patchset because as you have mentioned > below that the > > > [PATCH 2/2] was already done before by someone but I think > so it is not yet > > > applied in the Greg's tree yet.So I have done both the > changes and as they > > > should be applied one after other so that's why I have send > them as > > > Patchset. > > > > For the IIO patches, it is better to work on the IIO tree, not > Greg's. > > Greg manages staging, not IIO. The IIO patches should appear > in Greg's > > tree eventually. > > > > julia > > We didn't direct applicants to create an iio tree. At this > point, > it seems more than is necessary. They can follow the directions > in the > task descriptions and avoid the collisions. > > Of course, they are welcome to create a tree to iio/testing. > > (IMHO it's more overhead/busy work and maybe not the best use > of time in the home stretch of the application period.) > > alisons > > > Hi Alison > As you have mentioned that my [PATCH 2/2] is already being done someone. So > how can I make the changes of [PATCH 1/2] on top of it as [PATCH 2/2] is not > yet applied on the staging tree. Make a patch that applies to the current state of the IIO tree. Just clone that one like you cloned the staging one. julia > Please suggest me. > Thanks > Arushi > > > > > > > > > > Arushi Singhal (2): > > > > staging: ad7759: Replace mlock with driver private > lock > > > > > > This one is already been submitted. If you have a v2 > for it, > > > then v2 > > > the original patch. > > > > > > Is it submitted by me only before? And this is not the v2. > > > I have just resed it. > > > > staging: iio: ade7759: Move header content to > implementation > > > file > > > > > > This patch is done and applied already. See the > Coding Task #1 > > > notes > > > in the IIO Tasks page. > > > > > > Not at applied I think so. > > > Thanks > > > Arushi > > > > > > alisons > > > > > > > > > > > drivers/staging/iio/meter/ade7759.c | 56 > > > +-- > > > > drivers/staging/iio/meter/ade7759.h | 53 > > > - > > > > 2 files changed, 54 insertions(+), 57 deletions(-) > > > > > > > > -- > > > > 2.11.0 > > > > > > > > -- > > > > You received this message because you are subscribed to > the Google > > > Groups "outreachy-kernel" group. > > > > To unsubscribe from this group and stop receiving emails > from it, > > > send an email to > outreachy-kernel+unsubscr...@googlegroups.com. > > > > To post to this group, send email to > > > outreachy-ker...@googlegroups.com. > > > > To view this discussion on the > webvisithttps://groups.google.com/d/msgid/outreachy-kernel/20170321133021.6737 > -1-ar > > > ushisinghal19971997%40gmail.com. > > > > For more options, visit > https://groups.google.com/d/optout. > > > > > > > > > -- > > > You received this message because you are subscribed to the > Google Groups > > > "outreachy-kernel" group. > > > To unsubscribe from this group and stop receiving emails > from it, send an > > > email to outreachy-kernel+unsubscr...@googlegroups.com. > > > To post to this group, send email to > outreachy-ker...@googlegroups.com. > > > To view this discussion on the > webvisithttps://groups.google.com/d/msgid/outreachy-kernel/CA%2BXqjF9dVy33Dsv0 > H2z8x > > > taNeMOW7SQgr4qa4wLwz6xFNVTsUA%40mail.gmail.com. > > > For more options, visit https://groups.google.com/d/optout. > > > > > > > > > >___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [Outreachy kernel] [PATCH 0/2] IIO coding tasks
On Tue, 21 Mar 2017, Alison Schofield wrote: > On Tue, Mar 21, 2017 at 05:39:38PM +0100, Julia Lawall wrote: > > > > > > On Tue, 21 Mar 2017, Arushi Singhal wrote: > > > > > On Tue, Mar 21, 2017 at 9:33 PM, Alison Schofield > > > wrote: > > > On Tue, Mar 21, 2017 at 07:00:17PM +0530, Arushi Singhal wrote: > > > > Patchseries of IIO coding tasks > > > > > > This wouldn't be a patchset. Although they touch the same > > > driver, the changes are unrelated. See more below... > > > > > > This I have send as a Patchset because as you have mentioned below that > > > the > > > [PATCH 2/2] was already done before by someone but I think so it is not > > > yet > > > applied in the Greg's tree yet.So I have done both the changes and as they > > > should be applied one after other so that's why I have send them as > > > Patchset. > > > > For the IIO patches, it is better to work on the IIO tree, not Greg's. > > Greg manages staging, not IIO. The IIO patches should appear in Greg's > > tree eventually. > > > > julia > > We didn't direct applicants to create an iio tree. At this point, > it seems more than is necessary. They can follow the directions in the > task descriptions and avoid the collisions. I meant just pull from the IIO tree you mentioned, work on that, submit patches, and then expect to see the patches show up there at some time in the future. If someone make IIO patches on Greg's tree, then they will have an out of date view. julia > > Of course, they are welcome to create a tree to iio/testing. > > (IMHO it's more overhead/busy work and maybe not the best use > of time in the home stretch of the application period.) > > alisons > > > > > > > > > > Arushi Singhal (2): > > > > staging: ad7759: Replace mlock with driver private lock > > > > > > This one is already been submitted. If you have a v2 for it, > > > then v2 > > > the original patch. > > > > > > Is it submitted by me only before? And this is not the v2. > > > I have just resed it. > > > > staging: iio: ade7759: Move header content to implementation > > > file > > > > > > This patch is done and applied already. See the Coding Task #1 > > > notes > > > in the IIO Tasks page. > > > > > > Not at applied I think so. > > > Thanks > > > Arushi > > > > > > alisons > > > > > > > > > > > drivers/staging/iio/meter/ade7759.c | 56 > > > +-- > > > > drivers/staging/iio/meter/ade7759.h | 53 > > > - > > > > 2 files changed, 54 insertions(+), 57 deletions(-) > > > > > > > > -- > > > > 2.11.0 > > > > > > > > -- > > > > You received this message because you are subscribed to the Google > > > Groups "outreachy-kernel" group. > > > > To unsubscribe from this group and stop receiving emails from it, > > > send an email to outreachy-kernel+unsubscr...@googlegroups.com. > > > > To post to this group, send email to > > > outreachy-ker...@googlegroups.com. > > > > To view this discussion on the web > > > > visithttps://groups.google.com/d/msgid/outreachy-kernel/20170321133021.6737-1-ar > > > ushisinghal19971997%40gmail.com. > > > > For more options, visit https://groups.google.com/d/optout. > > > > > > > > > -- > > > You received this message because you are subscribed to the Google Groups > > > "outreachy-kernel" group. > > > To unsubscribe from this group and stop receiving emails from it, send an > > > email to outreachy-kernel+unsubscr...@googlegroups.com. > > > To post to this group, send email to outreachy-ker...@googlegroups.com. > > > To view this discussion on the web > > > visithttps://groups.google.com/d/msgid/outreachy-kernel/CA%2BXqjF9dVy33Dsv0H2z8x > > > taNeMOW7SQgr4qa4wLwz6xFNVTsUA%40mail.gmail.com. > > > For more options, visit https://groups.google.com/d/optout. > > > > > > > > -- > You received this message because you are subscribed to the Google Groups > "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to outreachy-kernel+unsubscr...@googlegroups.com. > To post to this group, send email to outreachy-ker...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/outreachy-kernel/20170321170221.GB2793%40d830.WORKGROUP. > For more options, visit https://groups.google.com/d/optout. >___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [Outreachy kernel] [PATCH 0/2] IIO coding tasks
On Tue, Mar 21, 2017 at 05:39:38PM +0100, Julia Lawall wrote: > > > On Tue, 21 Mar 2017, Arushi Singhal wrote: > > > On Tue, Mar 21, 2017 at 9:33 PM, Alison Schofield > > wrote: > > On Tue, Mar 21, 2017 at 07:00:17PM +0530, Arushi Singhal wrote: > > > Patchseries of IIO coding tasks > > > > This wouldn't be a patchset. Although they touch the same > > driver, the changes are unrelated. See more below... > > > > This I have send as a Patchset because as you have mentioned below that the > > [PATCH 2/2] was already done before by someone but I think so it is not yet > > applied in the Greg's tree yet.So I have done both the changes and as they > > should be applied one after other so that's why I have send them as > > Patchset. > > For the IIO patches, it is better to work on the IIO tree, not Greg's. > Greg manages staging, not IIO. The IIO patches should appear in Greg's > tree eventually. > > julia We didn't direct applicants to create an iio tree. At this point, it seems more than is necessary. They can follow the directions in the task descriptions and avoid the collisions. Of course, they are welcome to create a tree to iio/testing. (IMHO it's more overhead/busy work and maybe not the best use of time in the home stretch of the application period.) alisons > > > > > > > Arushi Singhal (2): > > > staging: ad7759: Replace mlock with driver private lock > > > > This one is already been submitted. If you have a v2 for it, > > then v2 > > the original patch. > > > > Is it submitted by me only before? And this is not the v2. > > I have just resed it. > > > staging: iio: ade7759: Move header content to implementation > > file > > > > This patch is done and applied already. See the Coding Task #1 > > notes > > in the IIO Tasks page. > > > > Not at applied I think so. > > Thanks > > Arushi > > > > alisons > > > > > > > > drivers/staging/iio/meter/ade7759.c | 56 > > +-- > > > drivers/staging/iio/meter/ade7759.h | 53 > > - > > > 2 files changed, 54 insertions(+), 57 deletions(-) > > > > > > -- > > > 2.11.0 > > > > > > -- > > > You received this message because you are subscribed to the Google > > Groups "outreachy-kernel" group. > > > To unsubscribe from this group and stop receiving emails from it, > > send an email to outreachy-kernel+unsubscr...@googlegroups.com. > > > To post to this group, send email to > > outreachy-ker...@googlegroups.com. > > > To view this discussion on the web > > > visithttps://groups.google.com/d/msgid/outreachy-kernel/20170321133021.6737-1-ar > > ushisinghal19971997%40gmail.com. > > > For more options, visit https://groups.google.com/d/optout. > > > > > > -- > > You received this message because you are subscribed to the Google Groups > > "outreachy-kernel" group. > > To unsubscribe from this group and stop receiving emails from it, send an > > email to outreachy-kernel+unsubscr...@googlegroups.com. > > To post to this group, send email to outreachy-ker...@googlegroups.com. > > To view this discussion on the web > > visithttps://groups.google.com/d/msgid/outreachy-kernel/CA%2BXqjF9dVy33Dsv0H2z8x > > taNeMOW7SQgr4qa4wLwz6xFNVTsUA%40mail.gmail.com. > > For more options, visit https://groups.google.com/d/optout. > > > > ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [Outreachy kernel] [PATCH 0/2] IIO coding tasks
On Tue, 21 Mar 2017, Arushi Singhal wrote: > On Tue, Mar 21, 2017 at 9:33 PM, Alison Schofield > wrote: > On Tue, Mar 21, 2017 at 07:00:17PM +0530, Arushi Singhal wrote: > > Patchseries of IIO coding tasks > > This wouldn't be a patchset. Although they touch the same > driver, the changes are unrelated. See more below... > > This I have send as a Patchset because as you have mentioned below that the > [PATCH 2/2] was already done before by someone but I think so it is not yet > applied in the Greg's tree yet.So I have done both the changes and as they > should be applied one after other so that's why I have send them as > Patchset. For the IIO patches, it is better to work on the IIO tree, not Greg's. Greg manages staging, not IIO. The IIO patches should appear in Greg's tree eventually. julia > > > > Arushi Singhal (2): > > staging: ad7759: Replace mlock with driver private lock > > This one is already been submitted. If you have a v2 for it, > then v2 > the original patch. > > Is it submitted by me only before? And this is not the v2. > I have just resed it. > > staging: iio: ade7759: Move header content to implementation > file > > This patch is done and applied already. See the Coding Task #1 > notes > in the IIO Tasks page. > > Not at applied I think so. > Thanks > Arushi > > alisons > > > > > drivers/staging/iio/meter/ade7759.c | 56 > +-- > > drivers/staging/iio/meter/ade7759.h | 53 > - > > 2 files changed, 54 insertions(+), 57 deletions(-) > > > > -- > > 2.11.0 > > > > -- > > You received this message because you are subscribed to the Google > Groups "outreachy-kernel" group. > > To unsubscribe from this group and stop receiving emails from it, > send an email to outreachy-kernel+unsubscr...@googlegroups.com. > > To post to this group, send email to > outreachy-ker...@googlegroups.com. > > To view this discussion on the web > > visithttps://groups.google.com/d/msgid/outreachy-kernel/20170321133021.6737-1-ar > ushisinghal19971997%40gmail.com. > > For more options, visit https://groups.google.com/d/optout. > > > -- > You received this message because you are subscribed to the Google Groups > "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to outreachy-kernel+unsubscr...@googlegroups.com. > To post to this group, send email to outreachy-ker...@googlegroups.com. > To view this discussion on the web > visithttps://groups.google.com/d/msgid/outreachy-kernel/CA%2BXqjF9dVy33Dsv0H2z8x > taNeMOW7SQgr4qa4wLwz6xFNVTsUA%40mail.gmail.com. > For more options, visit https://groups.google.com/d/optout. > >___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [Outreachy kernel] [PATCH 0/2] IIO coding tasks
On Tue, Mar 21, 2017 at 07:00:17PM +0530, Arushi Singhal wrote: > Patchseries of IIO coding tasks This wouldn't be a patchset. Although they touch the same driver, the changes are unrelated. See more below... > > Arushi Singhal (2): > staging: ad7759: Replace mlock with driver private lock This one is already been submitted. If you have a v2 for it, then v2 the original patch. > staging: iio: ade7759: Move header content to implementation file This patch is done and applied already. See the Coding Task #1 notes in the IIO Tasks page. alisons > > drivers/staging/iio/meter/ade7759.c | 56 > +-- > drivers/staging/iio/meter/ade7759.h | 53 - > 2 files changed, 54 insertions(+), 57 deletions(-) > > -- > 2.11.0 > > -- > You received this message because you are subscribed to the Google Groups > "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to outreachy-kernel+unsubscr...@googlegroups.com. > To post to this group, send email to outreachy-ker...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/outreachy-kernel/20170321133021.6737-1-arushisinghal19971997%40gmail.com. > For more options, visit https://groups.google.com/d/optout. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel