Re: [PATCH] Staging: android: ion: fixed a blank line after declarations coding style issue
On Thu, Jul 09, 2015 at 08:20:57AM +0530, rcodin wrote: From: Ronit Halder ronit@gmail.com Fixed a coding style issue. Signed-off-by: Ronit Halder ronit@gmail.com --- drivers/staging/android/ion/ion.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c index 6f48112..e44f5e6 100644 --- a/drivers/staging/android/ion/ion.c +++ b/drivers/staging/android/ion/ion.c @@ -1106,6 +1106,7 @@ struct dma_buf *ion_share_dma_buf(struct ion_client *client, struct ion_buffer *buffer; struct dma_buf *dmabuf; bool valid_handle; + DEFINE_DMA_BUF_EXPORT_INFO(exp_info); This is a false positive and has been rejected so many times it's really getting old... ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] Staging: android: ion: fixed a blank line after declarations coding style issue
From: Ronit Halder ronit@gmail.com Fixed a coding style issue. Signed-off-by: Ronit Halder ronit@gmail.com --- drivers/staging/android/ion/ion.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c index 6f48112..e44f5e6 100644 --- a/drivers/staging/android/ion/ion.c +++ b/drivers/staging/android/ion/ion.c @@ -1106,6 +1106,7 @@ struct dma_buf *ion_share_dma_buf(struct ion_client *client, struct ion_buffer *buffer; struct dma_buf *dmabuf; bool valid_handle; + DEFINE_DMA_BUF_EXPORT_INFO(exp_info); mutex_lock(client-lock); -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Staging: android: ion: fixed a blank line after declarations coding style issue
On Thu, Jul 09, 2015 at 08:20:57AM +0530, rcodin wrote: From: Ronit Halder ronit@gmail.com You do not need a From: here. Please fix your gitconfig file and git send-email will give your name correctly in the email header. regards sudip ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] Staging: android: ion: fixed a blank line after declarations coding style issue
On Thu, 2015-07-09 at 11:05 +0530, Sudip Mukherjee wrote: On Thu, Jul 09, 2015 at 08:20:57AM +0530, rcodin wrote: From: Ronit Halder ronit@gmail.com You do not need a From: here. Please fix your gitconfig file and git send-email will give your name correctly in the email header. regards sudip thanks for pointing it sudip. Sorry for the stupid mistake, version 2 of the patch is coming. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
