Re: [PATCH] Staging: bmc: fix coding style warning

2014-08-15 Thread Greg KH 
On Thu, Aug 14, 2014 at 10:11:44AM -0400, Ramesh Basukala wrote:
 This is a patch to the vendorspecificextn.c that fixes coding style
 warning message line over 80 characters found by checkpatch.pl script.
 I am submitting this patch as required by Eudyptula Challenge.

Minor nit, your subject is wrong, the driver is 'bcm' not 'bmc' :)

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] Staging: bmc: fix coding style warning

2014-08-14 Thread Ramesh Basukala 
This is a patch to the vendorspecificextn.c that fixes coding style
warning message line over 80 characters found by checkpatch.pl script.
I am submitting this patch as required by Eudyptula Challenge.

Signed-off-by: Ramesh Basukala basukalaram...@gmail.com
---
 drivers/staging/bcm/vendorspecificextn.c |   19 +++
 1 files changed, 11 insertions(+), 8 deletions(-)

diff --git a/drivers/staging/bcm/vendorspecificextn.c 
b/drivers/staging/bcm/vendorspecificextn.c
index 2c57a16..1d9bef6 100644
--- a/drivers/staging/bcm/vendorspecificextn.c
+++ b/drivers/staging/bcm/vendorspecificextn.c
@@ -11,7 +11,8 @@
  * STATUS_SUCCESS/STATUS_FAILURE
  *
  */
-INT vendorextnGetSectionInfo(PVOID  pContext, struct bcm_flash2x_vendor_info 
*pVendorInfo)
+INT vendorextnGetSectionInfo(PVOID  pContext,
+   struct bcm_flash2x_vendor_info *pVendorInfo)
 {
return STATUS_FAILURE;
 }
@@ -61,7 +62,8 @@ INT vendorextnExit(struct bcm_mini_adapter *Adapter)
  * arg -input parameter sent by vendor
  *
  * Returns:
- * CONTINUE_COMMON_PATH in case it is not meant to be processed by 
vendor ioctls
+ * CONTINUE_COMMON_PATH in case it is not meant to be processed
+ * by vendor ioctls
  * STATUS_SUCCESS/STATUS_FAILURE as per the IOCTL return value
  */
 
@@ -88,8 +90,8 @@ INT vendorextnIoctl(struct bcm_mini_adapter *Adapter, UINT 
cmd, ULONG arg)
  * STATUS_SUCCESS/STATUS_FAILURE
  */
 
-INT vendorextnReadSection(PVOID  pContext, PUCHAR pBuffer, enum 
bcm_flash2x_section_val SectionVal,
-   UINT offset, UINT numOfBytes)
+INT vendorextnReadSection(PVOID  pContext, PUCHAR pBuffer,
+   enum bcm_flash2x_section_val SectionVal, UINT offset, UINT numOfBytes)
 {
return STATUS_FAILURE;
 }
@@ -112,8 +114,9 @@ INT vendorextnReadSection(PVOID  pContext, PUCHAR pBuffer, 
enum bcm_flash2x_sect
  * Returns:
  * STATUS_SUCCESS/STATUS_FAILURE
  */
-INT vendorextnWriteSection(PVOID  pContext, PUCHAR pBuffer, enum 
bcm_flash2x_section_val SectionVal,
-   UINT offset, UINT numOfBytes, bool bVerify)
+INT vendorextnWriteSection(PVOID  pContext, PUCHAR pBuffer,
+   enum bcm_flash2x_section_val SectionVal, UINT offset,
+   UINT numOfBytes, bool bVerify)
 {
return STATUS_FAILURE;
 }
@@ -135,8 +138,8 @@ INT vendorextnWriteSection(PVOID  pContext, PUCHAR pBuffer, 
enum bcm_flash2x_sec
  * Returns:
  * STATUS_SUCCESS/STATUS_FAILURE
  */
-INT vendorextnWriteSectionWithoutErase(PVOID  pContext, PUCHAR pBuffer, enum 
bcm_flash2x_section_val SectionVal,
-   UINT offset, UINT numOfBytes)
+INT vendorextnWriteSectionWithoutErase(PVOID  pContext, PUCHAR pBuffer,
+   enum bcm_flash2x_section_val SectionVal, UINT offset, UINT numOfBytes)
 {
return STATUS_FAILURE;
 }
-- 
1.7.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] Staging: bmc: fix coding style warning

2014-08-13 Thread rbasukala 
This a a patch to the vendorspecificextn.c that fixes coding style warning 
found by checkpatch.pl script. I am submitting this patch as required by 
Eudyptula Challenge.

Signed-off-by: Ramesh Basukala basukalaram...@gmail.com
---
 drivers/staging/bcm/vendorspecificextn.c |   19 +++
 1 files changed, 11 insertions(+), 8 deletions(-)

diff --git a/drivers/staging/bcm/vendorspecificextn.c 
b/drivers/staging/bcm/vendorspecificextn.c
index 2c57a16..1d9bef6 100644
--- a/drivers/staging/bcm/vendorspecificextn.c
+++ b/drivers/staging/bcm/vendorspecificextn.c
@@ -11,7 +11,8 @@
  * STATUS_SUCCESS/STATUS_FAILURE
  *
  */
-INT vendorextnGetSectionInfo(PVOID  pContext, struct bcm_flash2x_vendor_info 
*pVendorInfo)
+INT vendorextnGetSectionInfo(PVOID  pContext,
+   struct bcm_flash2x_vendor_info *pVendorInfo)
 {
return STATUS_FAILURE;
 }
@@ -61,7 +62,8 @@ INT vendorextnExit(struct bcm_mini_adapter *Adapter)
  * arg -input parameter sent by vendor
  *
  * Returns:
- * CONTINUE_COMMON_PATH in case it is not meant to be processed by 
vendor ioctls
+ * CONTINUE_COMMON_PATH in case it is not meant to be processed
+ * by vendor ioctls
  * STATUS_SUCCESS/STATUS_FAILURE as per the IOCTL return value
  */
 
@@ -88,8 +90,8 @@ INT vendorextnIoctl(struct bcm_mini_adapter *Adapter, UINT 
cmd, ULONG arg)
  * STATUS_SUCCESS/STATUS_FAILURE
  */
 
-INT vendorextnReadSection(PVOID  pContext, PUCHAR pBuffer, enum 
bcm_flash2x_section_val SectionVal,
-   UINT offset, UINT numOfBytes)
+INT vendorextnReadSection(PVOID  pContext, PUCHAR pBuffer,
+   enum bcm_flash2x_section_val SectionVal, UINT offset, UINT numOfBytes)
 {
return STATUS_FAILURE;
 }
@@ -112,8 +114,9 @@ INT vendorextnReadSection(PVOID  pContext, PUCHAR pBuffer, 
enum bcm_flash2x_sect
  * Returns:
  * STATUS_SUCCESS/STATUS_FAILURE
  */
-INT vendorextnWriteSection(PVOID  pContext, PUCHAR pBuffer, enum 
bcm_flash2x_section_val SectionVal,
-   UINT offset, UINT numOfBytes, bool bVerify)
+INT vendorextnWriteSection(PVOID  pContext, PUCHAR pBuffer,
+   enum bcm_flash2x_section_val SectionVal, UINT offset,
+   UINT numOfBytes, bool bVerify)
 {
return STATUS_FAILURE;
 }
@@ -135,8 +138,8 @@ INT vendorextnWriteSection(PVOID  pContext, PUCHAR pBuffer, 
enum bcm_flash2x_sec
  * Returns:
  * STATUS_SUCCESS/STATUS_FAILURE
  */
-INT vendorextnWriteSectionWithoutErase(PVOID  pContext, PUCHAR pBuffer, enum 
bcm_flash2x_section_val SectionVal,
-   UINT offset, UINT numOfBytes)
+INT vendorextnWriteSectionWithoutErase(PVOID  pContext, PUCHAR pBuffer,
+   enum bcm_flash2x_section_val SectionVal, UINT offset, UINT numOfBytes)
 {
return STATUS_FAILURE;
 }
-- 
1.7.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] Staging: bmc: fix coding style warning

2014-08-13 Thread Greg KH 
On Wed, Aug 13, 2014 at 11:36:59AM -0400, rbasukala wrote:
 This a a patch to the vendorspecificextn.c that fixes coding style warning 
 found by checkpatch.pl script. I am submitting this patch as required by 
 Eudyptula Challenge.

That's a very long line for a changelog entry, please wrap them at the
proper lengths.

You need to describe _what_ warning you are fixing here, please be
specific.

Can you redo this patch please?

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] Staging: bmc: fix coding style warning

2014-08-13 Thread Ramesh Basukala 
From: rbasukala basukalaram...@gmail.com

This is a patch to the vendorspecificextn.c that fixes coding style
warning message line over 80 characters found by checkpatch.pl script.
I am submitting this patch as required by Eudyptula Challenge.

Signed-off-by: Ramesh Basukala basukalaram...@gmail.com
---
 drivers/staging/bcm/vendorspecificextn.c |   19 +++
 1 files changed, 11 insertions(+), 8 deletions(-)

diff --git a/drivers/staging/bcm/vendorspecificextn.c 
b/drivers/staging/bcm/vendorspecificextn.c
index 2c57a16..1d9bef6 100644
--- a/drivers/staging/bcm/vendorspecificextn.c
+++ b/drivers/staging/bcm/vendorspecificextn.c
@@ -11,7 +11,8 @@
  * STATUS_SUCCESS/STATUS_FAILURE
  *
  */
-INT vendorextnGetSectionInfo(PVOID  pContext, struct bcm_flash2x_vendor_info 
*pVendorInfo)
+INT vendorextnGetSectionInfo(PVOID  pContext,
+   struct bcm_flash2x_vendor_info *pVendorInfo)
 {
return STATUS_FAILURE;
 }
@@ -61,7 +62,8 @@ INT vendorextnExit(struct bcm_mini_adapter *Adapter)
  * arg -input parameter sent by vendor
  *
  * Returns:
- * CONTINUE_COMMON_PATH in case it is not meant to be processed by 
vendor ioctls
+ * CONTINUE_COMMON_PATH in case it is not meant to be processed
+ * by vendor ioctls
  * STATUS_SUCCESS/STATUS_FAILURE as per the IOCTL return value
  */
 
@@ -88,8 +90,8 @@ INT vendorextnIoctl(struct bcm_mini_adapter *Adapter, UINT 
cmd, ULONG arg)
  * STATUS_SUCCESS/STATUS_FAILURE
  */
 
-INT vendorextnReadSection(PVOID  pContext, PUCHAR pBuffer, enum 
bcm_flash2x_section_val SectionVal,
-   UINT offset, UINT numOfBytes)
+INT vendorextnReadSection(PVOID  pContext, PUCHAR pBuffer,
+   enum bcm_flash2x_section_val SectionVal, UINT offset, UINT numOfBytes)
 {
return STATUS_FAILURE;
 }
@@ -112,8 +114,9 @@ INT vendorextnReadSection(PVOID  pContext, PUCHAR pBuffer, 
enum bcm_flash2x_sect
  * Returns:
  * STATUS_SUCCESS/STATUS_FAILURE
  */
-INT vendorextnWriteSection(PVOID  pContext, PUCHAR pBuffer, enum 
bcm_flash2x_section_val SectionVal,
-   UINT offset, UINT numOfBytes, bool bVerify)
+INT vendorextnWriteSection(PVOID  pContext, PUCHAR pBuffer,
+   enum bcm_flash2x_section_val SectionVal, UINT offset,
+   UINT numOfBytes, bool bVerify)
 {
return STATUS_FAILURE;
 }
@@ -135,8 +138,8 @@ INT vendorextnWriteSection(PVOID  pContext, PUCHAR pBuffer, 
enum bcm_flash2x_sec
  * Returns:
  * STATUS_SUCCESS/STATUS_FAILURE
  */
-INT vendorextnWriteSectionWithoutErase(PVOID  pContext, PUCHAR pBuffer, enum 
bcm_flash2x_section_val SectionVal,
-   UINT offset, UINT numOfBytes)
+INT vendorextnWriteSectionWithoutErase(PVOID  pContext, PUCHAR pBuffer,
+   enum bcm_flash2x_section_val SectionVal, UINT offset, UINT numOfBytes)
 {
return STATUS_FAILURE;
 }
-- 
1.7.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] Staging: bmc: fix coding style warning

2014-08-13 Thread Greg KH 
On Wed, Aug 13, 2014 at 08:53:59PM -0400, Ramesh Basukala wrote:
 From: rbasukala basukalaram...@gmail.com

This doesn't match up with your signed-off-by: line, or your name up
there in the mail header.  Please fix this up and resend.

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel