Re: [PATCH] Staging: pi433: Updated bitrate range from datasheet
On Mon, Mar 04, 2024 at 02:28:02AM +0530, Aman Sharma wrote: > From a0528708b209739f0d566401bdd428e215abf366 Mon Sep 17 00:00:00 2001 > From: Aman Sharma > Date: Mon, 4 Mar 2024 00:44:06 +0530 > Subject: [PATCH] Staging: pi433: Updated bitrate range from datasheet Why is this all here in the changelog? Also, please use scripts/get_maintainer.pl, you have sent this to an obsolete email list. > > Updated bitrate range for FSK and OOK modulation from datasheet. > > Signed-off-by: Aman Sharma > --- > drivers/staging/pi433/Documentation/pi433.txt | 6 -- > drivers/staging/pi433/TODO| 1 - > 2 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/pi433/Documentation/pi433.txt > b/drivers/staging/pi433/Documentation/pi433.txt > index 4a0d34b4ad37..9ce7282ef6f8 100644 > --- a/drivers/staging/pi433/Documentation/pi433.txt > +++ b/drivers/staging/pi433/Documentation/pi433.txt > @@ -78,7 +78,8 @@ rf params: > Allowed values: 43305...43479 > bit_rate > bit rate used for transmission. > - Allowed values: # > + Allowed values (For FSK): 1200...32 > + Allowed values (For OOK): 1200...32768 > dev_frequency > frequency deviation in case of FSK. > Allowed values: 600...50 > @@ -169,7 +170,8 @@ rf params: > Allowed values: 43305...43479 > bit_rate > bit rate used for transmission. > - Allowed values: # > + Allowed values (For FSK): 1200...32 > + Allowed values (For OOK): 1200...32768 Where did these values come from? If you can explain that in the changelog text when you resend a v2, that would be great. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] Staging: pi433: Updated bitrate range from datasheet
From a0528708b209739f0d566401bdd428e215abf366 Mon Sep 17 00:00:00 2001 From: Aman Sharma Date: Mon, 4 Mar 2024 00:44:06 +0530 Subject: [PATCH] Staging: pi433: Updated bitrate range from datasheet Updated bitrate range for FSK and OOK modulation from datasheet. Signed-off-by: Aman Sharma --- drivers/staging/pi433/Documentation/pi433.txt | 6 -- drivers/staging/pi433/TODO| 1 - 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/pi433/Documentation/pi433.txt b/drivers/staging/pi433/Documentation/pi433.txt index 4a0d34b4ad37..9ce7282ef6f8 100644 --- a/drivers/staging/pi433/Documentation/pi433.txt +++ b/drivers/staging/pi433/Documentation/pi433.txt @@ -78,7 +78,8 @@ rf params: Allowed values: 43305...43479 bit_rate bit rate used for transmission. - Allowed values: # + Allowed values (For FSK): 1200...32 + Allowed values (For OOK): 1200...32768 dev_frequency frequency deviation in case of FSK. Allowed values: 600...50 @@ -169,7 +170,8 @@ rf params: Allowed values: 43305...43479 bit_rate bit rate used for transmission. - Allowed values: # + Allowed values (For FSK): 1200...32 + Allowed values (For OOK): 1200...32768 dev_frequency frequency deviation in case of FSK. Allowed values: 600...50 diff --git a/drivers/staging/pi433/TODO b/drivers/staging/pi433/TODO index 63a40bfcc67e..61ed3a1578bc 100644 --- a/drivers/staging/pi433/TODO +++ b/drivers/staging/pi433/TODO @@ -2,4 +2,3 @@ * still TODOs, annotated in the code * currently the code introduces new IOCTLs. I'm afraid this is a bad idea. -> Replace this with another interface, hints are welcome! -* Some missing data (marked with ###) needs to be added in the documentation -- 2.34.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
