Re: [PATCH] Staging: rtl8192e: rtllib_crypt_tkip.c: Use __func__ instead of function name and proper code ident for else statement

2018-02-23 Thread Greg KH 
On Fri, Feb 23, 2018 at 12:57:16AM +0530, Debopriyo Ghosh wrote:
> From: Debopriyo 
> 
> This is a patch to the rtllib_crypt_tkip.c file that fixes 2 issues found
> by the checkpatch.pl tool
> 1.Use of __func__ instead of function name
> 2.proper code identation for else statement

When you have to list different things you are doing in a single patch,
that's a huge sign you need to break the patch up into multiple ones.

Please do that here.

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] Staging: rtl8192e: rtllib_crypt_tkip.c: Use __func__ instead of function name and proper code ident for else statement

2018-02-22 Thread Debopriyo Ghosh 
From: Debopriyo 

This is a patch to the rtllib_crypt_tkip.c file that fixes 2 issues found
by the checkpatch.pl tool
1.Use of __func__ instead of function name
2.proper code identation for else statement

Signed-off-by: Debopriyo Ghosh 
---
 drivers/staging/rtl8192e/rtllib_crypt_tkip.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtllib_crypt_tkip.c 
b/drivers/staging/rtl8192e/rtllib_crypt_tkip.c
index ae103b0..e462c1e 100644
--- a/drivers/staging/rtl8192e/rtllib_crypt_tkip.c
+++ b/drivers/staging/rtl8192e/rtllib_crypt_tkip.c
@@ -314,7 +314,7 @@ static int rtllib_tkip_encrypt(struct sk_buff *skb, int 
hdr_len, void *priv)
tkip_mixing_phase2(rc4key, tkey->key, tkey->tx_ttak,
   tkey->tx_iv16);
} else
-   tkey->tx_phase1_done = 1;
+   tkey->tx_phase1_done = 1;
 
 
len = skb->len - hdr_len;
@@ -512,7 +512,7 @@ static int michael_mic(struct crypto_ahash *tfm_michael, u8 
*key, u8 *hdr,
int err;
 
if (tfm_michael == NULL) {
-   pr_warn("michael_mic: tfm_michael == NULL\n");
+   pr_warn("%s: tfm_michael == NULL\n", __func__);
return -1;
}
sg_init_table(sg, 2);
-- 
2.7.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel