Re: [PATCH] Staging : comedi : comedidev.h Fixed warning space coding style issue

[Dan Carpenter]

On Mon, Jan 20, 2014 at 12:19:09AM -0800, Surendra Patil wrote:
> Fixed a coding style issue,removed space after the function pointer name
> 
> Signed-off-by: Surendra Patil 
> ---
>  drivers/staging/comedi/comedidev.h | 32 
>  1 file changed, 16 insertions(+), 16 deletions(-)
> 
> diff --git a/drivers/staging/comedi/comedidev.h 
> b/drivers/staging/comedi/comedidev.h
> index f82bd42..588e9e7 100644
> --- a/drivers/staging/comedi/comedidev.h
> +++ b/drivers/staging/comedi/comedidev.h
> @@ -61,29 +61,29 @@ struct comedi_subdevice {
>  
>   unsigned int *chanlist; /* driver-owned chanlist (not used) */
>  
> - int (*insn_read) (struct comedi_device *, struct comedi_subdevice *,
> + int (*insn_read)(struct comedi_device *, struct comedi_subdevice *,
> struct comedi_insn *, unsigned int *);

Now the the second line has one extra space.  The 's' characters in
"struct comedi_device *" and "struct comedi_insn *" should be on the
same column.

regards,
dan carpenter

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] Staging : comedi : comedidev.h Fixed warning space coding style issue

[Surendra Patil]

Fixed a coding style issue,removed space after the function pointer name

Signed-off-by: Surendra Patil 
---
 drivers/staging/comedi/comedidev.h | 32 
 1 file changed, 16 insertions(+), 16 deletions(-)

diff --git a/drivers/staging/comedi/comedidev.h 
b/drivers/staging/comedi/comedidev.h
index f82bd42..588e9e7 100644
--- a/drivers/staging/comedi/comedidev.h
+++ b/drivers/staging/comedi/comedidev.h
@@ -61,29 +61,29 @@ struct comedi_subdevice {
 
unsigned int *chanlist; /* driver-owned chanlist (not used) */
 
-   int (*insn_read) (struct comedi_device *, struct comedi_subdevice *,
+   int (*insn_read)(struct comedi_device *, struct comedi_subdevice *,
  struct comedi_insn *, unsigned int *);
-   int (*insn_write) (struct comedi_device *, struct comedi_subdevice *,
+   int (*insn_write)(struct comedi_device *, struct comedi_subdevice *,
   struct comedi_insn *, unsigned int *);
-   int (*insn_bits) (struct comedi_device *, struct comedi_subdevice *,
+   int (*insn_bits)(struct comedi_device *, struct comedi_subdevice *,
  struct comedi_insn *, unsigned int *);
-   int (*insn_config) (struct comedi_device *, struct comedi_subdevice *,
+   int (*insn_config)(struct comedi_device *, struct comedi_subdevice *,
struct comedi_insn *, unsigned int *);
 
-   int (*do_cmd) (struct comedi_device *, struct comedi_subdevice *);
-   int (*do_cmdtest) (struct comedi_device *, struct comedi_subdevice *,
+   int (*do_cmd)(struct comedi_device *, struct comedi_subdevice *);
+   int (*do_cmdtest)(struct comedi_device *, struct comedi_subdevice *,
   struct comedi_cmd *);
-   int (*poll) (struct comedi_device *, struct comedi_subdevice *);
-   int (*cancel) (struct comedi_device *, struct comedi_subdevice *);
+   int (*poll)(struct comedi_device *, struct comedi_subdevice *);
+   int (*cancel)(struct comedi_device *, struct comedi_subdevice *);
/* int (*do_lock)(struct comedi_device *, struct comedi_subdevice *); */
/* int (*do_unlock)(struct comedi_device *, \
struct comedi_subdevice *); */
 
/* called when the buffer changes */
-   int (*buf_change) (struct comedi_device *dev,
+   int (*buf_change)(struct comedi_device *dev,
   struct comedi_subdevice *s, unsigned long new_size);
 
-   void (*munge) (struct comedi_device *dev, struct comedi_subdevice *s,
+   void (*munge)(struct comedi_device *dev, struct comedi_subdevice *s,
   void *data, unsigned int num_bytes,
   unsigned int start_chan_index);
enum dma_data_direction async_dma_dir;
@@ -146,7 +146,7 @@ struct comedi_async {
 
unsigned int cb_mask;
 
-   int (*inttrig) (struct comedi_device *dev, struct comedi_subdevice *s,
+   int (*inttrig)(struct comedi_device *dev, struct comedi_subdevice *s,
unsigned int x);
 };
 
@@ -155,9 +155,9 @@ struct comedi_driver {
 
const char *driver_name;
struct module *module;
-   int (*attach) (struct comedi_device *, struct comedi_devconfig *);
-   void (*detach) (struct comedi_device *);
-   int (*auto_attach) (struct comedi_device *, unsigned long);
+   int (*attach)(struct comedi_device *, struct comedi_devconfig *);
+   void (*detach)(struct comedi_device *);
+   int (*auto_attach)(struct comedi_device *, unsigned long);
 
/* number of elements in board_name and board_id arrays */
unsigned int num_names;
@@ -202,8 +202,8 @@ struct comedi_device {
 
struct fasync_struct *async_queue;
 
-   int (*open) (struct comedi_device *dev);
-   void (*close) (struct comedi_device *dev);
+   int (*open)(struct comedi_device *dev);
+   void (*close)(struct comedi_device *dev);
 };
 
 static inline const void *comedi_board(const struct comedi_device *dev)
-- 
1.8.3.2

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel