Re: [PATCH] change slave occurence to secondary everywhere
The patch prefix isn't right. On Thu, Jul 23, 2020 at 08:45:13PM +0530, Rohit K Bharadwaj wrote: > changed usage of slave (deprecated) to secondary > > Signed-off-by: Rohit K Bharadwaj > --- > drivers/staging/nvec/nvec.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c > index 360ec0407740..5d7b66719a39 100644 > --- a/drivers/staging/nvec/nvec.c > +++ b/drivers/staging/nvec/nvec.c > @@ -718,7 +718,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev) > return IRQ_HANDLED; > } > > -static void tegra_init_i2c_slave(struct nvec_chip *nvec) > +static void tegra_init_i2c_secondary(struct nvec_chip *nvec) > { > u32 val; > > @@ -744,7 +744,7 @@ static void tegra_init_i2c_slave(struct nvec_chip *nvec) > } > > #ifdef CONFIG_PM_SLEEP > -static void nvec_disable_i2c_slave(struct nvec_chip *nvec) > +static void nvec_disable_i2c_secondary(struct nvec_chip *nvec) > { > disable_irq(nvec->irq); > writel(I2C_SL_NEWSL | I2C_SL_NACK, nvec->base + I2C_SL_CNFG); > @@ -784,7 +784,7 @@ static int tegra_nvec_probe(struct platform_device *pdev) > platform_set_drvdata(pdev, nvec); > nvec->dev = dev; > > - if (of_property_read_u32(dev->of_node, "slave-addr", &nvec->i2c_addr)) { > + if (of_property_read_u32(dev->of_node, "secondary-addr", > &nvec->i2c_addr)) { Be careful not to break the driver. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] change slave occurence to secondary everywhere
On Thu, Jul 23, 2020 at 08:28:11PM +0530, Rohit K Bharadwaj wrote: > @@ -744,7 +744,7 @@ static void tegra_init_i2c_slave(struct nvec_chip *nvec) > } > > #ifdef CONFIG_PM_SLEEP > -static void nvec_disable_i2c_slave(struct nvec_chip *nvec) > +static void nvec_disable_i2c_secondary(struct nvec_chip *nvec) > { > disable_irq(nvec->irq); > writel(I2C_SL_NEWSL | I2C_SL_NACK, nvec->base + I2C_SL_CNFG); > @@ -784,7 +784,7 @@ static int tegra_nvec_probe(struct platform_device *pdev) > platform_set_drvdata(pdev, nvec); > nvec->dev = dev; > > - if (of_property_read_u32(dev->of_node, "slave-addr", &nvec->i2c_addr)) { > + if (of_property_read_u32(dev->of_node, "secondary-addr", > &nvec->i2c_addr)) { This change will break the driver. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] change slave occurence to secondary everywhere
On 23/07/20 10:36 pm, Greg KH wrote: > On Thu, Jul 23, 2020 at 08:45:13PM +0530, Rohit K Bharadwaj wrote: >> changed usage of slave (deprecated) to secondary >> >> Signed-off-by: Rohit K Bharadwaj >> --- >> drivers/staging/nvec/nvec.c | 12 ++-- >> 1 file changed, 6 insertions(+), 6 deletions(-) > > Odd subject line, you should follow the other patches for this driver: > staging: nvec: one_line_description_here > > Also, you need to version your patches, this was v2, right? Put below > the --- line what you changed for each version. > > v3? > > thanks, > > greg k-h > Thank you so much for the suggestions sir, I have made all the necessary changes and have submitted the patch again, I apologize for any inconvenience caused from my side. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] change slave occurence to secondary everywhere
On Thu, Jul 23, 2020 at 08:45:13PM +0530, Rohit K Bharadwaj wrote: > changed usage of slave (deprecated) to secondary > > Signed-off-by: Rohit K Bharadwaj > --- > drivers/staging/nvec/nvec.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) Odd subject line, you should follow the other patches for this driver: staging: nvec: one_line_description_here Also, you need to version your patches, this was v2, right? Put below the --- line what you changed for each version. v3? thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] change slave occurence to secondary everywhere
changed usage of slave (deprecated) to secondary Signed-off-by: Rohit K Bharadwaj --- drivers/staging/nvec/nvec.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c index 360ec0407740..5d7b66719a39 100644 --- a/drivers/staging/nvec/nvec.c +++ b/drivers/staging/nvec/nvec.c @@ -718,7 +718,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev) return IRQ_HANDLED; } -static void tegra_init_i2c_slave(struct nvec_chip *nvec) +static void tegra_init_i2c_secondary(struct nvec_chip *nvec) { u32 val; @@ -744,7 +744,7 @@ static void tegra_init_i2c_slave(struct nvec_chip *nvec) } #ifdef CONFIG_PM_SLEEP -static void nvec_disable_i2c_slave(struct nvec_chip *nvec) +static void nvec_disable_i2c_secondary(struct nvec_chip *nvec) { disable_irq(nvec->irq); writel(I2C_SL_NEWSL | I2C_SL_NACK, nvec->base + I2C_SL_CNFG); @@ -784,7 +784,7 @@ static int tegra_nvec_probe(struct platform_device *pdev) platform_set_drvdata(pdev, nvec); nvec->dev = dev; - if (of_property_read_u32(dev->of_node, "slave-addr", &nvec->i2c_addr)) { + if (of_property_read_u32(dev->of_node, "secondary-addr", &nvec->i2c_addr)) { dev_err(dev, "no i2c address specified"); return -ENODEV; } @@ -839,7 +839,7 @@ static int tegra_nvec_probe(struct platform_device *pdev) } disable_irq(nvec->irq); - tegra_init_i2c_slave(nvec); + tegra_init_i2c_secondary(nvec); /* enable event reporting */ nvec_toggle_global_events(nvec, true); @@ -913,7 +913,7 @@ static int nvec_suspend(struct device *dev) if (!err) nvec_msg_free(nvec, msg); - nvec_disable_i2c_slave(nvec); + nvec_disable_i2c_secondary(nvec); return 0; } @@ -923,7 +923,7 @@ static int nvec_resume(struct device *dev) struct nvec_chip *nvec = dev_get_drvdata(dev); dev_dbg(nvec->dev, "resuming\n"); - tegra_init_i2c_slave(nvec); + tegra_init_i2c_secondary(nvec); nvec_toggle_global_events(nvec, true); return 0; -- 2.25.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] change slave occurence to secondary everywhere
On Thu, Jul 23, 2020 at 08:28:11PM +0530, Rohit K Bharadwaj wrote: > Signed-off-by: Rohit K Bharadwaj I can't take patches without any changelog text :( ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] change slave occurence to secondary everywhere
Signed-off-by: Rohit K Bharadwaj --- drivers/staging/nvec/nvec.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c index 360ec0407740..5d7b66719a39 100644 --- a/drivers/staging/nvec/nvec.c +++ b/drivers/staging/nvec/nvec.c @@ -718,7 +718,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev) return IRQ_HANDLED; } -static void tegra_init_i2c_slave(struct nvec_chip *nvec) +static void tegra_init_i2c_secondary(struct nvec_chip *nvec) { u32 val; @@ -744,7 +744,7 @@ static void tegra_init_i2c_slave(struct nvec_chip *nvec) } #ifdef CONFIG_PM_SLEEP -static void nvec_disable_i2c_slave(struct nvec_chip *nvec) +static void nvec_disable_i2c_secondary(struct nvec_chip *nvec) { disable_irq(nvec->irq); writel(I2C_SL_NEWSL | I2C_SL_NACK, nvec->base + I2C_SL_CNFG); @@ -784,7 +784,7 @@ static int tegra_nvec_probe(struct platform_device *pdev) platform_set_drvdata(pdev, nvec); nvec->dev = dev; - if (of_property_read_u32(dev->of_node, "slave-addr", &nvec->i2c_addr)) { + if (of_property_read_u32(dev->of_node, "secondary-addr", &nvec->i2c_addr)) { dev_err(dev, "no i2c address specified"); return -ENODEV; } @@ -839,7 +839,7 @@ static int tegra_nvec_probe(struct platform_device *pdev) } disable_irq(nvec->irq); - tegra_init_i2c_slave(nvec); + tegra_init_i2c_secondary(nvec); /* enable event reporting */ nvec_toggle_global_events(nvec, true); @@ -913,7 +913,7 @@ static int nvec_suspend(struct device *dev) if (!err) nvec_msg_free(nvec, msg); - nvec_disable_i2c_slave(nvec); + nvec_disable_i2c_secondary(nvec); return 0; } @@ -923,7 +923,7 @@ static int nvec_resume(struct device *dev) struct nvec_chip *nvec = dev_get_drvdata(dev); dev_dbg(nvec->dev, "resuming\n"); - tegra_init_i2c_slave(nvec); + tegra_init_i2c_secondary(nvec); nvec_toggle_global_events(nvec, true); return 0; -- 2.25.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel