Re: [PATCH] drivers: dwc2: Mark function as static in core.c

2014-01-08 Thread Greg Kroah-Hartman 
On Sat, Dec 21, 2013 at 03:50:29PM +0530, Rashika Kheria wrote:
 Mark function dwc2_set_param_uframe_sched() as static in core.c because
 it is not used outside this file.
 
 This eliminates the following warning in core.c:
 drivers/staging/dwc2/core.c:2739:5: warning: no previous prototype for 
 ‘dwc2_set_param_uframe_sched’ [-Wmissing-prototypes]
 
 Signed-off-by: Rashika Kheria rashika.khe...@gmail.com

This patch doesn't apply to my tree.

And please stop sending patches in base64 mode, it makes it impossible
to add reviewed-by: markings to them.

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] drivers: dwc2: Mark function as static in core.c

2013-12-21 Thread Josh Triplett 
On Sat, Dec 21, 2013 at 03:50:29PM +0530, Rashika Kheria wrote:
 Mark function dwc2_set_param_uframe_sched() as static in core.c because
 it is not used outside this file.
 
 This eliminates the following warning in core.c:
 drivers/staging/dwc2/core.c:2739:5: warning: no previous prototype for 
 ‘dwc2_set_param_uframe_sched’ [-Wmissing-prototypes]
 
 Signed-off-by: Rashika Kheria rashika.khe...@gmail.com

Reviewed-by: Josh Triplett j...@joshtriplett.org

  drivers/staging/dwc2/core.c |2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
 
 diff --git a/drivers/staging/dwc2/core.c b/drivers/staging/dwc2/core.c
 index 6d001b5..c029cb6 100644
 --- a/drivers/staging/dwc2/core.c
 +++ b/drivers/staging/dwc2/core.c
 @@ -2736,7 +2736,7 @@ int dwc2_get_hwparams(struct dwc2_hsotg *hsotg)
   return 0;
  }
  
 -int dwc2_set_param_uframe_sched(struct dwc2_hsotg *hsotg, int val)
 +static int dwc2_set_param_uframe_sched(struct dwc2_hsotg *hsotg, int val)
  {
   int retval = 0;
  
 -- 
 1.7.9.5
 
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel