Re: [PATCH] netvsc: fix dereference before null check errors
From: Haiyang Zhang <haiya...@microsoft.com> Date: Mon, 27 Mar 2017 00:50:27 + > > >> -Original Message- >> From: Colin King [mailto:colin.k...@canonical.com] >> Sent: Saturday, March 25, 2017 10:27 AM >> To: KY Srinivasan <k...@microsoft.com>; Haiyang Zhang >> <haiya...@microsoft.com>; Stephen Hemminger <sthem...@microsoft.com>; >> de...@linuxdriverproject.org; net...@vger.kernel.org >> Cc: kernel-janit...@vger.kernel.org; linux-ker...@vger.kernel.org >> Subject: [PATCH] netvsc: fix dereference before null check errors >> >> From: Colin Ian King <colin.k...@canonical.com> >> >> ndev is being checked to see if it is a null pointer however before >> the null check ndev is being dereferenced; hence there is a potential >> null pointer dereference bug that needs fixing. Fix this by only >> dereferencing ndev after the null check. >> >> Detected by CoverityScan, CID#1420760, CID#140761 ("Dereference >> before null check") >> >> Signed-off-by: Colin Ian King <colin.k...@canonical.com> > > Reviewed-by: Haiyang Zhang <haiya...@microsoft.com> Applied. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
RE: [PATCH] netvsc: fix dereference before null check errors
> -Original Message- > From: Colin King [mailto:colin.k...@canonical.com] > Sent: Saturday, March 25, 2017 10:27 AM > To: KY Srinivasan <k...@microsoft.com>; Haiyang Zhang > <haiya...@microsoft.com>; Stephen Hemminger <sthem...@microsoft.com>; > de...@linuxdriverproject.org; net...@vger.kernel.org > Cc: kernel-janit...@vger.kernel.org; linux-ker...@vger.kernel.org > Subject: [PATCH] netvsc: fix dereference before null check errors > > From: Colin Ian King <colin.k...@canonical.com> > > ndev is being checked to see if it is a null pointer however before > the null check ndev is being dereferenced; hence there is a potential > null pointer dereference bug that needs fixing. Fix this by only > dereferencing ndev after the null check. > > Detected by CoverityScan, CID#1420760, CID#140761 ("Dereference > before null check") > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Reviewed-by: Haiyang Zhang <haiya...@microsoft.com> Thank you! ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] netvsc: fix dereference before null check errors
From: Colin Ian Kingndev is being checked to see if it is a null pointer however before the null check ndev is being dereferenced; hence there is a potential null pointer dereference bug that needs fixing. Fix this by only dereferencing ndev after the null check. Detected by CoverityScan, CID#1420760, CID#140761 ("Dereference before null check") Signed-off-by: Colin Ian King --- drivers/net/hyperv/netvsc_drv.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c index f830bbbd8ad4..f24c2891dd0c 100644 --- a/drivers/net/hyperv/netvsc_drv.c +++ b/drivers/net/hyperv/netvsc_drv.c @@ -1135,7 +1135,7 @@ static int netvsc_get_rxfh(struct net_device *dev, u32 *indir, u8 *key, { struct net_device_context *ndc = netdev_priv(dev); struct netvsc_device *ndev = rcu_dereference(ndc->nvdev); - struct rndis_device *rndis_dev = ndev->extension; + struct rndis_device *rndis_dev; int i; if (!ndev) @@ -1144,6 +1144,7 @@ static int netvsc_get_rxfh(struct net_device *dev, u32 *indir, u8 *key, if (hfunc) *hfunc = ETH_RSS_HASH_TOP; /* Toeplitz */ + rndis_dev = ndev->extension; if (indir) { for (i = 0; i < ITAB_NUM; i++) indir[i] = rndis_dev->ind_table[i]; @@ -1160,7 +1161,7 @@ static int netvsc_set_rxfh(struct net_device *dev, const u32 *indir, { struct net_device_context *ndc = netdev_priv(dev); struct netvsc_device *ndev = rtnl_dereference(ndc->nvdev); - struct rndis_device *rndis_dev = ndev->extension; + struct rndis_device *rndis_dev; int i; if (!ndev) @@ -1169,6 +1170,7 @@ static int netvsc_set_rxfh(struct net_device *dev, const u32 *indir, if (hfunc != ETH_RSS_HASH_NO_CHANGE && hfunc != ETH_RSS_HASH_TOP) return -EOPNOTSUPP; + rndis_dev = ndev->extension; if (indir) { for (i = 0; i < ITAB_NUM; i++) if (indir[i] >= dev->num_rx_queues) -- 2.11.0 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel