[PATCH] staging: davinci_vpfe: fix error check

2014-02-15 Thread Levente Kurusa 
The check would check the pointer, which is never less than 0.
According to the error message, the correct check would be
to check the return value of ipipe_mode. Check that instead.

Reported-by: David Binderman dcb...@hotmail.com
Signed-off-by: Levente Kurusa le...@linux.com
---
 drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c 
b/drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c
index 2d36b60..b2daf5e 100644
--- a/drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c
+++ b/drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c
@@ -267,7 +267,7 @@ int config_ipipe_hw(struct vpfe_ipipe_device *ipipe)
}
 
ipipe_mode = get_ipipe_mode(ipipe);
-   if (ipipe  0) {
+   if (ipipe_mode  0) {
pr_err(Failed to get ipipe mode);
return -EINVAL;
}
-- 
1.8.3.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: davinci_vpfe: fix error check

2014-02-15 Thread Josh Triplett 
On Sat, Feb 15, 2014 at 11:17:11AM +0100, Levente Kurusa wrote:
 The check would check the pointer, which is never less than 0.
 According to the error message, the correct check would be
 to check the return value of ipipe_mode. Check that instead.
 
 Reported-by: David Binderman dcb...@hotmail.com
 Signed-off-by: Levente Kurusa le...@linux.com

Reviewed-by: Josh Triplett j...@joshtriplett.org

  drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
 
 diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c 
 b/drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c
 index 2d36b60..b2daf5e 100644
 --- a/drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c
 +++ b/drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c
 @@ -267,7 +267,7 @@ int config_ipipe_hw(struct vpfe_ipipe_device *ipipe)
   }
  
   ipipe_mode = get_ipipe_mode(ipipe);
 - if (ipipe  0) {
 + if (ipipe_mode  0) {
   pr_err(Failed to get ipipe mode);
   return -EINVAL;
   }
 -- 
 1.8.3.1
 
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel