[PATCH] staging: dgnc: Fix multi-line comment alignment
This fixes a checkpatch warning.
Also, change the line above so it is aligned to the others in the
same block.
Signed-off-by: Fernando Apesteguia
---
drivers/staging/dgnc/digi.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/dgnc/digi.h b/drivers/staging/dgnc/digi.h
index 5b983e6..4e36573 100644
--- a/drivers/staging/dgnc/digi.h
+++ b/drivers/staging/dgnc/digi.h
@@ -44,11 +44,11 @@
#define DIGI_SETA (('e' << 8) | 95) /* Set params */
#define DIGI_SETAW (('e' << 8) | 96) /* Drain & set params */
#define DIGI_SETAF (('e' << 8) | 97) /* Drain, flush & set params */
-#define DIGI_GET_NI_INFO (('d' << 8) | 250) /* Non-intelligent state info */
-#define DIGI_LOOPBACK (('d' << 8) | 252) /*
- * Enable/disable UART
- * internal loopback
- */
+#define DIGI_GET_NI_INFO (('d' << 8) | 250)/* Non-intelligent state info */
+#define DIGI_LOOPBACK (('d' << 8) | 252) /*
+* Enable/disable UART
+* internal loopback
+*/
#define DIGI_FAST 0x0002 /* Fast baud rates */
#define RTSPACE0x0004 /* RTS input flow control
*/
#define CTSPACE0x0008 /* CTS output flow control
*/
--
2.7.4
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: dgnc: Fix multi line comment alignment
On Tue, Sep 06, 2016 at 03:19:03PM +0200, Fernando Apesteguia wrote: > Sorry, but I fail to see how I can align all the lines by changing just the > first and last ones. Ah now I see that original version doesn't have spaces before asterisk. Sorry for noise. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: dgnc: Fix multi line comment alignment
On Mon, Sep 05, 2016 at 11:45:30PM +0300, Andrey Utkin wrote:
> On Mon, Sep 05, 2016 at 08:28:32PM +0200, Fernando Apesteguia wrote:
> > Fix alignment in multi line comment block.
> >
> > Remove extra '*' to use the preferred comment style as in
> > Documentation/CodingStyle
> >
> > Signed-off-by: Fernando Apesteguia
> >
> > ---
> > drivers/staging/dgnc/dgnc_driver.c | 50
> > +++---
> > 1 file changed, 25 insertions(+), 25 deletions(-)
> >
> > diff --git a/drivers/staging/dgnc/dgnc_driver.c
> > b/drivers/staging/dgnc/dgnc_driver.c
> > index cc6105a..01e948c 100644
> > --- a/drivers/staging/dgnc/dgnc_driver.c
> > +++ b/drivers/staging/dgnc/dgnc_driver.c
> > @@ -602,31 +602,31 @@ static void dgnc_do_remap(struct dgnc_board *brd)
> > brd->re_map_membase = ioremap(brd->membase, 0x1000);
> > }
> >
> > -/*
> > -*
> > -* Function:
> > -*
> > -*dgnc_poll_handler
> > -*
> > -* Author:
> > -*
> > -*Scott H Kilau
> > -*
> > -* Parameters:
> > -*
> > -*dummy -- ignored
> > -*
> > -* Return Values:
> > -*
> > -*none
> > -*
> > -* Description:
> > -*
> > -*As each timer expires, it determines (a) whether the "transmit"
> > -*waiter needs to be woken up, and (b) whether the poller needs to
> > -*be rescheduled.
> > -*
> > -**/
> > +/*
> > + *
> > + * Function:
> > + *
> > + *dgnc_poll_handler
> > + *
> > + * Author:
> > + *
> > + *Scott H Kilau
> > + *
> > + * Parameters:
> > + *
> > + *dummy -- ignored
> > + *
> > + * Return Values:
> > + *
> > + *none
> > + *
> > + * Description:
> > + *
> > + *As each timer expires, it determines (a) whether the "transmit"
> > + *waiter needs to be woken up, and (b) whether the poller needs to
> > + *be rescheduled.
> > + *
> > + */
> >
> > static void dgnc_poll_handler(ulong dummy)
> > {
> > --
> > 2.7.4
>
> Changing first and last lines of that comment should be enough, but all
> lines got changed. I'd (re)submit it with just first and last lines
> changed.
Sorry, but I fail to see how I can align all the lines by changing just the
first and last ones.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: dgnc: Fix multi line comment alignment
On Mon, Sep 05, 2016 at 08:28:32PM +0200, Fernando Apesteguia wrote:
> Fix alignment in multi line comment block.
>
> Remove extra '*' to use the preferred comment style as in
> Documentation/CodingStyle
>
> Signed-off-by: Fernando Apesteguia
>
> ---
> drivers/staging/dgnc/dgnc_driver.c | 50
> +++---
> 1 file changed, 25 insertions(+), 25 deletions(-)
>
> diff --git a/drivers/staging/dgnc/dgnc_driver.c
> b/drivers/staging/dgnc/dgnc_driver.c
> index cc6105a..01e948c 100644
> --- a/drivers/staging/dgnc/dgnc_driver.c
> +++ b/drivers/staging/dgnc/dgnc_driver.c
> @@ -602,31 +602,31 @@ static void dgnc_do_remap(struct dgnc_board *brd)
> brd->re_map_membase = ioremap(brd->membase, 0x1000);
> }
>
> -/*
> -*
> -* Function:
> -*
> -*dgnc_poll_handler
> -*
> -* Author:
> -*
> -*Scott H Kilau
> -*
> -* Parameters:
> -*
> -*dummy -- ignored
> -*
> -* Return Values:
> -*
> -*none
> -*
> -* Description:
> -*
> -*As each timer expires, it determines (a) whether the "transmit"
> -*waiter needs to be woken up, and (b) whether the poller needs to
> -*be rescheduled.
> -*
> -**/
> +/*
> + *
> + * Function:
> + *
> + *dgnc_poll_handler
> + *
> + * Author:
> + *
> + *Scott H Kilau
> + *
> + * Parameters:
> + *
> + *dummy -- ignored
> + *
> + * Return Values:
> + *
> + *none
> + *
> + * Description:
> + *
> + *As each timer expires, it determines (a) whether the "transmit"
> + *waiter needs to be woken up, and (b) whether the poller needs to
> + *be rescheduled.
> + *
> + */
>
> static void dgnc_poll_handler(ulong dummy)
> {
> --
> 2.7.4
Changing first and last lines of that comment should be enough, but all
lines got changed. I'd (re)submit it with just first and last lines
changed.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: dgnc: Fix multi line comment alignment
Fix alignment in multi line comment block.
Remove extra '*' to use the preferred comment style as in
Documentation/CodingStyle
Signed-off-by: Fernando Apesteguia
---
drivers/staging/dgnc/dgnc_driver.c | 50 +++---
1 file changed, 25 insertions(+), 25 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_driver.c
b/drivers/staging/dgnc/dgnc_driver.c
index cc6105a..01e948c 100644
--- a/drivers/staging/dgnc/dgnc_driver.c
+++ b/drivers/staging/dgnc/dgnc_driver.c
@@ -602,31 +602,31 @@ static void dgnc_do_remap(struct dgnc_board *brd)
brd->re_map_membase = ioremap(brd->membase, 0x1000);
}
-/*
-*
-* Function:
-*
-*dgnc_poll_handler
-*
-* Author:
-*
-*Scott H Kilau
-*
-* Parameters:
-*
-*dummy -- ignored
-*
-* Return Values:
-*
-*none
-*
-* Description:
-*
-*As each timer expires, it determines (a) whether the "transmit"
-*waiter needs to be woken up, and (b) whether the poller needs to
-*be rescheduled.
-*
-**/
+/*
+ *
+ * Function:
+ *
+ *dgnc_poll_handler
+ *
+ * Author:
+ *
+ *Scott H Kilau
+ *
+ * Parameters:
+ *
+ *dummy -- ignored
+ *
+ * Return Values:
+ *
+ *none
+ *
+ * Description:
+ *
+ *As each timer expires, it determines (a) whether the "transmit"
+ *waiter needs to be woken up, and (b) whether the poller needs to
+ *be rescheduled.
+ *
+ */
static void dgnc_poll_handler(ulong dummy)
{
--
2.7.4
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
