[PATCH] staging: dgnc: remove DPR Macros and related codes.

2014-08-19 Thread Seunghun Lee 
In dgnc_drivers.h, DPR macro and DPR_* macros are defined but do nothing.

So remove them and related codes.

CC: Lidza Louina 
CC: Mark Hounschell 
Signed-off-by: Seunghun Lee 
---
 drivers/staging/dgnc/dgnc_cls.c|   51 
 drivers/staging/dgnc/dgnc_driver.c |   19 +--
 drivers/staging/dgnc/dgnc_driver.h |   21 ---
 drivers/staging/dgnc/dgnc_mgmt.c   |   23 
 drivers/staging/dgnc/dgnc_neo.c|  104 ++-
 drivers/staging/dgnc/dgnc_tty.c|  249 +++-
 6 files changed, 29 insertions(+), 438 deletions(-)

diff --git a/drivers/staging/dgnc/dgnc_cls.c b/drivers/staging/dgnc/dgnc_cls.c
index fe099c6..84b1377 100644
--- a/drivers/staging/dgnc/dgnc_cls.c
+++ b/drivers/staging/dgnc/dgnc_cls.c
@@ -99,7 +99,6 @@ static inline void cls_set_cts_flow_control(struct channel_t 
*ch)
uchar ier = readb(&ch->ch_cls_uart->ier);
uchar isr_fcr = 0;
 
-   DPR_PARAM(("Setting CTSFLOW\n"));
 
/*
 * The Enhanced Register Set may only be accessed when
@@ -144,7 +143,6 @@ static inline void cls_set_ixon_flow_control(struct 
channel_t *ch)
uchar ier = readb(&ch->ch_cls_uart->ier);
uchar isr_fcr = 0;
 
-   DPR_PARAM(("Setting IXON FLOW\n"));
 
/*
 * The Enhanced Register Set may only be accessed when
@@ -193,7 +191,6 @@ static inline void cls_set_no_output_flow_control(struct 
channel_t *ch)
uchar ier = readb(&ch->ch_cls_uart->ier);
uchar isr_fcr = 0;
 
-   DPR_PARAM(("Unsetting Output FLOW\n"));
 
/*
 * The Enhanced Register Set may only be accessed when
@@ -240,7 +237,6 @@ static inline void cls_set_rts_flow_control(struct 
channel_t *ch)
uchar ier = readb(&ch->ch_cls_uart->ier);
uchar isr_fcr = 0;
 
-   DPR_PARAM(("Setting RTSFLOW\n"));
 
/*
 * The Enhanced Register Set may only be accessed when
@@ -283,7 +279,6 @@ static inline void cls_set_ixoff_flow_control(struct 
channel_t *ch)
uchar ier = readb(&ch->ch_cls_uart->ier);
uchar isr_fcr = 0;
 
-   DPR_PARAM(("Setting IXOFF FLOW\n"));
 
/*
 * The Enhanced Register Set may only be accessed when
@@ -328,7 +323,6 @@ static inline void cls_set_no_input_flow_control(struct 
channel_t *ch)
uchar ier = readb(&ch->ch_cls_uart->ier);
uchar isr_fcr = 0;
 
-   DPR_PARAM(("Unsetting Input FLOW\n"));
 
/*
 * The Enhanced Register Set may only be accessed when
@@ -394,8 +388,6 @@ static inline void cls_clear_break(struct channel_t *ch, 
int force)
writeb((temp & ~UART_LCR_SBC), &ch->ch_cls_uart->lcr);
ch->ch_flags &= ~(CH_BREAK_SENDING);
ch->ch_stop_sending_break = 0;
-   DPR_IOCTL(("Finishing UART_LCR_SBC! finished: %lx\n",
-   jiffies));
}
}
DGNC_UNLOCK(ch->ch_lock, lock_flags);
@@ -430,9 +422,6 @@ static inline void cls_parse_isr(struct dgnc_board *brd, 
uint port)
if (isr & UART_IIR_NO_INT)
break;
 
-   DPR_INTR(("%s:%d port: %x isr: %x\n", __FILE__, __LINE__,
-port, isr));
-
/* Receive Interrupt pending */
if (isr & (UART_IIR_RDI | UART_IIR_RDI_TIMEOUT)) {
/* Read data from uart -> queue */
@@ -464,7 +453,6 @@ static inline void cls_parse_isr(struct dgnc_board *brd, 
uint port)
}
 
/* Parse any modem signal changes */
-   DPR_INTR(("MOD_STAT: sending to parse_modem_sigs\n"));
cls_parse_modem(ch, readb(&ch->ch_cls_uart->msr));
}
 }
@@ -501,10 +489,6 @@ static void cls_param(struct tty_struct *tty)
if (!bd || bd->magic != DGNC_BOARD_MAGIC)
return;
 
-   DPR_PARAM(("param start: tdev: %x cflags: %x oflags: %x iflags: %x\n",
-   ch->ch_tun.un_dev, ch->ch_c_cflag, ch->ch_c_oflag,
-ch->ch_c_iflag));
-
/*
 * If baud rate is zero, flush queues, and set mval to drop DTR.
 */
@@ -588,8 +572,6 @@ static void cls_param(struct tty_struct *tty)
(jindex < 16)) {
baud = bauds[iindex][jindex];
} else {
-   DPR_IOCTL(("baud indices were out of range (%d)(%d)",
-   iindex, jindex));
baud = 0;
}
 
@@ -840,14 +822,10 @@ static irqreturn_t cls_intr(int irq, void *voidbrd)
 
/* If 0, no interrupts pending */
if (!poll_reg) {
-   DPR_INTR((
-"Kernel interrupted to me, but no pending 
interrupts...\n"));
DGNC_UNLOCK(brd->bd_intr_lock, lock_flags);

Re: [PATCH] staging: dgnc: remove DPR Macros and related codes.

2014-08-15 Thread Seunghun Lee 

On 08/15/2014 03:08 PM, Greg KH wrote:
> On Tue, Aug 12, 2014 at 10:30:14PM +0900, Seunghun Lee wrote:
>> In dgnc_drivers.h, DPR macro and DPR_* macros are defined but do nothing.
>>
>> So remove them and related codes.
>>
>> CC: Lidza Louina 
>> CC: Mark Hounschell 
>> Signed-off-by: Seunghun Lee 
>> ---
>>  drivers/staging/dgnc/dgnc_cls.c|   63 +
>>  drivers/staging/dgnc/dgnc_driver.c |   20 +--
>>  drivers/staging/dgnc/dgnc_driver.h |   21 ---
>>  drivers/staging/dgnc/dgnc_mgmt.c   |   23 
>>  drivers/staging/dgnc/dgnc_neo.c|  104 ++-
>>  drivers/staging/dgnc/dgnc_tty.c|  249 
>> +++-
>>  6 files changed, 36 insertions(+), 444 deletions(-)
> This conflicts with patches others have sent, can you refresh it after
> next Tuesday or so when I catch up with the pending patches and can push
> them out?
>
> thanks,
>
> greg k-h
Ok, I will refresh it after next Tuesday.

Thanks.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: dgnc: remove DPR Macros and related codes.

2014-08-15 Thread Greg KH 
On Tue, Aug 12, 2014 at 10:30:14PM +0900, Seunghun Lee wrote:
> In dgnc_drivers.h, DPR macro and DPR_* macros are defined but do nothing.
> 
> So remove them and related codes.
> 
> CC: Lidza Louina 
> CC: Mark Hounschell 
> Signed-off-by: Seunghun Lee 
> ---
>  drivers/staging/dgnc/dgnc_cls.c|   63 +
>  drivers/staging/dgnc/dgnc_driver.c |   20 +--
>  drivers/staging/dgnc/dgnc_driver.h |   21 ---
>  drivers/staging/dgnc/dgnc_mgmt.c   |   23 
>  drivers/staging/dgnc/dgnc_neo.c|  104 ++-
>  drivers/staging/dgnc/dgnc_tty.c|  249 
> +++-
>  6 files changed, 36 insertions(+), 444 deletions(-)

This conflicts with patches others have sent, can you refresh it after
next Tuesday or so when I catch up with the pending patches and can push
them out?

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: dgnc: remove DPR Macros and related codes.

2014-08-12 Thread Seunghun Lee 
In dgnc_drivers.h, DPR macro and DPR_* macros are defined but do nothing.

So remove them and related codes.

CC: Lidza Louina 
CC: Mark Hounschell 
Signed-off-by: Seunghun Lee 
---
 drivers/staging/dgnc/dgnc_cls.c|   63 +
 drivers/staging/dgnc/dgnc_driver.c |   20 +--
 drivers/staging/dgnc/dgnc_driver.h |   21 ---
 drivers/staging/dgnc/dgnc_mgmt.c   |   23 
 drivers/staging/dgnc/dgnc_neo.c|  104 ++-
 drivers/staging/dgnc/dgnc_tty.c|  249 +++-
 6 files changed, 36 insertions(+), 444 deletions(-)

diff --git a/drivers/staging/dgnc/dgnc_cls.c b/drivers/staging/dgnc/dgnc_cls.c
index cfa8384..8ff39e6 100644
--- a/drivers/staging/dgnc/dgnc_cls.c
+++ b/drivers/staging/dgnc/dgnc_cls.c
@@ -99,8 +99,7 @@ static inline void cls_set_cts_flow_control(struct channel_t 
*ch)
uchar ier = readb(&ch->ch_cls_uart->ier);
uchar isr_fcr = 0;
 
-   DPR_PARAM(("Setting CTSFLOW\n"));
-
+
/*
 * The Enhanced Register Set may only be accessed when
 * the Line Control Register is set to 0xBFh.
@@ -144,8 +143,7 @@ static inline void cls_set_ixon_flow_control(struct 
channel_t *ch)
uchar ier = readb(&ch->ch_cls_uart->ier);
uchar isr_fcr = 0;
 
-   DPR_PARAM(("Setting IXON FLOW\n"));
-
+
/*
 * The Enhanced Register Set may only be accessed when
 * the Line Control Register is set to 0xBFh.
@@ -193,8 +191,7 @@ static inline void cls_set_no_output_flow_control(struct 
channel_t *ch)
uchar ier = readb(&ch->ch_cls_uart->ier);
uchar isr_fcr = 0;
 
-   DPR_PARAM(("Unsetting Output FLOW\n"));
-
+
/*
 * The Enhanced Register Set may only be accessed when
 * the Line Control Register is set to 0xBFh.
@@ -240,8 +237,7 @@ static inline void cls_set_rts_flow_control(struct 
channel_t *ch)
uchar ier = readb(&ch->ch_cls_uart->ier);
uchar isr_fcr = 0;
 
-   DPR_PARAM(("Setting RTSFLOW\n"));
-
+
/*
 * The Enhanced Register Set may only be accessed when
 * the Line Control Register is set to 0xBFh.
@@ -283,8 +279,7 @@ static inline void cls_set_ixoff_flow_control(struct 
channel_t *ch)
uchar ier = readb(&ch->ch_cls_uart->ier);
uchar isr_fcr = 0;
 
-   DPR_PARAM(("Setting IXOFF FLOW\n"));
-
+
/*
 * The Enhanced Register Set may only be accessed when
 * the Line Control Register is set to 0xBFh.
@@ -328,8 +323,7 @@ static inline void cls_set_no_input_flow_control(struct 
channel_t *ch)
uchar ier = readb(&ch->ch_cls_uart->ier);
uchar isr_fcr = 0;
 
-   DPR_PARAM(("Unsetting Input FLOW\n"));
-
+
/*
 * The Enhanced Register Set may only be accessed when
 * the Line Control Register is set to 0xBFh.
@@ -393,8 +387,6 @@ static inline void cls_clear_break(struct channel_t *ch, 
int force)
writeb((temp & ~UART_LCR_SBC), &ch->ch_cls_uart->lcr);
ch->ch_flags &= ~(CH_BREAK_SENDING);
ch->ch_stop_sending_break = 0;
-   DPR_IOCTL(("Finishing UART_LCR_SBC! finished: %lx\n",
-   jiffies));
}
}
DGNC_UNLOCK(ch->ch_lock, lock_flags);
@@ -429,9 +421,6 @@ static inline void cls_parse_isr(struct dgnc_board *brd, 
uint port)
if (isr & UART_IIR_NO_INT)
break;
 
-   DPR_INTR(("%s:%d port: %x isr: %x\n", __FILE__, __LINE__,
-port, isr));
-
/* Receive Interrupt pending */
if (isr & (UART_IIR_RDI | UART_IIR_RDI_TIMEOUT)) {
/* Read data from uart -> queue */
@@ -463,7 +452,6 @@ static inline void cls_parse_isr(struct dgnc_board *brd, 
uint port)
}
 
/* Parse any modem signal changes */
-   DPR_INTR(("MOD_STAT: sending to parse_modem_sigs\n"));
cls_parse_modem(ch, readb(&ch->ch_cls_uart->msr));
}
 }
@@ -500,10 +488,6 @@ static void cls_param(struct tty_struct *tty)
if (!bd || bd->magic != DGNC_BOARD_MAGIC)
return;
 
-   DPR_PARAM(("param start: tdev: %x cflags: %x oflags: %x iflags: %x\n",
-   ch->ch_tun.un_dev, ch->ch_c_cflag, ch->ch_c_oflag,
-ch->ch_c_iflag));
-
/*
 * If baud rate is zero, flush queues, and set mval to drop DTR.
 */
@@ -587,8 +571,6 @@ static void cls_param(struct tty_struct *tty)
(jindex < 16)) {
baud = bauds[iindex][jindex];
} else {
-   DPR_IOCTL(("baud indices were out of range (%d)(%d)",
-   iindex, jindex));
baud = 0;