Re: [PATCH] staging: gdm724x: Rename variable for consistency
On Thu, Aug 31, 2017 at 12:47:59PM -0400, Nick Fox wrote: > jonathan...@gctsemi.com, linux-ker...@vger.kernel.org > Bcc: > Subject: Re: [PATCH v2] staging : gdm724x: Rename variable for consistency > Reply-To: > In-Reply-To: <20170831162747.ga31...@kroah.com> What just happened there? What email are you responding to? Always properly quote emails, remember, I get over a thousand emails a day I need to do something with, and as such, I have the short-term memory of a squirrel. Please fix up and resend your questions such that I know what is being asked about... thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: gdm724x: Rename variable for consistency
jonathan...@gctsemi.com, linux-ker...@vger.kernel.org Bcc: Subject: Re: [PATCH v2] staging : gdm724x: Rename variable for consistency Reply-To: In-Reply-To: <20170831162747.ga31...@kroah.com> Sorry for the confusion. This patch is a revision to an earlier patch I submitted that did not compile. It should be part of this thread, but in case its not, reference is here: https://lkml.org/lkml/2017/8/24/885. I thought I had compiled it successfully but I discovered this was due to an issue with my build environment. Just for future reference, was I doing something wrong in this situation by adding a v2 in the changelog area? Various beginner guides I've been reading suggested I do this when a patch requires revisions. Thanks, Nick ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: gdm724x: Rename variable for consistency
On Thu, Aug 24, 2017 at 07:18:53PM -0400, Nick Fox wrote: > Rename dftEpsId variable to dft_eps_ID to be consistent with other > variables in the source file. > > Signed-off-by: Nick Fox > --- > drivers/staging/gdm724x/hci_packet.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Always test-build your patches, to not do so is rude to those of us you expect to apply your patch :( greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: gdm724x: Rename variable for consistency
Rename dftEpsId variable to dft_eps_ID to be consistent with other variables in the source file. Signed-off-by: Nick Fox --- drivers/staging/gdm724x/hci_packet.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/gdm724x/hci_packet.h b/drivers/staging/gdm724x/hci_packet.h index 22ce8b9477b6..d9e41e457f83 100644 --- a/drivers/staging/gdm724x/hci_packet.h +++ b/drivers/staging/gdm724x/hci_packet.h @@ -50,7 +50,7 @@ struct tlv { struct sdu_header { __dev16 cmd_evt; __dev16 len; - __dev32 dftEpsId; + __dev32 dft_eps_ID; __dev32 bearer_ID; __dev32 nic_type; } __packed; @@ -76,7 +76,7 @@ struct hci_pdn_table_ind { __dev16 cmd_evt; __dev16 len; u8 activate; - __dev32 dft_eps_id; + __dev32 dft_eps_ID; __dev32 nic_type; u8 pdn_type; u8 ipv4_addr[4]; -- 2.13.5 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel