Re: [PATCH] staging: i4l: icn: fix memdup_user.cocci warnings
On Mon, Aug 22, 2016 at 09:19:36PM -0400, Greg KH wrote: On Tue, Aug 23, 2016 at 08:36:58AM +0800, kbuild test robot wrote: drivers/staging/i4l/icn/icn.c:813:11-18: WARNING opportunity for memdup_user Use memdup_user rather than duplicating its implementation This is a little bit restricted to reduce false positives Generated by: scripts/coccinelle/api/memdup_user.cocci CC: Sudip Mukherjee Signed-off-by: Fengguang Wu --- 0 files changed rule starting on line 17: position variables or mixed modifs interfere with comm_assoc isobool ( ( ( (unknown *to == NULL) >>> IS_ERR(rule starting on line 17:to) | !unknown *to >>> IS_ERR(rule starting on line 17:to) ) | (unknown *NULL == unknown *to) >>> IS_ERR(rule starting on line 17:to) ) || ...) There's no patch here, did something go wrong? Yes, the above error messages look like problems in the cocci script. CC Julia for possible inputs. Hi Julia, here is the context of the problem: tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing head: f5a9a15f8fd4168e415e94f5dce367f3cef08e03 commit: ee05e5f7113ea0b0db7eff7011a534c92fec2648 [251/347] staging: i4l: icn: donot assign in if statement coccinelle warnings: (new ones prefixed by >>) drivers/staging/i4l/icn/icn.c:813:11-18: WARNING opportunity for memdup_user Thanks, Fengguang ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: i4l: icn: fix memdup_user.cocci warnings
On Mon, Aug 22, 2016 at 09:19:36PM -0400, Greg Kroah-Hartman wrote: > On Tue, Aug 23, 2016 at 08:36:58AM +0800, kbuild test robot wrote: > > drivers/staging/i4l/icn/icn.c:813:11-18: WARNING opportunity for memdup_user > > > > Use memdup_user rather than duplicating its implementation > > This is a little bit restricted to reduce false positives > > > > Generated by: scripts/coccinelle/api/memdup_user.cocci > > > > CC: Sudip Mukherjee > > Signed-off-by: Fengguang Wu > > --- > > > > There's no patch here, did something go wrong? No problem. I will make the patch for memdup_user and send today. regards sudip ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: i4l: icn: fix memdup_user.cocci warnings
On Tue, Aug 23, 2016 at 08:36:58AM +0800, kbuild test robot wrote: > drivers/staging/i4l/icn/icn.c:813:11-18: WARNING opportunity for memdup_user > > Use memdup_user rather than duplicating its implementation > This is a little bit restricted to reduce false positives > > Generated by: scripts/coccinelle/api/memdup_user.cocci > > CC: Sudip Mukherjee > Signed-off-by: Fengguang Wu > --- > > 0 files changed > > rule starting on line 17: position variables or mixed modifs interfere with > comm_assoc isobool ( > ( > > ( > (unknown *to == NULL) > >>> IS_ERR(rule starting on line 17:to) > > | > !unknown *to > >>> IS_ERR(rule starting on line 17:to) > > ) > | > (unknown *NULL == unknown *to) > >>> IS_ERR(rule starting on line 17:to) > > ) || ...) There's no patch here, did something go wrong? greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: i4l: icn: fix memdup_user.cocci warnings
drivers/staging/i4l/icn/icn.c:813:11-18: WARNING opportunity for memdup_user Use memdup_user rather than duplicating its implementation This is a little bit restricted to reduce false positives Generated by: scripts/coccinelle/api/memdup_user.cocci CC: Sudip Mukherjee Signed-off-by: Fengguang Wu --- 0 files changed rule starting on line 17: position variables or mixed modifs interfere with comm_assoc isobool ( ( ( (unknown *to == NULL) >>> IS_ERR(rule starting on line 17:to) | !unknown *to >>> IS_ERR(rule starting on line 17:to) ) | (unknown *NULL == unknown *to) >>> IS_ERR(rule starting on line 17:to) ) || ...) ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
