Re: [PATCH] staging: lustre: This patch fixes the following sparse warning:

[Greg KH]

On Fri, Dec 11, 2015 at 04:08:53PM +0800, Jandy Gou wrote:
> drivers/staging/lustre/lustre/osc/osc_cache.c:622:19: warning: symbol
> 'osc_extent_find' was not declared. Should it be static?
> drivers/staging/lustre/lustre/osc/osc_cache.c:1423:6: warning: symbol
> 'osc_unreserve_grant' was not declared. Should it be static?
> 
> Signed-off-by: Jandy Gou 
> ---
>  drivers/staging/lustre/lustre/osc/osc_cache.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

The subject is very odd, please fix it up to be more like other commits
are (look in the history of the file for specifics...)

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: lustre: This patch fixes the following sparse warning:

[Jandy Gou]

drivers/staging/lustre/lustre/osc/osc_cache.c:622:19: warning: symbol
'osc_extent_find' was not declared. Should it be static?
drivers/staging/lustre/lustre/osc/osc_cache.c:1423:6: warning: symbol
'osc_unreserve_grant' was not declared. Should it be static?

Signed-off-by: Jandy Gou 
---
 drivers/staging/lustre/lustre/osc/osc_cache.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/lustre/lustre/osc/osc_cache.c 
b/drivers/staging/lustre/lustre/osc/osc_cache.c
index b1d1a87f..62cfca6 100644
--- a/drivers/staging/lustre/lustre/osc/osc_cache.c
+++ b/drivers/staging/lustre/lustre/osc/osc_cache.c
@@ -619,7 +619,7 @@ static inline int overlapped(struct osc_extent *ex1, struct 
osc_extent *ex2)
  * Find or create an extent which includes @index, core function to manage
  * extent tree.
  */
-struct osc_extent *osc_extent_find(const struct lu_env *env,
+static struct osc_extent *osc_extent_find(const struct lu_env *env,
   struct osc_object *obj, pgoff_t index,
   int *grants)
 
@@ -1420,7 +1420,7 @@ static void __osc_unreserve_grant(struct client_obd *cli,
}
 }
 
-void osc_unreserve_grant(struct client_obd *cli,
+static void osc_unreserve_grant(struct client_obd *cli,
 unsigned int reserved, unsigned int unused)
 {
client_obd_list_lock(>cl_loi_list_lock);
-- 
1.9.1


___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel