Re: [PATCH] staging: lustre: mgc: Fix incorrect type in assignment

[Greg Kroah-Hartman]

On Sat, Jul 01, 2017 at 05:26:52PM +0300, Kamal Heib wrote:
> Fix the following sparse warnings:
> mgc_request.c:68:25: warning: incorrect type in assignment (different base 
> types)
> mgc_request.c:68:25:expected unsigned long long [unsigned] [long] [long 
> long] 
> mgc_request.c:68:25:got restricted __le64 [usertype] 
> mgc_request.c:82:25: warning: incorrect type in assignment (different base 
> types)
> mgc_request.c:82:25:expected unsigned long long [unsigned] [long] [long 
> long] 
> mgc_request.c:82:25:got restricted __le64 [usertype] 
> 
> Cc: Greg Kroah-Hartman 
> Signed-off-by: Kamal Heib 
> ---
>  drivers/staging/lustre/lustre/mgc/mgc_request.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lustre/mgc/mgc_request.c 
> b/drivers/staging/lustre/lustre/mgc/mgc_request.c
> index eee0b667a33c..93819bb84ef8 100644
> --- a/drivers/staging/lustre/lustre/mgc/mgc_request.c
> +++ b/drivers/staging/lustre/lustre/mgc/mgc_request.c
> @@ -65,7 +65,7 @@ static int mgc_name2resid(char *name, int len, struct 
> ldlm_res_id *res_id,
>  
>   /* Always use the same endianness for the resid */
>   memset(res_id, 0, sizeof(*res_id));
> - res_id->name[0] = cpu_to_le64(resname);
> + res_id->name[0] = resname;

Really?  What about that comment right above?  Are you _sure_ this patch
is correct?

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: lustre: mgc: Fix incorrect type in assignment

[Kamal Heib]

Fix the following sparse warnings:
mgc_request.c:68:25: warning: incorrect type in assignment (different base 
types)
mgc_request.c:68:25:expected unsigned long long [unsigned] [long] [long 
long] 
mgc_request.c:68:25:got restricted __le64 [usertype] 
mgc_request.c:82:25: warning: incorrect type in assignment (different base 
types)
mgc_request.c:82:25:expected unsigned long long [unsigned] [long] [long 
long] 
mgc_request.c:82:25:got restricted __le64 [usertype] 

Cc: Greg Kroah-Hartman 
Signed-off-by: Kamal Heib 
---
 drivers/staging/lustre/lustre/mgc/mgc_request.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/lustre/lustre/mgc/mgc_request.c 
b/drivers/staging/lustre/lustre/mgc/mgc_request.c
index eee0b667a33c..93819bb84ef8 100644
--- a/drivers/staging/lustre/lustre/mgc/mgc_request.c
+++ b/drivers/staging/lustre/lustre/mgc/mgc_request.c
@@ -65,7 +65,7 @@ static int mgc_name2resid(char *name, int len, struct 
ldlm_res_id *res_id,
 
/* Always use the same endianness for the resid */
memset(res_id, 0, sizeof(*res_id));
-   res_id->name[0] = cpu_to_le64(resname);
+   res_id->name[0] = resname;
/* XXX: unfortunately, sptlprc and config llog share one lock */
switch (type) {
case CONFIG_T_CONFIG:
@@ -79,7 +79,7 @@ static int mgc_name2resid(char *name, int len, struct 
ldlm_res_id *res_id,
default:
LBUG();
}
-   res_id->name[1] = cpu_to_le64(resname);
+   res_id->name[1] = resname;
CDEBUG(D_MGC, "log %s to resid %#llx/%#llx (%.8s)\n", name,
   res_id->name[0], res_id->name[1], (char *)_id->name[0]);
return 0;
-- 
2.9.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel