Re: [PATCH] staging: panel: fix block comment usage

[Sudip Mukherjee]

On Fri, Jul 31, 2015 at 03:12:23AM -0600, Alex Wilson wrote:
 Fixed two coding style warnings concerning multiline comments.
 
 Signed-off-by: Alex Wilson alex.david.wil...@gmail.com
 ---
  drivers/staging/panel/panel.c | 6 --
  1 file changed, 4 insertions(+), 2 deletions(-)
 
 diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c
 index bda208d..16a7adc 100644
 --- a/drivers/staging/panel/panel.c
 +++ b/drivers/staging/panel/panel.c
 @@ -782,13 +782,15 @@ static void long_sleep(int ms)
  }
  
  /* send a serial byte to the LCD panel. The caller is responsible for locking
 -   if needed. */
 + * if needed.
 + */
  static void lcd_send_serial(int byte)
  {
   int bit;
  
   /* the data bit is set on D0, and the clock on STROBE.
 -  * LCD reads D0 on STROBE's rising edge. */
 +  * LCD reads D0 on STROBE's rising edge.
 +  */
But this is also not the correct multiline comment style.
Should be:
/*
 * the data bit is set on D0, and the clock on STROBE.
 * LCD reads D0 on STROBE's rising edge.
 */

regards
sudip
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: panel: fix block comment usage

[Alex Wilson]

Fixed two coding style warnings concerning multiline comments.

Signed-off-by: Alex Wilson alex.david.wil...@gmail.com
---
 drivers/staging/panel/panel.c | 6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c
index bda208d..16a7adc 100644
--- a/drivers/staging/panel/panel.c
+++ b/drivers/staging/panel/panel.c
@@ -782,13 +782,15 @@ static void long_sleep(int ms)
 }
 
 /* send a serial byte to the LCD panel. The caller is responsible for locking
-   if needed. */
+ * if needed.
+ */
 static void lcd_send_serial(int byte)
 {
int bit;
 
/* the data bit is set on D0, and the clock on STROBE.
-* LCD reads D0 on STROBE's rising edge. */
+* LCD reads D0 on STROBE's rising edge.
+*/
for (bit = 0; bit  8; bit++) {
bits.cl = BIT_CLR;  /* CLK low */
panel_set_bits();
-- 
2.5.0

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel